drivers/gpu/drm/i915/intel_dp_mst.c

   1 /*
   2  * Copyright © 2008 Intel Corporation
   3  *             2014 Red Hat Inc.
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  22  * IN THE SOFTWARE.
  23  *
  24  */
  25
  26 #include <drm/drmP.h>
  27 #include "i915_drv.h"
  28 #include "intel_drv.h"
  29 #include <drm/drm_atomic_helper.h>
  30 #include <drm/drm_crtc_helper.h>
  31 #include <drm/drm_edid.h>
  32
  33 static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
  34                                         struct intel_crtc_state *pipe_config)
  35 {
  36         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  37         struct intel_digital_port *intel_dig_port = intel_mst->primary;
  38         struct intel_dp *intel_dp = &intel_dig_port->dp;
  39         struct drm_atomic_state *state;
  40         int bpp, i;
  41         int lane_count, slots;
  42         const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  43         struct drm_connector *drm_connector;
  44         struct intel_connector *connector, *found = NULL;
  45         struct drm_connector_state *connector_state;
  46         int mst_pbn;
  47
  48         pipe_config->dp_encoder_is_mst = true;
  49         pipe_config->has_pch_encoder = false;
  50         pipe_config->has_dp_encoder = true;
  51         bpp = 24;
  52         /*
  53          * for MST we always configure max link bw - the spec doesn't
  54          * seem to suggest we should do otherwise.
  55          */
  56         lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
  57
  58
  59         pipe_config->lane_count = lane_count;
  60
  61         pipe_config->pipe_bpp = 24;
  62         pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
  63
  64         state = pipe_config->base.state;
  65
  66         for_each_connector_in_state(state, drm_connector, connector_state, i) {
  67                 connector = to_intel_connector(drm_connector);
  68
  69                 if (connector_state->best_encoder == &encoder->base) {
  70                         found = connector;
  71                         break;
  72                 }
  73         }
  74
  75         if (!found) {
  76                 DRM_ERROR("can't find connector\n");
  77                 return false;
  78         }
  79
  80         mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->crtc_clock, bpp);
  81
  82         pipe_config->pbn = mst_pbn;
  83         slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);
  84
  85         intel_link_compute_m_n(bpp, lane_count,
  86                                adjusted_mode->crtc_clock,
  87                                pipe_config->port_clock,
  88                                &pipe_config->dp_m_n);
  89
  90         pipe_config->dp_m_n.tu = slots;
  91
  92         return true;
  93
  94 }
  95
  96 static void intel_mst_disable_dp(struct intel_encoder *encoder)
  97 {
  98         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
  99         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 100         struct intel_dp *intel_dp = &intel_dig_port->dp;
 101         int ret;
 102
 103         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 104
 105         drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, intel_mst->connector->port);
 106
 107         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 108         if (ret) {
 109                 DRM_ERROR("failed to update payload %d\n", ret);
 110         }
 111 }
 112
 113 static void intel_mst_post_disable_dp(struct intel_encoder *encoder)
 114 {
 115         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 116         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 117         struct intel_dp *intel_dp = &intel_dig_port->dp;
 118
 119         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 120
 121         /* this can fail */
 122         drm_dp_check_act_status(&intel_dp->mst_mgr);
 123         /* and this can also fail */
 124         drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 125
 126         drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, intel_mst->connector->port);
 127
 128         intel_dp->active_mst_links--;
 129
 130         intel_mst->connector = NULL;
 131         if (intel_dp->active_mst_links == 0) {
 132                 intel_dig_port->base.post_disable(&intel_dig_port->base);
 133                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
 134         }
 135 }
 136
 137 static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
 138 {
 139         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 140         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 141         struct intel_dp *intel_dp = &intel_dig_port->dp;
 142         struct drm_device *dev = encoder->base.dev;
 143         struct drm_i915_private *dev_priv = dev->dev_private;
 144         enum port port = intel_dig_port->port;
 145         int ret;
 146         uint32_t temp;
 147         struct intel_connector *found = NULL, *connector;
 148         int slots;
 149         struct drm_crtc *crtc = encoder->base.crtc;
 150         struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 151
 152         for_each_intel_connector(dev, connector) {
 153                 if (connector->base.state->best_encoder == &encoder->base) {
 154                         found = connector;
 155                         break;
 156                 }
 157         }
 158
 159         if (!found) {
 160                 DRM_ERROR("can't find connector\n");
 161                 return;
 162         }
 163
 164         /* MST encoders are bound to a crtc, not to a connector,
 165          * force the mapping here for get_hw_state.
 166          */
 167         found->encoder = encoder;
 168
 169         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 170
 171         intel_mst->connector = found;
 172
 173         if (intel_dp->active_mst_links == 0) {
 174                 intel_prepare_ddi_buffer(&intel_dig_port->base);
 175
 176                 intel_ddi_clk_select(&intel_dig_port->base, intel_crtc->config);
 177
 178                 intel_dp_set_link_params(intel_dp, intel_crtc->config);
 179
 180                 intel_ddi_init_dp_buf_reg(&intel_dig_port->base);
 181
 182                 intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
 183
 184                 intel_dp_start_link_train(intel_dp);
 185                 intel_dp_stop_link_train(intel_dp);
 186         }
 187
 188         ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
 189                                        intel_mst->connector->port,
 190                                        intel_crtc->config->pbn, &slots);
 191         if (ret == false) {
 192                 DRM_ERROR("failed to allocate vcpi\n");
 193                 return;
 194         }
 195
 196
 197         intel_dp->active_mst_links++;
 198         temp = I915_READ(DP_TP_STATUS(port));
 199         I915_WRITE(DP_TP_STATUS(port), temp);
 200
 201         ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
 202 }
 203
 204 static void intel_mst_enable_dp(struct intel_encoder *encoder)
 205 {
 206         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 207         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 208         struct intel_dp *intel_dp = &intel_dig_port->dp;
 209         struct drm_device *dev = intel_dig_port->base.base.dev;
 210         struct drm_i915_private *dev_priv = dev->dev_private;
 211         enum port port = intel_dig_port->port;
 212         int ret;
 213
 214         DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
 215
 216         if (wait_for((I915_READ(DP_TP_STATUS(port)) & DP_TP_STATUS_ACT_SENT),
 217                      1))
 218                 DRM_ERROR("Timed out waiting for ACT sent\n");
 219
 220         ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
 221
 222         ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
 223 }
 224
 225 static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
 226                                       enum pipe *pipe)
 227 {
 228         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 229         *pipe = intel_mst->pipe;
 230         if (intel_mst->connector)
 231                 return true;
 232         return false;
 233 }
 234
 235 static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
 236                                         struct intel_crtc_state *pipe_config)
 237 {
 238         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
 239         struct intel_digital_port *intel_dig_port = intel_mst->primary;
 240         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 241         struct drm_device *dev = encoder->base.dev;
 242         struct drm_i915_private *dev_priv = dev->dev_private;
 243         enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
 244         u32 temp, flags = 0;
 245
 246         pipe_config->has_dp_encoder = true;
 247
 248         temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
 249         if (temp & TRANS_DDI_PHSYNC)
 250                 flags |= DRM_MODE_FLAG_PHSYNC;
 251         else
 252                 flags |= DRM_MODE_FLAG_NHSYNC;
 253         if (temp & TRANS_DDI_PVSYNC)
 254                 flags |= DRM_MODE_FLAG_PVSYNC;
 255         else
 256                 flags |= DRM_MODE_FLAG_NVSYNC;
 257
 258         switch (temp & TRANS_DDI_BPC_MASK) {
 259         case TRANS_DDI_BPC_6:
 260                 pipe_config->pipe_bpp = 18;
 261                 break;
 262         case TRANS_DDI_BPC_8:
 263                 pipe_config->pipe_bpp = 24;
 264                 break;
 265         case TRANS_DDI_BPC_10:
 266                 pipe_config->pipe_bpp = 30;
 267                 break;
 268         case TRANS_DDI_BPC_12:
 269                 pipe_config->pipe_bpp = 36;
 270                 break;
 271         default:
 272                 break;
 273         }
 274         pipe_config->base.adjusted_mode.flags |= flags;
 275
 276         pipe_config->lane_count =
 277                 ((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
 278
 279         intel_dp_get_m_n(crtc, pipe_config);
 280
 281         intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
 282 }
 283
 284 static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
 285 {
 286         struct intel_connector *intel_connector = to_intel_connector(connector);
 287         struct intel_dp *intel_dp = intel_connector->mst_port;
 288         struct edid *edid;
 289         int ret;
 290
 291         if (!intel_dp) {
 292                 return intel_connector_update_modes(connector, NULL);
 293         }
 294
 295         edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
 296         ret = intel_connector_update_modes(connector, edid);
 297         kfree(edid);
 298
 299         return ret;
 300 }
 301
 302 static enum drm_connector_status
 303 intel_dp_mst_detect(struct drm_connector *connector, bool force)
 304 {
 305         struct intel_connector *intel_connector = to_intel_connector(connector);
 306         struct intel_dp *intel_dp = intel_connector->mst_port;
 307
 308         if (!intel_dp)
 309                 return connector_status_disconnected;
 310         return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
 311 }
 312
 313 static int
 314 intel_dp_mst_set_property(struct drm_connector *connector,
 315                           struct drm_property *property,
 316                           uint64_t val)
 317 {
 318         return 0;
 319 }
 320
 321 static void
 322 intel_dp_mst_connector_destroy(struct drm_connector *connector)
 323 {
 324         struct intel_connector *intel_connector = to_intel_connector(connector);
 325
 326         if (!IS_ERR_OR_NULL(intel_connector->edid))
 327                 kfree(intel_connector->edid);
 328
 329         drm_connector_cleanup(connector);
 330         kfree(connector);
 331 }
 332
 333 static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
 334         .dpms = drm_atomic_helper_connector_dpms,
 335         .detect = intel_dp_mst_detect,
 336         .fill_modes = drm_helper_probe_single_connector_modes,
 337         .set_property = intel_dp_mst_set_property,
 338         .atomic_get_property = intel_connector_atomic_get_property,
 339         .destroy = intel_dp_mst_connector_destroy,
 340         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 341         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 342 };
 343
 344 static int intel_dp_mst_get_modes(struct drm_connector *connector)
 345 {
 346         return intel_dp_mst_get_ddc_modes(connector);
 347 }
 348
 349 static enum drm_mode_status
 350 intel_dp_mst_mode_valid(struct drm_connector *connector,
 351                         struct drm_display_mode *mode)
 352 {
 353         int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
 354
 355         /* TODO - validate mode against available PBN for link */
 356         if (mode->clock < 10000)
 357                 return MODE_CLOCK_LOW;
 358
 359         if (mode->flags & DRM_MODE_FLAG_DBLCLK)
 360                 return MODE_H_ILLEGAL;
 361
 362         if (mode->clock > max_dotclk)
 363                 return MODE_CLOCK_HIGH;
 364
 365         return MODE_OK;
 366 }
 367
 368 static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
 369                                                          struct drm_connector_state *state)
 370 {
 371         struct intel_connector *intel_connector = to_intel_connector(connector);
 372         struct intel_dp *intel_dp = intel_connector->mst_port;
 373         struct intel_crtc *crtc = to_intel_crtc(state->crtc);
 374
 375         if (!intel_dp)
 376                 return NULL;
 377         return &intel_dp->mst_encoders[crtc->pipe]->base.base;
 378 }
 379
 380 static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
 381 {
 382         struct intel_connector *intel_connector = to_intel_connector(connector);
 383         struct intel_dp *intel_dp = intel_connector->mst_port;
 384         if (!intel_dp)
 385                 return NULL;
 386         return &intel_dp->mst_encoders[0]->base.base;
 387 }
 388
 389 static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
 390         .get_modes = intel_dp_mst_get_modes,
 391         .mode_valid = intel_dp_mst_mode_valid,
 392         .atomic_best_encoder = intel_mst_atomic_best_encoder,
 393         .best_encoder = intel_mst_best_encoder,
 394 };
 395
 396 static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
 397 {
 398         struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
 399
 400         drm_encoder_cleanup(encoder);
 401         kfree(intel_mst);
 402 }
 403
 404 static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
 405         .destroy = intel_dp_mst_encoder_destroy,
 406 };
 407
 408 static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
 409 {
 410         if (connector->encoder && connector->base.state->crtc) {
 411                 enum pipe pipe;
 412                 if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
 413                         return false;
 414                 return true;
 415         }
 416         return false;
 417 }
 418
 419 static void intel_connector_add_to_fbdev(struct intel_connector *connector)
 420 {
 421 #ifdef CONFIG_DRM_FBDEV_EMULATION
 422         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 423
 424         if (dev_priv->fbdev)
 425                 drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper,
 426                                                 &connector->base);
 427 #endif
 428 }
 429
 430 static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
 431 {
 432 #ifdef CONFIG_DRM_FBDEV_EMULATION
 433         struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 434
 435         if (dev_priv->fbdev)
 436                 drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper,
 437                                                    &connector->base);
 438 #endif
 439 }
 440
 441 static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
 442 {
 443         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 444         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 445         struct drm_device *dev = intel_dig_port->base.base.dev;
 446         struct intel_connector *intel_connector;
 447         struct drm_connector *connector;
 448         int i;
 449
 450         intel_connector = intel_connector_alloc();
 451         if (!intel_connector)
 452                 return NULL;
 453
 454         connector = &intel_connector->base;
 455         drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
 456         drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);
 457
 458         intel_connector->unregister = intel_connector_unregister;
 459         intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
 460         intel_connector->mst_port = intel_dp;
 461         intel_connector->port = port;
 462
 463         for (i = PIPE_A; i <= PIPE_C; i++) {
 464                 drm_mode_connector_attach_encoder(&intel_connector->base,
 465                                                   &intel_dp->mst_encoders[i]->base.base);
 466         }
 467         intel_dp_add_properties(intel_dp, connector);
 468
 469         drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
 470         drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);
 471
 472         drm_mode_connector_set_path_property(connector, pathprop);
 473         return connector;
 474 }
 475
 476 static void intel_dp_register_mst_connector(struct drm_connector *connector)
 477 {
 478         struct intel_connector *intel_connector = to_intel_connector(connector);
 479         struct drm_device *dev = connector->dev;
 480         drm_modeset_lock_all(dev);
 481         intel_connector_add_to_fbdev(intel_connector);
 482         drm_modeset_unlock_all(dev);
 483         drm_connector_register(&intel_connector->base);
 484 }
 485
 486 static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 487                                            struct drm_connector *connector)
 488 {
 489         struct intel_connector *intel_connector = to_intel_connector(connector);
 490         struct drm_device *dev = connector->dev;
 491
 492         intel_connector->unregister(intel_connector);
 493
 494         /* need to nuke the connector */
 495         drm_modeset_lock_all(dev);
 496         intel_connector_remove_from_fbdev(intel_connector);
 497         intel_connector->mst_port = NULL;
 498         drm_modeset_unlock_all(dev);
 499
 500         drm_connector_unreference(&intel_connector->base);
 501         DRM_DEBUG_KMS("\n");
 502 }
 503
 504 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
 505 {
 506         struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
 507         struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 508         struct drm_device *dev = intel_dig_port->base.base.dev;
 509
 510         drm_kms_helper_hotplug_event(dev);
 511 }
 512
 513 static const struct drm_dp_mst_topology_cbs mst_cbs = {
 514         .add_connector = intel_dp_add_mst_connector,
 515         .register_connector = intel_dp_register_mst_connector,
 516         .destroy_connector = intel_dp_destroy_mst_connector,
 517         .hotplug = intel_dp_mst_hotplug,
 518 };
 519
 520 static struct intel_dp_mst_encoder *
 521 intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
 522 {
 523         struct intel_dp_mst_encoder *intel_mst;
 524         struct intel_encoder *intel_encoder;
 525         struct drm_device *dev = intel_dig_port->base.base.dev;
 526
 527         intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);
 528
 529         if (!intel_mst)
 530                 return NULL;
 531
 532         intel_mst->pipe = pipe;
 533         intel_encoder = &intel_mst->base;
 534         intel_mst->primary = intel_dig_port;
 535
 536         drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
 537                          DRM_MODE_ENCODER_DPMST, NULL);
 538
 539         intel_encoder->type = INTEL_OUTPUT_DP_MST;
 540         intel_encoder->crtc_mask = 0x7;
 541         intel_encoder->cloneable = 0;
 542
 543         intel_encoder->compute_config = intel_dp_mst_compute_config;
 544         intel_encoder->disable = intel_mst_disable_dp;
 545         intel_encoder->post_disable = intel_mst_post_disable_dp;
 546         intel_encoder->pre_enable = intel_mst_pre_enable_dp;
 547         intel_encoder->enable = intel_mst_enable_dp;
 548         intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
 549         intel_encoder->get_config = intel_dp_mst_enc_get_config;
 550
 551         return intel_mst;
 552
 553 }
 554
 555 static bool
 556 intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
 557 {
 558         int i;
 559         struct intel_dp *intel_dp = &intel_dig_port->dp;
 560
 561         for (i = PIPE_A; i <= PIPE_C; i++)
 562                 intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
 563         return true;
 564 }
 565
 566 int
 567 intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
 568 {
 569         struct intel_dp *intel_dp = &intel_dig_port->dp;
 570         struct drm_device *dev = intel_dig_port->base.base.dev;
 571         int ret;
 572
 573         intel_dp->can_mst = true;
 574         intel_dp->mst_mgr.cbs = &mst_cbs;
 575
 576         /* create encoders */
 577         intel_dp_create_fake_mst_encoders(intel_dig_port);
 578         ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev->dev, &intel_dp->aux, 16, 3, conn_base_id);
 579         if (ret) {
 580                 intel_dp->can_mst = false;
 581                 return ret;
 582         }
 583         return 0;
 584 }
 585
 586 void
 587 intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
 588 {
 589         struct intel_dp *intel_dp = &intel_dig_port->dp;
 590
 591         if (!intel_dp->can_mst)
 592                 return;
 593
 594         drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
 595         /* encoders will get killed by normal cleanup */
 596 }