3 * Copyright (C) 2011 Novell Inc.
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
11 #include <linux/namei.h>
12 #include <linux/pagemap.h>
13 #include <linux/xattr.h>
14 #include <linux/security.h>
15 #include <linux/mount.h>
16 #include <linux/slab.h>
17 #include <linux/parser.h>
18 #include <linux/module.h>
19 #include <linux/pagemap.h>
20 #include <linux/sched.h>
21 #include <linux/statfs.h>
22 #include <linux/seq_file.h>
23 #include "overlayfs.h"
25 MODULE_AUTHOR("Miklos Szeredi <miklos@szeredi.hu>");
26 MODULE_DESCRIPTION("Overlay filesystem");
27 MODULE_LICENSE("GPL");
33 bool default_permissions;
36 /* private information held for overlayfs's superblock */
38 struct vfsmount *upper_mnt;
40 struct vfsmount **lower_mnt;
41 struct dentry *workdir;
43 /* pathnames of lower and upper dirs, for show_options */
44 struct ovl_config config;
45 /* creds of process who forced instantiation of super block */
46 const struct cred *creator_cred;
51 /* private information held for every overlayfs dentry */
53 struct dentry *__upperdentry;
54 struct ovl_dir_cache *cache;
63 struct path lowerstack[];
66 #define OVL_MAX_STACK 500
68 static struct dentry *__ovl_dentry_lower(struct ovl_entry *oe)
70 return oe->numlower ? oe->lowerstack[0].dentry : NULL;
73 enum ovl_path_type ovl_path_type(struct dentry *dentry)
75 struct ovl_entry *oe = dentry->d_fsdata;
76 enum ovl_path_type type = 0;
78 if (oe->__upperdentry) {
79 type = __OVL_PATH_UPPER;
82 * Non-dir dentry can hold lower dentry from previous
83 * location. Its purity depends only on opaque flag.
85 if (oe->numlower && S_ISDIR(dentry->d_inode->i_mode))
86 type |= __OVL_PATH_MERGE;
88 type |= __OVL_PATH_PURE;
91 type |= __OVL_PATH_MERGE;
96 static struct dentry *ovl_upperdentry_dereference(struct ovl_entry *oe)
98 return lockless_dereference(oe->__upperdentry);
101 void ovl_path_upper(struct dentry *dentry, struct path *path)
103 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
104 struct ovl_entry *oe = dentry->d_fsdata;
106 path->mnt = ofs->upper_mnt;
107 path->dentry = ovl_upperdentry_dereference(oe);
110 enum ovl_path_type ovl_path_real(struct dentry *dentry, struct path *path)
112 enum ovl_path_type type = ovl_path_type(dentry);
114 if (!OVL_TYPE_UPPER(type))
115 ovl_path_lower(dentry, path);
117 ovl_path_upper(dentry, path);
122 struct dentry *ovl_dentry_upper(struct dentry *dentry)
124 struct ovl_entry *oe = dentry->d_fsdata;
126 return ovl_upperdentry_dereference(oe);
129 struct dentry *ovl_dentry_lower(struct dentry *dentry)
131 struct ovl_entry *oe = dentry->d_fsdata;
133 return __ovl_dentry_lower(oe);
136 struct dentry *ovl_dentry_real(struct dentry *dentry)
138 struct ovl_entry *oe = dentry->d_fsdata;
139 struct dentry *realdentry;
141 realdentry = ovl_upperdentry_dereference(oe);
143 realdentry = __ovl_dentry_lower(oe);
148 struct dentry *ovl_entry_real(struct ovl_entry *oe, bool *is_upper)
150 struct dentry *realdentry;
152 realdentry = ovl_upperdentry_dereference(oe);
156 realdentry = __ovl_dentry_lower(oe);
162 struct inode *ovl_inode_real(struct inode *inode)
166 return d_inode(ovl_entry_real(inode->i_private, &tmp));
169 struct vfsmount *ovl_entry_mnt_real(struct ovl_entry *oe, struct inode *inode,
173 struct ovl_fs *ofs = inode->i_sb->s_fs_info;
175 return ofs->upper_mnt;
177 return oe->numlower ? oe->lowerstack[0].mnt : NULL;
181 struct ovl_dir_cache *ovl_dir_cache(struct dentry *dentry)
183 struct ovl_entry *oe = dentry->d_fsdata;
188 void ovl_set_dir_cache(struct dentry *dentry, struct ovl_dir_cache *cache)
190 struct ovl_entry *oe = dentry->d_fsdata;
195 void ovl_path_lower(struct dentry *dentry, struct path *path)
197 struct ovl_entry *oe = dentry->d_fsdata;
199 *path = oe->numlower ? oe->lowerstack[0] : (struct path) { NULL, NULL };
202 int ovl_want_write(struct dentry *dentry)
204 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
205 return mnt_want_write(ofs->upper_mnt);
208 void ovl_drop_write(struct dentry *dentry)
210 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
211 mnt_drop_write(ofs->upper_mnt);
214 struct dentry *ovl_workdir(struct dentry *dentry)
216 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
220 bool ovl_dentry_is_opaque(struct dentry *dentry)
222 struct ovl_entry *oe = dentry->d_fsdata;
226 void ovl_dentry_set_opaque(struct dentry *dentry, bool opaque)
228 struct ovl_entry *oe = dentry->d_fsdata;
232 void ovl_dentry_update(struct dentry *dentry, struct dentry *upperdentry)
234 struct ovl_entry *oe = dentry->d_fsdata;
236 WARN_ON(!inode_is_locked(upperdentry->d_parent->d_inode));
237 WARN_ON(oe->__upperdentry);
238 BUG_ON(!upperdentry->d_inode);
240 * Make sure upperdentry is consistent before making it visible to
241 * ovl_upperdentry_dereference().
244 oe->__upperdentry = upperdentry;
247 void ovl_dentry_version_inc(struct dentry *dentry)
249 struct ovl_entry *oe = dentry->d_fsdata;
251 WARN_ON(!inode_is_locked(dentry->d_inode));
255 u64 ovl_dentry_version_get(struct dentry *dentry)
257 struct ovl_entry *oe = dentry->d_fsdata;
259 WARN_ON(!inode_is_locked(dentry->d_inode));
263 bool ovl_is_whiteout(struct dentry *dentry)
265 struct inode *inode = dentry->d_inode;
267 return inode && IS_WHITEOUT(inode);
270 const struct cred *ovl_override_creds(struct super_block *sb)
272 struct ovl_fs *ofs = sb->s_fs_info;
274 return override_creds(ofs->creator_cred);
277 static bool ovl_is_opaquedir(struct dentry *dentry)
281 struct inode *inode = dentry->d_inode;
283 if (!S_ISDIR(inode->i_mode) || !inode->i_op->getxattr)
286 res = inode->i_op->getxattr(dentry, inode, OVL_XATTR_OPAQUE, &val, 1);
287 if (res == 1 && val == 'y')
293 static void ovl_dentry_release(struct dentry *dentry)
295 struct ovl_entry *oe = dentry->d_fsdata;
300 dput(oe->__upperdentry);
301 for (i = 0; i < oe->numlower; i++)
302 dput(oe->lowerstack[i].dentry);
307 static struct dentry *ovl_d_real(struct dentry *dentry,
308 const struct inode *inode,
309 unsigned int open_flags)
313 if (d_is_dir(dentry)) {
314 if (!inode || inode == d_inode(dentry))
319 if (d_is_negative(dentry))
323 int err = ovl_open_maybe_copy_up(dentry, open_flags);
329 real = ovl_dentry_upper(dentry);
330 if (real && (!inode || inode == d_inode(real)))
333 real = ovl_dentry_lower(dentry);
337 if (!inode || inode == d_inode(real))
340 /* Handle recursion */
341 return d_real(real, inode, open_flags);
343 WARN(1, "ovl_d_real(%pd4, %s:%lu\n): real dentry not found\n", dentry,
344 inode ? inode->i_sb->s_id : "NULL", inode ? inode->i_ino : 0);
348 static int ovl_dentry_revalidate(struct dentry *dentry, unsigned int flags)
350 struct ovl_entry *oe = dentry->d_fsdata;
354 for (i = 0; i < oe->numlower; i++) {
355 struct dentry *d = oe->lowerstack[i].dentry;
357 if (d->d_flags & DCACHE_OP_REVALIDATE) {
358 ret = d->d_op->d_revalidate(d, flags);
362 if (!(flags & LOOKUP_RCU))
371 static int ovl_dentry_weak_revalidate(struct dentry *dentry, unsigned int flags)
373 struct ovl_entry *oe = dentry->d_fsdata;
377 for (i = 0; i < oe->numlower; i++) {
378 struct dentry *d = oe->lowerstack[i].dentry;
380 if (d->d_flags & DCACHE_OP_WEAK_REVALIDATE) {
381 ret = d->d_op->d_weak_revalidate(d, flags);
389 static const struct dentry_operations ovl_dentry_operations = {
390 .d_release = ovl_dentry_release,
391 .d_real = ovl_d_real,
394 static const struct dentry_operations ovl_reval_dentry_operations = {
395 .d_release = ovl_dentry_release,
396 .d_real = ovl_d_real,
397 .d_revalidate = ovl_dentry_revalidate,
398 .d_weak_revalidate = ovl_dentry_weak_revalidate,
401 static struct ovl_entry *ovl_alloc_entry(unsigned int numlower)
403 size_t size = offsetof(struct ovl_entry, lowerstack[numlower]);
404 struct ovl_entry *oe = kzalloc(size, GFP_KERNEL);
407 oe->numlower = numlower;
412 static bool ovl_dentry_remote(struct dentry *dentry)
414 return dentry->d_flags &
415 (DCACHE_OP_REVALIDATE | DCACHE_OP_WEAK_REVALIDATE);
418 static bool ovl_dentry_weird(struct dentry *dentry)
420 return dentry->d_flags & (DCACHE_NEED_AUTOMOUNT |
421 DCACHE_MANAGE_TRANSIT |
426 static inline struct dentry *ovl_lookup_real(struct super_block *ovl_sb,
430 const struct cred *old_cred;
431 struct dentry *dentry;
433 old_cred = ovl_override_creds(ovl_sb);
434 dentry = lookup_one_len_unlocked(name->name, dir, name->len);
435 revert_creds(old_cred);
437 if (IS_ERR(dentry)) {
438 if (PTR_ERR(dentry) == -ENOENT)
440 } else if (!dentry->d_inode) {
443 } else if (ovl_dentry_weird(dentry)) {
445 /* Don't support traversing automounts and other weirdness */
446 dentry = ERR_PTR(-EREMOTE);
452 * Returns next layer in stack starting from top.
453 * Returns -1 if this is the last layer.
455 int ovl_path_next(int idx, struct dentry *dentry, struct path *path)
457 struct ovl_entry *oe = dentry->d_fsdata;
461 ovl_path_upper(dentry, path);
463 return oe->numlower ? 1 : -1;
466 BUG_ON(idx > oe->numlower);
467 *path = oe->lowerstack[idx - 1];
469 return (idx < oe->numlower) ? idx + 1 : -1;
472 struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
475 struct ovl_entry *oe;
476 struct ovl_entry *poe = dentry->d_parent->d_fsdata;
477 struct path *stack = NULL;
478 struct dentry *upperdir, *upperdentry = NULL;
479 unsigned int ctr = 0;
480 struct inode *inode = NULL;
481 bool upperopaque = false;
482 struct dentry *this, *prev = NULL;
486 upperdir = ovl_upperdentry_dereference(poe);
488 this = ovl_lookup_real(dentry->d_sb, upperdir, &dentry->d_name);
494 if (unlikely(ovl_dentry_remote(this))) {
499 if (ovl_is_whiteout(this)) {
503 } else if (poe->numlower && ovl_is_opaquedir(this)) {
507 upperdentry = prev = this;
510 if (!upperopaque && poe->numlower) {
512 stack = kcalloc(poe->numlower, sizeof(struct path), GFP_KERNEL);
517 for (i = 0; !upperopaque && i < poe->numlower; i++) {
519 struct path lowerpath = poe->lowerstack[i];
521 this = ovl_lookup_real(dentry->d_sb,
522 lowerpath.dentry, &dentry->d_name);
526 * If it's positive, then treat ENAMETOOLONG as ENOENT.
528 if (err == -ENAMETOOLONG && (upperdentry || ctr))
534 if (ovl_is_whiteout(this)) {
539 * Only makes sense to check opaque dir if this is not the
542 if (i < poe->numlower - 1 && ovl_is_opaquedir(this))
545 if (prev && (!S_ISDIR(prev->d_inode->i_mode) ||
546 !S_ISDIR(this->d_inode->i_mode))) {
548 * FIXME: check for upper-opaqueness maybe better done
551 if (prev == upperdentry)
557 * If this is a non-directory then stop here.
559 if (!S_ISDIR(this->d_inode->i_mode))
562 stack[ctr].dentry = this;
563 stack[ctr].mnt = lowerpath.mnt;
570 oe = ovl_alloc_entry(ctr);
575 if (upperdentry || ctr) {
576 struct dentry *realdentry;
578 realdentry = upperdentry ? upperdentry : stack[0].dentry;
581 inode = ovl_new_inode(dentry->d_sb, realdentry->d_inode->i_mode,
585 ovl_copyattr(realdentry->d_inode, inode);
588 oe->opaque = upperopaque;
589 oe->__upperdentry = upperdentry;
590 memcpy(oe->lowerstack, stack, sizeof(struct path) * ctr);
592 dentry->d_fsdata = oe;
593 d_add(dentry, inode);
600 for (i = 0; i < ctr; i++)
601 dput(stack[i].dentry);
609 struct file *ovl_path_open(struct path *path, int flags)
611 return dentry_open(path, flags, current_cred());
614 static void ovl_put_super(struct super_block *sb)
616 struct ovl_fs *ufs = sb->s_fs_info;
620 mntput(ufs->upper_mnt);
621 for (i = 0; i < ufs->numlower; i++)
622 mntput(ufs->lower_mnt[i]);
623 kfree(ufs->lower_mnt);
625 kfree(ufs->config.lowerdir);
626 kfree(ufs->config.upperdir);
627 kfree(ufs->config.workdir);
628 put_cred(ufs->creator_cred);
634 * @sb: The overlayfs super block
635 * @buf: The struct kstatfs to fill in with stats
637 * Get the filesystem statistics. As writes always target the upper layer
638 * filesystem pass the statfs to the upper filesystem (if it exists)
640 static int ovl_statfs(struct dentry *dentry, struct kstatfs *buf)
642 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
643 struct dentry *root_dentry = dentry->d_sb->s_root;
647 ovl_path_real(root_dentry, &path);
649 err = vfs_statfs(&path, buf);
651 buf->f_namelen = max(buf->f_namelen, ofs->lower_namelen);
652 buf->f_type = OVERLAYFS_SUPER_MAGIC;
661 * Prints the mount options for a given superblock.
662 * Returns zero; does not fail.
664 static int ovl_show_options(struct seq_file *m, struct dentry *dentry)
666 struct super_block *sb = dentry->d_sb;
667 struct ovl_fs *ufs = sb->s_fs_info;
669 seq_show_option(m, "lowerdir", ufs->config.lowerdir);
670 if (ufs->config.upperdir) {
671 seq_show_option(m, "upperdir", ufs->config.upperdir);
672 seq_show_option(m, "workdir", ufs->config.workdir);
674 if (ufs->config.default_permissions)
675 seq_puts(m, ",default_permissions");
679 static int ovl_remount(struct super_block *sb, int *flags, char *data)
681 struct ovl_fs *ufs = sb->s_fs_info;
683 if (!(*flags & MS_RDONLY) && (!ufs->upper_mnt || !ufs->workdir))
689 static const struct super_operations ovl_super_operations = {
690 .put_super = ovl_put_super,
691 .statfs = ovl_statfs,
692 .show_options = ovl_show_options,
693 .remount_fs = ovl_remount,
694 .drop_inode = generic_delete_inode,
701 OPT_DEFAULT_PERMISSIONS,
705 static const match_table_t ovl_tokens = {
706 {OPT_LOWERDIR, "lowerdir=%s"},
707 {OPT_UPPERDIR, "upperdir=%s"},
708 {OPT_WORKDIR, "workdir=%s"},
709 {OPT_DEFAULT_PERMISSIONS, "default_permissions"},
713 static char *ovl_next_opt(char **s)
721 for (p = sbegin; *p; p++) {
726 } else if (*p == ',') {
736 static int ovl_parse_opt(char *opt, struct ovl_config *config)
740 while ((p = ovl_next_opt(&opt)) != NULL) {
742 substring_t args[MAX_OPT_ARGS];
747 token = match_token(p, ovl_tokens, args);
750 kfree(config->upperdir);
751 config->upperdir = match_strdup(&args[0]);
752 if (!config->upperdir)
757 kfree(config->lowerdir);
758 config->lowerdir = match_strdup(&args[0]);
759 if (!config->lowerdir)
764 kfree(config->workdir);
765 config->workdir = match_strdup(&args[0]);
766 if (!config->workdir)
770 case OPT_DEFAULT_PERMISSIONS:
771 config->default_permissions = true;
775 pr_err("overlayfs: unrecognized mount option \"%s\" or missing value\n", p);
780 /* Workdir is useless in non-upper mount */
781 if (!config->upperdir && config->workdir) {
782 pr_info("overlayfs: option \"workdir=%s\" is useless in a non-upper mount, ignore\n",
784 kfree(config->workdir);
785 config->workdir = NULL;
791 #define OVL_WORKDIR_NAME "work"
793 static struct dentry *ovl_workdir_create(struct vfsmount *mnt,
794 struct dentry *dentry)
796 struct inode *dir = dentry->d_inode;
799 bool retried = false;
801 err = mnt_want_write(mnt);
805 inode_lock_nested(dir, I_MUTEX_PARENT);
807 work = lookup_one_len(OVL_WORKDIR_NAME, dentry,
808 strlen(OVL_WORKDIR_NAME));
811 struct kstat stat = {
821 ovl_cleanup(dir, work);
826 err = ovl_create_real(dir, work, &stat, NULL, NULL, true);
842 static void ovl_unescape(char *s)
855 static int ovl_mount_dir_noesc(const char *name, struct path *path)
860 pr_err("overlayfs: empty lowerdir\n");
863 err = kern_path(name, LOOKUP_FOLLOW, path);
865 pr_err("overlayfs: failed to resolve '%s': %i\n", name, err);
869 if (ovl_dentry_weird(path->dentry)) {
870 pr_err("overlayfs: filesystem on '%s' not supported\n", name);
873 if (!S_ISDIR(path->dentry->d_inode->i_mode)) {
874 pr_err("overlayfs: '%s' not a directory\n", name);
885 static int ovl_mount_dir(const char *name, struct path *path)
888 char *tmp = kstrdup(name, GFP_KERNEL);
892 err = ovl_mount_dir_noesc(tmp, path);
895 if (ovl_dentry_remote(path->dentry)) {
896 pr_err("overlayfs: filesystem on '%s' not supported as upperdir\n",
906 static int ovl_lower_dir(const char *name, struct path *path, long *namelen,
907 int *stack_depth, bool *remote)
910 struct kstatfs statfs;
912 err = ovl_mount_dir_noesc(name, path);
916 err = vfs_statfs(path, &statfs);
918 pr_err("overlayfs: statfs failed on '%s'\n", name);
921 *namelen = max(*namelen, statfs.f_namelen);
922 *stack_depth = max(*stack_depth, path->mnt->mnt_sb->s_stack_depth);
924 if (ovl_dentry_remote(path->dentry))
935 /* Workdir should not be subdir of upperdir and vice versa */
936 static bool ovl_workdir_ok(struct dentry *workdir, struct dentry *upperdir)
940 if (workdir != upperdir) {
941 ok = (lock_rename(workdir, upperdir) == NULL);
942 unlock_rename(workdir, upperdir);
947 static unsigned int ovl_split_lowerdirs(char *str)
949 unsigned int ctr = 1;
952 for (s = d = str;; s++, d++) {
955 } else if (*s == ':') {
967 static int ovl_fill_super(struct super_block *sb, void *data, int silent)
969 struct path upperpath = { NULL, NULL };
970 struct path workpath = { NULL, NULL };
971 struct dentry *root_dentry;
972 struct ovl_entry *oe;
974 struct path *stack = NULL;
977 unsigned int numlower;
978 unsigned int stacklen = 0;
984 ufs = kzalloc(sizeof(struct ovl_fs), GFP_KERNEL);
988 err = ovl_parse_opt((char *) data, &ufs->config);
990 goto out_free_config;
993 if (!ufs->config.lowerdir) {
995 pr_err("overlayfs: missing 'lowerdir'\n");
996 goto out_free_config;
999 sb->s_stack_depth = 0;
1000 sb->s_maxbytes = MAX_LFS_FILESIZE;
1001 if (ufs->config.upperdir) {
1002 if (!ufs->config.workdir) {
1003 pr_err("overlayfs: missing 'workdir'\n");
1004 goto out_free_config;
1007 err = ovl_mount_dir(ufs->config.upperdir, &upperpath);
1009 goto out_free_config;
1011 /* Upper fs should not be r/o */
1012 if (upperpath.mnt->mnt_sb->s_flags & MS_RDONLY) {
1013 pr_err("overlayfs: upper fs is r/o, try multi-lower layers mount\n");
1015 goto out_put_upperpath;
1018 err = ovl_mount_dir(ufs->config.workdir, &workpath);
1020 goto out_put_upperpath;
1023 if (upperpath.mnt != workpath.mnt) {
1024 pr_err("overlayfs: workdir and upperdir must reside under the same mount\n");
1025 goto out_put_workpath;
1027 if (!ovl_workdir_ok(workpath.dentry, upperpath.dentry)) {
1028 pr_err("overlayfs: workdir and upperdir must be separate subtrees\n");
1029 goto out_put_workpath;
1031 sb->s_stack_depth = upperpath.mnt->mnt_sb->s_stack_depth;
1034 lowertmp = kstrdup(ufs->config.lowerdir, GFP_KERNEL);
1036 goto out_put_workpath;
1039 stacklen = ovl_split_lowerdirs(lowertmp);
1040 if (stacklen > OVL_MAX_STACK) {
1041 pr_err("overlayfs: too many lower directries, limit is %d\n",
1043 goto out_free_lowertmp;
1044 } else if (!ufs->config.upperdir && stacklen == 1) {
1045 pr_err("overlayfs: at least 2 lowerdir are needed while upperdir nonexistent\n");
1046 goto out_free_lowertmp;
1049 stack = kcalloc(stacklen, sizeof(struct path), GFP_KERNEL);
1051 goto out_free_lowertmp;
1054 for (numlower = 0; numlower < stacklen; numlower++) {
1055 err = ovl_lower_dir(lower, &stack[numlower],
1056 &ufs->lower_namelen, &sb->s_stack_depth,
1059 goto out_put_lowerpath;
1061 lower = strchr(lower, '\0') + 1;
1065 sb->s_stack_depth++;
1066 if (sb->s_stack_depth > FILESYSTEM_MAX_STACK_DEPTH) {
1067 pr_err("overlayfs: maximum fs stacking depth exceeded\n");
1068 goto out_put_lowerpath;
1071 if (ufs->config.upperdir) {
1072 ufs->upper_mnt = clone_private_mount(&upperpath);
1073 err = PTR_ERR(ufs->upper_mnt);
1074 if (IS_ERR(ufs->upper_mnt)) {
1075 pr_err("overlayfs: failed to clone upperpath\n");
1076 goto out_put_lowerpath;
1079 ufs->workdir = ovl_workdir_create(ufs->upper_mnt, workpath.dentry);
1080 err = PTR_ERR(ufs->workdir);
1081 if (IS_ERR(ufs->workdir)) {
1082 pr_warn("overlayfs: failed to create directory %s/%s (errno: %i); mounting read-only\n",
1083 ufs->config.workdir, OVL_WORKDIR_NAME, -err);
1084 sb->s_flags |= MS_RDONLY;
1085 ufs->workdir = NULL;
1089 * Upper should support d_type, else whiteouts are visible.
1090 * Given workdir and upper are on same fs, we can do
1091 * iterate_dir() on workdir. This check requires successful
1092 * creation of workdir in previous step.
1095 err = ovl_check_d_type_supported(&workpath);
1097 goto out_put_workdir;
1100 * We allowed this configuration and don't want to
1101 * break users over kernel upgrade. So warn instead
1105 pr_warn("overlayfs: upper fs needs to support d_type.\n");
1110 ufs->lower_mnt = kcalloc(numlower, sizeof(struct vfsmount *), GFP_KERNEL);
1111 if (ufs->lower_mnt == NULL)
1112 goto out_put_workdir;
1113 for (i = 0; i < numlower; i++) {
1114 struct vfsmount *mnt = clone_private_mount(&stack[i]);
1118 pr_err("overlayfs: failed to clone lowerpath\n");
1119 goto out_put_lower_mnt;
1122 * Make lower_mnt R/O. That way fchmod/fchown on lower file
1123 * will fail instead of modifying lower fs.
1125 mnt->mnt_flags |= MNT_READONLY;
1127 ufs->lower_mnt[ufs->numlower] = mnt;
1131 /* If the upper fs is nonexistent, we mark overlayfs r/o too */
1132 if (!ufs->upper_mnt)
1133 sb->s_flags |= MS_RDONLY;
1136 sb->s_d_op = &ovl_reval_dentry_operations;
1138 sb->s_d_op = &ovl_dentry_operations;
1140 ufs->creator_cred = prepare_creds();
1141 if (!ufs->creator_cred)
1142 goto out_put_lower_mnt;
1145 oe = ovl_alloc_entry(numlower);
1149 root_dentry = d_make_root(ovl_new_inode(sb, S_IFDIR, oe));
1153 mntput(upperpath.mnt);
1154 for (i = 0; i < numlower; i++)
1155 mntput(stack[i].mnt);
1156 path_put(&workpath);
1159 oe->__upperdentry = upperpath.dentry;
1160 for (i = 0; i < numlower; i++) {
1161 oe->lowerstack[i].dentry = stack[i].dentry;
1162 oe->lowerstack[i].mnt = ufs->lower_mnt[i];
1166 root_dentry->d_fsdata = oe;
1168 ovl_copyattr(ovl_dentry_real(root_dentry)->d_inode,
1169 root_dentry->d_inode);
1171 sb->s_magic = OVERLAYFS_SUPER_MAGIC;
1172 sb->s_op = &ovl_super_operations;
1173 sb->s_root = root_dentry;
1174 sb->s_fs_info = ufs;
1175 sb->s_flags |= MS_POSIXACL;
1182 put_cred(ufs->creator_cred);
1184 for (i = 0; i < ufs->numlower; i++)
1185 mntput(ufs->lower_mnt[i]);
1186 kfree(ufs->lower_mnt);
1189 mntput(ufs->upper_mnt);
1191 for (i = 0; i < numlower; i++)
1192 path_put(&stack[i]);
1197 path_put(&workpath);
1199 path_put(&upperpath);
1201 kfree(ufs->config.lowerdir);
1202 kfree(ufs->config.upperdir);
1203 kfree(ufs->config.workdir);
1209 static struct dentry *ovl_mount(struct file_system_type *fs_type, int flags,
1210 const char *dev_name, void *raw_data)
1212 return mount_nodev(fs_type, flags, raw_data, ovl_fill_super);
1215 static struct file_system_type ovl_fs_type = {
1216 .owner = THIS_MODULE,
1219 .kill_sb = kill_anon_super,
1221 MODULE_ALIAS_FS("overlay");
1223 static int __init ovl_init(void)
1225 return register_filesystem(&ovl_fs_type);
1228 static void __exit ovl_exit(void)
1230 unregister_filesystem(&ovl_fs_type);
1233 module_init(ovl_init);
1234 module_exit(ovl_exit);