2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
17 use Getopt::Long qw(:config no_auto_abbrev);
43 my $configuration_file = ".checkpatch.conf";
44 my $max_line_length = 80;
45 my $ignore_perl_version = 0;
46 my $minimum_perl_version = 5.10.0;
47 my $min_conf_desc_length = 4;
48 my $spelling_file = "$D/spelling.txt";
54 Usage: $P [OPTION]... [FILE]...
59 --no-tree run without a kernel tree
60 --no-signoff do not check for 'Signed-off-by' line
61 --patch treat FILE as patchfile (default)
62 --emacs emacs compile window format
63 --terse one line per report
64 -f, --file treat FILE as regular source file
65 --subjective, --strict enable more subjective tests
66 --types TYPE(,TYPE2...) show only these comma separated message types
67 --ignore TYPE(,TYPE2...) ignore various comma separated message types
68 --max-line-length=n set the maximum line length, if exceeded, warn
69 --min-conf-desc-length=n set the min description length, if shorter, warn
70 --show-types show the message "types" in the output
71 --root=PATH PATH to the kernel tree root
72 --no-summary suppress the per-file summary
73 --mailback only produce a report in case of warnings/errors
74 --summary-file include the filename in summary
75 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
76 'values', 'possible', 'type', and 'attr' (default
78 --test-only=WORD report only warnings/errors containing WORD
80 --fix EXPERIMENTAL - may create horrible results
81 If correctable single-line errors exist, create
82 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
83 with potential errors corrected to the preferred
85 --fix-inplace EXPERIMENTAL - may create horrible results
86 Is the same as --fix, but overwrites the input
87 file. It's your fault if there's no backup or git
88 --ignore-perl-version override checking of perl version. expect
90 -h, --help, --version display this help and exit
92 When FILE is - read standard input.
98 my $conf = which_conf($configuration_file);
101 open(my $conffile, '<', "$conf")
102 or warn "$P: Can't find a readable $configuration_file file $!\n";
104 while (<$conffile>) {
107 $line =~ s/\s*\n?$//g;
111 next if ($line =~ m/^\s*#/);
112 next if ($line =~ m/^\s*$/);
114 my @words = split(" ", $line);
115 foreach my $word (@words) {
116 last if ($word =~ m/^#/);
117 push (@conf_args, $word);
121 unshift(@ARGV, @conf_args) if @conf_args;
125 'q|quiet+' => \$quiet,
127 'signoff!' => \$chk_signoff,
128 'patch!' => \$chk_patch,
132 'subjective!' => \$check,
133 'strict!' => \$check,
134 'ignore=s' => \@ignore,
136 'show-types!' => \$show_types,
137 'max-line-length=i' => \$max_line_length,
138 'min-conf-desc-length=i' => \$min_conf_desc_length,
140 'summary!' => \$summary,
141 'mailback!' => \$mailback,
142 'summary-file!' => \$summary_file,
144 'fix-inplace!' => \$fix_inplace,
145 'ignore-perl-version!' => \$ignore_perl_version,
146 'debug=s' => \%debug,
147 'test-only=s' => \$tst_only,
154 $fix = 1 if ($fix_inplace);
155 $check_orig = $check;
159 if ($^V && $^V lt $minimum_perl_version) {
160 printf "$P: requires at least perl version %vd\n", $minimum_perl_version;
161 if (!$ignore_perl_version) {
167 print "$P: no input files\n";
171 sub hash_save_array_words {
172 my ($hashRef, $arrayRef) = @_;
174 my @array = split(/,/, join(',', @$arrayRef));
175 foreach my $word (@array) {
176 $word =~ s/\s*\n?$//g;
179 $word =~ tr/[a-z]/[A-Z]/;
181 next if ($word =~ m/^\s*#/);
182 next if ($word =~ m/^\s*$/);
188 sub hash_show_words {
189 my ($hashRef, $prefix) = @_;
191 if ($quiet == 0 && keys %$hashRef) {
192 print "NOTE: $prefix message types:";
193 foreach my $word (sort keys %$hashRef) {
200 hash_save_array_words(\%ignore_type, \@ignore);
201 hash_save_array_words(\%use_type, \@use);
204 my $dbg_possible = 0;
207 for my $key (keys %debug) {
209 eval "\${dbg_$key} = '$debug{$key}';";
213 my $rpt_cleaners = 0;
222 if (!top_of_kernel_tree($root)) {
223 die "$P: $root: --root does not point at a valid tree\n";
226 if (top_of_kernel_tree('.')) {
228 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
229 top_of_kernel_tree($1)) {
234 if (!defined $root) {
235 print "Must be run from the top-level dir. of a kernel tree\n";
240 my $emitted_corrupt = 0;
243 [A-Za-z_][A-Za-z\d_]*
244 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
246 our $Storage = qr{extern|static|asmlinkage};
258 our $InitAttributePrefix = qr{__(?:mem|cpu|dev|net_|)};
259 our $InitAttributeData = qr{$InitAttributePrefix(?:initdata\b)};
260 our $InitAttributeConst = qr{$InitAttributePrefix(?:initconst\b)};
261 our $InitAttributeInit = qr{$InitAttributePrefix(?:init\b)};
262 our $InitAttribute = qr{$InitAttributeData|$InitAttributeConst|$InitAttributeInit};
264 # Notes to $Attribute:
265 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
285 ____cacheline_aligned|
286 ____cacheline_aligned_in_smp|
287 ____cacheline_internodealigned_in_smp|
291 our $Inline = qr{inline|__always_inline|noinline|__inline|__inline__};
292 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
293 our $Lval = qr{$Ident(?:$Member)*};
295 our $Int_type = qr{(?i)llu|ull|ll|lu|ul|l|u};
296 our $Binary = qr{(?i)0b[01]+$Int_type?};
297 our $Hex = qr{(?i)0x[0-9a-f]+$Int_type?};
298 our $Int = qr{[0-9]+$Int_type?};
299 our $Octal = qr{0[0-7]+$Int_type?};
300 our $Float_hex = qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
301 our $Float_dec = qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
302 our $Float_int = qr{(?i)[0-9]+e-?[0-9]+[fl]?};
303 our $Float = qr{$Float_hex|$Float_dec|$Float_int};
304 our $Constant = qr{$Float|$Binary|$Octal|$Hex|$Int};
305 our $Assignment = qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
306 our $Compare = qr{<=|>=|==|!=|<|(?<!-)>};
307 our $Arithmetic = qr{\+|-|\*|\/|%};
311 &&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
314 our $c90_Keywords = qr{do|for|while|if|else|return|goto|continue|switch|default|case|break}x;
317 our $NonptrTypeMisordered;
318 our $NonptrTypeWithAttr;
322 our $DeclareMisordered;
324 our $NON_ASCII_UTF8 = qr{
325 [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
326 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
327 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
328 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
329 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
330 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
331 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
335 [\x09\x0A\x0D\x20-\x7E] # ASCII
339 our $typeTypedefs = qr{(?x:
340 (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
344 our $logFunctions = qr{(?x:
345 printk(?:_ratelimited|_once|)|
346 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
347 WARN(?:_RATELIMIT|_ONCE|)|
350 seq_vprintf|seq_printf|seq_puts
353 our $signature_tags = qr{(?xi:
364 our @typeListMisordered = (
365 qr{char\s+(?:un)?signed},
366 qr{int\s+(?:(?:un)?signed\s+)?short\s},
367 qr{int\s+short(?:\s+(?:un)?signed)},
368 qr{short\s+int(?:\s+(?:un)?signed)},
369 qr{(?:un)?signed\s+int\s+short},
370 qr{short\s+(?:un)?signed},
371 qr{long\s+int\s+(?:un)?signed},
372 qr{int\s+long\s+(?:un)?signed},
373 qr{long\s+(?:un)?signed\s+int},
374 qr{int\s+(?:un)?signed\s+long},
375 qr{int\s+(?:un)?signed},
376 qr{int\s+long\s+long\s+(?:un)?signed},
377 qr{long\s+long\s+int\s+(?:un)?signed},
378 qr{long\s+long\s+(?:un)?signed\s+int},
379 qr{long\s+long\s+(?:un)?signed},
380 qr{long\s+(?:un)?signed},
385 qr{(?:(?:un)?signed\s+)?char},
386 qr{(?:(?:un)?signed\s+)?short\s+int},
387 qr{(?:(?:un)?signed\s+)?short},
388 qr{(?:(?:un)?signed\s+)?int},
389 qr{(?:(?:un)?signed\s+)?long\s+int},
390 qr{(?:(?:un)?signed\s+)?long\s+long\s+int},
391 qr{(?:(?:un)?signed\s+)?long\s+long},
392 qr{(?:(?:un)?signed\s+)?long},
401 qr{${Ident}_handler},
402 qr{${Ident}_handler_fn},
405 our @typeListWithAttr = (
407 qr{struct\s+$InitAttribute\s+$Ident},
408 qr{union\s+$InitAttribute\s+$Ident},
411 our @modifierList = (
415 our @mode_permission_funcs = (
417 ["module_param_(?:array|named|string)", 4],
418 ["module_param_array_named", 5],
419 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
420 ["proc_create(?:_data|)", 2],
421 ["(?:CLASS|DEVICE|SENSOR)_ATTR", 2],
424 #Create a search pattern for all these functions to speed up a loop below
425 our $mode_perms_search = "";
426 foreach my $entry (@mode_permission_funcs) {
427 $mode_perms_search .= '|' if ($mode_perms_search ne "");
428 $mode_perms_search .= $entry->[0];
431 our $allowed_asm_includes = qr{(?x:
437 # memory.h: ARM has a custom one
439 # Load common spelling mistakes and build regular expression list.
443 open(my $spelling, '<', $spelling_file)
444 or die "$P: Can't open $spelling_file for reading: $!\n";
445 while (<$spelling>) {
448 $line =~ s/\s*\n?$//g;
451 next if ($line =~ m/^\s*#/);
452 next if ($line =~ m/^\s*$/);
454 my ($suspect, $fix) = split(/\|\|/, $line);
456 push(@spelling_list, $suspect);
457 $spelling_fix{$suspect} = $fix;
460 $misspellings = join("|", @spelling_list);
463 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
464 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
465 my $Misordered = "(?x: \n" . join("|\n ", @typeListMisordered) . "\n)";
466 my $allWithAttr = "(?x: \n" . join("|\n ", @typeListWithAttr) . "\n)";
467 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
469 (?:$Modifier\s+|const\s+)*
471 (?:typeof|__typeof__)\s*\([^\)]*\)|
475 (?:\s+$Modifier|\s+const)*
477 $NonptrTypeMisordered = qr{
478 (?:$Modifier\s+|const\s+)*
482 (?:\s+$Modifier|\s+const)*
484 $NonptrTypeWithAttr = qr{
485 (?:$Modifier\s+|const\s+)*
487 (?:typeof|__typeof__)\s*\([^\)]*\)|
491 (?:\s+$Modifier|\s+const)*
495 (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*\s*(?:const\s*)?|\[\])+|(?:\s*\[\s*\])+)?
496 (?:\s+$Inline|\s+$Modifier)*
498 $TypeMisordered = qr{
499 $NonptrTypeMisordered
500 (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*\s*(?:const\s*)?|\[\])+|(?:\s*\[\s*\])+)?
501 (?:\s+$Inline|\s+$Modifier)*
503 $Declare = qr{(?:$Storage\s+(?:$Inline\s+)?)?$Type};
504 $DeclareMisordered = qr{(?:$Storage\s+(?:$Inline\s+)?)?$TypeMisordered};
508 our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
510 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
511 # requires at least perl version v5.10.0
512 # Any use must be runtime checked with $^V
514 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
515 our $LvalOrFunc = qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*};
516 our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
518 our $declaration_macros = qr{(?x:
519 (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,2}\s*\(|
520 (?:$Storage\s+)?LIST_HEAD\s*\(|
521 (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
526 return "" if (!defined($string));
528 while ($string =~ /^\s*\(.*\)\s*$/) {
529 $string =~ s@^\s*\(\s*@@;
530 $string =~ s@\s*\)\s*$@@;
533 $string =~ s@\s+@ @g;
538 sub seed_camelcase_file {
541 return if (!(-f $file));
545 open(my $include_file, '<', "$file")
546 or warn "$P: Can't read '$file' $!\n";
547 my $text = <$include_file>;
548 close($include_file);
550 my @lines = split('\n', $text);
552 foreach my $line (@lines) {
553 next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
554 if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
556 } elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[\(\[,;]/) {
558 } elsif ($line =~ /^\s*(?:union|struct|enum)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[;\{]/) {
564 my $camelcase_seeded = 0;
565 sub seed_camelcase_includes {
566 return if ($camelcase_seeded);
569 my $camelcase_cache = "";
570 my @include_files = ();
572 $camelcase_seeded = 1;
575 my $git_last_include_commit = `git log --no-merges --pretty=format:"%h%n" -1 -- include`;
576 chomp $git_last_include_commit;
577 $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
579 my $last_mod_date = 0;
580 $files = `find $root/include -name "*.h"`;
581 @include_files = split('\n', $files);
582 foreach my $file (@include_files) {
583 my $date = POSIX::strftime("%Y%m%d%H%M",
584 localtime((stat $file)[9]));
585 $last_mod_date = $date if ($last_mod_date < $date);
587 $camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
590 if ($camelcase_cache ne "" && -f $camelcase_cache) {
591 open(my $camelcase_file, '<', "$camelcase_cache")
592 or warn "$P: Can't read '$camelcase_cache' $!\n";
593 while (<$camelcase_file>) {
597 close($camelcase_file);
603 $files = `git ls-files "include/*.h"`;
604 @include_files = split('\n', $files);
607 foreach my $file (@include_files) {
608 seed_camelcase_file($file);
611 if ($camelcase_cache ne "") {
612 unlink glob ".checkpatch-camelcase.*";
613 open(my $camelcase_file, '>', "$camelcase_cache")
614 or warn "$P: Can't write '$camelcase_cache' $!\n";
615 foreach (sort { lc($a) cmp lc($b) } keys(%camelcase)) {
616 print $camelcase_file ("$_\n");
618 close($camelcase_file);
622 sub git_commit_info {
623 my ($commit, $id, $desc) = @_;
625 return ($id, $desc) if ((which("git") eq "") || !(-e ".git"));
627 my $output = `git log --no-color --format='%H %s' -1 $commit 2>&1`;
628 $output =~ s/^\s*//gm;
629 my @lines = split("\n", $output);
631 if ($lines[0] =~ /^error: short SHA1 $commit is ambiguous\./) {
632 # Maybe one day convert this block of bash into something that returns
633 # all matching commit ids, but it's very slow...
635 # echo "checking commits $1..."
636 # git rev-list --remotes | grep -i "^$1" |
637 # while read line ; do
638 # git log --format='%H %s' -1 $line |
639 # echo "commit $(cut -c 1-12,41-)"
641 } elsif ($lines[0] =~ /^fatal: ambiguous argument '$commit': unknown revision or path not in the working tree\./) {
643 $id = substr($lines[0], 0, 12);
644 $desc = substr($lines[0], 41);
650 $chk_signoff = 0 if ($file);
655 my @fixed_inserted = ();
656 my @fixed_deleted = ();
660 for my $filename (@ARGV) {
663 open($FILE, '-|', "diff -u /dev/null $filename") ||
664 die "$P: $filename: diff failed - $!\n";
665 } elsif ($filename eq '-') {
666 open($FILE, '<&STDIN');
668 open($FILE, '<', "$filename") ||
669 die "$P: $filename: open failed - $!\n";
671 if ($filename eq '-') {
672 $vname = 'Your patch';
681 if (!process($filename)) {
687 @fixed_inserted = ();
694 sub top_of_kernel_tree {
698 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
699 "README", "Documentation", "arch", "include", "drivers",
700 "fs", "init", "ipc", "kernel", "lib", "scripts",
703 foreach my $check (@tree_check) {
704 if (! -e $root . '/' . $check) {
712 my ($formatted_email) = @_;
718 if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
721 $comment = $3 if defined $3;
722 } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
724 $comment = $2 if defined $2;
725 } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
727 $comment = $2 if defined $2;
728 $formatted_email =~ s/$address.*$//;
729 $name = $formatted_email;
731 $name =~ s/^\"|\"$//g;
732 # If there's a name left after stripping spaces and
733 # leading quotes, and the address doesn't have both
734 # leading and trailing angle brackets, the address
736 # "joe smith joe@smith.com" bad
737 # "joe smith <joe@smith.com" bad
738 if ($name ne "" && $address !~ /^<[^>]+>$/) {
746 $name =~ s/^\"|\"$//g;
747 $address = trim($address);
748 $address =~ s/^\<|\>$//g;
750 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
751 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
755 return ($name, $address, $comment);
759 my ($name, $address) = @_;
764 $name =~ s/^\"|\"$//g;
765 $address = trim($address);
767 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
768 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
773 $formatted_email = "$address";
775 $formatted_email = "$name <$address>";
778 return $formatted_email;
784 foreach my $path (split(/:/, $ENV{PATH})) {
785 if (-e "$path/$bin") {
796 foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
797 if (-e "$path/$conf") {
798 return "$path/$conf";
810 for my $c (split(//, $str)) {
814 for (; ($n % 8) != 0; $n++) {
826 (my $res = shift) =~ tr/\t/ /c;
833 # Drop the diff line leader and expand tabs
835 $line = expand_tabs($line);
837 # Pick the indent from the front of the line.
838 my ($white) = ($line =~ /^(\s*)/);
840 return (length($line), length($white));
843 my $sanitise_quote = '';
845 sub sanitise_line_reset {
846 my ($in_comment) = @_;
849 $sanitise_quote = '*/';
851 $sanitise_quote = '';
864 # Always copy over the diff marker.
865 $res = substr($line, 0, 1);
867 for ($off = 1; $off < length($line); $off++) {
868 $c = substr($line, $off, 1);
870 # Comments we are wacking completly including the begin
871 # and end, all to $;.
872 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
873 $sanitise_quote = '*/';
875 substr($res, $off, 2, "$;$;");
879 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
880 $sanitise_quote = '';
881 substr($res, $off, 2, "$;$;");
885 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
886 $sanitise_quote = '//';
888 substr($res, $off, 2, $sanitise_quote);
893 # A \ in a string means ignore the next character.
894 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
896 substr($res, $off, 2, 'XX');
901 if ($c eq "'" || $c eq '"') {
902 if ($sanitise_quote eq '') {
903 $sanitise_quote = $c;
905 substr($res, $off, 1, $c);
907 } elsif ($sanitise_quote eq $c) {
908 $sanitise_quote = '';
912 #print "c<$c> SQ<$sanitise_quote>\n";
913 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
914 substr($res, $off, 1, $;);
915 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
916 substr($res, $off, 1, $;);
917 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
918 substr($res, $off, 1, 'X');
920 substr($res, $off, 1, $c);
924 if ($sanitise_quote eq '//') {
925 $sanitise_quote = '';
928 # The pathname on a #include may be surrounded by '<' and '>'.
929 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
930 my $clean = 'X' x length($1);
931 $res =~ s@\<.*\>@<$clean>@;
933 # The whole of a #error is a string.
934 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
935 my $clean = 'X' x length($1);
936 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
942 sub get_quoted_string {
943 my ($line, $rawline) = @_;
945 return "" if ($line !~ m/(\"[X]+\")/g);
946 return substr($rawline, $-[0], $+[0] - $-[0]);
949 sub ctx_statement_block {
950 my ($linenr, $remain, $off) = @_;
951 my $line = $linenr - 1;
968 @stack = (['', 0]) if ($#stack == -1);
970 #warn "CSB: blk<$blk> remain<$remain>\n";
971 # If we are about to drop off the end, pull in more
974 for (; $remain > 0; $line++) {
975 last if (!defined $lines[$line]);
976 next if ($lines[$line] =~ /^-/);
979 $blk .= $lines[$line] . "\n";
984 # Bail if there is no further context.
985 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
989 if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
995 $c = substr($blk, $off, 1);
996 $remainder = substr($blk, $off);
998 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
1000 # Handle nested #if/#else.
1001 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
1002 push(@stack, [ $type, $level ]);
1003 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
1004 ($type, $level) = @{$stack[$#stack - 1]};
1005 } elsif ($remainder =~ /^#\s*endif\b/) {
1006 ($type, $level) = @{pop(@stack)};
1009 # Statement ends at the ';' or a close '}' at the
1011 if ($level == 0 && $c eq ';') {
1015 # An else is really a conditional as long as its not else if
1016 if ($level == 0 && $coff_set == 0 &&
1017 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
1018 $remainder =~ /^(else)(?:\s|{)/ &&
1019 $remainder !~ /^else\s+if\b/) {
1020 $coff = $off + length($1) - 1;
1022 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
1023 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1026 if (($type eq '' || $type eq '(') && $c eq '(') {
1030 if ($type eq '(' && $c eq ')') {
1032 $type = ($level != 0)? '(' : '';
1034 if ($level == 0 && $coff < $soff) {
1037 #warn "CSB: mark coff<$coff>\n";
1040 if (($type eq '' || $type eq '{') && $c eq '{') {
1044 if ($type eq '{' && $c eq '}') {
1046 $type = ($level != 0)? '{' : '';
1049 if (substr($blk, $off + 1, 1) eq ';') {
1055 # Preprocessor commands end at the newline unless escaped.
1056 if ($type eq '#' && $c eq "\n" && $p ne "\\") {
1064 # We are truly at the end, so shuffle to the next line.
1071 my $statement = substr($blk, $soff, $off - $soff + 1);
1072 my $condition = substr($blk, $soff, $coff - $soff + 1);
1074 #warn "STATEMENT<$statement>\n";
1075 #warn "CONDITION<$condition>\n";
1077 #print "coff<$coff> soff<$off> loff<$loff>\n";
1079 return ($statement, $condition,
1080 $line, $remain + 1, $off - $loff + 1, $level);
1083 sub statement_lines {
1086 # Strip the diff line prefixes and rip blank lines at start and end.
1087 $stmt =~ s/(^|\n)./$1/g;
1091 my @stmt_lines = ($stmt =~ /\n/g);
1093 return $#stmt_lines + 2;
1096 sub statement_rawlines {
1099 my @stmt_lines = ($stmt =~ /\n/g);
1101 return $#stmt_lines + 2;
1104 sub statement_block_size {
1107 $stmt =~ s/(^|\n)./$1/g;
1113 my @stmt_lines = ($stmt =~ /\n/g);
1114 my @stmt_statements = ($stmt =~ /;/g);
1116 my $stmt_lines = $#stmt_lines + 2;
1117 my $stmt_statements = $#stmt_statements + 1;
1119 if ($stmt_lines > $stmt_statements) {
1122 return $stmt_statements;
1126 sub ctx_statement_full {
1127 my ($linenr, $remain, $off) = @_;
1128 my ($statement, $condition, $level);
1132 # Grab the first conditional/block pair.
1133 ($statement, $condition, $linenr, $remain, $off, $level) =
1134 ctx_statement_block($linenr, $remain, $off);
1135 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1136 push(@chunks, [ $condition, $statement ]);
1137 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
1138 return ($level, $linenr, @chunks);
1141 # Pull in the following conditional/block pairs and see if they
1142 # could continue the statement.
1144 ($statement, $condition, $linenr, $remain, $off, $level) =
1145 ctx_statement_block($linenr, $remain, $off);
1146 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1147 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
1149 push(@chunks, [ $condition, $statement ]);
1152 return ($level, $linenr, @chunks);
1156 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
1158 my $start = $linenr - 1;
1165 my @stack = ($level);
1166 for ($line = $start; $remain > 0; $line++) {
1167 next if ($rawlines[$line] =~ /^-/);
1170 $blk .= $rawlines[$line];
1172 # Handle nested #if/#else.
1173 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
1174 push(@stack, $level);
1175 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
1176 $level = $stack[$#stack - 1];
1177 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
1178 $level = pop(@stack);
1181 foreach my $c (split(//, $lines[$line])) {
1182 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1188 if ($c eq $close && $level > 0) {
1190 last if ($level == 0);
1191 } elsif ($c eq $open) {
1196 if (!$outer || $level <= 1) {
1197 push(@res, $rawlines[$line]);
1200 last if ($level == 0);
1203 return ($level, @res);
1205 sub ctx_block_outer {
1206 my ($linenr, $remain) = @_;
1208 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
1212 my ($linenr, $remain) = @_;
1214 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1218 my ($linenr, $remain, $off) = @_;
1220 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1223 sub ctx_block_level {
1224 my ($linenr, $remain) = @_;
1226 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1228 sub ctx_statement_level {
1229 my ($linenr, $remain, $off) = @_;
1231 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1234 sub ctx_locate_comment {
1235 my ($first_line, $end_line) = @_;
1237 # Catch a comment on the end of the line itself.
1238 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1239 return $current_comment if (defined $current_comment);
1241 # Look through the context and try and figure out if there is a
1244 $current_comment = '';
1245 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
1246 my $line = $rawlines[$linenr - 1];
1248 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
1251 if ($line =~ m@/\*@) {
1254 if (!$in_comment && $current_comment ne '') {
1255 $current_comment = '';
1257 $current_comment .= $line . "\n" if ($in_comment);
1258 if ($line =~ m@\*/@) {
1263 chomp($current_comment);
1264 return($current_comment);
1266 sub ctx_has_comment {
1267 my ($first_line, $end_line) = @_;
1268 my $cmt = ctx_locate_comment($first_line, $end_line);
1270 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1271 ##print "CMMT: $cmt\n";
1273 return ($cmt ne '');
1277 my ($linenr, $cnt) = @_;
1279 my $offset = $linenr - 1;
1284 $line = $rawlines[$offset++];
1285 next if (defined($line) && $line =~ /^-/);
1297 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
1300 $coded = sprintf("^%c", unpack('C', $2) + 64);
1309 my $av_preprocessor = 0;
1314 sub annotate_reset {
1315 $av_preprocessor = 0;
1317 @av_paren_type = ('E');
1318 $av_pend_colon = 'O';
1321 sub annotate_values {
1322 my ($stream, $type) = @_;
1325 my $var = '_' x length($stream);
1328 print "$stream\n" if ($dbg_values > 1);
1330 while (length($cur)) {
1331 @av_paren_type = ('E') if ($#av_paren_type < 0);
1332 print " <" . join('', @av_paren_type) .
1333 "> <$type> <$av_pending>" if ($dbg_values > 1);
1334 if ($cur =~ /^(\s+)/o) {
1335 print "WS($1)\n" if ($dbg_values > 1);
1336 if ($1 =~ /\n/ && $av_preprocessor) {
1337 $type = pop(@av_paren_type);
1338 $av_preprocessor = 0;
1341 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1342 print "CAST($1)\n" if ($dbg_values > 1);
1343 push(@av_paren_type, $type);
1346 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1347 print "DECLARE($1)\n" if ($dbg_values > 1);
1350 } elsif ($cur =~ /^($Modifier)\s*/) {
1351 print "MODIFIER($1)\n" if ($dbg_values > 1);
1354 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1355 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1356 $av_preprocessor = 1;
1357 push(@av_paren_type, $type);
1363 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1364 print "UNDEF($1)\n" if ($dbg_values > 1);
1365 $av_preprocessor = 1;
1366 push(@av_paren_type, $type);
1368 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1369 print "PRE_START($1)\n" if ($dbg_values > 1);
1370 $av_preprocessor = 1;
1372 push(@av_paren_type, $type);
1373 push(@av_paren_type, $type);
1376 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1377 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1378 $av_preprocessor = 1;
1380 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1384 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1385 print "PRE_END($1)\n" if ($dbg_values > 1);
1387 $av_preprocessor = 1;
1389 # Assume all arms of the conditional end as this
1390 # one does, and continue as if the #endif was not here.
1391 pop(@av_paren_type);
1392 push(@av_paren_type, $type);
1395 } elsif ($cur =~ /^(\\\n)/o) {
1396 print "PRECONT($1)\n" if ($dbg_values > 1);
1398 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1399 print "ATTR($1)\n" if ($dbg_values > 1);
1400 $av_pending = $type;
1403 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1404 print "SIZEOF($1)\n" if ($dbg_values > 1);
1410 } elsif ($cur =~ /^(if|while|for)\b/o) {
1411 print "COND($1)\n" if ($dbg_values > 1);
1415 } elsif ($cur =~/^(case)/o) {
1416 print "CASE($1)\n" if ($dbg_values > 1);
1417 $av_pend_colon = 'C';
1420 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1421 print "KEYWORD($1)\n" if ($dbg_values > 1);
1424 } elsif ($cur =~ /^(\()/o) {
1425 print "PAREN('$1')\n" if ($dbg_values > 1);
1426 push(@av_paren_type, $av_pending);
1430 } elsif ($cur =~ /^(\))/o) {
1431 my $new_type = pop(@av_paren_type);
1432 if ($new_type ne '_') {
1434 print "PAREN('$1') -> $type\n"
1435 if ($dbg_values > 1);
1437 print "PAREN('$1')\n" if ($dbg_values > 1);
1440 } elsif ($cur =~ /^($Ident)\s*\(/o) {
1441 print "FUNC($1)\n" if ($dbg_values > 1);
1445 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1446 if (defined $2 && $type eq 'C' || $type eq 'T') {
1447 $av_pend_colon = 'B';
1448 } elsif ($type eq 'E') {
1449 $av_pend_colon = 'L';
1451 print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1454 } elsif ($cur =~ /^($Ident|$Constant)/o) {
1455 print "IDENT($1)\n" if ($dbg_values > 1);
1458 } elsif ($cur =~ /^($Assignment)/o) {
1459 print "ASSIGN($1)\n" if ($dbg_values > 1);
1462 } elsif ($cur =~/^(;|{|})/) {
1463 print "END($1)\n" if ($dbg_values > 1);
1465 $av_pend_colon = 'O';
1467 } elsif ($cur =~/^(,)/) {
1468 print "COMMA($1)\n" if ($dbg_values > 1);
1471 } elsif ($cur =~ /^(\?)/o) {
1472 print "QUESTION($1)\n" if ($dbg_values > 1);
1475 } elsif ($cur =~ /^(:)/o) {
1476 print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1478 substr($var, length($res), 1, $av_pend_colon);
1479 if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1484 $av_pend_colon = 'O';
1486 } elsif ($cur =~ /^(\[)/o) {
1487 print "CLOSE($1)\n" if ($dbg_values > 1);
1490 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1493 print "OPV($1)\n" if ($dbg_values > 1);
1500 substr($var, length($res), 1, $variant);
1503 } elsif ($cur =~ /^($Operators)/o) {
1504 print "OP($1)\n" if ($dbg_values > 1);
1505 if ($1 ne '++' && $1 ne '--') {
1509 } elsif ($cur =~ /(^.)/o) {
1510 print "C($1)\n" if ($dbg_values > 1);
1513 $cur = substr($cur, length($1));
1514 $res .= $type x length($1);
1518 return ($res, $var);
1522 my ($possible, $line) = @_;
1523 my $notPermitted = qr{(?:
1540 ^(?:typedef|struct|enum)\b
1542 warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1543 if ($possible !~ $notPermitted) {
1544 # Check for modifiers.
1545 $possible =~ s/\s*$Storage\s*//g;
1546 $possible =~ s/\s*$Sparse\s*//g;
1547 if ($possible =~ /^\s*$/) {
1549 } elsif ($possible =~ /\s/) {
1550 $possible =~ s/\s*$Type\s*//g;
1551 for my $modifier (split(' ', $possible)) {
1552 if ($modifier !~ $notPermitted) {
1553 warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1554 push(@modifierList, $modifier);
1559 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1560 push(@typeList, $possible);
1564 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1573 return defined $use_type{$type} if (scalar keys %use_type > 0);
1575 return !defined $ignore_type{$type};
1579 my ($level, $type, $msg) = @_;
1581 if (!show_type($type) ||
1582 (defined $tst_only && $msg !~ /\Q$tst_only\E/)) {
1587 $line = "$prefix$level:$type: $msg\n";
1589 $line = "$prefix$level: $msg\n";
1591 $line = (split('\n', $line))[0] . "\n" if ($terse);
1593 push(our @report, $line);
1602 sub fixup_current_range {
1603 my ($lineRef, $offset, $length) = @_;
1605 if ($$lineRef =~ /^\@\@ -\d+,\d+ \+(\d+),(\d+) \@\@/) {
1608 my $no = $o + $offset;
1609 my $nl = $l + $length;
1610 $$lineRef =~ s/\+$o,$l \@\@/\+$no,$nl \@\@/;
1614 sub fix_inserted_deleted_lines {
1615 my ($linesRef, $insertedRef, $deletedRef) = @_;
1617 my $range_last_linenr = 0;
1618 my $delta_offset = 0;
1623 my $next_insert = 0;
1624 my $next_delete = 0;
1628 my $inserted = @{$insertedRef}[$next_insert++];
1629 my $deleted = @{$deletedRef}[$next_delete++];
1631 foreach my $old_line (@{$linesRef}) {
1633 my $line = $old_line; #don't modify the array
1634 if ($line =~ /^(?:\+\+\+\|\-\-\-)\s+\S+/) { #new filename
1636 } elsif ($line =~ /^\@\@ -\d+,\d+ \+\d+,\d+ \@\@/) { #new hunk
1637 $range_last_linenr = $new_linenr;
1638 fixup_current_range(\$line, $delta_offset, 0);
1641 while (defined($deleted) && ${$deleted}{'LINENR'} == $old_linenr) {
1642 $deleted = @{$deletedRef}[$next_delete++];
1644 fixup_current_range(\$lines[$range_last_linenr], $delta_offset--, -1);
1647 while (defined($inserted) && ${$inserted}{'LINENR'} == $old_linenr) {
1648 push(@lines, ${$inserted}{'LINE'});
1649 $inserted = @{$insertedRef}[$next_insert++];
1651 fixup_current_range(\$lines[$range_last_linenr], $delta_offset++, 1);
1655 push(@lines, $line);
1665 sub fix_insert_line {
1666 my ($linenr, $line) = @_;
1672 push(@fixed_inserted, $inserted);
1675 sub fix_delete_line {
1676 my ($linenr, $line) = @_;
1683 push(@fixed_deleted, $deleted);
1687 my ($type, $msg) = @_;
1689 if (report("ERROR", $type, $msg)) {
1697 my ($type, $msg) = @_;
1699 if (report("WARNING", $type, $msg)) {
1707 my ($type, $msg) = @_;
1709 if ($check && report("CHECK", $type, $msg)) {
1717 sub check_absolute_file {
1718 my ($absolute, $herecurr) = @_;
1719 my $file = $absolute;
1721 ##print "absolute<$absolute>\n";
1723 # See if any suffix of this path is a path within the tree.
1724 while ($file =~ s@^[^/]*/@@) {
1725 if (-f "$root/$file") {
1726 ##print "file<$file>\n";
1734 # It is, so see if the prefix is acceptable.
1735 my $prefix = $absolute;
1736 substr($prefix, -length($file)) = '';
1738 ##print "prefix<$prefix>\n";
1739 if ($prefix ne ".../") {
1740 WARN("USE_RELATIVE_PATH",
1741 "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1748 $string =~ s/^\s+|\s+$//g;
1756 $string =~ s/^\s+//;
1764 $string =~ s/\s+$//;
1769 sub string_find_replace {
1770 my ($string, $find, $replace) = @_;
1772 $string =~ s/$find/$replace/g;
1780 my $source_indent = 8;
1781 my $max_spaces_before_tab = $source_indent - 1;
1782 my $spaces_to_tab = " " x $source_indent;
1784 #convert leading spaces to tabs
1785 1 while $leading =~ s@^([\t]*)$spaces_to_tab@$1\t@g;
1786 #Remove spaces before a tab
1787 1 while $leading =~ s@^([\t]*)( {1,$max_spaces_before_tab})\t@$1\t@g;
1792 sub pos_last_openparen {
1797 my $opens = $line =~ tr/\(/\(/;
1798 my $closes = $line =~ tr/\)/\)/;
1800 my $last_openparen = 0;
1802 if (($opens == 0) || ($closes >= $opens)) {
1806 my $len = length($line);
1808 for ($pos = 0; $pos < $len; $pos++) {
1809 my $string = substr($line, $pos);
1810 if ($string =~ /^($FuncArg|$balanced_parens)/) {
1811 $pos += length($1) - 1;
1812 } elsif (substr($line, $pos, 1) eq '(') {
1813 $last_openparen = $pos;
1814 } elsif (index($string, '(') == -1) {
1819 return length(expand_tabs(substr($line, 0, $last_openparen))) + 1;
1823 my $filename = shift;
1829 my $stashrawline="";
1840 my $in_header_lines = $file ? 0 : 1;
1841 my $in_commit_log = 0; #Scanning lines before patch
1842 my $reported_maintainer_file = 0;
1843 my $non_utf8_charset = 0;
1845 my $last_blank_line = 0;
1853 # Trace the real file/line as we go.
1859 my $comment_edge = 0;
1863 my $prev_values = 'E';
1866 my %suppress_ifbraces;
1867 my %suppress_whiletrailers;
1868 my %suppress_export;
1869 my $suppress_statement = 0;
1871 my %signatures = ();
1873 # Pre-scan the patch sanitizing the lines.
1874 # Pre-scan the patch looking for any __setup documentation.
1876 my @setup_docs = ();
1879 my $camelcase_file_seeded = 0;
1881 sanitise_line_reset();
1883 foreach my $rawline (@rawlines) {
1887 push(@fixed, $rawline) if ($fix);
1889 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1891 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1896 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1905 # Guestimate if this is a continuing comment. Run
1906 # the context looking for a comment "edge". If this
1907 # edge is a close comment then we must be in a comment
1911 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1912 next if (defined $rawlines[$ln - 1] &&
1913 $rawlines[$ln - 1] =~ /^-/);
1915 #print "RAW<$rawlines[$ln - 1]>\n";
1916 last if (!defined $rawlines[$ln - 1]);
1917 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1918 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1923 if (defined $edge && $edge eq '*/') {
1927 # Guestimate if this is a continuing comment. If this
1928 # is the start of a diff block and this line starts
1929 # ' *' then it is very likely a comment.
1930 if (!defined $edge &&
1931 $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1936 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1937 sanitise_line_reset($in_comment);
1939 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1940 # Standardise the strings and chars within the input to
1941 # simplify matching -- only bother with positive lines.
1942 $line = sanitise_line($rawline);
1944 push(@lines, $line);
1947 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1952 #print "==>$rawline\n";
1953 #print "-->$line\n";
1955 if ($setup_docs && $line =~ /^\+/) {
1956 push(@setup_docs, $line);
1965 foreach my $line (@lines) {
1968 my $sline = $line; #copy of $line
1969 $sline =~ s/$;/ /g; #with comments as spaces
1971 my $rawline = $rawlines[$linenr - 1];
1973 #extract the line range in the file after the patch is applied
1974 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1976 $first_line = $linenr + 1;
1986 %suppress_ifbraces = ();
1987 %suppress_whiletrailers = ();
1988 %suppress_export = ();
1989 $suppress_statement = 0;
1992 # track the line number as we move through the hunk, note that
1993 # new versions of GNU diff omit the leading space on completely
1994 # blank context lines so we need to count that too.
1995 } elsif ($line =~ /^( |\+|$)/) {
1997 $realcnt-- if ($realcnt != 0);
1999 # Measure the line length and indent.
2000 ($length, $indent) = line_stats($rawline);
2002 # Track the previous line.
2003 ($prevline, $stashline) = ($stashline, $line);
2004 ($previndent, $stashindent) = ($stashindent, $indent);
2005 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
2007 #warn "line<$line>\n";
2009 } elsif ($realcnt == 1) {
2013 my $hunk_line = ($realcnt != 0);
2015 #make up the handle for any error we report on this line
2016 $prefix = "$filename:$realline: " if ($emacs && $file);
2017 $prefix = "$filename:$linenr: " if ($emacs && !$file);
2019 $here = "#$linenr: " if (!$file);
2020 $here = "#$realline: " if ($file);
2023 # extract the filename as it passes
2024 if ($line =~ /^diff --git.*?(\S+)$/) {
2026 $realfile =~ s@^([^/]*)/@@ if (!$file);
2029 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
2031 $realfile =~ s@^([^/]*)/@@ if (!$file);
2035 if (!$file && $tree && $p1_prefix ne '' &&
2036 -e "$root/$p1_prefix") {
2037 WARN("PATCH_PREFIX",
2038 "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
2041 if ($realfile =~ m@^include/asm/@) {
2042 ERROR("MODIFIED_INCLUDE_ASM",
2043 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
2049 if ($realfile =~ m@^(drivers/net/|net/)@) {
2052 $check = $check_orig;
2057 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
2059 my $hereline = "$here\n$rawline\n";
2060 my $herecurr = "$here\n$rawline\n";
2061 my $hereprev = "$here\n$prevrawline\n$rawline\n";
2063 $cnt_lines++ if ($realcnt != 0);
2065 # Check for incorrect file permissions
2066 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
2067 my $permhere = $here . "FILE: $realfile\n";
2068 if ($realfile !~ m@scripts/@ &&
2069 $realfile !~ /\.(py|pl|awk|sh)$/) {
2070 ERROR("EXECUTE_PERMISSIONS",
2071 "do not set execute permissions for source files\n" . $permhere);
2075 # Check the patch for a signoff:
2076 if ($line =~ /^\s*signed-off-by:/i) {
2081 # Check signature styles
2082 if (!$in_header_lines &&
2083 $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
2084 my $space_before = $1;
2086 my $space_after = $3;
2088 my $ucfirst_sign_off = ucfirst(lc($sign_off));
2090 if ($sign_off !~ /$signature_tags/) {
2091 WARN("BAD_SIGN_OFF",
2092 "Non-standard signature: $sign_off\n" . $herecurr);
2094 if (defined $space_before && $space_before ne "") {
2095 if (WARN("BAD_SIGN_OFF",
2096 "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr) &&
2098 $fixed[$fixlinenr] =
2099 "$ucfirst_sign_off $email";
2102 if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
2103 if (WARN("BAD_SIGN_OFF",
2104 "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr) &&
2106 $fixed[$fixlinenr] =
2107 "$ucfirst_sign_off $email";
2111 if (!defined $space_after || $space_after ne " ") {
2112 if (WARN("BAD_SIGN_OFF",
2113 "Use a single space after $ucfirst_sign_off\n" . $herecurr) &&
2115 $fixed[$fixlinenr] =
2116 "$ucfirst_sign_off $email";
2120 my ($email_name, $email_address, $comment) = parse_email($email);
2121 my $suggested_email = format_email(($email_name, $email_address));
2122 if ($suggested_email eq "") {
2123 ERROR("BAD_SIGN_OFF",
2124 "Unrecognized email address: '$email'\n" . $herecurr);
2126 my $dequoted = $suggested_email;
2127 $dequoted =~ s/^"//;
2128 $dequoted =~ s/" </ </;
2129 # Don't force email to have quotes
2130 # Allow just an angle bracketed address
2131 if ("$dequoted$comment" ne $email &&
2132 "<$email_address>$comment" ne $email &&
2133 "$suggested_email$comment" ne $email) {
2134 WARN("BAD_SIGN_OFF",
2135 "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
2139 # Check for duplicate signatures
2140 my $sig_nospace = $line;
2141 $sig_nospace =~ s/\s//g;
2142 $sig_nospace = lc($sig_nospace);
2143 if (defined $signatures{$sig_nospace}) {
2144 WARN("BAD_SIGN_OFF",
2145 "Duplicate signature\n" . $herecurr);
2147 $signatures{$sig_nospace} = 1;
2151 # Check for old stable address
2152 if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) {
2153 ERROR("STABLE_ADDRESS",
2154 "The 'stable' address should be 'stable\@vger.kernel.org'\n" . $herecurr);
2157 # Check for unwanted Gerrit info
2158 if ($in_commit_log && $line =~ /^\s*change-id:/i) {
2159 ERROR("GERRIT_CHANGE_ID",
2160 "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
2163 # Check for improperly formed commit descriptions
2164 if ($in_commit_log &&
2165 $line =~ /\bcommit\s+[0-9a-f]{5,}/i &&
2166 !($line =~ /\b[Cc]ommit [0-9a-f]{12,40} \("/ ||
2167 ($line =~ /\b[Cc]ommit [0-9a-f]{12,40}\s*$/ &&
2168 defined $rawlines[$linenr] &&
2169 $rawlines[$linenr] =~ /^\s*\("/))) {
2170 $line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i;
2172 my $orig_commit = lc($2);
2173 my $id = '01234567890ab';
2174 my $desc = 'commit description';
2175 ($id, $desc) = git_commit_info($orig_commit, $id, $desc);
2176 ERROR("GIT_COMMIT_ID",
2177 "Please use 12 or more chars for the git commit ID like: '${init_char}ommit $id (\"$desc\")'\n" . $herecurr);
2180 # Check for added, moved or deleted files
2181 if (!$reported_maintainer_file && !$in_commit_log &&
2182 ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
2183 $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
2184 ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
2185 (defined($1) || defined($2))))) {
2186 $reported_maintainer_file = 1;
2187 WARN("FILE_PATH_CHANGES",
2188 "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
2191 # Check for wrappage within a valid hunk of the file
2192 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
2193 ERROR("CORRUPTED_PATCH",
2194 "patch seems to be corrupt (line wrapped?)\n" .
2195 $herecurr) if (!$emitted_corrupt++);
2198 # Check for absolute kernel paths.
2200 while ($line =~ m{(?:^|\s)(/\S*)}g) {
2203 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
2204 check_absolute_file($1, $herecurr)) {
2207 check_absolute_file($file, $herecurr);
2212 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2213 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
2214 $rawline !~ m/^$UTF8*$/) {
2215 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
2217 my $blank = copy_spacing($rawline);
2218 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
2219 my $hereptr = "$hereline$ptr\n";
2222 "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
2225 # Check if it's the start of a commit log
2226 # (not a header line and we haven't seen the patch filename)
2227 if ($in_header_lines && $realfile =~ /^$/ &&
2228 !($rawline =~ /^\s+\S/ ||
2229 $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
2230 $in_header_lines = 0;
2234 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2235 # declined it, i.e defined some charset where it is missing.
2236 if ($in_header_lines &&
2237 $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
2239 $non_utf8_charset = 1;
2242 if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ &&
2243 $rawline =~ /$NON_ASCII_UTF8/) {
2244 WARN("UTF8_BEFORE_PATCH",
2245 "8-bit UTF-8 used in possible commit log\n" . $herecurr);
2248 # Check for various typo / spelling mistakes
2249 if ($in_commit_log || $line =~ /^\+/) {
2250 while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
2252 my $typo_fix = $spelling_fix{lc($typo)};
2253 $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
2254 $typo_fix = uc($typo_fix) if ($typo =~ /^[A-Z]+$/);
2255 my $msg_type = \&WARN;
2256 $msg_type = \&CHK if ($file);
2257 if (&{$msg_type}("TYPO_SPELLING",
2258 "'$typo' may be misspelled - perhaps '$typo_fix'?\n" . $herecurr) &&
2260 $fixed[$fixlinenr] =~ s/(^|[^A-Za-z@])($typo)($|[^A-Za-z@])/$1$typo_fix$3/;
2265 # ignore non-hunk lines and lines being removed
2266 next if (!$hunk_line || $line =~ /^-/);
2268 #trailing whitespace
2269 if ($line =~ /^\+.*\015/) {
2270 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2271 if (ERROR("DOS_LINE_ENDINGS",
2272 "DOS line endings\n" . $herevet) &&
2274 $fixed[$fixlinenr] =~ s/[\s\015]+$//;
2276 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
2277 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2278 if (ERROR("TRAILING_WHITESPACE",
2279 "trailing whitespace\n" . $herevet) &&
2281 $fixed[$fixlinenr] =~ s/\s+$//;
2287 # Check for FSF mailing addresses.
2288 if ($rawline =~ /\bwrite to the Free/i ||
2289 $rawline =~ /\b59\s+Temple\s+Pl/i ||
2290 $rawline =~ /\b51\s+Franklin\s+St/i) {
2291 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2292 my $msg_type = \&ERROR;
2293 $msg_type = \&CHK if ($file);
2294 &{$msg_type}("FSF_MAILING_ADDRESS",
2295 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2298 # check for Kconfig help text having a real description
2299 # Only applies when adding the entry originally, after that we do not have
2300 # sufficient context to determine whether it is indeed long enough.
2301 if ($realfile =~ /Kconfig/ &&
2302 $line =~ /^\+\s*config\s+/) {
2305 my $ln = $linenr + 1;
2309 for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
2310 $f = $lines[$ln - 1];
2311 $cnt-- if ($lines[$ln - 1] !~ /^-/);
2312 $is_end = $lines[$ln - 1] =~ /^\+/;
2314 next if ($f =~ /^-/);
2315 last if (!$file && $f =~ /^\@\@/);
2317 if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) {
2319 } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
2326 next if ($f =~ /^$/);
2327 if ($f =~ /^\s*config\s/) {
2333 if ($is_start && $is_end && $length < $min_conf_desc_length) {
2334 WARN("CONFIG_DESCRIPTION",
2335 "please write a paragraph that describes the config symbol fully\n" . $herecurr);
2337 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2340 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2341 if ($realfile =~ /Kconfig/ &&
2342 $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
2343 WARN("CONFIG_EXPERIMENTAL",
2344 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2347 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
2348 ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
2351 'EXTRA_AFLAGS' => 'asflags-y',
2352 'EXTRA_CFLAGS' => 'ccflags-y',
2353 'EXTRA_CPPFLAGS' => 'cppflags-y',
2354 'EXTRA_LDFLAGS' => 'ldflags-y',
2357 WARN("DEPRECATED_VARIABLE",
2358 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2361 # check for DT compatible documentation
2362 if (defined $root &&
2363 (($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
2364 ($realfile =~ /\.[ch]$/ && $line =~ /^\+.*\.compatible\s*=\s*\"/))) {
2366 my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
2368 my $dt_path = $root . "/Documentation/devicetree/bindings/";
2369 my $vp_file = $dt_path . "vendor-prefixes.txt";
2371 foreach my $compat (@compats) {
2372 my $compat2 = $compat;
2373 $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
2374 my $compat3 = $compat;
2375 $compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
2376 `grep -Erq "$compat|$compat2|$compat3" $dt_path`;
2378 WARN("UNDOCUMENTED_DT_STRING",
2379 "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr);
2382 next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
2384 `grep -Eq "^$vendor\\b" $vp_file`;
2386 WARN("UNDOCUMENTED_DT_STRING",
2387 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2392 # check we are in a valid source file if not then ignore this hunk
2393 next if ($realfile !~ /\.(h|c|s|S|pl|sh|dtsi|dts)$/);
2396 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
2397 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
2398 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
2399 $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
2400 $length > $max_line_length)
2403 "line over $max_line_length characters\n" . $herecurr);
2406 # Check for user-visible strings broken across lines, which breaks the ability
2407 # to grep for the string. Make exceptions when the previous string ends in a
2408 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
2409 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
2410 if ($line =~ /^\+\s*"/ &&
2411 $prevline =~ /"\s*$/ &&
2412 $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
2413 WARN("SPLIT_STRING",
2414 "quoted string split across lines\n" . $hereprev);
2417 # check for missing a space in a string concatination
2418 if ($prevrawline =~ /[^\\]\w"$/ && $rawline =~ /^\+[\t ]+"\w/) {
2419 WARN('MISSING_SPACE',
2420 "break quoted strings at a space character\n" . $hereprev);
2423 # check for spaces before a quoted newline
2424 if ($rawline =~ /^.*\".*\s\\n/) {
2425 if (WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
2426 "unnecessary whitespace before a quoted newline\n" . $herecurr) &&
2428 $fixed[$fixlinenr] =~ s/^(\+.*\".*)\s+\\n/$1\\n/;
2433 # check for adding lines without a newline.
2434 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2435 WARN("MISSING_EOF_NEWLINE",
2436 "adding a line without newline at end of file\n" . $herecurr);
2439 # Blackfin: use hi/lo macros
2440 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
2441 if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
2442 my $herevet = "$here\n" . cat_vet($line) . "\n";
2444 "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
2446 if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
2447 my $herevet = "$here\n" . cat_vet($line) . "\n";
2449 "use the HI() macro, not (... >> 16)\n" . $herevet);
2453 # check we are in a valid source file C or perl if not then ignore this hunk
2454 next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
2456 # at the beginning of a line any tabs must come first and anything
2457 # more than 8 must use tabs.
2458 if ($rawline =~ /^\+\s* \t\s*\S/ ||
2459 $rawline =~ /^\+\s* \s*/) {
2460 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2462 if (ERROR("CODE_INDENT",
2463 "code indent should use tabs where possible\n" . $herevet) &&
2465 $fixed[$fixlinenr] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
2469 # check for space before tabs.
2470 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
2471 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2472 if (WARN("SPACE_BEFORE_TAB",
2473 "please, no space before tabs\n" . $herevet) &&
2475 while ($fixed[$fixlinenr] =~
2476 s/(^\+.*) {8,8}\t/$1\t\t/) {}
2477 while ($fixed[$fixlinenr] =~
2478 s/(^\+.*) +\t/$1\t/) {}
2482 # check for && or || at the start of a line
2483 if ($rawline =~ /^\+\s*(&&|\|\|)/) {
2484 CHK("LOGICAL_CONTINUATIONS",
2485 "Logical continuations should be on the previous line\n" . $hereprev);
2488 # check multi-line statement indentation matches previous line
2489 if ($^V && $^V ge 5.10.0 &&
2490 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2491 $prevline =~ /^\+(\t*)(.*)$/;
2495 my $pos = pos_last_openparen($rest);
2497 $line =~ /^(\+| )([ \t]*)/;
2500 my $goodtabindent = $oldindent .
2503 my $goodspaceindent = $oldindent . " " x $pos;
2505 if ($newindent ne $goodtabindent &&
2506 $newindent ne $goodspaceindent) {
2508 if (CHK("PARENTHESIS_ALIGNMENT",
2509 "Alignment should match open parenthesis\n" . $hereprev) &&
2510 $fix && $line =~ /^\+/) {
2511 $fixed[$fixlinenr] =~
2512 s/^\+[ \t]*/\+$goodtabindent/;
2518 if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;\({\[\<\>])/ &&
2519 (!defined($1) || $1 !~ /sizeof\s*/)) {
2521 "No space is necessary after a cast\n" . $herecurr) &&
2523 $fixed[$fixlinenr] =~
2524 s/(\(\s*$Type\s*\))[ \t]+/$1/;
2528 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2529 $prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
2530 $rawline =~ /^\+[ \t]*\*/ &&
2532 WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2533 "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
2536 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2537 $prevrawline =~ /^\+[ \t]*\/\*/ && #starting /*
2538 $prevrawline !~ /\*\/[ \t]*$/ && #no trailing */
2539 $rawline =~ /^\+/ && #line is new
2540 $rawline !~ /^\+[ \t]*\*/) { #no leading *
2541 WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2542 "networking block comments start with * on subsequent lines\n" . $hereprev);
2545 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2546 $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ && #trailing */
2547 $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ && #inline /*...*/
2548 $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ && #trailing **/
2549 $rawline =~ m@^\+[ \t]*.+\*\/[ \t]*$@) { #non blank */
2550 WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2551 "networking block comments put the trailing */ on a separate line\n" . $herecurr);
2554 # check for missing blank lines after struct/union declarations
2555 # with exceptions for various attributes and macros
2556 if ($prevline =~ /^[\+ ]};?\s*$/ &&
2558 !($line =~ /^\+\s*$/ ||
2559 $line =~ /^\+\s*EXPORT_SYMBOL/ ||
2560 $line =~ /^\+\s*MODULE_/i ||
2561 $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
2562 $line =~ /^\+[a-z_]*init/ ||
2563 $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
2564 $line =~ /^\+\s*DECLARE/ ||
2565 $line =~ /^\+\s*__setup/)) {
2566 if (CHK("LINE_SPACING",
2567 "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev) &&
2569 fix_insert_line($fixlinenr, "\+");
2573 # check for multiple consecutive blank lines
2574 if ($prevline =~ /^[\+ ]\s*$/ &&
2575 $line =~ /^\+\s*$/ &&
2576 $last_blank_line != ($linenr - 1)) {
2577 if (CHK("LINE_SPACING",
2578 "Please don't use multiple blank lines\n" . $hereprev) &&
2580 fix_delete_line($fixlinenr, $rawline);
2583 $last_blank_line = $linenr;
2586 # check for missing blank lines after declarations
2587 if ($sline =~ /^\+\s+\S/ && #Not at char 1
2588 # actual declarations
2589 ($prevline =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ ||
2590 # function pointer declarations
2591 $prevline =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ ||
2592 # foo bar; where foo is some local typedef or #define
2593 $prevline =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ ||
2594 # known declaration macros
2595 $prevline =~ /^\+\s+$declaration_macros/) &&
2596 # for "else if" which can look like "$Ident $Ident"
2597 !($prevline =~ /^\+\s+$c90_Keywords\b/ ||
2598 # other possible extensions of declaration lines
2599 $prevline =~ /(?:$Compare|$Assignment|$Operators)\s*$/ ||
2600 # not starting a section or a macro "\" extended line
2601 $prevline =~ /(?:\{\s*|\\)$/) &&
2602 # looks like a declaration
2603 !($sline =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ ||
2604 # function pointer declarations
2605 $sline =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ ||
2606 # foo bar; where foo is some local typedef or #define
2607 $sline =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ ||
2608 # known declaration macros
2609 $sline =~ /^\+\s+$declaration_macros/ ||
2610 # start of struct or union or enum
2611 $sline =~ /^\+\s+(?:union|struct|enum|typedef)\b/ ||
2612 # start or end of block or continuation of declaration
2613 $sline =~ /^\+\s+(?:$|[\{\}\.\#\"\?\:\(\[])/ ||
2614 # bitfield continuation
2615 $sline =~ /^\+\s+$Ident\s*:\s*\d+\s*[,;]/ ||
2616 # other possible extensions of declaration lines
2617 $sline =~ /^\+\s+\(?\s*(?:$Compare|$Assignment|$Operators)/) &&
2618 # indentation of previous and current line are the same
2619 (($prevline =~ /\+(\s+)\S/) && $sline =~ /^\+$1\S/)) {
2620 if (WARN("LINE_SPACING",
2621 "Missing a blank line after declarations\n" . $hereprev) &&
2623 fix_insert_line($fixlinenr, "\+");
2627 # check for spaces at the beginning of a line.
2629 # 1) within comments
2630 # 2) indented preprocessor commands
2632 if ($rawline =~ /^\+ / && $line !~ /^\+ *(?:$;|#|$Ident:)/) {
2633 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2634 if (WARN("LEADING_SPACE",
2635 "please, no spaces at the start of a line\n" . $herevet) &&
2637 $fixed[$fixlinenr] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
2641 # check we are in a valid C source file if not then ignore this hunk
2642 next if ($realfile !~ /\.(h|c)$/);
2644 # check indentation of any line with a bare else
2645 # (but not if it is a multiple line "if (foo) return bar; else return baz;")
2646 # if the previous line is a break or return and is indented 1 tab more...
2647 if ($sline =~ /^\+([\t]+)(?:}[ \t]*)?else(?:[ \t]*{)?\s*$/) {
2648 my $tabs = length($1) + 1;
2649 if ($prevline =~ /^\+\t{$tabs,$tabs}break\b/ ||
2650 ($prevline =~ /^\+\t{$tabs,$tabs}return\b/ &&
2651 defined $lines[$linenr] &&
2652 $lines[$linenr] !~ /^[ \+]\t{$tabs,$tabs}return/)) {
2653 WARN("UNNECESSARY_ELSE",
2654 "else is not generally useful after a break or return\n" . $hereprev);
2658 # check indentation of a line with a break;
2659 # if the previous line is a goto or return and is indented the same # of tabs
2660 if ($sline =~ /^\+([\t]+)break\s*;\s*$/) {
2662 if ($prevline =~ /^\+$tabs(?:goto|return)\b/) {
2663 WARN("UNNECESSARY_BREAK",
2664 "break is not useful after a goto or return\n" . $hereprev);
2668 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2669 if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
2670 WARN("CONFIG_EXPERIMENTAL",
2671 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2674 # check for RCS/CVS revision markers
2675 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
2677 "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
2680 # Blackfin: don't use __builtin_bfin_[cs]sync
2681 if ($line =~ /__builtin_bfin_csync/) {
2682 my $herevet = "$here\n" . cat_vet($line) . "\n";
2684 "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
2686 if ($line =~ /__builtin_bfin_ssync/) {
2687 my $herevet = "$here\n" . cat_vet($line) . "\n";
2689 "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
2692 # check for old HOTPLUG __dev<foo> section markings
2693 if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) {
2694 WARN("HOTPLUG_SECTION",
2695 "Using $1 is unnecessary\n" . $herecurr);
2698 # Check for potential 'bare' types
2699 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
2701 #print "LINE<$line>\n";
2702 if ($linenr >= $suppress_statement &&
2703 $realcnt && $sline =~ /.\s*\S/) {
2704 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2705 ctx_statement_block($linenr, $realcnt, 0);
2706 $stat =~ s/\n./\n /g;
2707 $cond =~ s/\n./\n /g;
2709 #print "linenr<$linenr> <$stat>\n";
2710 # If this statement has no statement boundaries within
2711 # it there is no point in retrying a statement scan
2712 # until we hit end of it.
2713 my $frag = $stat; $frag =~ s/;+\s*$//;
2714 if ($frag !~ /(?:{|;)/) {
2715 #print "skip<$line_nr_next>\n";
2716 $suppress_statement = $line_nr_next;
2719 # Find the real next line.
2720 $realline_next = $line_nr_next;
2721 if (defined $realline_next &&
2722 (!defined $lines[$realline_next - 1] ||
2723 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
2730 # Ignore goto labels.
2731 if ($s =~ /$Ident:\*$/s) {
2733 # Ignore functions being called
2734 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
2736 } elsif ($s =~ /^.\s*else\b/s) {
2738 # declarations always start with types
2739 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2742 possible($type, "A:" . $s);
2744 # definitions in global scope can only start with types
2745 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
2746 possible($1, "B:" . $s);
2749 # any (foo ... *) is a pointer cast, and foo is a type
2750 while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
2751 possible($1, "C:" . $s);
2754 # Check for any sort of function declaration.
2755 # int foo(something bar, other baz);
2756 # void (*store_gdt)(x86_descr_ptr *);
2757 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2758 my ($name_len) = length($1);
2761 substr($ctx, 0, $name_len + 1, '');
2762 $ctx =~ s/\)[^\)]*$//;
2764 for my $arg (split(/\s*,\s*/, $ctx)) {
2765 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2767 possible($1, "D:" . $s);
2775 # Checks which may be anchored in the context.
2778 # Check for switch () and associated case and default
2779 # statements should be at the same indent.
2780 if ($line=~/\bswitch\s*\(.*\)/) {
2783 my @ctx = ctx_block_outer($linenr, $realcnt);
2785 for my $ctx (@ctx) {
2786 my ($clen, $cindent) = line_stats($ctx);
2787 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
2788 $indent != $cindent) {
2789 $err .= "$sep$ctx\n";
2796 ERROR("SWITCH_CASE_INDENT_LEVEL",
2797 "switch and case should be at the same indent\n$hereline$err");
2801 # if/while/etc brace do not go on next line, unless defining a do while loop,
2802 # or if that brace on the next line is for something else
2803 if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2804 my $pre_ctx = "$1$2";
2806 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
2808 if ($line =~ /^\+\t{6,}/) {
2809 WARN("DEEP_INDENTATION",
2810 "Too many leading tabs - consider code refactoring\n" . $herecurr);
2813 my $ctx_cnt = $realcnt - $#ctx - 1;
2814 my $ctx = join("\n", @ctx);
2816 my $ctx_ln = $linenr;
2817 my $ctx_skip = $realcnt;
2819 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2820 defined $lines[$ctx_ln - 1] &&
2821 $lines[$ctx_ln - 1] =~ /^-/)) {
2822 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2823 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
2827 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2828 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2830 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
2832 "that open brace { should be on the previous line\n" .
2833 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2835 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2836 $ctx =~ /\)\s*\;\s*$/ &&
2837 defined $lines[$ctx_ln - 1])
2839 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2840 if ($nindent > $indent) {
2841 WARN("TRAILING_SEMICOLON",
2842 "trailing semicolon indicates no statements, indent implies otherwise\n" .
2843 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2848 # Check relative indent for conditionals and blocks.
2849 if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2850 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2851 ctx_statement_block($linenr, $realcnt, 0)
2852 if (!defined $stat);
2853 my ($s, $c) = ($stat, $cond);
2855 substr($s, 0, length($c), '');
2857 # Make sure we remove the line prefixes as we have
2858 # none on the first line, and are going to readd them
2862 # Find out how long the conditional actually is.
2863 my @newlines = ($c =~ /\n/gs);
2864 my $cond_lines = 1 + $#newlines;
2866 # We want to check the first line inside the block
2867 # starting at the end of the conditional, so remove:
2868 # 1) any blank line termination
2869 # 2) any opening brace { on end of the line
2871 my $continuation = 0;
2873 $s =~ s/^.*\bdo\b//;
2875 if ($s =~ s/^\s*\\//) {
2878 if ($s =~ s/^\s*?\n//) {
2883 # Also ignore a loop construct at the end of a
2884 # preprocessor statement.
2885 if (($prevline =~ /^.\s*#\s*define\s/ ||
2886 $prevline =~ /\\\s*$/) && $continuation == 0) {
2892 while ($cond_ptr != $cond_lines) {
2893 $cond_ptr = $cond_lines;
2895 # If we see an #else/#elif then the code
2897 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2902 # 1) blank lines, they should be at 0,
2903 # 2) preprocessor lines, and
2905 if ($continuation ||
2907 $s =~ /^\s*#\s*?/ ||
2908 $s =~ /^\s*$Ident\s*:/) {
2909 $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
2910 if ($s =~ s/^.*?\n//) {
2916 my (undef, $sindent) = line_stats("+" . $s);
2917 my $stat_real = raw_line($linenr, $cond_lines);
2919 # Check if either of these lines are modified, else
2920 # this is not this patch's fault.
2921 if (!defined($stat_real) ||
2922 $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2925 if (defined($stat_real) && $cond_lines > 1) {
2926 $stat_real = "[...]\n$stat_real";
2929 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2931 if ($check && (($sindent % 8) != 0 ||
2932 ($sindent <= $indent && $s ne ''))) {
2933 WARN("SUSPECT_CODE_INDENT",
2934 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2938 # Track the 'values' across context and added lines.
2939 my $opline = $line; $opline =~ s/^./ /;
2940 my ($curr_values, $curr_vars) =
2941 annotate_values($opline . "\n", $prev_values);
2942 $curr_values = $prev_values . $curr_values;
2944 my $outline = $opline; $outline =~ s/\t/ /g;
2945 print "$linenr > .$outline\n";
2946 print "$linenr > $curr_values\n";
2947 print "$linenr > $curr_vars\n";
2949 $prev_values = substr($curr_values, -1);
2951 #ignore lines not being added
2952 next if ($line =~ /^[^\+]/);
2954 # TEST: allow direct testing of the type matcher.
2956 if ($line =~ /^.\s*$Declare\s*$/) {
2958 "TEST: is type\n" . $herecurr);
2959 } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2960 ERROR("TEST_NOT_TYPE",
2961 "TEST: is not type ($1 is)\n". $herecurr);
2965 # TEST: allow direct testing of the attribute matcher.
2967 if ($line =~ /^.\s*$Modifier\s*$/) {
2969 "TEST: is attr\n" . $herecurr);
2970 } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2971 ERROR("TEST_NOT_ATTR",
2972 "TEST: is not attr ($1 is)\n". $herecurr);
2977 # check for initialisation to aggregates open brace on the next line
2978 if ($line =~ /^.\s*{/ &&
2979 $prevline =~ /(?:^|[^=])=\s*$/) {
2980 if (ERROR("OPEN_BRACE",
2981 "that open brace { should be on the previous line\n" . $hereprev) &&
2982 $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
2983 fix_delete_line($fixlinenr - 1, $prevrawline);
2984 fix_delete_line($fixlinenr, $rawline);
2985 my $fixedline = $prevrawline;
2986 $fixedline =~ s/\s*=\s*$/ = {/;
2987 fix_insert_line($fixlinenr, $fixedline);
2989 $fixedline =~ s/^(.\s*){\s*/$1/;
2990 fix_insert_line($fixlinenr, $fixedline);
2995 # Checks which are anchored on the added line.
2998 # check for malformed paths in #include statements (uses RAW line)
2999 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
3001 if ($path =~ m{//}) {
3002 ERROR("MALFORMED_INCLUDE",
3003 "malformed #include filename\n" . $herecurr);
3005 if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) {
3006 ERROR("UAPI_INCLUDE",
3007 "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr);
3011 # no C99 // comments
3012 if ($line =~ m{//}) {
3013 if (ERROR("C99_COMMENTS",
3014 "do not use C99 // comments\n" . $herecurr) &&
3016 my $line = $fixed[$fixlinenr];
3017 if ($line =~ /\/\/(.*)$/) {
3018 my $comment = trim($1);
3019 $fixed[$fixlinenr] =~ s@\/\/(.*)$@/\* $comment \*/@;
3023 # Remove C99 comments.
3025 $opline =~ s@//.*@@;
3027 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
3028 # the whole statement.
3029 #print "APW <$lines[$realline_next - 1]>\n";
3030 if (defined $realline_next &&
3031 exists $lines[$realline_next - 1] &&
3032 !defined $suppress_export{$realline_next} &&
3033 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
3034 $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
3035 # Handle definitions which produce identifiers with
3038 # EXPORT_SYMBOL(something_foo);
3040 if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
3041 $name =~ /^${Ident}_$2/) {
3042 #print "FOO C name<$name>\n";
3043 $suppress_export{$realline_next} = 1;
3045 } elsif ($stat !~ /(?:
3047 ^.DEFINE_$Ident\(\Q$name\E\)|
3048 ^.DECLARE_$Ident\(\Q$name\E\)|
3049 ^.LIST_HEAD\(\Q$name\E\)|
3050 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
3051 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
3053 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
3054 $suppress_export{$realline_next} = 2;
3056 $suppress_export{$realline_next} = 1;
3059 if (!defined $suppress_export{$linenr} &&
3060 $prevline =~ /^.\s*$/ &&
3061 ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
3062 $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
3063 #print "FOO B <$lines[$linenr - 1]>\n";
3064 $suppress_export{$linenr} = 2;
3066 if (defined $suppress_export{$linenr} &&
3067 $suppress_export{$linenr} == 2) {
3068 WARN("EXPORT_SYMBOL",
3069 "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
3072 # check for global initialisers.
3073 if ($line =~ /^\+(\s*$Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/) {
3074 if (ERROR("GLOBAL_INITIALISERS",
3075 "do not initialise globals to 0 or NULL\n" .
3078 $fixed[$fixlinenr] =~ s/($Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/$1;/;
3081 # check for static initialisers.
3082 if ($line =~ /^\+.*\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
3083 if (ERROR("INITIALISED_STATIC",
3084 "do not initialise statics to 0 or NULL\n" .
3087 $fixed[$fixlinenr] =~ s/(\bstatic\s.*?)\s*=\s*(0|NULL|false)\s*;/$1;/;
3091 # check for misordered declarations of char/short/int/long with signed/unsigned
3092 while ($sline =~ m{(\b$TypeMisordered\b)}g) {
3094 WARN("MISORDERED_TYPE",
3095 "type '$tmp' should be specified in [[un]signed] [short|int|long|long long] order\n" . $herecurr);
3098 # check for static const char * arrays.
3099 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
3100 WARN("STATIC_CONST_CHAR_ARRAY",
3101 "static const char * array should probably be static const char * const\n" .
3105 # check for static char foo[] = "bar" declarations.
3106 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
3107 WARN("STATIC_CONST_CHAR_ARRAY",
3108 "static char array declaration should probably be static const char\n" .
3112 # check for non-global char *foo[] = {"bar", ...} declarations.
3113 if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) {
3114 WARN("STATIC_CONST_CHAR_ARRAY",
3115 "char * array declaration might be better as static const\n" .
3119 # check for function declarations without arguments like "int foo()"
3120 if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) {
3121 if (ERROR("FUNCTION_WITHOUT_ARGS",
3122 "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&
3124 $fixed[$fixlinenr] =~ s/(\b($Type)\s+($Ident))\s*\(\s*\)/$2 $3(void)/;
3128 # check for uses of DEFINE_PCI_DEVICE_TABLE
3129 if ($line =~ /\bDEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=/) {
3130 if (WARN("DEFINE_PCI_DEVICE_TABLE",
3131 "Prefer struct pci_device_id over deprecated DEFINE_PCI_DEVICE_TABLE\n" . $herecurr) &&
3133 $fixed[$fixlinenr] =~ s/\b(?:static\s+|)DEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=\s*/static const struct pci_device_id $1\[\] = /;
3137 # check for new typedefs, only function parameters and sparse annotations
3139 if ($line =~ /\btypedef\s/ &&
3140 $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
3141 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
3142 $line !~ /\b$typeTypedefs\b/ &&
3143 $line !~ /\b__bitwise(?:__|)\b/) {
3144 WARN("NEW_TYPEDEFS",
3145 "do not add new typedefs\n" . $herecurr);
3148 # * goes on variable not on type
3150 while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
3152 my ($ident, $from, $to) = ($1, $2, $2);
3154 # Should start with a space.
3155 $to =~ s/^(\S)/ $1/;
3156 # Should not end with a space.
3158 # '*'s should not have spaces between.
3159 while ($to =~ s/\*\s+\*/\*\*/) {
3162 ## print "1: from<$from> to<$to> ident<$ident>\n";
3164 if (ERROR("POINTER_LOCATION",
3165 "\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr) &&
3167 my $sub_from = $ident;
3168 my $sub_to = $ident;
3169 $sub_to =~ s/\Q$from\E/$to/;
3170 $fixed[$fixlinenr] =~
3171 s@\Q$sub_from\E@$sub_to@;
3175 while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
3177 my ($match, $from, $to, $ident) = ($1, $2, $2, $3);
3179 # Should start with a space.
3180 $to =~ s/^(\S)/ $1/;
3181 # Should not end with a space.
3183 # '*'s should not have spaces between.
3184 while ($to =~ s/\*\s+\*/\*\*/) {
3186 # Modifiers should have spaces.
3187 $to =~ s/(\b$Modifier$)/$1 /;
3189 ## print "2: from<$from> to<$to> ident<$ident>\n";
3190 if ($from ne $to && $ident !~ /^$Modifier$/) {
3191 if (ERROR("POINTER_LOCATION",
3192 "\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr) &&
3195 my $sub_from = $match;
3196 my $sub_to = $match;
3197 $sub_to =~ s/\Q$from\E/$to/;
3198 $fixed[$fixlinenr] =~
3199 s@\Q$sub_from\E@$sub_to@;
3204 # # no BUG() or BUG_ON()
3205 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
3206 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
3207 # print "$herecurr";
3211 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
3212 WARN("LINUX_VERSION_CODE",
3213 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
3216 # check for uses of printk_ratelimit
3217 if ($line =~ /\bprintk_ratelimit\s*\(/) {
3218 WARN("PRINTK_RATELIMITED",
3219 "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
3222 # printk should use KERN_* levels. Note that follow on printk's on the
3223 # same line do not need a level, so we use the current block context
3224 # to try and find and validate the current printk. In summary the current
3225 # printk includes all preceding printk's which have no newline on the end.
3226 # we assume the first bad printk is the one to report.
3227 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
3229 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
3230 #print "CHECK<$lines[$ln - 1]\n";
3231 # we have a preceding printk if it ends
3232 # with "\n" ignore it, else it is to blame
3233 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
3234 if ($rawlines[$ln - 1] !~ m{\\n"}) {
3241 WARN("PRINTK_WITHOUT_KERN_LEVEL",
3242 "printk() should include KERN_ facility level\n" . $herecurr);
3246 if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
3248 my $level = lc($orig);
3249 $level = "warn" if ($level eq "warning");
3250 my $level2 = $level;
3251 $level2 = "dbg" if ($level eq "debug");
3252 WARN("PREFER_PR_LEVEL",
3253 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
3256 if ($line =~ /\bpr_warning\s*\(/) {
3257 if (WARN("PREFER_PR_LEVEL",
3258 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
3260 $fixed[$fixlinenr] =~
3261 s/\bpr_warning\b/pr_warn/;
3265 if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
3267 my $level = lc($orig);
3268 $level = "warn" if ($level eq "warning");
3269 $level = "dbg" if ($level eq "debug");
3270 WARN("PREFER_DEV_LEVEL",
3271 "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr);
3274 # function brace can't be on same line, except for #defines of do while,
3275 # or if closed on same line
3276 if (($line=~/$Type\s*$Ident\(.*\).*\s*{/) and
3277 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
3278 if (ERROR("OPEN_BRACE",
3279 "open brace '{' following function declarations go on the next line\n" . $herecurr) &&
3281 fix_delete_line($fixlinenr, $rawline);
3282 my $fixed_line = $rawline;
3283 $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*){(.*)$/;
3286 fix_insert_line($fixlinenr, ltrim($line1));
3287 fix_insert_line($fixlinenr, "\+{");
3288 if ($line2 !~ /^\s*$/) {
3289 fix_insert_line($fixlinenr, "\+\t" . trim($line2));
3294 # open braces for enum, union and struct go on the same line.
3295 if ($line =~ /^.\s*{/ &&
3296 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
3297 if (ERROR("OPEN_BRACE",
3298 "open brace '{' following $1 go on the same line\n" . $hereprev) &&
3299 $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
3300 fix_delete_line($fixlinenr - 1, $prevrawline);
3301 fix_delete_line($fixlinenr, $rawline);
3302 my $fixedline = rtrim($prevrawline) . " {";
3303 fix_insert_line($fixlinenr, $fixedline);
3304 $fixedline = $rawline;
3305 $fixedline =~ s/^(.\s*){\s*/$1\t/;
3306 if ($fixedline !~ /^\+\s*$/) {
3307 fix_insert_line($fixlinenr, $fixedline);
3312 # missing space after union, struct or enum definition
3313 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident){1,2}[=\{]/) {
3315 "missing space after $1 definition\n" . $herecurr) &&
3317 $fixed[$fixlinenr] =~
3318 s/^(.\s*(?:typedef\s+)?(?:enum|union|struct)(?:\s+$Ident){1,2})([=\{])/$1 $2/;
3322 # Function pointer declarations
3323 # check spacing between type, funcptr, and args
3324 # canonical declaration is "type (*funcptr)(args...)"
3325 if ($line =~ /^.\s*($Declare)\((\s*)\*(\s*)($Ident)(\s*)\)(\s*)\(/) {
3327 my $pre_pointer_space = $2;
3328 my $post_pointer_space = $3;
3330 my $post_funcname_space = $5;
3331 my $pre_args_space = $6;
3333 # the $Declare variable will capture all spaces after the type
3334 # so check it for a missing trailing missing space but pointer return types
3335 # don't need a space so don't warn for those.
3336 my $post_declare_space = "";
3337 if ($declare =~ /(\s+)$/) {
3338 $post_declare_space = $1;
3339 $declare = rtrim($declare);
3341 if ($declare !~ /\*$/ && $post_declare_space =~ /^$/) {
3343 "missing space after return type\n" . $herecurr);
3344 $post_declare_space = " ";
3347 # unnecessary space "type (*funcptr)(args...)"
3348 # This test is not currently implemented because these declarations are
3350 # int foo(int bar, ...)
3351 # and this is form shouldn't/doesn't generate a checkpatch warning.
3353 # elsif ($declare =~ /\s{2,}$/) {
3355 # "Multiple spaces after return type\n" . $herecurr);
3358 # unnecessary space "type ( *funcptr)(args...)"
3359 if (defined $pre_pointer_space &&
3360 $pre_pointer_space =~ /^\s/) {
3362 "Unnecessary space after function pointer open parenthesis\n" . $herecurr);
3365 # unnecessary space "type (* funcptr)(args...)"
3366 if (defined $post_pointer_space &&
3367 $post_pointer_space =~ /^\s/) {
3369 "Unnecessary space before function pointer name\n" . $herecurr);
3372 # unnecessary space "type (*funcptr )(args...)"
3373 if (defined $post_funcname_space &&
3374 $post_funcname_space =~ /^\s/) {
3376 "Unnecessary space after function pointer name\n" . $herecurr);
3379 # unnecessary space "type (*funcptr) (args...)"
3380 if (defined $pre_args_space &&
3381 $pre_args_space =~ /^\s/) {
3383 "Unnecessary space before function pointer arguments\n" . $herecurr);
3386 if (show_type("SPACING") && $fix) {
3387 $fixed[$fixlinenr] =~
3388 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3392 # check for spacing round square brackets; allowed:
3393 # 1. with a type on the left -- int [] a;
3394 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3395 # 3. inside a curly brace -- = { [0...10] = 5 }
3396 while ($line =~ /(.*?\s)\[/g) {
3397 my ($where, $prefix) = ($-[1], $1);
3398 if ($prefix !~ /$Type\s+$/ &&
3399 ($where != 0 || $prefix !~ /^.\s+$/) &&
3400 $prefix !~ /[{,]\s+$/) {
3401 if (ERROR("BRACKET_SPACE",
3402 "space prohibited before open square bracket '['\n" . $herecurr) &&
3404 $fixed[$fixlinenr] =~
3405 s/^(\+.*?)\s+\[/$1\[/;
3410 # check for spaces between functions and their parentheses.
3411 while ($line =~ /($Ident)\s+\(/g) {
3413 my $ctx_before = substr($line, 0, $-[1]);
3414 my $ctx = "$ctx_before$name";
3416 # Ignore those directives where spaces _are_ permitted.
3418 if|for|while|switch|return|case|
3419 volatile|__volatile__|
3420 __attribute__|format|__extension__|
3423 # cpp #define statements have non-optional spaces, ie
3424 # if there is a space between the name and the open
3425 # parenthesis it is simply not a parameter group.
3426 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
3428 # cpp #elif statement condition may start with a (
3429 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
3431 # If this whole things ends with a type its most
3432 # likely a typedef for a function.
3433 } elsif ($ctx =~ /$Type$/) {
3437 "space prohibited between function name and open parenthesis '('\n" . $herecurr) &&
3439 $fixed[$fixlinenr] =~
3440 s/\b$name\s+\(/$name\(/;
3445 # Check operator spacing.
3446 if (!($line=~/\#\s*include/)) {
3447 my $fixed_line = "";
3451 <<=|>>=|<=|>=|==|!=|
3452 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
3453 =>|->|<<|>>|<|>|=|!|~|
3454 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
3457 my @elements = split(/($ops|;)/, $opline);
3459 ## print("element count: <" . $#elements . ">\n");
3460 ## foreach my $el (@elements) {
3461 ## print("el: <$el>\n");
3464 my @fix_elements = ();
3467 foreach my $el (@elements) {
3468 push(@fix_elements, substr($rawline, $off, length($el)));
3469 $off += length($el);
3474 my $blank = copy_spacing($opline);
3475 my $last_after = -1;
3477 for (my $n = 0; $n < $#elements; $n += 2) {
3479 my $good = $fix_elements[$n] . $fix_elements[$n + 1];
3481 ## print("n: <$n> good: <$good>\n");
3483 $off += length($elements[$n]);
3485 # Pick up the preceding and succeeding characters.
3486 my $ca = substr($opline, 0, $off);
3488 if (length($opline) >= ($off + length($elements[$n + 1]))) {
3489 $cc = substr($opline, $off + length($elements[$n + 1]));
3491 my $cb = "$ca$;$cc";
3494 $a = 'V' if ($elements[$n] ne '');
3495 $a = 'W' if ($elements[$n] =~ /\s$/);
3496 $a = 'C' if ($elements[$n] =~ /$;$/);
3497 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
3498 $a = 'O' if ($elements[$n] eq '');
3499 $a = 'E' if ($ca =~ /^\s*$/);
3501 my $op = $elements[$n + 1];
3504 if (defined $elements[$n + 2]) {
3505 $c = 'V' if ($elements[$n + 2] ne '');
3506 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
3507 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
3508 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
3509 $c = 'O' if ($elements[$n + 2] eq '');
3510 $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
3515 my $ctx = "${a}x${c}";
3517 my $at = "(ctx:$ctx)";
3519 my $ptr = substr($blank, 0, $off) . "^";
3520 my $hereptr = "$hereline$ptr\n";
3522 # Pull out the value of this operator.
3523 my $op_type = substr($curr_values, $off + 1, 1);
3525 # Get the full operator variant.
3526 my $opv = $op . substr($curr_vars, $off, 1);
3528 # Ignore operators passed as parameters.
3529 if ($op_type ne 'V' &&
3530 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
3533 # } elsif ($op =~ /^$;+$/) {
3535 # ; should have either the end of line or a space or \ after it
3536 } elsif ($op eq ';') {
3537 if ($ctx !~ /.x[WEBC]/ &&
3538 $cc !~ /^\\/ && $cc !~ /^;/) {
3539 if (ERROR("SPACING",
3540 "space required after that '$op' $at\n" . $hereptr)) {
3541 $good = $fix_elements[$n] . trim($fix_elements[$n + 1]) . " ";
3547 } elsif ($op eq '//') {
3549 # : when part of a bitfield
3550 } elsif ($opv eq ':B') {
3551 # skip the bitfield test for now
3555 } elsif ($op eq '->') {
3556 if ($ctx =~ /Wx.|.xW/) {
3557 if (ERROR("SPACING",
3558 "spaces prohibited around that '$op' $at\n" . $hereptr)) {
3559 $good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3560 if (defined $fix_elements[$n + 2]) {
3561 $fix_elements[$n + 2] =~ s/^\s+//;
3567 # , must not have a space before and must have a space on the right.
3568 } elsif ($op eq ',') {
3569 my $rtrim_before = 0;
3570 my $space_after = 0;
3571 if ($ctx =~ /Wx./) {
3572 if (ERROR("SPACING",
3573 "space prohibited before that '$op' $at\n" . $hereptr)) {
3578 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
3579 if (ERROR("SPACING",
3580 "space required after that '$op' $at\n" . $hereptr)) {
3586 if ($rtrim_before || $space_after) {
3587 if ($rtrim_before) {
3588 $good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3590 $good = $fix_elements[$n] . trim($fix_elements[$n + 1]);
3597 # '*' as part of a type definition -- reported already.
3598 } elsif ($opv eq '*_') {
3599 #warn "'*' is part of type\n";
3601 # unary operators should have a space before and
3602 # none after. May be left adjacent to another
3603 # unary operator, or a cast
3604 } elsif ($op eq '!' || $op eq '~' ||
3605 $opv eq '*U' || $opv eq '-U' ||
3606 $opv eq '&U' || $opv eq '&&U') {
3607 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
3608 if (ERROR("SPACING",
3609 "space required before that '$op' $at\n" . $hereptr)) {
3610 if ($n != $last_after + 2) {
3611 $good = $fix_elements[$n] . " " . ltrim($fix_elements[$n + 1]);
3616 if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
3617 # A unary '*' may be const
3619 } elsif ($ctx =~ /.xW/) {
3620 if (ERROR("SPACING",
3621 "space prohibited after that '$op' $at\n" . $hereptr)) {
3622 $good = $fix_elements[$n] . rtrim($fix_elements[$n + 1]);
3623 if (defined $fix_elements[$n + 2]) {
3624 $fix_elements[$n + 2] =~ s/^\s+//;
3630 # unary ++ and unary -- are allowed no space on one side.
3631 } elsif ($op eq '++' or $op eq '--') {
3632 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
3633 if (ERROR("SPACING",
3634 "space required one side of that '$op' $at\n" . $hereptr)) {
3635 $good = $fix_elements[$n] . trim($fix_elements[$n + 1]) . " ";
3639 if ($ctx =~ /Wx[BE]/ ||
3640 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
3641 if (ERROR("SPACING",
3642 "space prohibited before that '$op' $at\n" . $hereptr)) {
3643 $good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3647 if ($ctx =~ /ExW/) {
3648 if (ERROR("SPACING",
3649 "space prohibited after that '$op' $at\n" . $hereptr)) {
3650 $good = $fix_elements[$n] . trim($fix_elements[$n + 1]);
3651 if (defined $fix_elements[$n + 2]) {
3652 $fix_elements[$n + 2] =~ s/^\s+//;
3658 # << and >> may either have or not have spaces both sides
3659 } elsif ($op eq '<<' or $op eq '>>' or
3660 $op eq '&' or $op eq '^' or $op eq '|' or
3661 $op eq '+' or $op eq '-' or
3662 $op eq '*' or $op eq '/' or
3665 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
3666 if (ERROR("SPACING",
3667 "need consistent spacing around '$op' $at\n" . $hereptr)) {
3668 $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
3669 if (defined $fix_elements[$n + 2]) {
3670 $fix_elements[$n + 2] =~ s/^\s+//;
3676 # A colon needs no spaces before when it is
3677 # terminating a case value or a label.
3678 } elsif ($opv eq ':C' || $opv eq ':L') {
3679 if ($ctx =~ /Wx./) {
3680 if (ERROR("SPACING",
3681 "space prohibited before that '$op' $at\n" . $hereptr)) {
3682 $good = rtrim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
3687 # All the others need spaces both sides.
3688 } elsif ($ctx !~ /[EWC]x[CWE]/) {
3691 # Ignore email addresses <foo@bar>
3693 $cc =~ /^\S+\@\S+>/) ||
3695 $ca =~ /<\S+\@\S+$/))
3700 # messages are ERROR, but ?: are CHK
3702 my $msg_type = \&ERROR;
3703 $msg_type = \&CHK if (($op eq '?:' || $op eq '?' || $op eq ':') && $ctx =~ /VxV/);
3705 if (&{$msg_type}("SPACING",
3706 "spaces required around that '$op' $at\n" . $hereptr)) {
3707 $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
3708 if (defined $fix_elements[$n + 2]) {
3709 $fix_elements[$n + 2] =~ s/^\s+//;
3715 $off += length($elements[$n + 1]);
3717 ## print("n: <$n> GOOD: <$good>\n");
3719 $fixed_line = $fixed_line . $good;
3722 if (($#elements % 2) == 0) {
3723 $fixed_line = $fixed_line . $fix_elements[$#elements];
3726 if ($fix && $line_fixed && $fixed_line ne $fixed[$fixlinenr]) {
3727 $fixed[$fixlinenr] = $fixed_line;
3733 # check for whitespace before a non-naked semicolon
3734 if ($line =~ /^\+.*\S\s+;\s*$/) {
3736 "space prohibited before semicolon\n" . $herecurr) &&
3738 1 while $fixed[$fixlinenr] =~
3739 s/^(\+.*\S)\s+;/$1;/;
3743 # check for multiple assignments
3744 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
3745 CHK("MULTIPLE_ASSIGNMENTS",
3746 "multiple assignments should be avoided\n" . $herecurr);
3749 ## # check for multiple declarations, allowing for a function declaration
3751 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
3752 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
3754 ## # Remove any bracketed sections to ensure we do not
3755 ## # falsly report the parameters of functions.
3757 ## while ($ln =~ s/\([^\(\)]*\)//g) {
3759 ## if ($ln =~ /,/) {
3760 ## WARN("MULTIPLE_DECLARATION",
3761 ## "declaring multiple variables together should be avoided\n" . $herecurr);
3765 #need space before brace following if, while, etc
3766 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
3768 if (ERROR("SPACING",
3769 "space required before the open brace '{'\n" . $herecurr) &&
3771 $fixed[$fixlinenr] =~ s/^(\+.*(?:do|\))){/$1 {/;
3775 ## # check for blank lines before declarations
3776 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
3777 ## $prevrawline =~ /^.\s*$/) {
3779 ## "No blank lines before declarations\n" . $hereprev);
3783 # closing brace should have a space following it when it has anything
3785 if ($line =~ /}(?!(?:,|;|\)))\S/) {
3786 if (ERROR("SPACING",
3787 "space required after that close brace '}'\n" . $herecurr) &&
3789 $fixed[$fixlinenr] =~
3790 s/}((?!(?:,|;|\)))\S)/} $1/;
3794 # check spacing on square brackets
3795 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
3796 if (ERROR("SPACING",
3797 "space prohibited after that open square bracket '['\n" . $herecurr) &&
3799 $fixed[$fixlinenr] =~
3803 if ($line =~ /\s\]/) {
3804 if (ERROR("SPACING",
3805 "space prohibited before that close square bracket ']'\n" . $herecurr) &&
3807 $fixed[$fixlinenr] =~
3812 # check spacing on parentheses
3813 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
3814 $line !~ /for\s*\(\s+;/) {
3815 if (ERROR("SPACING",
3816 "space prohibited after that open parenthesis '('\n" . $herecurr) &&
3818 $fixed[$fixlinenr] =~
3822 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
3823 $line !~ /for\s*\(.*;\s+\)/ &&
3824 $line !~ /:\s+\)/) {
3825 if (ERROR("SPACING",
3826 "space prohibited before that close parenthesis ')'\n" . $herecurr) &&
3828 $fixed[$fixlinenr] =~
3833 # check unnecessary parentheses around addressof/dereference single $Lvals
3834 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
3836 while ($line =~ /(?:[^&]&\s*|\*)\(\s*($Ident\s*(?:$Member\s*)+)\s*\)/g) {
3837 CHK("UNNECESSARY_PARENTHESES",
3838 "Unnecessary parentheses around $1\n" . $herecurr);
3841 #goto labels aren't indented, allow a single space however
3842 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
3843 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
3844 if (WARN("INDENTED_LABEL",
3845 "labels should not be indented\n" . $herecurr) &&
3847 $fixed[$fixlinenr] =~
3852 # return is not a function
3853 if (defined($stat) && $stat =~ /^.\s*return(\s*)\(/s) {
3855 if ($^V && $^V ge 5.10.0 &&
3856 $stat =~ /^.\s*return\s*($balanced_parens)\s*;\s*$/) {
3858 $value = deparenthesize($value);
3859 if ($value =~ m/^\s*$FuncArg\s*(?:\?|$)/) {
3860 ERROR("RETURN_PARENTHESES",
3861 "return is not a function, parentheses are not required\n" . $herecurr);
3863 } elsif ($spacing !~ /\s+/) {
3865 "space required before the open parenthesis '('\n" . $herecurr);
3869 # unnecessary return in a void function
3870 # at end-of-function, with the previous line a single leading tab, then return;
3871 # and the line before that not a goto label target like "out:"
3872 if ($sline =~ /^[ \+]}\s*$/ &&
3873 $prevline =~ /^\+\treturn\s*;\s*$/ &&
3875 $lines[$linenr - 3] =~ /^[ +]/ &&
3876 $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
3878 "void function return statements are not generally useful\n" . $hereprev);
3881 # if statements using unnecessary parentheses - ie: if ((foo == bar))
3882 if ($^V && $^V ge 5.10.0 &&
3883 $line =~ /\bif\s*((?:\(\s*){2,})/) {
3884 my $openparens = $1;
3885 my $count = $openparens =~ tr@\(@\(@;
3887 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
3888 my $comp = $4; #Not $1 because of $LvalOrFunc
3889 $msg = " - maybe == should be = ?" if ($comp eq "==");
3890 WARN("UNNECESSARY_PARENTHESES",
3891 "Unnecessary parentheses$msg\n" . $herecurr);
3895 # Return of what appears to be an errno should normally be -'ve
3896 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
3898 if ($name ne 'EOF' && $name ne 'ERROR') {
3899 WARN("USE_NEGATIVE_ERRNO",
3900 "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
3904 # Need a space before open parenthesis after if, while etc
3905 if ($line =~ /\b(if|while|for|switch)\(/) {
3906 if (ERROR("SPACING",
3907 "space required before the open parenthesis '('\n" . $herecurr) &&
3909 $fixed[$fixlinenr] =~
3910 s/\b(if|while|for|switch)\(/$1 \(/;
3914 # Check for illegal assignment in if conditional -- and check for trailing
3915 # statements after the conditional.
3916 if ($line =~ /do\s*(?!{)/) {
3917 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
3918 ctx_statement_block($linenr, $realcnt, 0)
3919 if (!defined $stat);
3920 my ($stat_next) = ctx_statement_block($line_nr_next,
3921 $remain_next, $off_next);
3922 $stat_next =~ s/\n./\n /g;
3923 ##print "stat<$stat> stat_next<$stat_next>\n";
3925 if ($stat_next =~ /^\s*while\b/) {
3926 # If the statement carries leading newlines,
3927 # then count those as offsets.
3929 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
3931 statement_rawlines($whitespace) - 1;
3933 $suppress_whiletrailers{$line_nr_next +
3937 if (!defined $suppress_whiletrailers{$linenr} &&
3938 defined($stat) && defined($cond) &&
3939 $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
3940 my ($s, $c) = ($stat, $cond);
3942 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
3943 ERROR("ASSIGN_IN_IF",
3944 "do not use assignment in if condition\n" . $herecurr);
3947 # Find out what is on the end of the line after the
3949 substr($s, 0, length($c), '');
3951 $s =~ s/$;//g; # Remove any comments
3952 if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
3953 $c !~ /}\s*while\s*/)
3955 # Find out how long the conditional actually is.
3956 my @newlines = ($c =~ /\n/gs);
3957 my $cond_lines = 1 + $#newlines;
3960 $stat_real = raw_line($linenr, $cond_lines)
3961 . "\n" if ($cond_lines);
3962 if (defined($stat_real) && $cond_lines > 1) {
3963 $stat_real = "[...]\n$stat_real";
3966 ERROR("TRAILING_STATEMENTS",
3967 "trailing statements should be on next line\n" . $herecurr . $stat_real);
3971 # Check for bitwise tests written as boolean
3983 WARN("HEXADECIMAL_BOOLEAN_TEST",
3984 "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
3987 # if and else should not have general statements after it
3988 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
3990 $s =~ s/$;//g; # Remove any comments
3991 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
3992 ERROR("TRAILING_STATEMENTS",
3993 "trailing statements should be on next line\n" . $herecurr);
3996 # if should not continue a brace
3997 if ($line =~ /}\s*if\b/) {
3998 ERROR("TRAILING_STATEMENTS",
3999 "trailing statements should be on next line (or did you mean 'else if'?)\n" .
4002 # case and default should not have general statements after them
4003 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
4005 (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
4009 ERROR("TRAILING_STATEMENTS",
4010 "trailing statements should be on next line\n" . $herecurr);
4013 # Check for }<nl>else {, these must be at the same
4014 # indent level to be relevant to each other.
4015 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ &&
4016 $previndent == $indent) {
4017 if (ERROR("ELSE_AFTER_BRACE",
4018 "else should follow close brace '}'\n" . $hereprev) &&
4019 $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
4020 fix_delete_line($fixlinenr - 1, $prevrawline);
4021 fix_delete_line($fixlinenr, $rawline);
4022 my $fixedline = $prevrawline;
4023 $fixedline =~ s/}\s*$//;
4024 if ($fixedline !~ /^\+\s*$/) {
4025 fix_insert_line($fixlinenr, $fixedline);
4027 $fixedline = $rawline;
4028 $fixedline =~ s/^(.\s*)else/$1} else/;
4029 fix_insert_line($fixlinenr, $fixedline);
4033 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ &&
4034 $previndent == $indent) {
4035 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
4037 # Find out what is on the end of the line after the
4039 substr($s, 0, length($c), '');
4042 if ($s =~ /^\s*;/) {
4043 if (ERROR("WHILE_AFTER_BRACE",
4044 "while should follow close brace '}'\n" . $hereprev) &&
4045 $fix && $prevline =~ /^\+/ && $line =~ /^\+/) {
4046 fix_delete_line($fixlinenr - 1, $prevrawline);
4047 fix_delete_line($fixlinenr, $rawline);
4048 my $fixedline = $prevrawline;
4049 my $trailing = $rawline;
4050 $trailing =~ s/^\+//;
4051 $trailing = trim($trailing);
4052 $fixedline =~ s/}\s*$/} $trailing/;
4053 fix_insert_line($fixlinenr, $fixedline);
4058 #Specific variable tests
4059 while ($line =~ m{($Constant|$Lval)}g) {
4062 #gcc binary extension
4063 if ($var =~ /^$Binary$/) {
4064 if (WARN("GCC_BINARY_CONSTANT",
4065 "Avoid gcc v4.3+ binary constant extension: <$var>\n" . $herecurr) &&
4067 my $hexval = sprintf("0x%x", oct($var));
4068 $fixed[$fixlinenr] =~
4069 s/\b$var\b/$hexval/;
4074 if ($var !~ /^$Constant$/ &&
4075 $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
4076 #Ignore Page<foo> variants
4077 $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
4078 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
4079 $var !~ /^(?:[a-z_]*?)_?[a-z][A-Z](?:_[a-z_]+)?$/) {
4080 while ($var =~ m{($Ident)}g) {
4082 next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
4084 seed_camelcase_includes();
4085 if (!$file && !$camelcase_file_seeded) {
4086 seed_camelcase_file($realfile);
4087 $camelcase_file_seeded = 1;
4090 if (!defined $camelcase{$word}) {
4091 $camelcase{$word} = 1;
4093 "Avoid CamelCase: <$word>\n" . $herecurr);
4099 #no spaces allowed after \ in define
4100 if ($line =~ /\#\s*define.*\\\s+$/) {
4101 if (WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
4102 "Whitespace after \\ makes next lines useless\n" . $herecurr) &&
4104 $fixed[$fixlinenr] =~ s/\s+$//;
4108 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
4109 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
4111 my $checkfile = "include/linux/$file";
4112 if (-f "$root/$checkfile" &&
4113 $realfile ne $checkfile &&
4114 $1 !~ /$allowed_asm_includes/)
4116 if ($realfile =~ m{^arch/}) {
4117 CHK("ARCH_INCLUDE_LINUX",
4118 "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
4120 WARN("INCLUDE_LINUX",
4121 "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
4126 # multi-statement macros should be enclosed in a do while loop, grab the
4127 # first statement and ensure its the whole macro if its not enclosed
4128 # in a known good container
4129 if ($realfile !~ m@/vmlinux.lds.h$@ &&
4130 $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
4133 my ($off, $dstat, $dcond, $rest);
4135 my $has_flow_statement = 0;
4136 my $has_arg_concat = 0;
4137 ($dstat, $dcond, $ln, $cnt, $off) =
4138 ctx_statement_block($linenr, $realcnt, 0);
4140 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
4141 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
4143 $has_flow_statement = 1 if ($ctx =~ /\b(goto|return)\b/);
4144 $has_arg_concat = 1 if ($ctx =~ /\#\#/);
4146 $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
4148 $dstat =~ s/\\\n.//g;
4149 $dstat =~ s/^\s*//s;
4150 $dstat =~ s/\s*$//s;
4152 # Flatten any parentheses and braces
4153 while ($dstat =~ s/\([^\(\)]*\)/1/ ||
4154 $dstat =~ s/\{[^\{\}]*\}/1/ ||
4155 $dstat =~ s/\[[^\[\]]*\]/1/)
4159 # Flatten any obvious string concatentation.
4160 while ($dstat =~ s/("X*")\s*$Ident/$1/ ||
4161 $dstat =~ s/$Ident\s*("X*")/$1/)
4165 my $exceptions = qr{
4177 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
4179 $dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
4180 $dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
4181 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
4182 $dstat !~ /^'X'$/ && $dstat !~ /^'XX'$/ && # character constants
4183 $dstat !~ /$exceptions/ &&
4184 $dstat !~ /^\.$Ident\s*=/ && # .foo =
4185 $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ && # stringification #foo
4186 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
4187 $dstat !~ /^for\s*$Constant$/ && # for (...)
4188 $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
4189 $dstat !~ /^do\s*{/ && # do {...
4190 $dstat !~ /^\({/ && # ({...
4191 $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)
4194 my $herectx = $here . "\n";
4195 my $cnt = statement_rawlines($ctx);
4197 for (my $n = 0; $n < $cnt; $n++) {
4198 $herectx .= raw_line($linenr, $n) . "\n";
4201 if ($dstat =~ /;/) {
4202 ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
4203 "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
4205 ERROR("COMPLEX_MACRO",
4206 "Macros with complex values should be enclosed in parentheses\n" . "$herectx");
4210 # check for macros with flow control, but without ## concatenation
4211 # ## concatenation is commonly a macro that defines a function so ignore those
4212 if ($has_flow_statement && !$has_arg_concat) {
4213 my $herectx = $here . "\n";
4214 my $cnt = statement_rawlines($ctx);
4216 for (my $n = 0; $n < $cnt; $n++) {
4217 $herectx .= raw_line($linenr, $n) . "\n";
4219 WARN("MACRO_WITH_FLOW_CONTROL",
4220 "Macros with flow control statements should be avoided\n" . "$herectx");
4223 # check for line continuations outside of #defines, preprocessor #, and asm
4226 if ($prevline !~ /^..*\\$/ &&
4227 $line !~ /^\+\s*\#.*\\$/ && # preprocessor
4228 $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ && # asm
4229 $line =~ /^\+.*\\$/) {
4230 WARN("LINE_CONTINUATIONS",
4231 "Avoid unnecessary line continuations\n" . $herecurr);
4235 # do {} while (0) macro tests:
4236 # single-statement macros do not need to be enclosed in do while (0) loop,
4237 # macro should not end with a semicolon
4238 if ($^V && $^V ge 5.10.0 &&
4239 $realfile !~ m@/vmlinux.lds.h$@ &&
4240 $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
4243 my ($off, $dstat, $dcond, $rest);
4245 ($dstat, $dcond, $ln, $cnt, $off) =
4246 ctx_statement_block($linenr, $realcnt, 0);
4249 $dstat =~ s/\\\n.//g;
4251 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
4256 my $cnt = statement_rawlines($ctx);
4257 my $herectx = $here . "\n";
4259 for (my $n = 0; $n < $cnt; $n++) {
4260 $herectx .= raw_line($linenr, $n) . "\n";
4263 if (($stmts =~ tr/;/;/) == 1 &&
4264 $stmts !~ /^\s*(if|while|for|switch)\b/) {
4265 WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
4266 "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
4268 if (defined $semis && $semis ne "") {
4269 WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
4270 "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
4272 } elsif ($dstat =~ /^\+\s*#\s*define\s+$Ident.*;\s*$/) {
4274 my $cnt = statement_rawlines($ctx);
4275 my $herectx = $here . "\n";
4277 for (my $n = 0; $n < $cnt; $n++) {
4278 $herectx .= raw_line($linenr, $n) . "\n";
4281 WARN("TRAILING_SEMICOLON",
4282 "macros should not use a trailing semicolon\n" . "$herectx");
4286 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
4287 # all assignments may have only one of the following with an assignment:
4290 # VMLINUX_SYMBOL(...)
4291 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
4292 WARN("MISSING_VMLINUX_SYMBOL",
4293 "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
4296 # check for redundant bracing round if etc
4297 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
4298 my ($level, $endln, @chunks) =
4299 ctx_statement_full($linenr, $realcnt, 1);
4300 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
4301 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
4302 if ($#chunks > 0 && $level == 0) {
4306 my $herectx = $here . "\n";
4307 my $ln = $linenr - 1;
4308 for my $chunk (@chunks) {
4309 my ($cond, $block) = @{$chunk};
4311 # If the condition carries leading newlines, then count those as offsets.
4312 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
4313 my $offset = statement_rawlines($whitespace) - 1;
4315 $allowed[$allow] = 0;
4316 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
4318 # We have looked at and allowed this specific line.
4319 $suppress_ifbraces{$ln + $offset} = 1;
4321 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
4322 $ln += statement_rawlines($block) - 1;
4324 substr($block, 0, length($cond), '');
4326 $seen++ if ($block =~ /^\s*{/);
4328 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
4329 if (statement_lines($cond) > 1) {
4330 #print "APW: ALLOWED: cond<$cond>\n";
4331 $allowed[$allow] = 1;
4333 if ($block =~/\b(?:if|for|while)\b/) {
4334 #print "APW: ALLOWED: block<$block>\n";
4335 $allowed[$allow] = 1;
4337 if (statement_block_size($block) > 1) {
4338 #print "APW: ALLOWED: lines block<$block>\n";
4339 $allowed[$allow] = 1;
4344 my $sum_allowed = 0;
4345 foreach (@allowed) {
4348 if ($sum_allowed == 0) {
4350 "braces {} are not necessary for any arm of this statement\n" . $herectx);
4351 } elsif ($sum_allowed != $allow &&
4354 "braces {} should be used on all arms of this statement\n" . $herectx);
4359 if (!defined $suppress_ifbraces{$linenr - 1} &&
4360 $line =~ /\b(if|while|for|else)\b/) {
4363 # Check the pre-context.
4364 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
4365 #print "APW: ALLOWED: pre<$1>\n";
4369 my ($level, $endln, @chunks) =
4370 ctx_statement_full($linenr, $realcnt, $-[0]);
4372 # Check the condition.
4373 my ($cond, $block) = @{$chunks[0]};
4374 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
4375 if (defined $cond) {
4376 substr($block, 0, length($cond), '');
4378 if (statement_lines($cond) > 1) {
4379 #print "APW: ALLOWED: cond<$cond>\n";
4382 if ($block =~/\b(?:if|for|while)\b/) {
4383 #print "APW: ALLOWED: block<$block>\n";
4386 if (statement_block_size($block) > 1) {
4387 #print "APW: ALLOWED: lines block<$block>\n";
4390 # Check the post-context.
4391 if (defined $chunks[1]) {
4392 my ($cond, $block) = @{$chunks[1]};
4393 if (defined $cond) {
4394 substr($block, 0, length($cond), '');
4396 if ($block =~ /^\s*\{/) {
4397 #print "APW: ALLOWED: chunk-1 block<$block>\n";
4401 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
4402 my $herectx = $here . "\n";
4403 my $cnt = statement_rawlines($block);
4405 for (my $n = 0; $n < $cnt; $n++) {
4406 $herectx .= raw_line($linenr, $n) . "\n";
4410 "braces {} are not necessary for single statement blocks\n" . $herectx);
4414 # check for unnecessary blank lines around braces
4415 if (($line =~ /^.\s*}\s*$/ && $prevrawline =~ /^.\s*$/)) {
4417 "Blank lines aren't necessary before a close brace '}'\n" . $hereprev);
4419 if (($rawline =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) {
4421 "Blank lines aren't necessary after an open brace '{'\n" . $hereprev);
4424 # no volatiles please
4425 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
4426 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
4428 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
4431 # concatenated string without spaces between elements
4432 if ($line =~ /"X+"[A-Z_]+/ || $line =~ /[A-Z_]+"X+"/) {
4433 CHK("CONCATENATED_STRING",
4434 "Concatenated strings should use spaces between elements\n" . $herecurr);
4438 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
4439 CHK("REDUNDANT_CODE",
4440 "if this code is redundant consider removing it\n" .
4444 # check for needless "if (<foo>) fn(<foo>)" uses
4445 if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
4446 my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
4447 if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
4449 "$1(NULL) is safe this check is probably not required\n" . $hereprev);
4453 # check for unnecessary "Out of Memory" messages
4454 if ($line =~ /^\+.*\b$logFunctions\s*\(/ &&
4455 $prevline =~ /^[ \+]\s*if\s*\(\s*(\!\s*|NULL\s*==\s*)?($Lval)(\s*==\s*NULL\s*)?\s*\)/ &&
4456 (defined $1 || defined $3) &&
4459 my $testline = $lines[$linenr - 3];
4461 my ($s, $c) = ctx_statement_block($linenr - 3, $realcnt, 0);
4462 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
4464 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
4466 "Possible unnecessary 'out of memory' message\n" . $hereprev);
4470 # check for logging functions with KERN_<LEVEL>
4471 if ($line !~ /printk\s*\(/ &&
4472 $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
4474 if (WARN("UNNECESSARY_KERN_LEVEL",
4475 "Possible unnecessary $level\n" . $herecurr) &&
4477 $fixed[$fixlinenr] =~ s/\s*$level\s*//;
4481 # check for bad placement of section $InitAttribute (e.g.: __initdata)
4482 if ($line =~ /(\b$InitAttribute\b)/) {
4484 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
4487 if ((($ptr =~ /\b(union|struct)\s+$attr\b/ &&
4488 ERROR("MISPLACED_INIT",
4489 "$attr should be placed after $var\n" . $herecurr)) ||
4490 ($ptr !~ /\b(union|struct)\s+$attr\b/ &&
4491 WARN("MISPLACED_INIT",
4492 "$attr should be placed after $var\n" . $herecurr))) &&
4494 $fixed[$fixlinenr] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
4499 # check for $InitAttributeData (ie: __initdata) with const
4500 if ($line =~ /\bconst\b/ && $line =~ /($InitAttributeData)/) {
4502 $attr =~ /($InitAttributePrefix)(.*)/;
4503 my $attr_prefix = $1;
4505 if (ERROR("INIT_ATTRIBUTE",
4506 "Use of const init definition must use ${attr_prefix}initconst\n" . $herecurr) &&
4508 $fixed[$fixlinenr] =~
4509 s/$InitAttributeData/${attr_prefix}initconst/;
4513 # check for $InitAttributeConst (ie: __initconst) without const
4514 if ($line !~ /\bconst\b/ && $line =~ /($InitAttributeConst)/) {
4516 if (ERROR("INIT_ATTRIBUTE",
4517 "Use of $attr requires a separate use of const\n" . $herecurr) &&
4519 my $lead = $fixed[$fixlinenr] =~
4520 /(^\+\s*(?:static\s+))/;
4522 $lead = "$lead " if ($lead !~ /^\+$/);
4523 $lead = "${lead}const ";
4524 $fixed[$fixlinenr] =~ s/(^\+\s*(?:static\s+))/$lead/;
4528 # don't use __constant_<foo> functions outside of include/uapi/
4529 if ($realfile !~ m@^include/uapi/@ &&
4530 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
4531 my $constant_func = $1;
4532 my $func = $constant_func;
4533 $func =~ s/^__constant_//;
4534 if (WARN("CONSTANT_CONVERSION",
4535 "$constant_func should be $func\n" . $herecurr) &&
4537 $fixed[$fixlinenr] =~ s/\b$constant_func\b/$func/g;
4541 # prefer usleep_range over udelay
4542 if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {
4544 # ignore udelay's < 10, however
4545 if (! ($delay < 10) ) {
4547 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4549 if ($delay > 2000) {
4551 "long udelay - prefer mdelay; see arch/arm/include/asm/delay.h\n" . $herecurr);
4555 # warn about unexpectedly long msleep's
4556 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
4559 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4563 # check for comparisons of jiffies
4564 if ($line =~ /\bjiffies\s*$Compare|$Compare\s*jiffies\b/) {
4565 WARN("JIFFIES_COMPARISON",
4566 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
4569 # check for comparisons of get_jiffies_64()
4570 if ($line =~ /\bget_jiffies_64\s*\(\s*\)\s*$Compare|$Compare\s*get_jiffies_64\s*\(\s*\)/) {
4571 WARN("JIFFIES_COMPARISON",
4572 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
4575 # warn about #ifdefs in C files
4576 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
4577 # print "#ifdef in C files should be avoided\n";
4578 # print "$herecurr";
4582 # warn about spacing in #ifdefs
4583 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
4584 if (ERROR("SPACING",
4585 "exactly one space required after that #$1\n" . $herecurr) &&
4587 $fixed[$fixlinenr] =~
4588 s/^(.\s*\#\s*(ifdef|ifndef|elif))\s{2,}/$1 /;
4593 # check for spinlock_t definitions without a comment.
4594 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
4595 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
4597 if (!ctx_has_comment($first_line, $linenr)) {
4598 CHK("UNCOMMENTED_DEFINITION",
4599 "$1 definition without comment\n" . $herecurr);
4602 # check for memory barriers without a comment.
4603 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
4604 if (!ctx_has_comment($first_line, $linenr)) {
4605 WARN("MEMORY_BARRIER",
4606 "memory barrier without comment\n" . $herecurr);
4609 # check of hardware specific defines
4610 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
4612 "architecture specific defines should be avoided\n" . $herecurr);
4615 # Check that the storage class is at the beginning of a declaration
4616 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
4617 WARN("STORAGE_CLASS",
4618 "storage class should be at the beginning of the declaration\n" . $herecurr)
4621 # check the location of the inline attribute, that it is between
4622 # storage class and type.
4623 if ($line =~ /\b$Type\s+$Inline\b/ ||
4624 $line =~ /\b$Inline\s+$Storage\b/) {
4625 ERROR("INLINE_LOCATION",
4626 "inline keyword should sit between storage class and type\n" . $herecurr);
4629 # Check for __inline__ and __inline, prefer inline
4630 if ($realfile !~ m@\binclude/uapi/@ &&
4631 $line =~ /\b(__inline__|__inline)\b/) {
4633 "plain inline is preferred over $1\n" . $herecurr) &&
4635 $fixed[$fixlinenr] =~ s/\b(__inline__|__inline)\b/inline/;
4640 # Check for __attribute__ packed, prefer __packed
4641 if ($realfile !~ m@\binclude/uapi/@ &&
4642 $line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
4643 WARN("PREFER_PACKED",
4644 "__packed is preferred over __attribute__((packed))\n" . $herecurr);
4647 # Check for __attribute__ aligned, prefer __aligned
4648 if ($realfile !~ m@\binclude/uapi/@ &&
4649 $line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
4650 WARN("PREFER_ALIGNED",
4651 "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
4654 # Check for __attribute__ format(printf, prefer __printf
4655 if ($realfile !~ m@\binclude/uapi/@ &&
4656 $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
4657 if (WARN("PREFER_PRINTF",
4658 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
4660 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
4665 # Check for __attribute__ format(scanf, prefer __scanf
4666 if ($realfile !~ m@\binclude/uapi/@ &&
4667 $line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
4668 if (WARN("PREFER_SCANF",
4669 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
4671 $fixed[$fixlinenr] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
4675 # Check for __attribute__ weak, or __weak declarations (may have link issues)
4676 if ($^V && $^V ge 5.10.0 &&
4677 $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
4678 ($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ ||
4679 $line =~ /\b__weak\b/)) {
4680 ERROR("WEAK_DECLARATION",
4681 "Using weak declarations can have unintended link defects\n" . $herecurr);
4684 # check for sizeof(&)
4685 if ($line =~ /\bsizeof\s*\(\s*\&/) {
4686 WARN("SIZEOF_ADDRESS",
4687 "sizeof(& should be avoided\n" . $herecurr);
4690 # check for sizeof without parenthesis
4691 if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
4692 if (WARN("SIZEOF_PARENTHESIS",
4693 "sizeof $1 should be sizeof($1)\n" . $herecurr) &&
4695 $fixed[$fixlinenr] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
4699 # check for line continuations in quoted strings with odd counts of "
4700 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
4701 WARN("LINE_CONTINUATIONS",
4702 "Avoid line continuations in quoted strings\n" . $herecurr);
4705 # check for struct spinlock declarations
4706 if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
4707 WARN("USE_SPINLOCK_T",
4708 "struct spinlock should be spinlock_t\n" . $herecurr);
4711 # check for seq_printf uses that could be seq_puts
4712 if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
4713 my $fmt = get_quoted_string($line, $rawline);
4714 if ($fmt ne "" && $fmt !~ /[^\\]\%/) {
4715 if (WARN("PREFER_SEQ_PUTS",
4716 "Prefer seq_puts to seq_printf\n" . $herecurr) &&
4718 $fixed[$fixlinenr] =~ s/\bseq_printf\b/seq_puts/;
4723 # Check for misused memsets
4724 if ($^V && $^V ge 5.10.0 &&
4726 $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
4732 if ($ms_size =~ /^(0x|)0$/i) {
4734 "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
4735 } elsif ($ms_size =~ /^(0x|)1$/i) {
4737 "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
4741 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
4742 if ($^V && $^V ge 5.10.0 &&
4743 $line =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) {
4744 if (WARN("PREFER_ETHER_ADDR_COPY",
4745 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . $herecurr) &&
4747 $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
4751 # typecasts on min/max could be min_t/max_t
4752 if ($^V && $^V ge 5.10.0 &&
4754 $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
4755 if (defined $2 || defined $7) {
4757 my $cast1 = deparenthesize($2);
4759 my $cast2 = deparenthesize($7);
4763 if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
4764 $cast = "$cast1 or $cast2";
4765 } elsif ($cast1 ne "") {
4771 "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
4775 # check usleep_range arguments
4776 if ($^V && $^V ge 5.10.0 &&
4778 $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
4782 WARN("USLEEP_RANGE",
4783 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4784 } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
4786 WARN("USLEEP_RANGE",
4787 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4791 # check for naked sscanf
4792 if ($^V && $^V ge 5.10.0 &&
4794 $line =~ /\bsscanf\b/ &&
4795 ($stat !~ /$Ident\s*=\s*sscanf\s*$balanced_parens/ &&
4796 $stat !~ /\bsscanf\s*$balanced_parens\s*(?:$Compare)/ &&
4797 $stat !~ /(?:$Compare)\s*\bsscanf\s*$balanced_parens/)) {
4798 my $lc = $stat =~ tr@\n@@;
4799 $lc = $lc + $linenr;
4800 my $stat_real = raw_line($linenr, 0);
4801 for (my $count = $linenr + 1; $count <= $lc; $count++) {
4802 $stat_real = $stat_real . "\n" . raw_line($count, 0);
4804 WARN("NAKED_SSCANF",
4805 "unchecked sscanf return value\n" . "$here\n$stat_real\n");
4808 # check for simple sscanf that should be kstrto<foo>
4809 if ($^V && $^V ge 5.10.0 &&
4811 $line =~ /\bsscanf\b/) {
4812 my $lc = $stat =~ tr@\n@@;
4813 $lc = $lc + $linenr;
4814 my $stat_real = raw_line($linenr, 0);
4815 for (my $count = $linenr + 1; $count <= $lc; $count++) {
4816 $stat_real = $stat_real . "\n" . raw_line($count, 0);
4818 if ($stat_real =~ /\bsscanf\b\s*\(\s*$FuncArg\s*,\s*("[^"]+")/) {
4820 my $count = $format =~ tr@%@%@;
4822 $format =~ /^"\%(?i:ll[udxi]|[udxi]ll|ll|[hl]h?[udxi]|[udxi][hl]h?|[hl]h?|[udxi])"$/) {
4823 WARN("SSCANF_TO_KSTRTO",
4824 "Prefer kstrto<type> to single variable sscanf\n" . "$here\n$stat_real\n");
4829 # check for new externs in .h files.
4830 if ($realfile =~ /\.h$/ &&
4831 $line =~ /^\+\s*(extern\s+)$Type\s*$Ident\s*\(/s) {
4832 if (CHK("AVOID_EXTERNS",
4833 "extern prototypes should be avoided in .h files\n" . $herecurr) &&
4835 $fixed[$fixlinenr] =~ s/(.*)\bextern\b\s*(.*)/$1$2/;
4839 # check for new externs in .c files.
4840 if ($realfile =~ /\.c$/ && defined $stat &&
4841 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
4843 my $function_name = $1;
4844 my $paren_space = $2;
4847 if (defined $cond) {
4848 substr($s, 0, length($cond), '');
4850 if ($s =~ /^\s*;/ &&
4851 $function_name ne 'uninitialized_var')
4853 WARN("AVOID_EXTERNS",
4854 "externs should be avoided in .c files\n" . $herecurr);
4857 if ($paren_space =~ /\n/) {
4858 WARN("FUNCTION_ARGUMENTS",
4859 "arguments for function declarations should follow identifier\n" . $herecurr);
4862 } elsif ($realfile =~ /\.c$/ && defined $stat &&
4863 $stat =~ /^.\s*extern\s+/)
4865 WARN("AVOID_EXTERNS",
4866 "externs should be avoided in .c files\n" . $herecurr);
4869 # checks for new __setup's
4870 if ($rawline =~ /\b__setup\("([^"]*)"/) {
4873 if (!grep(/$name/, @setup_docs)) {
4874 CHK("UNDOCUMENTED_SETUP",
4875 "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
4879 # check for pointless casting of kmalloc return
4880 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
4881 WARN("UNNECESSARY_CASTS",
4882 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
4886 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
4887 if ($^V && $^V ge 5.10.0 &&
4888 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
4889 CHK("ALLOC_SIZEOF_STRUCT",
4890 "Prefer $3(sizeof(*$1)...) over $3($4...)\n" . $herecurr);
4893 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
4894 if ($^V && $^V ge 5.10.0 &&
4895 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) {
4899 my $newfunc = "kmalloc_array";
4900 $newfunc = "kcalloc" if ($oldfunc eq "kzalloc");
4903 if ($a1 =~ /^sizeof\s*\S/) {
4907 if ($r1 !~ /^sizeof\b/ && $r2 =~ /^sizeof\s*\S/ &&
4908 !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) {
4909 if (WARN("ALLOC_WITH_MULTIPLY",
4910 "Prefer $newfunc over $oldfunc with multiply\n" . $herecurr) &&
4912 $fixed[$fixlinenr] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
4918 # check for krealloc arg reuse
4919 if ($^V && $^V ge 5.10.0 &&
4920 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*krealloc\s*\(\s*\1\s*,/) {
4921 WARN("KREALLOC_ARG_REUSE",
4922 "Reusing the krealloc arg is almost always a bug\n" . $herecurr);
4925 # check for alloc argument mismatch
4926 if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
4927 WARN("ALLOC_ARRAY_ARGS",
4928 "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
4931 # check for multiple semicolons
4932 if ($line =~ /;\s*;\s*$/) {
4933 if (WARN("ONE_SEMICOLON",
4934 "Statements terminations use 1 semicolon\n" . $herecurr) &&
4936 $fixed[$fixlinenr] =~ s/(\s*;\s*){2,}$/;/g;
4940 # check for case / default statements not preceded by break/fallthrough/switch
4941 if ($line =~ /^.\s*(?:case\s+(?:$Ident|$Constant)\s*|default):/) {
4943 my $has_statement = 0;
4945 my $prevline = $linenr;
4946 while ($prevline > 1 && ($file || $count < 3) && !$has_break) {
4948 my $rline = $rawlines[$prevline - 1];
4949 my $fline = $lines[$prevline - 1];
4950 last if ($fline =~ /^\@\@/);
4951 next if ($fline =~ /^\-/);
4952 next if ($fline =~ /^.(?:\s*(?:case\s+(?:$Ident|$Constant)[\s$;]*|default):[\s$;]*)*$/);
4953 $has_break = 1 if ($rline =~ /fall[\s_-]*(through|thru)/i);
4954 next if ($fline =~ /^.[\s$;]*$/);
4957 $has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|return\b|goto\b|continue\b)/);
4959 if (!$has_break && $has_statement) {
4960 WARN("MISSING_BREAK",
4961 "Possible switch case/default not preceeded by break or fallthrough comment\n" . $herecurr);
4965 # check for switch/default statements without a break;
4966 if ($^V && $^V ge 5.10.0 &&
4968 $stat =~ /^\+[$;\s]*(?:case[$;\s]+\w+[$;\s]*:[$;\s]*|)*[$;\s]*\bdefault[$;\s]*:[$;\s]*;/g) {
4970 my $herectx = $here . "\n";
4971 my $cnt = statement_rawlines($stat);
4972 for (my $n = 0; $n < $cnt; $n++) {
4973 $herectx .= raw_line($linenr, $n) . "\n";
4975 WARN("DEFAULT_NO_BREAK",
4976 "switch default: should use break\n" . $herectx);
4979 # check for gcc specific __FUNCTION__
4980 if ($line =~ /\b__FUNCTION__\b/) {
4981 if (WARN("USE_FUNC",
4982 "__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr) &&
4984 $fixed[$fixlinenr] =~ s/\b__FUNCTION__\b/__func__/g;
4988 # check for use of yield()
4989 if ($line =~ /\byield\s*\(\s*\)/) {
4991 "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
4994 # check for comparisons against true and false
4995 if ($line =~ /\+\s*(.*?)\b(true|false|$Lval)\s*(==|\!=)\s*(true|false|$Lval)\b(.*)$/i) {
5003 ($arg, $otype) = ($otype, $arg) if ($arg =~ /^(?:true|false)$/i);
5005 my $type = lc($otype);
5006 if ($type =~ /^(?:true|false)$/) {
5007 if (("$test" eq "==" && "$type" eq "true") ||
5008 ("$test" eq "!=" && "$type" eq "false")) {
5012 CHK("BOOL_COMPARISON",
5013 "Using comparison to $otype is error prone\n" . $herecurr);
5015 ## maybe suggesting a correct construct would better
5016 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
5021 # check for semaphores initialized locked
5022 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
5023 WARN("CONSIDER_COMPLETION",
5024 "consider using a completion\n" . $herecurr);
5027 # recommend kstrto* over simple_strto* and strict_strto*
5028 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
5029 WARN("CONSIDER_KSTRTO",
5030 "$1 is obsolete, use k$3 instead\n" . $herecurr);
5033 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
5034 if ($line =~ /^.\s*__initcall\s*\(/) {
5035 WARN("USE_DEVICE_INITCALL",
5036 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
5039 # check for various ops structs, ensure they are const.
5040 my $struct_ops = qr{acpi_dock_ops|
5041 address_space_operations|
5043 block_device_operations|
5048 file_lock_operations|
5058 lock_manager_operations|
5064 pipe_buf_operations|
5065 platform_hibernation_ops|
5066 platform_suspend_ops|
5071 soc_pcmcia_socket_ops|
5077 if ($line !~ /\bconst\b/ &&
5078 $line =~ /\bstruct\s+($struct_ops)\b/) {
5079 WARN("CONST_STRUCT",
5080 "struct $1 should normally be const\n" .
5084 # use of NR_CPUS is usually wrong
5085 # ignore definitions of NR_CPUS and usage to define arrays as likely right
5086 if ($line =~ /\bNR_CPUS\b/ &&
5087 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
5088 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
5089 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
5090 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
5091 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
5094 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
5097 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
5098 if ($line =~ /\+\s*#\s*define\s+((?:__)?ARCH_(?:HAS|HAVE)\w*)\b/) {
5099 ERROR("DEFINE_ARCH_HAS",
5100 "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);
5103 # check for %L{u,d,i} in strings
5105 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
5106 $string = substr($rawline, $-[1], $+[1] - $-[1]);
5107 $string =~ s/%%/__/g;
5108 if ($string =~ /(?<!%)%L[udi]/) {
5110 "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
5115 # whine mightly about in_atomic
5116 if ($line =~ /\bin_atomic\s*\(/) {
5117 if ($realfile =~ m@^drivers/@) {
5119 "do not use in_atomic in drivers\n" . $herecurr);
5120 } elsif ($realfile !~ m@^kernel/@) {
5122 "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
5126 # check for lockdep_set_novalidate_class
5127 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
5128 $line =~ /__lockdep_no_validate__\s*\)/ ) {
5129 if ($realfile !~ m@^kernel/lockdep@ &&
5130 $realfile !~ m@^include/linux/lockdep@ &&
5131 $realfile !~ m@^drivers/base/core@) {
5133 "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
5137 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
5138 $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
5139 WARN("EXPORTED_WORLD_WRITABLE",
5140 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
5143 # Mode permission misuses where it seems decimal should be octal
5144 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
5145 if ($^V && $^V ge 5.10.0 &&
5146 $line =~ /$mode_perms_search/) {
5147 foreach my $entry (@mode_permission_funcs) {
5148 my $func = $entry->[0];
5149 my $arg_pos = $entry->[1];
5154 $skip_args = "(?:\\s*$FuncArg\\s*,\\s*){$arg_pos,$arg_pos}";
5156 my $test = "\\b$func\\s*\\(${skip_args}([\\d]+)\\s*[,\\)]";
5157 if ($line =~ /$test/) {
5159 $val = $6 if ($skip_args ne "");
5161 if ($val !~ /^0$/ &&
5162 (($val =~ /^$Int$/ && $val !~ /^$Octal$/) ||
5163 length($val) ne 4)) {
5164 ERROR("NON_OCTAL_PERMISSIONS",
5165 "Use 4 digit octal (0777) not decimal permissions\n" . $herecurr);
5172 # If we have no input at all, then there is nothing to report on
5173 # so just keep quiet.
5174 if ($#rawlines == -1) {
5178 # In mailback mode only produce a report in the negative, for
5179 # things that appear to be patches.
5180 if ($mailback && ($clean == 1 || !$is_patch)) {
5184 # This is not a patch, and we are are in 'no-patch' mode so
5186 if (!$chk_patch && !$is_patch) {
5191 ERROR("NOT_UNIFIED_DIFF",
5192 "Does not appear to be a unified-diff format patch\n");
5194 if ($is_patch && $chk_signoff && $signoff == 0) {
5195 ERROR("MISSING_SIGN_OFF",
5196 "Missing Signed-off-by: line(s)\n");
5199 print report_dump();
5200 if ($summary && !($clean == 1 && $quiet == 1)) {
5201 print "$filename " if ($summary_file);
5202 print "total: $cnt_error errors, $cnt_warn warnings, " .
5203 (($check)? "$cnt_chk checks, " : "") .
5204 "$cnt_lines lines checked\n";
5205 print "\n" if ($quiet == 0);
5210 if ($^V lt 5.10.0) {
5211 print("NOTE: perl $^V is not modern enough to detect all possible issues.\n");
5212 print("An upgrade to at least perl v5.10.0 is suggested.\n\n");
5215 # If there were whitespace errors which cleanpatch can fix
5216 # then suggest that.
5217 if ($rpt_cleaners) {
5218 print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
5219 print " scripts/cleanfile\n\n";
5224 hash_show_words(\%use_type, "Used");
5225 hash_show_words(\%ignore_type, "Ignored");
5227 if ($clean == 0 && $fix &&
5228 ("@rawlines" ne "@fixed" ||
5229 $#fixed_inserted >= 0 || $#fixed_deleted >= 0)) {
5230 my $newfile = $filename;
5231 $newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace);
5235 @fixed = fix_inserted_deleted_lines(\@fixed, \@fixed_inserted, \@fixed_deleted);
5237 open($f, '>', $newfile)
5238 or die "$P: Can't open $newfile for write\n";
5239 foreach my $fixed_line (@fixed) {
5242 if ($linecount > 3) {
5243 $fixed_line =~ s/^\+//;
5244 print $f $fixed_line . "\n";
5247 print $f $fixed_line . "\n";
5254 Wrote EXPERIMENTAL --fix correction(s) to '$newfile'
5256 Do _NOT_ trust the results written to this file.
5257 Do _NOT_ submit these changes without inspecting them for correctness.
5259 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
5260 No warranties, expressed or implied...
5266 if ($clean == 1 && $quiet == 0) {
5267 print "$vname has no obvious style problems and is ready for submission.\n"
5269 if ($clean == 0 && $quiet == 0) {
5271 $vname has style problems, please review.
5273 If any of these errors are false positives, please report
5274 them to the maintainer, see CHECKPATCH in MAINTAINERS.