Merge branch 'timers/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git...

[cascardo/linux.git] / drivers / net / es3210.c

diff --git a/drivers/net/es3210.c b/drivers/net/es3210.c
index 50f8e23..deefa51 100644 (file)
--- a/drivers/net/es3210.c
+++ b/drivers/net/es3210.c
@@ -130,8 +130,6 @@ static int __init do_es_probe(struct net_device *dev)
        int irq = dev->irq;
        int mem_start = dev->mem_start;
 
-       SET_MODULE_OWNER(dev);
-
        if (ioaddr > 0x1ff)             /* Check a single specified location. */
                return es_probe1(dev, ioaddr);
        else if (ioaddr > 0)            /* Don't probe at all. */
@@ -155,13 +153,6 @@ static int __init do_es_probe(struct net_device *dev)
        return -ENODEV;
 }
 
-static void cleanup_card(struct net_device *dev)
-{
-       free_irq(dev->irq, dev);
-       release_region(dev->base_addr, ES_IO_EXTENT);
-       iounmap(ei_status.mem);
-}
-
 #ifndef MODULE
 struct net_device * __init es_probe(int unit)
 {
@@ -188,6 +179,7 @@ static int __init es_probe1(struct net_device *dev, int ioaddr)
 {
        int i, retval;
        unsigned long eisa_id;
+       DECLARE_MAC_BUF(mac);
 
        if (!request_region(ioaddr + ES_SA_PROM, ES_IO_EXTENT, "es3210"))
                return -ENODEV;
@@ -199,7 +191,6 @@ static int __init es_probe1(struct net_device *dev, int ioaddr)
                inb(ioaddr + ES_CFG4), inb(ioaddr + ES_CFG5), inb(ioaddr + ES_CFG6));
 #endif
 
-
 /*     Check the EISA ID of the card. */
        eisa_id = inl(ioaddr + ES_ID_PORT);
        if ((eisa_id != ES_EISA_ID1) && (eisa_id != ES_EISA_ID2)) {
@@ -207,21 +198,21 @@ static int __init es_probe1(struct net_device *dev, int ioaddr)
                goto out;
        }
 
+       for (i = 0; i < ETHER_ADDR_LEN ; i++)
+               dev->dev_addr[i] = inb(ioaddr + ES_SA_PROM + i);
+
 /*     Check the Racal vendor ID as well. */
-       if (inb(ioaddr + ES_SA_PROM + 0) != ES_ADDR0
-               || inb(ioaddr + ES_SA_PROM + 1) != ES_ADDR1
-               || inb(ioaddr + ES_SA_PROM + 2) != ES_ADDR2 ) {
-               printk("es3210.c: card not found");
-               for(i = 0; i < ETHER_ADDR_LEN; i++)
-                       printk(" %02x", inb(ioaddr + ES_SA_PROM + i));
-               printk(" (invalid prefix).\n");
+       if (dev->dev_addr[0] != ES_ADDR0 ||
+           dev->dev_addr[1] != ES_ADDR1 ||
+           dev->dev_addr[2] != ES_ADDR2) {
+               printk("es3210.c: card not found %s (invalid_prefix).\n",
+                      print_mac(mac, dev->dev_addr));
                retval = -ENODEV;
                goto out;
        }
 
-       printk("es3210.c: ES3210 rev. %ld at %#x, node", eisa_id>>24, ioaddr);
-       for(i = 0; i < ETHER_ADDR_LEN; i++)
-               printk(" %02x", (dev->dev_addr[i] = inb(ioaddr + ES_SA_PROM + i)));
+       printk("es3210.c: ES3210 rev. %ld at %#x, node %s",
+              eisa_id>>24, ioaddr, print_mac(mac, dev->dev_addr));
 
        /* Snarf the interrupt now. */
        if (dev->irq == 0) {
@@ -382,7 +373,7 @@ static void es_block_input(struct net_device *dev, int count, struct sk_buff *sk
                memcpy_fromio(skb->data + semi_count, ei_status.mem, count);
        } else {
                /* Packet is in one chunk. */
-               eth_io_copy_and_sum(skb, xfer_start, count, 0);
+               memcpy_fromio(skb->data, xfer_start, count);
        }
 }
 
@@ -428,8 +419,7 @@ MODULE_PARM_DESC(mem, "memory base address(es)");
 MODULE_DESCRIPTION("Racal-Interlan ES3210 EISA ethernet driver");
 MODULE_LICENSE("GPL");
 
-int
-init_module(void)
+int __init init_module(void)
 {
        struct net_device *dev;
        int this_dev, found = 0;
@@ -456,7 +446,14 @@ init_module(void)
        return -ENXIO;
 }
 
-void
+static void cleanup_card(struct net_device *dev)
+{
+       free_irq(dev->irq, dev);
+       release_region(dev->base_addr, ES_IO_EXTENT);
+       iounmap(ei_status.mem);
+}
+
+void __exit
 cleanup_module(void)
 {
        int this_dev;