Merge branch 'pci/trivial' into next
[cascardo/linux.git] / drivers / pci / hotplug / ibmphp_res.c
index f279060..aee6e41 100644 (file)
 
 static int flags = 0;          /* for testing */
 
-static void update_resources (struct bus_node *bus_cur, int type, int rangeno);
-static int once_over (void);
-static int remove_ranges (struct bus_node *, struct bus_node *);
-static int update_bridge_ranges (struct bus_node **);
-static int add_bus_range (int type, struct range_node *, struct bus_node *);
-static void fix_resources (struct bus_node *);
-static struct bus_node *find_bus_wprev (u8, struct bus_node **, u8);
+static void update_resources(struct bus_node *bus_cur, int type, int rangeno);
+static int once_over(void);
+static int remove_ranges(struct bus_node *, struct bus_node *);
+static int update_bridge_ranges(struct bus_node **);
+static int add_bus_range(int type, struct range_node *, struct bus_node *);
+static void fix_resources(struct bus_node *);
+static struct bus_node *find_bus_wprev(u8, struct bus_node **, u8);
 
 static LIST_HEAD(gbuses);
 
-static struct bus_node * __init alloc_error_bus (struct ebda_pci_rsrc *curr, u8 busno, int flag)
+static struct bus_node * __init alloc_error_bus(struct ebda_pci_rsrc *curr, u8 busno, int flag)
 {
        struct bus_node *newbus;
 
        if (!(curr) && !(flag)) {
-               err ("NULL pointer passed\n");
+               err("NULL pointer passed\n");
                return NULL;
        }
 
        newbus = kzalloc(sizeof(struct bus_node), GFP_KERNEL);
        if (!newbus) {
-               err ("out of system memory\n");
+               err("out of system memory\n");
                return NULL;
        }
 
@@ -65,22 +65,22 @@ static struct bus_node * __init alloc_error_bus (struct ebda_pci_rsrc *curr, u8
                newbus->busno = busno;
        else
                newbus->busno = curr->bus_num;
-       list_add_tail (&newbus->bus_list, &gbuses);
+       list_add_tail(&newbus->bus_list, &gbuses);
        return newbus;
 }
 
-static struct resource_node * __init alloc_resources (struct ebda_pci_rsrc *curr)
+static struct resource_node * __init alloc_resources(struct ebda_pci_rsrc *curr)
 {
        struct resource_node *rs;
 
        if (!curr) {
-               err ("NULL passed to allocate\n");
+               err("NULL passed to allocate\n");
                return NULL;
        }
 
        rs = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
        if (!rs) {
-               err ("out of system memory\n");
+               err("out of system memory\n");
                return NULL;
        }
        rs->busno = curr->bus_num;
@@ -91,7 +91,7 @@ static struct resource_node * __init alloc_resources (struct ebda_pci_rsrc *curr
        return rs;
 }
 
-static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node **new_range, struct ebda_pci_rsrc *curr, int flag, u8 first_bus)
+static int __init alloc_bus_range(struct bus_node **new_bus, struct range_node **new_range, struct ebda_pci_rsrc *curr, int flag, u8 first_bus)
 {
        struct bus_node *newbus;
        struct range_node *newrange;
@@ -100,7 +100,7 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
        if (first_bus) {
                newbus = kzalloc(sizeof(struct bus_node), GFP_KERNEL);
                if (!newbus) {
-                       err ("out of system memory.\n");
+                       err("out of system memory.\n");
                        return -ENOMEM;
                }
                newbus->busno = curr->bus_num;
@@ -122,8 +122,8 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
        newrange = kzalloc(sizeof(struct range_node), GFP_KERNEL);
        if (!newrange) {
                if (first_bus)
-                       kfree (newbus);
-               err ("out of system memory\n");
+                       kfree(newbus);
+               err("out of system memory\n");
                return -ENOMEM;
        }
        newrange->start = curr->start_addr;
@@ -133,8 +133,8 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
                newrange->rangeno = 1;
        else {
                /* need to insert our range */
-               add_bus_range (flag, newrange, newbus);
-               debug ("%d resource Primary Bus inserted on bus %x [%x - %x]\n", flag, newbus->busno, newrange->start, newrange->end);
+               add_bus_range(flag, newrange, newbus);
+               debug("%d resource Primary Bus inserted on bus %x [%x - %x]\n", flag, newbus->busno, newrange->start, newrange->end);
        }
 
        switch (flag) {
@@ -143,9 +143,9 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
                        if (first_bus)
                                newbus->noMemRanges = 1;
                        else {
-                               debug ("First Memory Primary on bus %x, [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                               debug("First Memory Primary on bus %x, [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                ++newbus->noMemRanges;
-                               fix_resources (newbus);
+                               fix_resources(newbus);
                        }
                        break;
                case IO:
@@ -153,9 +153,9 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
                        if (first_bus)
                                newbus->noIORanges = 1;
                        else {
-                               debug ("First IO Primary on bus %x, [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                               debug("First IO Primary on bus %x, [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                ++newbus->noIORanges;
-                               fix_resources (newbus);
+                               fix_resources(newbus);
                        }
                        break;
                case PFMEM:
@@ -163,9 +163,9 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
                        if (first_bus)
                                newbus->noPFMemRanges = 1;
                        else {
-                               debug ("1st PFMemory Primary on Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                               debug("1st PFMemory Primary on Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                ++newbus->noPFMemRanges;
-                               fix_resources (newbus);
+                               fix_resources(newbus);
                        }
 
                        break;
@@ -183,7 +183,7 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
  * 2. If cannot allocate out of PFMem range, allocate from Mem ranges.  PFmemFromMem
  * are not sorted. (no need since use mem node). To not change the entire code, we
  * also add mem node whenever this case happens so as not to change
- * ibmphp_check_mem_resource etc (and since it really is taking Mem resource)
+ * ibmphp_check_mem_resource etc(and since it really is taking Mem resource)
  */
 
 /*****************************************************************************
@@ -196,25 +196,23 @@ static int __init alloc_bus_range (struct bus_node **new_bus, struct range_node
  * Input: ptr to the head of the resource list from EBDA
  * Output: 0, -1 or error codes
  ***************************************************************************/
-int __init ibmphp_rsrc_init (void)
+int __init ibmphp_rsrc_init(void)
 {
        struct ebda_pci_rsrc *curr;
        struct range_node *newrange = NULL;
        struct bus_node *newbus = NULL;
        struct bus_node *bus_cur;
        struct bus_node *bus_prev;
-       struct list_head *tmp;
        struct resource_node *new_io = NULL;
        struct resource_node *new_mem = NULL;
        struct resource_node *new_pfmem = NULL;
        int rc;
-       struct list_head *tmp_ebda;
 
-       list_for_each (tmp_ebda, &ibmphp_ebda_pci_rsrc_head) {
-               curr = list_entry (tmp_ebda, struct ebda_pci_rsrc, ebda_pci_rsrc_list);
+       list_for_each_entry(curr, &ibmphp_ebda_pci_rsrc_head,
+                           ebda_pci_rsrc_list) {
                if (!(curr->rsrc_type & PCIDEVMASK)) {
                        /* EBDA still lists non PCI devices, so ignore... */
-                       debug ("this is not a PCI DEVICE in rsrc_init, please take care\n");
+                       debug("this is not a PCI DEVICE in rsrc_init, please take care\n");
                        // continue;
                }
 
@@ -223,17 +221,17 @@ int __init ibmphp_rsrc_init (void)
                        /* memory */
                        if ((curr->rsrc_type & RESTYPE) == MMASK) {
                                /* no bus structure exists in place yet */
-                               if (list_empty (&gbuses)) {
+                               if (list_empty(&gbuses)) {
                                        rc = alloc_bus_range(&newbus, &newrange, curr, MEM, 1);
                                        if (rc)
                                                return rc;
-                                       list_add_tail (&newbus->bus_list, &gbuses);
-                                       debug ("gbuses = NULL, Memory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                       list_add_tail(&newbus->bus_list, &gbuses);
+                                       debug("gbuses = NULL, Memory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                } else {
-                                       bus_cur = find_bus_wprev (curr->bus_num, &bus_prev, 1);
+                                       bus_cur = find_bus_wprev(curr->bus_num, &bus_prev, 1);
                                        /* found our bus */
                                        if (bus_cur) {
-                                               rc = alloc_bus_range (&bus_cur, &newrange, curr, MEM, 0);
+                                               rc = alloc_bus_range(&bus_cur, &newrange, curr, MEM, 0);
                                                if (rc)
                                                        return rc;
                                        } else {
@@ -242,24 +240,24 @@ int __init ibmphp_rsrc_init (void)
                                                if (rc)
                                                        return rc;
 
-                                               list_add_tail (&newbus->bus_list, &gbuses);
-                                               debug ("New Bus, Memory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                               list_add_tail(&newbus->bus_list, &gbuses);
+                                               debug("New Bus, Memory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                        }
                                }
                        } else if ((curr->rsrc_type & RESTYPE) == PFMASK) {
                                /* prefetchable memory */
-                               if (list_empty (&gbuses)) {
+                               if (list_empty(&gbuses)) {
                                        /* no bus structure exists in place yet */
                                        rc = alloc_bus_range(&newbus, &newrange, curr, PFMEM, 1);
                                        if (rc)
                                                return rc;
-                                       list_add_tail (&newbus->bus_list, &gbuses);
-                                       debug ("gbuses = NULL, PFMemory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                       list_add_tail(&newbus->bus_list, &gbuses);
+                                       debug("gbuses = NULL, PFMemory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                } else {
-                                       bus_cur = find_bus_wprev (curr->bus_num, &bus_prev, 1);
+                                       bus_cur = find_bus_wprev(curr->bus_num, &bus_prev, 1);
                                        if (bus_cur) {
                                                /* found our bus */
-                                               rc = alloc_bus_range (&bus_cur, &newrange, curr, PFMEM, 0);
+                                               rc = alloc_bus_range(&bus_cur, &newrange, curr, PFMEM, 0);
                                                if (rc)
                                                        return rc;
                                        } else {
@@ -267,23 +265,23 @@ int __init ibmphp_rsrc_init (void)
                                                rc = alloc_bus_range(&newbus, &newrange, curr, PFMEM, 1);
                                                if (rc)
                                                        return rc;
-                                               list_add_tail (&newbus->bus_list, &gbuses);
-                                               debug ("1st Bus, PFMemory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                               list_add_tail(&newbus->bus_list, &gbuses);
+                                               debug("1st Bus, PFMemory Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                        }
                                }
                        } else if ((curr->rsrc_type & RESTYPE) == IOMASK) {
                                /* IO */
-                               if (list_empty (&gbuses)) {
+                               if (list_empty(&gbuses)) {
                                        /* no bus structure exists in place yet */
                                        rc = alloc_bus_range(&newbus, &newrange, curr, IO, 1);
                                        if (rc)
                                                return rc;
-                                       list_add_tail (&newbus->bus_list, &gbuses);
-                                       debug ("gbuses = NULL, IO Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                       list_add_tail(&newbus->bus_list, &gbuses);
+                                       debug("gbuses = NULL, IO Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                } else {
-                                       bus_cur = find_bus_wprev (curr->bus_num, &bus_prev, 1);
+                                       bus_cur = find_bus_wprev(curr->bus_num, &bus_prev, 1);
                                        if (bus_cur) {
-                                               rc = alloc_bus_range (&bus_cur, &newrange, curr, IO, 0);
+                                               rc = alloc_bus_range(&bus_cur, &newrange, curr, IO, 0);
                                                if (rc)
                                                        return rc;
                                        } else {
@@ -291,8 +289,8 @@ int __init ibmphp_rsrc_init (void)
                                                rc = alloc_bus_range(&newbus, &newrange, curr, IO, 1);
                                                if (rc)
                                                        return rc;
-                                               list_add_tail (&newbus->bus_list, &gbuses);
-                                               debug ("1st Bus, IO Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
+                                               list_add_tail(&newbus->bus_list, &gbuses);
+                                               debug("1st Bus, IO Primary Bus %x [%x - %x]\n", newbus->busno, newrange->start, newrange->end);
                                        }
                                }
 
@@ -304,7 +302,7 @@ int __init ibmphp_rsrc_init (void)
                        /* regular pci device resource */
                        if ((curr->rsrc_type & RESTYPE) == MMASK) {
                                /* Memory resource */
-                               new_mem = alloc_resources (curr);
+                               new_mem = alloc_resources(curr);
                                if (!new_mem)
                                        return -ENOMEM;
                                new_mem->type = MEM;
@@ -315,25 +313,25 @@ int __init ibmphp_rsrc_init (void)
                                 * assign a -1 and then update once the range
                                 * actually appears...
                                 */
-                               if (ibmphp_add_resource (new_mem) < 0) {
-                                       newbus = alloc_error_bus (curr, 0, 0);
+                               if (ibmphp_add_resource(new_mem) < 0) {
+                                       newbus = alloc_error_bus(curr, 0, 0);
                                        if (!newbus)
                                                return -ENOMEM;
                                        newbus->firstMem = new_mem;
                                        ++newbus->needMemUpdate;
                                        new_mem->rangeno = -1;
                                }
-                               debug ("Memory resource for device %x, bus %x, [%x - %x]\n", new_mem->devfunc, new_mem->busno, new_mem->start, new_mem->end);
+                               debug("Memory resource for device %x, bus %x, [%x - %x]\n", new_mem->devfunc, new_mem->busno, new_mem->start, new_mem->end);
 
                        } else if ((curr->rsrc_type & RESTYPE) == PFMASK) {
                                /* PFMemory resource */
-                               new_pfmem = alloc_resources (curr);
+                               new_pfmem = alloc_resources(curr);
                                if (!new_pfmem)
                                        return -ENOMEM;
                                new_pfmem->type = PFMEM;
                                new_pfmem->fromMem = 0;
-                               if (ibmphp_add_resource (new_pfmem) < 0) {
-                                       newbus = alloc_error_bus (curr, 0, 0);
+                               if (ibmphp_add_resource(new_pfmem) < 0) {
+                                       newbus = alloc_error_bus(curr, 0, 0);
                                        if (!newbus)
                                                return -ENOMEM;
                                        newbus->firstPFMem = new_pfmem;
@@ -341,10 +339,10 @@ int __init ibmphp_rsrc_init (void)
                                        new_pfmem->rangeno = -1;
                                }
 
-                               debug ("PFMemory resource for device %x, bus %x, [%x - %x]\n", new_pfmem->devfunc, new_pfmem->busno, new_pfmem->start, new_pfmem->end);
+                               debug("PFMemory resource for device %x, bus %x, [%x - %x]\n", new_pfmem->devfunc, new_pfmem->busno, new_pfmem->start, new_pfmem->end);
                        } else if ((curr->rsrc_type & RESTYPE) == IOMASK) {
                                /* IO resource */
-                               new_io = alloc_resources (curr);
+                               new_io = alloc_resources(curr);
                                if (!new_io)
                                        return -ENOMEM;
                                new_io->type = IO;
@@ -356,27 +354,26 @@ int __init ibmphp_rsrc_init (void)
                                 * Can assign a -1 and then update once the
                                 * range actually appears...
                                 */
-                               if (ibmphp_add_resource (new_io) < 0) {
-                                       newbus = alloc_error_bus (curr, 0, 0);
+                               if (ibmphp_add_resource(new_io) < 0) {
+                                       newbus = alloc_error_bus(curr, 0, 0);
                                        if (!newbus)
                                                return -ENOMEM;
                                        newbus->firstIO = new_io;
                                        ++newbus->needIOUpdate;
                                        new_io->rangeno = -1;
                                }
-                               debug ("IO resource for device %x, bus %x, [%x - %x]\n", new_io->devfunc, new_io->busno, new_io->start, new_io->end);
+                               debug("IO resource for device %x, bus %x, [%x - %x]\n", new_io->devfunc, new_io->busno, new_io->start, new_io->end);
                        }
                }
        }
 
-       list_for_each (tmp, &gbuses) {
-               bus_cur = list_entry (tmp, struct bus_node, bus_list);
+       list_for_each_entry(bus_cur, &gbuses, bus_list) {
                /* This is to get info about PPB resources, since EBDA doesn't put this info into the primary bus info */
-               rc = update_bridge_ranges (&bus_cur);
+               rc = update_bridge_ranges(&bus_cur);
                if (rc)
                        return rc;
        }
-       return once_over ();    /* This is to align ranges (so no -1) */
+       return once_over();     /* This is to align ranges (so no -1) */
 }
 
 /********************************************************************************
@@ -387,7 +384,7 @@ int __init ibmphp_rsrc_init (void)
  * Input: type of the resource, range to add, current bus
  * Output: 0 or -1, bus and range ptrs
  ********************************************************************************/
-static int add_bus_range (int type, struct range_node *range, struct bus_node *bus_cur)
+static int add_bus_range(int type, struct range_node *range, struct bus_node *bus_cur)
 {
        struct range_node *range_cur = NULL;
        struct range_node *range_prev;
@@ -452,7 +449,7 @@ static int add_bus_range (int type, struct range_node *range, struct bus_node *b
                range_cur = range_cur->next;
        }
 
-       update_resources (bus_cur, type, i_init + 1);
+       update_resources(bus_cur, type, i_init + 1);
        return 0;
 }
 
@@ -462,7 +459,7 @@ static int add_bus_range (int type, struct range_node *range, struct bus_node *b
  *
  * Input: bus, type of the resource, the rangeno starting from which to update
  ******************************************************************************/
-static void update_resources (struct bus_node *bus_cur, int type, int rangeno)
+static void update_resources(struct bus_node *bus_cur, int type, int rangeno)
 {
        struct resource_node *res = NULL;
        u8 eol = 0;     /* end of list indicator */
@@ -506,9 +503,9 @@ static void update_resources (struct bus_node *bus_cur, int type, int rangeno)
        }
 }
 
-static void fix_me (struct resource_node *res, struct bus_node *bus_cur, struct range_node *range)
+static void fix_me(struct resource_node *res, struct bus_node *bus_cur, struct range_node *range)
 {
-       char * str = "";
+       char *str = "";
        switch (res->type) {
                case IO:
                        str = "io";
@@ -526,7 +523,7 @@ static void fix_me (struct resource_node *res, struct bus_node *bus_cur, struct
                        while (range) {
                                if ((res->start >= range->start) && (res->end <= range->end)) {
                                        res->rangeno = range->rangeno;
-                                       debug ("%s->rangeno in fix_resources is %d\n", str, res->rangeno);
+                                       debug("%s->rangeno in fix_resources is %d\n", str, res->rangeno);
                                        switch (res->type) {
                                                case IO:
                                                        --bus_cur->needIOUpdate;
@@ -561,27 +558,27 @@ static void fix_me (struct resource_node *res, struct bus_node *bus_cur, struct
  * Input: current bus
  * Output: none, list of resources for that bus are fixed if can be
  *******************************************************************************/
-static void fix_resources (struct bus_node *bus_cur)
+static void fix_resources(struct bus_node *bus_cur)
 {
        struct range_node *range;
        struct resource_node *res;
 
-       debug ("%s - bus_cur->busno = %d\n", __func__, bus_cur->busno);
+       debug("%s - bus_cur->busno = %d\n", __func__, bus_cur->busno);
 
        if (bus_cur->needIOUpdate) {
                res = bus_cur->firstIO;
                range = bus_cur->rangeIO;
-               fix_me (res, bus_cur, range);
+               fix_me(res, bus_cur, range);
        }
        if (bus_cur->needMemUpdate) {
                res = bus_cur->firstMem;
                range = bus_cur->rangeMem;
-               fix_me (res, bus_cur, range);
+               fix_me(res, bus_cur, range);
        }
        if (bus_cur->needPFMemUpdate) {
                res = bus_cur->firstPFMem;
                range = bus_cur->rangePFMem;
-               fix_me (res, bus_cur, range);
+               fix_me(res, bus_cur, range);
        }
 }
 
@@ -594,7 +591,7 @@ static void fix_resources (struct bus_node *bus_cur)
  * Output: ptrs assigned (to the node)
  * 0 or -1
  *******************************************************************************/
-int ibmphp_add_resource (struct resource_node *res)
+int ibmphp_add_resource(struct resource_node *res)
 {
        struct resource_node *res_cur;
        struct resource_node *res_prev;
@@ -602,18 +599,18 @@ int ibmphp_add_resource (struct resource_node *res)
        struct range_node *range_cur = NULL;
        struct resource_node *res_start = NULL;
 
-       debug ("%s - enter\n", __func__);
+       debug("%s - enter\n", __func__);
 
        if (!res) {
-               err ("NULL passed to add\n");
+               err("NULL passed to add\n");
                return -ENODEV;
        }
 
-       bus_cur = find_bus_wprev (res->busno, NULL, 0);
+       bus_cur = find_bus_wprev(res->busno, NULL, 0);
 
        if (!bus_cur) {
                /* didn't find a bus, something's wrong!!! */
-               debug ("no bus in the system, either pci_dev's wrong or allocation failed\n");
+               debug("no bus in the system, either pci_dev's wrong or allocation failed\n");
                return -ENODEV;
        }
 
@@ -632,7 +629,7 @@ int ibmphp_add_resource (struct resource_node *res)
                        res_start = bus_cur->firstPFMem;
                        break;
                default:
-                       err ("cannot read the type of the resource to add... problem\n");
+                       err("cannot read the type of the resource to add... problem\n");
                        return -EINVAL;
        }
        while (range_cur) {
@@ -663,7 +660,7 @@ int ibmphp_add_resource (struct resource_node *res)
                res->rangeno = -1;
        }
 
-       debug ("The range is %d\n", res->rangeno);
+       debug("The range is %d\n", res->rangeno);
        if (!res_start) {
                /* no first{IO,Mem,Pfmem} on the bus, 1st IO/Mem/Pfmem resource ever */
                switch (res->type) {
@@ -683,7 +680,7 @@ int ibmphp_add_resource (struct resource_node *res)
                res_cur = res_start;
                res_prev = NULL;
 
-               debug ("res_cur->rangeno is %d\n", res_cur->rangeno);
+               debug("res_cur->rangeno is %d\n", res_cur->rangeno);
 
                while (res_cur) {
                        if (res_cur->rangeno >= res->rangeno)
@@ -697,7 +694,7 @@ int ibmphp_add_resource (struct resource_node *res)
 
                if (!res_cur) {
                        /* at the end of the resource list */
-                       debug ("i should be here, [%x - %x]\n", res->start, res->end);
+                       debug("i should be here, [%x - %x]\n", res->start, res->end);
                        res_prev->nextRange = res;
                        res->next = NULL;
                        res->nextRange = NULL;
@@ -765,7 +762,7 @@ int ibmphp_add_resource (struct resource_node *res)
                }
        }
 
-       debug ("%s - exit\n", __func__);
+       debug("%s - exit\n", __func__);
        return 0;
 }
 
@@ -776,23 +773,23 @@ int ibmphp_add_resource (struct resource_node *res)
  * Output: modified resource list
  *        0 or error code
  ****************************************************************************/
-int ibmphp_remove_resource (struct resource_node *res)
+int ibmphp_remove_resource(struct resource_node *res)
 {
        struct bus_node *bus_cur;
        struct resource_node *res_cur = NULL;
        struct resource_node *res_prev;
        struct resource_node *mem_cur;
-       char * type = "";
+       char *type = "";
 
        if (!res)  {
-               err ("resource to remove is NULL\n");
+               err("resource to remove is NULL\n");
                return -ENODEV;
        }
 
-       bus_cur = find_bus_wprev (res->busno, NULL, 0);
+       bus_cur = find_bus_wprev(res->busno, NULL, 0);
 
        if (!bus_cur) {
-               err ("cannot find corresponding bus of the io resource to remove  bailing out...\n");
+               err("cannot find corresponding bus of the io resource to remove  bailing out...\n");
                return -ENODEV;
        }
 
@@ -810,7 +807,7 @@ int ibmphp_remove_resource (struct resource_node *res)
                        type = "pfmem";
                        break;
                default:
-                       err ("unknown type for resource to remove\n");
+                       err("unknown type for resource to remove\n");
                        return -EINVAL;
        }
        res_prev = NULL;
@@ -848,16 +845,16 @@ int ibmphp_remove_resource (struct resource_node *res)
                                                        mem_cur = mem_cur->nextRange;
                                        }
                                        if (!mem_cur) {
-                                               err ("cannot find corresponding mem node for pfmem...\n");
+                                               err("cannot find corresponding mem node for pfmem...\n");
                                                return -EINVAL;
                                        }
 
-                                       ibmphp_remove_resource (mem_cur);
+                                       ibmphp_remove_resource(mem_cur);
                                        if (!res_prev)
                                                bus_cur->firstPFMemFromMem = res_cur->next;
                                        else
                                                res_prev->next = res_cur->next;
-                                       kfree (res_cur);
+                                       kfree(res_cur);
                                        return 0;
                                }
                                res_prev = res_cur;
@@ -867,11 +864,11 @@ int ibmphp_remove_resource (struct resource_node *res)
                                        res_cur = res_cur->nextRange;
                        }
                        if (!res_cur) {
-                               err ("cannot find pfmem to delete...\n");
+                               err("cannot find pfmem to delete...\n");
                                return -EINVAL;
                        }
                } else {
-                       err ("the %s resource is not in the list to be deleted...\n", type);
+                       err("the %s resource is not in the list to be deleted...\n", type);
                        return -EINVAL;
                }
        }
@@ -914,7 +911,7 @@ int ibmphp_remove_resource (struct resource_node *res)
                                        break;
                        }
                }
-               kfree (res_cur);
+               kfree(res_cur);
                return 0;
        } else {
                if (res_cur->next) {
@@ -929,14 +926,14 @@ int ibmphp_remove_resource (struct resource_node *res)
                        res_prev->next = NULL;
                        res_prev->nextRange = NULL;
                }
-               kfree (res_cur);
+               kfree(res_cur);
                return 0;
        }
 
        return 0;
 }
 
-static struct range_node *find_range (struct bus_node *bus_cur, struct resource_node *res)
+static struct range_node *find_range(struct bus_node *bus_cur, struct resource_node *res)
 {
        struct range_node *range = NULL;
 
@@ -951,7 +948,7 @@ static struct range_node *find_range (struct bus_node *bus_cur, struct resource_
                        range = bus_cur->rangePFMem;
                        break;
                default:
-                       err ("cannot read resource type in find_range\n");
+                       err("cannot read resource type in find_range\n");
        }
 
        while (range) {
@@ -971,7 +968,7 @@ static struct range_node *find_range (struct bus_node *bus_cur, struct resource_
  * Output: the correct start and end address are inputted into the resource node,
  *        0 or -EINVAL
  *****************************************************************************/
-int ibmphp_check_resource (struct resource_node *res, u8 bridge)
+int ibmphp_check_resource(struct resource_node *res, u8 bridge)
 {
        struct bus_node *bus_cur;
        struct range_node *range = NULL;
@@ -995,16 +992,16 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
        } else
                tmp_divide = res->len;
 
-       bus_cur = find_bus_wprev (res->busno, NULL, 0);
+       bus_cur = find_bus_wprev(res->busno, NULL, 0);
 
        if (!bus_cur) {
                /* didn't find a bus, something's wrong!!! */
-               debug ("no bus in the system, either pci_dev's wrong or allocation failed\n");
+               debug("no bus in the system, either pci_dev's wrong or allocation failed\n");
                return -EINVAL;
        }
 
-       debug ("%s - enter\n", __func__);
-       debug ("bus_cur->busno is %d\n", bus_cur->busno);
+       debug("%s - enter\n", __func__);
+       debug("bus_cur->busno is %d\n", bus_cur->busno);
 
        /* This is a quick fix to not mess up with the code very much.  i.e.,
         * 2000-2fff, len = 1000, but when we compare, we need it to be fff */
@@ -1024,17 +1021,17 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                        noranges = bus_cur->noPFMemRanges;
                        break;
                default:
-                       err ("wrong type of resource to check\n");
+                       err("wrong type of resource to check\n");
                        return -EINVAL;
        }
        res_prev = NULL;
 
        while (res_cur) {
-               range = find_range (bus_cur, res_cur);
-               debug ("%s - rangeno = %d\n", __func__, res_cur->rangeno);
+               range = find_range(bus_cur, res_cur);
+               debug("%s - rangeno = %d\n", __func__, res_cur->rangeno);
 
                if (!range) {
-                       err ("no range for the device exists... bailing out...\n");
+                       err("no range for the device exists... bailing out...\n");
                        return -EINVAL;
                }
 
@@ -1044,7 +1041,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                        len_tmp = res_cur->start - 1 - range->start;
 
                        if ((res_cur->start != range->start) && (len_tmp >= res->len)) {
-                               debug ("len_tmp = %x\n", len_tmp);
+                               debug("len_tmp = %x\n", len_tmp);
 
                                if ((len_tmp < len_cur) || (len_cur == 0)) {
 
@@ -1072,7 +1069,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                        }
 
                                        if (flag && len_cur == res->len) {
-                                               debug ("but we are not here, right?\n");
+                                               debug("but we are not here, right?\n");
                                                res->start = start_cur;
                                                res->len += 1; /* To restore the balance */
                                                res->end = res->start + res->len - 1;
@@ -1086,7 +1083,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                        len_tmp = range->end - (res_cur->end + 1);
 
                        if ((range->end != res_cur->end) && (len_tmp >= res->len)) {
-                               debug ("len_tmp = %x\n", len_tmp);
+                               debug("len_tmp = %x\n", len_tmp);
                                if ((len_tmp < len_cur) || (len_cur == 0)) {
 
                                        if (((res_cur->end + 1) % tmp_divide) == 0) {
@@ -1262,7 +1259,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
 
                if ((!range) && (len_cur == 0)) {
                        /* have gone through the list of devices and ranges and haven't found n.e.thing */
-                       err ("no appropriate range.. bailing out...\n");
+                       err("no appropriate range.. bailing out...\n");
                        return -EINVAL;
                } else if (len_cur) {
                        res->start = start_cur;
@@ -1273,7 +1270,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
        }
 
        if (!res_cur) {
-               debug ("prev->rangeno = %d, noranges = %d\n", res_prev->rangeno, noranges);
+               debug("prev->rangeno = %d, noranges = %d\n", res_prev->rangeno, noranges);
                if (res_prev->rangeno < noranges) {
                        /* if there're more ranges out there to check */
                        switch (res->type) {
@@ -1328,7 +1325,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
 
                        if ((!range) && (len_cur == 0)) {
                                /* have gone through the list of devices and ranges and haven't found n.e.thing */
-                               err ("no appropriate range.. bailing out...\n");
+                               err("no appropriate range.. bailing out...\n");
                                return -EINVAL;
                        } else if (len_cur) {
                                res->start = start_cur;
@@ -1345,7 +1342,7 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
                                return 0;
                        } else {
                                /* have gone through the list of devices and haven't found n.e.thing */
-                               err ("no appropriate range.. bailing out...\n");
+                               err("no appropriate range.. bailing out...\n");
                                return -EINVAL;
                        }
                }
@@ -1359,23 +1356,23 @@ int ibmphp_check_resource (struct resource_node *res, u8 bridge)
  * Input: Bus
  * Output: 0, -ENODEV
  ********************************************************************************/
-int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
+int ibmphp_remove_bus(struct bus_node *bus, u8 parent_busno)
 {
        struct resource_node *res_cur;
        struct resource_node *res_tmp;
        struct bus_node *prev_bus;
        int rc;
 
-       prev_bus = find_bus_wprev (parent_busno, NULL, 0);
+       prev_bus = find_bus_wprev(parent_busno, NULL, 0);
 
        if (!prev_bus) {
-               debug ("something terribly wrong. Cannot find parent bus to the one to remove\n");
+               debug("something terribly wrong. Cannot find parent bus to the one to remove\n");
                return -ENODEV;
        }
 
-       debug ("In ibmphp_remove_bus... prev_bus->busno is %x\n", prev_bus->busno);
+       debug("In ibmphp_remove_bus... prev_bus->busno is %x\n", prev_bus->busno);
 
-       rc = remove_ranges (bus, prev_bus);
+       rc = remove_ranges(bus, prev_bus);
        if (rc)
                return rc;
 
@@ -1387,7 +1384,7 @@ int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
                                res_cur = res_cur->next;
                        else
                                res_cur = res_cur->nextRange;
-                       kfree (res_tmp);
+                       kfree(res_tmp);
                        res_tmp = NULL;
                }
                bus->firstIO = NULL;
@@ -1400,7 +1397,7 @@ int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
                                res_cur = res_cur->next;
                        else
                                res_cur = res_cur->nextRange;
-                       kfree (res_tmp);
+                       kfree(res_tmp);
                        res_tmp = NULL;
                }
                bus->firstMem = NULL;
@@ -1413,7 +1410,7 @@ int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
                                res_cur = res_cur->next;
                        else
                                res_cur = res_cur->nextRange;
-                       kfree (res_tmp);
+                       kfree(res_tmp);
                        res_tmp = NULL;
                }
                bus->firstPFMem = NULL;
@@ -1425,14 +1422,14 @@ int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
                        res_tmp = res_cur;
                        res_cur = res_cur->next;
 
-                       kfree (res_tmp);
+                       kfree(res_tmp);
                        res_tmp = NULL;
                }
                bus->firstPFMemFromMem = NULL;
        }
 
-       list_del (&bus->bus_list);
-       kfree (bus);
+       list_del(&bus->bus_list);
+       kfree(bus);
        return 0;
 }
 
@@ -1442,7 +1439,7 @@ int ibmphp_remove_bus (struct bus_node *bus, u8 parent_busno)
  * Input: current bus, previous bus
  * Output: 0, -EINVAL
  ******************************************************************************/
-static int remove_ranges (struct bus_node *bus_cur, struct bus_node *bus_prev)
+static int remove_ranges(struct bus_node *bus_cur, struct bus_node *bus_prev)
 {
        struct range_node *range_cur;
        struct range_node *range_tmp;
@@ -1452,13 +1449,13 @@ static int remove_ranges (struct bus_node *bus_cur, struct bus_node *bus_prev)
        if (bus_cur->noIORanges) {
                range_cur = bus_cur->rangeIO;
                for (i = 0; i < bus_cur->noIORanges; i++) {
-                       if (ibmphp_find_resource (bus_prev, range_cur->start, &res, IO) < 0)
+                       if (ibmphp_find_resource(bus_prev, range_cur->start, &res, IO) < 0)
                                return -EINVAL;
-                       ibmphp_remove_resource (res);
+                       ibmphp_remove_resource(res);
 
                        range_tmp = range_cur;
                        range_cur = range_cur->next;
-                       kfree (range_tmp);
+                       kfree(range_tmp);
                        range_tmp = NULL;
                }
                bus_cur->rangeIO = NULL;
@@ -1466,13 +1463,13 @@ static int remove_ranges (struct bus_node *bus_cur, struct bus_node *bus_prev)
        if (bus_cur->noMemRanges) {
                range_cur = bus_cur->rangeMem;
                for (i = 0; i < bus_cur->noMemRanges; i++) {
-                       if (ibmphp_find_resource (bus_prev, range_cur->start, &res, MEM) < 0)
+                       if (ibmphp_find_resource(bus_prev, range_cur->start, &res, MEM) < 0)
                                return -EINVAL;
 
-                       ibmphp_remove_resource (res);
+                       ibmphp_remove_resource(res);
                        range_tmp = range_cur;
                        range_cur = range_cur->next;
-                       kfree (range_tmp);
+                       kfree(range_tmp);
                        range_tmp = NULL;
                }
                bus_cur->rangeMem = NULL;
@@ -1480,13 +1477,13 @@ static int remove_ranges (struct bus_node *bus_cur, struct bus_node *bus_prev)
        if (bus_cur->noPFMemRanges) {
                range_cur = bus_cur->rangePFMem;
                for (i = 0; i < bus_cur->noPFMemRanges; i++) {
-                       if (ibmphp_find_resource (bus_prev, range_cur->start, &res, PFMEM) < 0)
+                       if (ibmphp_find_resource(bus_prev, range_cur->start, &res, PFMEM) < 0)
                                return -EINVAL;
 
-                       ibmphp_remove_resource (res);
+                       ibmphp_remove_resource(res);
                        range_tmp = range_cur;
                        range_cur = range_cur->next;
-                       kfree (range_tmp);
+                       kfree(range_tmp);
                        range_tmp = NULL;
                }
                bus_cur->rangePFMem = NULL;
@@ -1498,13 +1495,13 @@ static int remove_ranges (struct bus_node *bus_cur, struct bus_node *bus_prev)
  * find the resource node in the bus
  * Input: Resource needed, start address of the resource, type of resource
  */
-int ibmphp_find_resource (struct bus_node *bus, u32 start_address, struct resource_node **res, int flag)
+int ibmphp_find_resource(struct bus_node *bus, u32 start_address, struct resource_node **res, int flag)
 {
        struct resource_node *res_cur = NULL;
-       char * type = "";
+       char *type = "";
 
        if (!bus) {
-               err ("The bus passed in NULL to find resource\n");
+               err("The bus passed in NULL to find resource\n");
                return -ENODEV;
        }
 
@@ -1522,7 +1519,7 @@ int ibmphp_find_resource (struct bus_node *bus, u32 start_address, struct resour
                        type = "pfmem";
                        break;
                default:
-                       err ("wrong type of flag\n");
+                       err("wrong type of flag\n");
                        return -EINVAL;
        }
 
@@ -1548,17 +1545,17 @@ int ibmphp_find_resource (struct bus_node *bus, u32 start_address, struct resour
                                res_cur = res_cur->next;
                        }
                        if (!res_cur) {
-                               debug ("SOS...cannot find %s resource in the bus.\n", type);
+                               debug("SOS...cannot find %s resource in the bus.\n", type);
                                return -EINVAL;
                        }
                } else {
-                       debug ("SOS... cannot find %s resource in the bus.\n", type);
+                       debug("SOS... cannot find %s resource in the bus.\n", type);
                        return -EINVAL;
                }
        }
 
        if (*res)
-               debug ("*res->start = %x\n", (*res)->start);
+               debug("*res->start = %x\n", (*res)->start);
 
        return 0;
 }
@@ -1569,21 +1566,18 @@ int ibmphp_find_resource (struct bus_node *bus, u32 start_address, struct resour
  * Parameters: none
  * Returns: none
  ***********************************************************************/
-void ibmphp_free_resources (void)
+void ibmphp_free_resources(void)
 {
-       struct bus_node *bus_cur = NULL;
+       struct bus_node *bus_cur = NULL, *next;
        struct bus_node *bus_tmp;
        struct range_node *range_cur;
        struct range_node *range_tmp;
        struct resource_node *res_cur;
        struct resource_node *res_tmp;
-       struct list_head *tmp;
-       struct list_head *next;
        int i = 0;
        flags = 1;
 
-       list_for_each_safe (tmp, next, &gbuses) {
-               bus_cur = list_entry (tmp, struct bus_node, bus_list);
+       list_for_each_entry_safe(bus_cur, next, &gbuses, bus_list) {
                if (bus_cur->noIORanges) {
                        range_cur = bus_cur->rangeIO;
                        for (i = 0; i < bus_cur->noIORanges; i++) {
@@ -1591,7 +1585,7 @@ void ibmphp_free_resources (void)
                                        break;
                                range_tmp = range_cur;
                                range_cur = range_cur->next;
-                               kfree (range_tmp);
+                               kfree(range_tmp);
                                range_tmp = NULL;
                        }
                }
@@ -1602,7 +1596,7 @@ void ibmphp_free_resources (void)
                                        break;
                                range_tmp = range_cur;
                                range_cur = range_cur->next;
-                               kfree (range_tmp);
+                               kfree(range_tmp);
                                range_tmp = NULL;
                        }
                }
@@ -1613,7 +1607,7 @@ void ibmphp_free_resources (void)
                                        break;
                                range_tmp = range_cur;
                                range_cur = range_cur->next;
-                               kfree (range_tmp);
+                               kfree(range_tmp);
                                range_tmp = NULL;
                        }
                }
@@ -1626,7 +1620,7 @@ void ibmphp_free_resources (void)
                                        res_cur = res_cur->next;
                                else
                                        res_cur = res_cur->nextRange;
-                               kfree (res_tmp);
+                               kfree(res_tmp);
                                res_tmp = NULL;
                        }
                        bus_cur->firstIO = NULL;
@@ -1639,7 +1633,7 @@ void ibmphp_free_resources (void)
                                        res_cur = res_cur->next;
                                else
                                        res_cur = res_cur->nextRange;
-                               kfree (res_tmp);
+                               kfree(res_tmp);
                                res_tmp = NULL;
                        }
                        bus_cur->firstMem = NULL;
@@ -1652,7 +1646,7 @@ void ibmphp_free_resources (void)
                                        res_cur = res_cur->next;
                                else
                                        res_cur = res_cur->nextRange;
-                               kfree (res_tmp);
+                               kfree(res_tmp);
                                res_tmp = NULL;
                        }
                        bus_cur->firstPFMem = NULL;
@@ -1664,15 +1658,15 @@ void ibmphp_free_resources (void)
                                res_tmp = res_cur;
                                res_cur = res_cur->next;
 
-                               kfree (res_tmp);
+                               kfree(res_tmp);
                                res_tmp = NULL;
                        }
                        bus_cur->firstPFMemFromMem = NULL;
                }
 
                bus_tmp = bus_cur;
-               list_del (&bus_cur->bus_list);
-               kfree (bus_tmp);
+               list_del(&bus_cur->bus_list);
+               kfree(bus_tmp);
                bus_tmp = NULL;
        }
 }
@@ -1685,16 +1679,14 @@ void ibmphp_free_resources (void)
  * a new Mem node
  * This routine is called right after initialization
  *******************************************************************************/
-static int __init once_over (void)
+static int __init once_over(void)
 {
        struct resource_node *pfmem_cur;
        struct resource_node *pfmem_prev;
        struct resource_node *mem;
        struct bus_node *bus_cur;
-       struct list_head *tmp;
 
-       list_for_each (tmp, &gbuses) {
-               bus_cur = list_entry (tmp, struct bus_node, bus_list);
+       list_for_each_entry(bus_cur, &gbuses, bus_list) {
                if ((!bus_cur->rangePFMem) && (bus_cur->firstPFMem)) {
                        for (pfmem_cur = bus_cur->firstPFMem, pfmem_prev = NULL; pfmem_cur; pfmem_prev = pfmem_cur, pfmem_cur = pfmem_cur->next) {
                                pfmem_cur->fromMem = 1;
@@ -1716,7 +1708,7 @@ static int __init once_over (void)
 
                                mem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                if (!mem) {
-                                       err ("out of system memory\n");
+                                       err("out of system memory\n");
                                        return -ENOMEM;
                                }
                                mem->type = MEM;
@@ -1725,8 +1717,8 @@ static int __init once_over (void)
                                mem->start = pfmem_cur->start;
                                mem->end = pfmem_cur->end;
                                mem->len = pfmem_cur->len;
-                               if (ibmphp_add_resource (mem) < 0)
-                                       err ("Trouble...trouble... EBDA allocated pfmem from mem, but system doesn't display it has this space... unless not PCI device...\n");
+                               if (ibmphp_add_resource(mem) < 0)
+                                       err("Trouble...trouble... EBDA allocated pfmem from mem, but system doesn't display it has this space... unless not PCI device...\n");
                                pfmem_cur->rangeno = mem->rangeno;
                        }       /* end for pfmem */
                }       /* end if */
@@ -1734,12 +1726,12 @@ static int __init once_over (void)
        return 0;
 }
 
-int ibmphp_add_pfmem_from_mem (struct resource_node *pfmem)
+int ibmphp_add_pfmem_from_mem(struct resource_node *pfmem)
 {
-       struct bus_node *bus_cur = find_bus_wprev (pfmem->busno, NULL, 0);
+       struct bus_node *bus_cur = find_bus_wprev(pfmem->busno, NULL, 0);
 
        if (!bus_cur) {
-               err ("cannot find bus of pfmem to add...\n");
+               err("cannot find bus of pfmem to add...\n");
                return -ENODEV;
        }
 
@@ -1759,22 +1751,18 @@ int ibmphp_add_pfmem_from_mem (struct resource_node *pfmem)
  * Parameters: bus_number
  * Returns: Bus pointer or NULL
  */
-struct bus_node *ibmphp_find_res_bus (u8 bus_number)
+struct bus_node *ibmphp_find_res_bus(u8 bus_number)
 {
-       return find_bus_wprev (bus_number, NULL, 0);
+       return find_bus_wprev(bus_number, NULL, 0);
 }
 
-static struct bus_node *find_bus_wprev (u8 bus_number, struct bus_node **prev, u8 flag)
+static struct bus_node *find_bus_wprev(u8 bus_number, struct bus_node **prev, u8 flag)
 {
        struct bus_node *bus_cur;
-       struct list_head *tmp;
-       struct list_head *tmp_prev;
 
-       list_for_each (tmp, &gbuses) {
-               tmp_prev = tmp->prev;
-               bus_cur = list_entry (tmp, struct bus_node, bus_list);
+       list_for_each_entry(bus_cur, &gbuses, bus_list) {
                if (flag)
-                       *prev = list_entry (tmp_prev, struct bus_node, bus_list);
+                       *prev = list_prev_entry(bus_cur, bus_list);
                if (bus_cur->busno == bus_number)
                        return bus_cur;
        }
@@ -1782,23 +1770,21 @@ static struct bus_node *find_bus_wprev (u8 bus_number, struct bus_node **prev, u
        return NULL;
 }
 
-void ibmphp_print_test (void)
+void ibmphp_print_test(void)
 {
        int i = 0;
        struct bus_node *bus_cur = NULL;
        struct range_node *range;
        struct resource_node *res;
-       struct list_head *tmp;
 
-       debug_pci ("*****************START**********************\n");
+       debug_pci("*****************START**********************\n");
 
        if ((!list_empty(&gbuses)) && flags) {
-               err ("The GBUSES is not NULL?!?!?!?!?\n");
+               err("The GBUSES is not NULL?!?!?!?!?\n");
                return;
        }
 
-       list_for_each (tmp, &gbuses) {
-               bus_cur = list_entry (tmp, struct bus_node, bus_list);
+       list_for_each_entry(bus_cur, &gbuses, bus_list) {
                debug_pci ("This is bus # %d.  There are\n", bus_cur->busno);
                debug_pci ("IORanges = %d\t", bus_cur->noIORanges);
                debug_pci ("MemRanges = %d\t", bus_cur->noMemRanges);
@@ -1807,42 +1793,42 @@ void ibmphp_print_test (void)
                if (bus_cur->rangeIO) {
                        range = bus_cur->rangeIO;
                        for (i = 0; i < bus_cur->noIORanges; i++) {
-                               debug_pci ("rangeno is %d\n", range->rangeno);
-                               debug_pci ("[%x - %x]\n", range->start, range->end);
+                               debug_pci("rangeno is %d\n", range->rangeno);
+                               debug_pci("[%x - %x]\n", range->start, range->end);
                                range = range->next;
                        }
                }
 
-               debug_pci ("The Mem Ranges are as follows:\n");
+               debug_pci("The Mem Ranges are as follows:\n");
                if (bus_cur->rangeMem) {
                        range = bus_cur->rangeMem;
                        for (i = 0; i < bus_cur->noMemRanges; i++) {
-                               debug_pci ("rangeno is %d\n", range->rangeno);
-                               debug_pci ("[%x - %x]\n", range->start, range->end);
+                               debug_pci("rangeno is %d\n", range->rangeno);
+                               debug_pci("[%x - %x]\n", range->start, range->end);
                                range = range->next;
                        }
                }
 
-               debug_pci ("The PFMem Ranges are as follows:\n");
+               debug_pci("The PFMem Ranges are as follows:\n");
 
                if (bus_cur->rangePFMem) {
                        range = bus_cur->rangePFMem;
                        for (i = 0; i < bus_cur->noPFMemRanges; i++) {
-                               debug_pci ("rangeno is %d\n", range->rangeno);
-                               debug_pci ("[%x - %x]\n", range->start, range->end);
+                               debug_pci("rangeno is %d\n", range->rangeno);
+                               debug_pci("[%x - %x]\n", range->start, range->end);
                                range = range->next;
                        }
                }
 
-               debug_pci ("The resources on this bus are as follows\n");
+               debug_pci("The resources on this bus are as follows\n");
 
-               debug_pci ("IO...\n");
+               debug_pci("IO...\n");
                if (bus_cur->firstIO) {
                        res = bus_cur->firstIO;
                        while (res) {
-                               debug_pci ("The range # is %d\n", res->rangeno);
-                               debug_pci ("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
-                               debug_pci ("[%x - %x], len=%x\n", res->start, res->end, res->len);
+                               debug_pci("The range # is %d\n", res->rangeno);
+                               debug_pci("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
+                               debug_pci("[%x - %x], len=%x\n", res->start, res->end, res->len);
                                if (res->next)
                                        res = res->next;
                                else if (res->nextRange)
@@ -1851,13 +1837,13 @@ void ibmphp_print_test (void)
                                        break;
                        }
                }
-               debug_pci ("Mem...\n");
+               debug_pci("Mem...\n");
                if (bus_cur->firstMem) {
                        res = bus_cur->firstMem;
                        while (res) {
-                               debug_pci ("The range # is %d\n", res->rangeno);
-                               debug_pci ("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
-                               debug_pci ("[%x - %x], len=%x\n", res->start, res->end, res->len);
+                               debug_pci("The range # is %d\n", res->rangeno);
+                               debug_pci("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
+                               debug_pci("[%x - %x], len=%x\n", res->start, res->end, res->len);
                                if (res->next)
                                        res = res->next;
                                else if (res->nextRange)
@@ -1866,13 +1852,13 @@ void ibmphp_print_test (void)
                                        break;
                        }
                }
-               debug_pci ("PFMem...\n");
+               debug_pci("PFMem...\n");
                if (bus_cur->firstPFMem) {
                        res = bus_cur->firstPFMem;
                        while (res) {
-                               debug_pci ("The range # is %d\n", res->rangeno);
-                               debug_pci ("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
-                               debug_pci ("[%x - %x], len=%x\n", res->start, res->end, res->len);
+                               debug_pci("The range # is %d\n", res->rangeno);
+                               debug_pci("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
+                               debug_pci("[%x - %x], len=%x\n", res->start, res->end, res->len);
                                if (res->next)
                                        res = res->next;
                                else if (res->nextRange)
@@ -1882,23 +1868,23 @@ void ibmphp_print_test (void)
                        }
                }
 
-               debug_pci ("PFMemFromMem...\n");
+               debug_pci("PFMemFromMem...\n");
                if (bus_cur->firstPFMemFromMem) {
                        res = bus_cur->firstPFMemFromMem;
                        while (res) {
-                               debug_pci ("The range # is %d\n", res->rangeno);
-                               debug_pci ("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
-                               debug_pci ("[%x - %x], len=%x\n", res->start, res->end, res->len);
+                               debug_pci("The range # is %d\n", res->rangeno);
+                               debug_pci("The bus, devfnc is %d, %x\n", res->busno, res->devfunc);
+                               debug_pci("[%x - %x], len=%x\n", res->start, res->end, res->len);
                                res = res->next;
                        }
                }
        }
-       debug_pci ("***********************END***********************\n");
+       debug_pci("***********************END***********************\n");
 }
 
-static int range_exists_already (struct range_node * range, struct bus_node * bus_cur, u8 type)
+static int range_exists_already(struct range_node *range, struct bus_node *bus_cur, u8 type)
 {
-       struct range_node * range_cur = NULL;
+       struct range_node *range_cur = NULL;
        switch (type) {
                case IO:
                        range_cur = bus_cur->rangeIO;
@@ -1910,7 +1896,7 @@ static int range_exists_already (struct range_node * range, struct bus_node * bu
                        range_cur = bus_cur->rangePFMem;
                        break;
                default:
-                       err ("wrong type passed to find out if range already exists\n");
+                       err("wrong type passed to find out if range already exists\n");
                        return -ENODEV;
        }
 
@@ -1937,7 +1923,7 @@ static int range_exists_already (struct range_node * range, struct bus_node * bu
  *      behind them All these are TO DO.
  *      Also need to add more error checkings... (from fnc returns etc)
  */
-static int __init update_bridge_ranges (struct bus_node **bus)
+static int __init update_bridge_ranges(struct bus_node **bus)
 {
        u8 sec_busno, device, function, hdr_type, start_io_address, end_io_address;
        u16 vendor_id, upper_io_start, upper_io_end, start_mem_address, end_mem_address;
@@ -1955,17 +1941,17 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                return -ENODEV;
        ibmphp_pci_bus->number = bus_cur->busno;
 
-       debug ("inside %s\n", __func__);
-       debug ("bus_cur->busno = %x\n", bus_cur->busno);
+       debug("inside %s\n", __func__);
+       debug("bus_cur->busno = %x\n", bus_cur->busno);
 
        for (device = 0; device < 32; device++) {
                for (function = 0x00; function < 0x08; function++) {
                        devfn = PCI_DEVFN(device, function);
-                       pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_VENDOR_ID, &vendor_id);
+                       pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_VENDOR_ID, &vendor_id);
 
                        if (vendor_id != PCI_VENDOR_ID_NOTVALID) {
                                /* found correct device!!! */
-                               pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_HEADER_TYPE, &hdr_type);
+                               pci_bus_read_config_byte(ibmphp_pci_bus, devfn, PCI_HEADER_TYPE, &hdr_type);
 
                                switch (hdr_type) {
                                        case PCI_HEADER_TYPE_NORMAL:
@@ -1984,18 +1970,18 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                   temp++;
                                                   }
                                                 */
-                                               pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_SECONDARY_BUS, &sec_busno);
-                                               bus_sec = find_bus_wprev (sec_busno, NULL, 0);
+                                               pci_bus_read_config_byte(ibmphp_pci_bus, devfn, PCI_SECONDARY_BUS, &sec_busno);
+                                               bus_sec = find_bus_wprev(sec_busno, NULL, 0);
                                                /* this bus structure doesn't exist yet, PPB was configured during previous loading of ibmphp */
                                                if (!bus_sec) {
-                                                       bus_sec = alloc_error_bus (NULL, sec_busno, 1);
+                                                       bus_sec = alloc_error_bus(NULL, sec_busno, 1);
                                                        /* the rest will be populated during NVRAM call */
                                                        return 0;
                                                }
-                                               pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_IO_BASE, &start_io_address);
-                                               pci_bus_read_config_byte (ibmphp_pci_bus, devfn, PCI_IO_LIMIT, &end_io_address);
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_IO_BASE_UPPER16, &upper_io_start);
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_IO_LIMIT_UPPER16, &upper_io_end);
+                                               pci_bus_read_config_byte(ibmphp_pci_bus, devfn, PCI_IO_BASE, &start_io_address);
+                                               pci_bus_read_config_byte(ibmphp_pci_bus, devfn, PCI_IO_LIMIT, &end_io_address);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_IO_BASE_UPPER16, &upper_io_start);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_IO_LIMIT_UPPER16, &upper_io_end);
                                                start_address = (start_io_address & PCI_IO_RANGE_MASK) << 8;
                                                start_address |= (upper_io_start << 16);
                                                end_address = (end_io_address & PCI_IO_RANGE_MASK) << 8;
@@ -2004,18 +1990,18 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                if ((start_address) && (start_address <= end_address)) {
                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                        if (!range) {
-                                                               err ("out of system memory\n");
+                                                               err("out of system memory\n");
                                                                return -ENOMEM;
                                                        }
                                                        range->start = start_address;
                                                        range->end = end_address + 0xfff;
 
                                                        if (bus_sec->noIORanges > 0) {
-                                                               if (!range_exists_already (range, bus_sec, IO)) {
-                                                                       add_bus_range (IO, range, bus_sec);
+                                                               if (!range_exists_already(range, bus_sec, IO)) {
+                                                                       add_bus_range(IO, range, bus_sec);
                                                                        ++bus_sec->noIORanges;
                                                                } else {
-                                                                       kfree (range);
+                                                                       kfree(range);
                                                                        range = NULL;
                                                                }
                                                        } else {
@@ -2024,13 +2010,13 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                bus_sec->rangeIO = range;
                                                                ++bus_sec->noIORanges;
                                                        }
-                                                       fix_resources (bus_sec);
+                                                       fix_resources(bus_sec);
 
-                                                       if (ibmphp_find_resource (bus_cur, start_address, &io, IO)) {
+                                                       if (ibmphp_find_resource(bus_cur, start_address, &io, IO)) {
                                                                io = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                if (!io) {
-                                                                       kfree (range);
-                                                                       err ("out of system memory\n");
+                                                                       kfree(range);
+                                                                       err("out of system memory\n");
                                                                        return -ENOMEM;
                                                                }
                                                                io->type = IO;
@@ -2039,12 +2025,12 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                io->start = start_address;
                                                                io->end = end_address + 0xfff;
                                                                io->len = io->end - io->start + 1;
-                                                               ibmphp_add_resource (io);
+                                                               ibmphp_add_resource(io);
                                                        }
                                                }
 
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_MEMORY_BASE, &start_mem_address);
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_MEMORY_LIMIT, &end_mem_address);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_MEMORY_BASE, &start_mem_address);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_MEMORY_LIMIT, &end_mem_address);
 
                                                start_address = 0x00000000 | (start_mem_address & PCI_MEMORY_RANGE_MASK) << 16;
                                                end_address = 0x00000000 | (end_mem_address & PCI_MEMORY_RANGE_MASK) << 16;
@@ -2053,18 +2039,18 @@ static int __init update_bridge_ranges (struct bus_node **bus)
 
                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                        if (!range) {
-                                                               err ("out of system memory\n");
+                                                               err("out of system memory\n");
                                                                return -ENOMEM;
                                                        }
                                                        range->start = start_address;
                                                        range->end = end_address + 0xfffff;
 
                                                        if (bus_sec->noMemRanges > 0) {
-                                                               if (!range_exists_already (range, bus_sec, MEM)) {
-                                                                       add_bus_range (MEM, range, bus_sec);
+                                                               if (!range_exists_already(range, bus_sec, MEM)) {
+                                                                       add_bus_range(MEM, range, bus_sec);
                                                                        ++bus_sec->noMemRanges;
                                                                } else {
-                                                                       kfree (range);
+                                                                       kfree(range);
                                                                        range = NULL;
                                                                }
                                                        } else {
@@ -2074,13 +2060,13 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                ++bus_sec->noMemRanges;
                                                        }
 
-                                                       fix_resources (bus_sec);
+                                                       fix_resources(bus_sec);
 
-                                                       if (ibmphp_find_resource (bus_cur, start_address, &mem, MEM)) {
+                                                       if (ibmphp_find_resource(bus_cur, start_address, &mem, MEM)) {
                                                                mem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                if (!mem) {
-                                                                       kfree (range);
-                                                                       err ("out of system memory\n");
+                                                                       kfree(range);
+                                                                       err("out of system memory\n");
                                                                        return -ENOMEM;
                                                                }
                                                                mem->type = MEM;
@@ -2089,13 +2075,13 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                mem->start = start_address;
                                                                mem->end = end_address + 0xfffff;
                                                                mem->len = mem->end - mem->start + 1;
-                                                               ibmphp_add_resource (mem);
+                                                               ibmphp_add_resource(mem);
                                                        }
                                                }
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_PREF_MEMORY_BASE, &start_mem_address);
-                                               pci_bus_read_config_word (ibmphp_pci_bus, devfn, PCI_PREF_MEMORY_LIMIT, &end_mem_address);
-                                               pci_bus_read_config_dword (ibmphp_pci_bus, devfn, PCI_PREF_BASE_UPPER32, &upper_start);
-                                               pci_bus_read_config_dword (ibmphp_pci_bus, devfn, PCI_PREF_LIMIT_UPPER32, &upper_end);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_PREF_MEMORY_BASE, &start_mem_address);
+                                               pci_bus_read_config_word(ibmphp_pci_bus, devfn, PCI_PREF_MEMORY_LIMIT, &end_mem_address);
+                                               pci_bus_read_config_dword(ibmphp_pci_bus, devfn, PCI_PREF_BASE_UPPER32, &upper_start);
+                                               pci_bus_read_config_dword(ibmphp_pci_bus, devfn, PCI_PREF_LIMIT_UPPER32, &upper_end);
                                                start_address = 0x00000000 | (start_mem_address & PCI_MEMORY_RANGE_MASK) << 16;
                                                end_address = 0x00000000 | (end_mem_address & PCI_MEMORY_RANGE_MASK) << 16;
 #if BITS_PER_LONG == 64
@@ -2107,18 +2093,18 @@ static int __init update_bridge_ranges (struct bus_node **bus)
 
                                                        range = kzalloc(sizeof(struct range_node), GFP_KERNEL);
                                                        if (!range) {
-                                                               err ("out of system memory\n");
+                                                               err("out of system memory\n");
                                                                return -ENOMEM;
                                                        }
                                                        range->start = start_address;
                                                        range->end = end_address + 0xfffff;
 
                                                        if (bus_sec->noPFMemRanges > 0) {
-                                                               if (!range_exists_already (range, bus_sec, PFMEM)) {
-                                                                       add_bus_range (PFMEM, range, bus_sec);
+                                                               if (!range_exists_already(range, bus_sec, PFMEM)) {
+                                                                       add_bus_range(PFMEM, range, bus_sec);
                                                                        ++bus_sec->noPFMemRanges;
                                                                } else {
-                                                                       kfree (range);
+                                                                       kfree(range);
                                                                        range = NULL;
                                                                }
                                                        } else {
@@ -2128,12 +2114,12 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                ++bus_sec->noPFMemRanges;
                                                        }
 
-                                                       fix_resources (bus_sec);
-                                                       if (ibmphp_find_resource (bus_cur, start_address, &pfmem, PFMEM)) {
+                                                       fix_resources(bus_sec);
+                                                       if (ibmphp_find_resource(bus_cur, start_address, &pfmem, PFMEM)) {
                                                                pfmem = kzalloc(sizeof(struct resource_node), GFP_KERNEL);
                                                                if (!pfmem) {
-                                                                       kfree (range);
-                                                                       err ("out of system memory\n");
+                                                                       kfree(range);
+                                                                       err("out of system memory\n");
                                                                        return -ENOMEM;
                                                                }
                                                                pfmem->type = PFMEM;
@@ -2144,7 +2130,7 @@ static int __init update_bridge_ranges (struct bus_node **bus)
                                                                pfmem->len = pfmem->end - pfmem->start + 1;
                                                                pfmem->fromMem = 0;
 
-                                                               ibmphp_add_resource (pfmem);
+                                                               ibmphp_add_resource(pfmem);
                                                        }
                                                }
                                                break;