Merge tag 'gfs2-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/steve...
[cascardo/linux.git] / drivers / scsi / scsi_error.c
index 9a6f846..e42fff6 100644 (file)
@@ -36,6 +36,7 @@
 #include <scsi/scsi_transport.h>
 #include <scsi/scsi_host.h>
 #include <scsi/scsi_ioctl.h>
+#include <scsi/sg.h>
 
 #include "scsi_priv.h"
 #include "scsi_logging.h"
@@ -157,8 +158,9 @@ scmd_eh_abort_handler(struct work_struct *work)
                } else {
                        SCSI_LOG_ERROR_RECOVERY(3,
                                scmd_printk(KERN_INFO, scmd,
-                                           "scmd %p abort failed, rtn %d\n",
-                                           scmd, rtn));
+                                           "scmd %p abort %s\n", scmd,
+                                           (rtn == FAST_IO_FAIL) ?
+                                           "not send" : "failed"));
                }
        }
 
@@ -355,7 +357,7 @@ static inline void scsi_eh_prt_fail_stats(struct Scsi_Host *shost,
 
                if (cmd_cancel || cmd_failed) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               sdev_printk(KERN_INFO, sdev,
+                               shost_printk(KERN_INFO, shost,
                                            "%s: cmds failed: %d, cancel: %d\n",
                                            __func__, cmd_failed,
                                            cmd_cancel));
@@ -459,14 +461,6 @@ static int scsi_check_sense(struct scsi_cmnd *scmd)
        if (! scsi_command_normalize_sense(scmd, &sshdr))
                return FAILED;  /* no valid sense data */
 
-       if (scmd->cmnd[0] == TEST_UNIT_READY && scmd->scsi_done != scsi_eh_done)
-               /*
-                * nasty: for mid-layer issued TURs, we need to return the
-                * actual sense data without any recovery attempt.  For eh
-                * issued ones, we need to try to recover and interpret
-                */
-               return SUCCESS;
-
        scsi_report_sense(sdev, &sshdr);
 
        if (scsi_sense_is_deferred(&sshdr))
@@ -482,6 +476,14 @@ static int scsi_check_sense(struct scsi_cmnd *scmd)
                /* handler does not care. Drop down to default handling */
        }
 
+       if (scmd->cmnd[0] == TEST_UNIT_READY && scmd->scsi_done != scsi_eh_done)
+               /*
+                * nasty: for mid-layer issued TURs, we need to return the
+                * actual sense data without any recovery attempt.  For eh
+                * issued ones, we need to try to recover and interpret
+                */
+               return SUCCESS;
+
        /*
         * Previous logic looked for FILEMARK, EOM or ILI which are
         * mainly associated with tapes and returned SUCCESS.
@@ -608,7 +610,7 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
        struct scsi_host_template *sht = sdev->host->hostt;
        struct scsi_device *tmp_sdev;
 
-       if (!sht->change_queue_depth ||
+       if (!sht->track_queue_depth ||
            sdev->queue_depth >= sdev->max_queue_depth)
                return;
 
@@ -629,12 +631,8 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
                    tmp_sdev->id != sdev->id ||
                    tmp_sdev->queue_depth == sdev->max_queue_depth)
                        continue;
-               /*
-                * call back into LLD to increase queue_depth by one
-                * with ramp up reason code.
-                */
-               sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1,
-                                       SCSI_QDEPTH_RAMP_UP);
+
+               scsi_change_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1);
                sdev->last_queue_ramp_up = jiffies;
        }
 }
@@ -644,7 +642,7 @@ static void scsi_handle_queue_full(struct scsi_device *sdev)
        struct scsi_host_template *sht = sdev->host->hostt;
        struct scsi_device *tmp_sdev;
 
-       if (!sht->change_queue_depth)
+       if (!sht->track_queue_depth)
                return;
 
        shost_for_each_device(tmp_sdev, sdev->host) {
@@ -656,8 +654,7 @@ static void scsi_handle_queue_full(struct scsi_device *sdev)
                 * the device when we got the queue full so we start
                 * from the highest possible value and work our way down.
                 */
-               sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth - 1,
-                                       SCSI_QDEPTH_QFULL);
+               scsi_track_queue_full(tmp_sdev, tmp_sdev->queue_depth - 1);
        }
 }
 
@@ -869,7 +866,24 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
        return rtn;
 }
 
-static int scsi_try_to_abort_cmd(struct scsi_host_template *hostt, struct scsi_cmnd *scmd)
+/**
+ * scsi_try_to_abort_cmd - Ask host to abort a SCSI command
+ * @scmd:      SCSI cmd used to send a target reset
+ *
+ * Return value:
+ *     SUCCESS, FAILED, or FAST_IO_FAIL
+ *
+ * Notes:
+ *    SUCCESS does not necessarily indicate that the command
+ *    has been aborted; it only indicates that the LLDDs
+ *    has cleared all references to that command.
+ *    LLDDs should return FAILED only if an abort was required
+ *    but could not be executed. LLDDs should return FAST_IO_FAIL
+ *    if the device is temporarily unavailable (eg due to a
+ *    link down on FibreChannel)
+ */
+static int scsi_try_to_abort_cmd(struct scsi_host_template *hostt,
+                                struct scsi_cmnd *scmd)
 {
        if (!hostt->eh_abort_handler)
                return FAILED;
@@ -1156,9 +1170,9 @@ int scsi_eh_get_sense(struct list_head *work_q,
                shost = scmd->device->host;
                if (scsi_host_eh_past_deadline(shost)) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                               scmd_printk(KERN_INFO, scmd,
+                                           "%s: skip request sense, past eh deadline\n",
+                                            current->comm));
                        break;
                }
                if (status_byte(scmd->result) != CHECK_CONDITION)
@@ -1180,7 +1194,7 @@ int scsi_eh_get_sense(struct list_head *work_q,
                SCSI_LOG_ERROR_RECOVERY(3, scmd_printk(KERN_INFO, scmd,
                        "sense requested for %p result %x\n",
                        scmd, scmd->result));
-               SCSI_LOG_ERROR_RECOVERY(3, scsi_print_sense("bh", scmd));
+               SCSI_LOG_ERROR_RECOVERY(3, scsi_print_sense(scmd));
 
                rtn = scsi_decide_disposition(scmd);
 
@@ -1265,9 +1279,9 @@ static int scsi_eh_test_devices(struct list_head *cmd_list,
                                /* Push items back onto work_q */
                                list_splice_init(cmd_list, work_q);
                                SCSI_LOG_ERROR_RECOVERY(3,
-                                       shost_printk(KERN_INFO, sdev->host,
-                                                    "skip %s, past eh deadline",
-                                                    __func__));
+                                       sdev_printk(KERN_INFO, sdev,
+                                                   "%s: skip test device, past eh deadline",
+                                                   current->comm));
                                break;
                        }
                }
@@ -1318,21 +1332,20 @@ static int scsi_eh_abort_cmds(struct list_head *work_q,
                if (scsi_host_eh_past_deadline(shost)) {
                        list_splice_init(&check_list, work_q);
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                               scmd_printk(KERN_INFO, scmd,
+                                           "%s: skip aborting cmd, past eh deadline\n",
+                                           current->comm));
                        return list_empty(work_q);
                }
                SCSI_LOG_ERROR_RECOVERY(3,
-                       shost_printk(KERN_INFO, shost,
-                                    "%s: aborting cmd: 0x%p\n",
-                                    current->comm, scmd));
+                       scmd_printk(KERN_INFO, scmd,
+                                    "%s: aborting cmd\n", current->comm));
                rtn = scsi_try_to_abort_cmd(shost->hostt, scmd);
                if (rtn == FAILED) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                            "%s: aborting cmd failed: 0x%p\n",
-                                            current->comm, scmd));
+                               scmd_printk(KERN_INFO, scmd,
+                                           "%s: aborting cmd failed\n",
+                                            current->comm));
                        list_splice_init(&check_list, work_q);
                        return list_empty(work_q);
                }
@@ -1390,9 +1403,9 @@ static int scsi_eh_stu(struct Scsi_Host *shost,
        shost_for_each_device(sdev, shost) {
                if (scsi_host_eh_past_deadline(shost)) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                               sdev_printk(KERN_INFO, sdev,
+                                           "%s: skip START_UNIT, past eh deadline\n",
+                                           current->comm));
                        break;
                }
                stu_scmd = NULL;
@@ -1407,9 +1420,9 @@ static int scsi_eh_stu(struct Scsi_Host *shost,
                        continue;
 
                SCSI_LOG_ERROR_RECOVERY(3,
-                       shost_printk(KERN_INFO, shost,
-                                    "%s: Sending START_UNIT to sdev: 0x%p\n",
-                                    current->comm, sdev));
+                       sdev_printk(KERN_INFO, sdev,
+                                    "%s: Sending START_UNIT\n",
+                                   current->comm));
 
                if (!scsi_eh_try_stu(stu_scmd)) {
                        if (!scsi_device_online(sdev) ||
@@ -1423,9 +1436,9 @@ static int scsi_eh_stu(struct Scsi_Host *shost,
                        }
                } else {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                            "%s: START_UNIT failed to sdev:"
-                                            " 0x%p\n", current->comm, sdev));
+                               sdev_printk(KERN_INFO, sdev,
+                                           "%s: START_UNIT failed\n",
+                                           current->comm));
                }
        }
 
@@ -1456,9 +1469,9 @@ static int scsi_eh_bus_device_reset(struct Scsi_Host *shost,
        shost_for_each_device(sdev, shost) {
                if (scsi_host_eh_past_deadline(shost)) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                               sdev_printk(KERN_INFO, sdev,
+                                           "%s: skip BDR, past eh deadline\n",
+                                            current->comm));
                        break;
                }
                bdr_scmd = NULL;
@@ -1472,9 +1485,8 @@ static int scsi_eh_bus_device_reset(struct Scsi_Host *shost,
                        continue;
 
                SCSI_LOG_ERROR_RECOVERY(3,
-                       shost_printk(KERN_INFO, shost,
-                                    "%s: Sending BDR sdev: 0x%p\n",
-                                    current->comm, sdev));
+                       sdev_printk(KERN_INFO, sdev,
+                                    "%s: Sending BDR\n", current->comm));
                rtn = scsi_try_bus_device_reset(bdr_scmd);
                if (rtn == SUCCESS || rtn == FAST_IO_FAIL) {
                        if (!scsi_device_online(sdev) ||
@@ -1490,9 +1502,8 @@ static int scsi_eh_bus_device_reset(struct Scsi_Host *shost,
                        }
                } else {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               shost_printk(KERN_INFO, shost,
-                                            "%s: BDR failed sdev: 0x%p\n",
-                                            current->comm, sdev));
+                               sdev_printk(KERN_INFO, sdev,
+                                           "%s: BDR failed\n", current->comm));
                }
        }
 
@@ -1528,8 +1539,8 @@ static int scsi_eh_target_reset(struct Scsi_Host *shost,
                        list_splice_init(&tmp_list, work_q);
                        SCSI_LOG_ERROR_RECOVERY(3,
                                shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                                           "%s: Skip target reset, past eh deadline\n",
+                                            current->comm));
                        return list_empty(work_q);
                }
 
@@ -1591,8 +1602,8 @@ static int scsi_eh_bus_reset(struct Scsi_Host *shost,
                        list_splice_init(&check_list, work_q);
                        SCSI_LOG_ERROR_RECOVERY(3,
                                shost_printk(KERN_INFO, shost,
-                                           "skip %s, past eh deadline\n",
-                                            __func__));
+                                           "%s: skip BRST, past eh deadline\n",
+                                            current->comm));
                        return list_empty(work_q);
                }
 
@@ -2001,8 +2012,10 @@ static void scsi_restart_operations(struct Scsi_Host *shost)
         * is no point trying to lock the door of an off-line device.
         */
        shost_for_each_device(sdev, shost) {
-               if (scsi_device_online(sdev) && sdev->locked)
+               if (scsi_device_online(sdev) && sdev->was_reset && sdev->locked) {
                        scsi_eh_lock_door(sdev);
+                       sdev->was_reset = 0;
+               }
        }
 
        /*
@@ -2191,9 +2204,9 @@ int scsi_error_handler(void *data)
                 */
                if (!shost->eh_noresume && scsi_autopm_get_host(shost) != 0) {
                        SCSI_LOG_ERROR_RECOVERY(1,
-                               printk(KERN_ERR "Error handler scsi_eh_%d "
-                                               "unable to autoresume\n",
-                                               shost->host_no));
+                               shost_printk(KERN_ERR, shost,
+                                            "scsi_eh_%d: unable to autoresume\n",
+                                            shost->host_no));
                        continue;
                }
 
@@ -2294,42 +2307,34 @@ scsi_reset_provider_done_command(struct scsi_cmnd *scmd)
 {
 }
 
-/*
- * Function:   scsi_reset_provider
- *
- * Purpose:    Send requested reset to a bus or device at any phase.
- *
- * Arguments:  device  - device to send reset to
- *             flag - reset type (see scsi.h)
- *
- * Returns:    SUCCESS/FAILURE.
- *
- * Notes:      This is used by the SCSI Generic driver to provide
- *             Bus/Device reset capability.
+/**
+ * scsi_ioctl_reset: explicitly reset a host/bus/target/device
+ * @dev:       scsi_device to operate on
+ * @arg:       reset type (see sg.h)
  */
 int
-scsi_reset_provider(struct scsi_device *dev, int flag)
+scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
 {
        struct scsi_cmnd *scmd;
        struct Scsi_Host *shost = dev->host;
        struct request req;
        unsigned long flags;
-       int rtn;
+       int error = 0, rtn, val;
 
-       if (scsi_autopm_get_host(shost) < 0)
-               return FAILED;
+       if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
+               return -EACCES;
 
-       if (!get_device(&dev->sdev_gendev)) {
-               rtn = FAILED;
-               goto out_put_autopm_host;
-       }
+       error = get_user(val, arg);
+       if (error)
+               return error;
 
+       if (scsi_autopm_get_host(shost) < 0)
+               return -EIO;
+
+       error = -EIO;
        scmd = scsi_get_command(dev, GFP_KERNEL);
-       if (!scmd) {
-               rtn = FAILED;
-               put_device(&dev->sdev_gendev);
+       if (!scmd)
                goto out_put_autopm_host;
-       }
 
        blk_rq_init(NULL, &req);
        scmd->request = &req;
@@ -2347,29 +2352,37 @@ scsi_reset_provider(struct scsi_device *dev, int flag)
        shost->tmf_in_progress = 1;
        spin_unlock_irqrestore(shost->host_lock, flags);
 
-       switch (flag) {
-       case SCSI_TRY_RESET_DEVICE:
+       switch (val & ~SG_SCSI_RESET_NO_ESCALATE) {
+       case SG_SCSI_RESET_NOTHING:
+               rtn = SUCCESS;
+               break;
+       case SG_SCSI_RESET_DEVICE:
                rtn = scsi_try_bus_device_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_TARGET:
+       case SG_SCSI_RESET_TARGET:
                rtn = scsi_try_target_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_BUS:
+       case SG_SCSI_RESET_BUS:
                rtn = scsi_try_bus_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_HOST:
+       case SG_SCSI_RESET_HOST:
                rtn = scsi_try_host_reset(scmd);
-               break;
+               if (rtn == SUCCESS)
+                       break;
        default:
+               /* FALLTHROUGH */
                rtn = FAILED;
+               break;
        }
 
+       error = (rtn == SUCCESS) ? 0 : -EIO;
+
        spin_lock_irqsave(shost->host_lock, flags);
        shost->tmf_in_progress = 0;
        spin_unlock_irqrestore(shost->host_lock, flags);
@@ -2383,15 +2396,15 @@ scsi_reset_provider(struct scsi_device *dev, int flag)
                             "waking up host to restart after TMF\n"));
 
        wake_up(&shost->host_wait);
-
        scsi_run_host_queues(shost);
 
-       scsi_next_command(scmd);
+       scsi_put_command(scmd);
+
 out_put_autopm_host:
        scsi_autopm_put_host(shost);
-       return rtn;
+       return error;
 }
-EXPORT_SYMBOL(scsi_reset_provider);
+EXPORT_SYMBOL(scsi_ioctl_reset);
 
 /**
  * scsi_normalize_sense - normalize main elements from either fixed or
@@ -2410,20 +2423,20 @@ EXPORT_SYMBOL(scsi_reset_provider);
  *     responded to a SCSI command with the CHECK_CONDITION status.
  *
  * Return value:
- *     1 if valid sense data information found, else 0;
+ *     true if valid sense data information found, else false;
  */
-int scsi_normalize_sense(const u8 *sense_buffer, int sb_len,
-                         struct scsi_sense_hdr *sshdr)
+bool scsi_normalize_sense(const u8 *sense_buffer, int sb_len,
+                         struct scsi_sense_hdr *sshdr)
 {
        if (!sense_buffer || !sb_len)
-               return 0;
+               return false;
 
        memset(sshdr, 0, sizeof(struct scsi_sense_hdr));
 
        sshdr->response_code = (sense_buffer[0] & 0x7f);
 
        if (!scsi_sense_valid(sshdr))
-               return 0;
+               return false;
 
        if (sshdr->response_code >= 0x72) {
                /*
@@ -2453,12 +2466,12 @@ int scsi_normalize_sense(const u8 *sense_buffer, int sb_len,
                }
        }
 
-       return 1;
+       return true;
 }
 EXPORT_SYMBOL(scsi_normalize_sense);
 
-int scsi_command_normalize_sense(struct scsi_cmnd *cmd,
-                                struct scsi_sense_hdr *sshdr)
+bool scsi_command_normalize_sense(const struct scsi_cmnd *cmd,
+                                 struct scsi_sense_hdr *sshdr)
 {
        return scsi_normalize_sense(cmd->sense_buffer,
                        SCSI_SENSE_BUFFERSIZE, sshdr);