ocfs2: fix double unlock in case retry after free truncate log

[cascardo/linux.git] / fs / nilfs2 / sysfs.c

diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index 8ffa42b..490303e 100644 (file)
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -272,8 +272,8 @@ nilfs_checkpoints_checkpoints_number_show(struct nilfs_checkpoints_attr *attr,
        err = nilfs_cpfile_get_stat(nilfs->ns_cpfile, &cpstat);
        up_read(&nilfs->ns_segctor_sem);
        if (err < 0) {
-               printk(KERN_ERR "NILFS: unable to get checkpoint stat: err=%d\n",
-                       err);
+               nilfs_msg(nilfs->ns_sb, KERN_ERR,
+                         "unable to get checkpoint stat: err=%d", err);
                return err;
        }
 
@@ -295,8 +295,8 @@ nilfs_checkpoints_snapshots_number_show(struct nilfs_checkpoints_attr *attr,
        err = nilfs_cpfile_get_stat(nilfs->ns_cpfile, &cpstat);
        up_read(&nilfs->ns_segctor_sem);
        if (err < 0) {
-               printk(KERN_ERR "NILFS: unable to get checkpoint stat: err=%d\n",
-                       err);
+               nilfs_msg(nilfs->ns_sb, KERN_ERR,
+                         "unable to get checkpoint stat: err=%d", err);
                return err;
        }
 
@@ -326,9 +326,9 @@ nilfs_checkpoints_next_checkpoint_show(struct nilfs_checkpoints_attr *attr,
 {
        __u64 cno;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        cno = nilfs->ns_cno;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", cno);
 }
@@ -414,8 +414,8 @@ nilfs_segments_dirty_segments_show(struct nilfs_segments_attr *attr,
        err = nilfs_sufile_get_stat(nilfs->ns_sufile, &sustat);
        up_read(&nilfs->ns_segctor_sem);
        if (err < 0) {
-               printk(KERN_ERR "NILFS: unable to get segment stat: err=%d\n",
-                       err);
+               nilfs_msg(nilfs->ns_sb, KERN_ERR,
+                         "unable to get segment stat: err=%d", err);
                return err;
        }
 
@@ -511,9 +511,9 @@ nilfs_segctor_current_seg_sequence_show(struct nilfs_segctor_attr *attr,
 {
        u64 seg_seq;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        seg_seq = nilfs->ns_seg_seq;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", seg_seq);
 }
@@ -525,9 +525,9 @@ nilfs_segctor_current_last_full_seg_show(struct nilfs_segctor_attr *attr,
 {
        __u64 segnum;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        segnum = nilfs->ns_segnum;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", segnum);
 }
@@ -539,9 +539,9 @@ nilfs_segctor_next_full_seg_show(struct nilfs_segctor_attr *attr,
 {
        __u64 nextnum;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        nextnum = nilfs->ns_nextnum;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", nextnum);
 }
@@ -553,9 +553,9 @@ nilfs_segctor_next_pseg_offset_show(struct nilfs_segctor_attr *attr,
 {
        unsigned long pseg_offset;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        pseg_offset = nilfs->ns_pseg_offset;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%lu\n", pseg_offset);
 }
@@ -567,9 +567,9 @@ nilfs_segctor_next_checkpoint_show(struct nilfs_segctor_attr *attr,
 {
        __u64 cno;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        cno = nilfs->ns_cno;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", cno);
 }
@@ -581,9 +581,9 @@ nilfs_segctor_last_seg_write_time_show(struct nilfs_segctor_attr *attr,
 {
        time_t ctime;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        ctime = nilfs->ns_ctime;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return NILFS_SHOW_TIME(ctime, buf);
 }
@@ -595,9 +595,9 @@ nilfs_segctor_last_seg_write_time_secs_show(struct nilfs_segctor_attr *attr,
 {
        time_t ctime;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        ctime = nilfs->ns_ctime;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n", (unsigned long long)ctime);
 }
@@ -609,9 +609,9 @@ nilfs_segctor_last_nongc_write_time_show(struct nilfs_segctor_attr *attr,
 {
        time_t nongc_ctime;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        nongc_ctime = nilfs->ns_nongc_ctime;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return NILFS_SHOW_TIME(nongc_ctime, buf);
 }
@@ -623,9 +623,9 @@ nilfs_segctor_last_nongc_write_time_secs_show(struct nilfs_segctor_attr *attr,
 {
        time_t nongc_ctime;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        nongc_ctime = nilfs->ns_nongc_ctime;
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%llu\n",
                        (unsigned long long)nongc_ctime);
@@ -638,9 +638,9 @@ nilfs_segctor_dirty_data_blocks_count_show(struct nilfs_segctor_attr *attr,
 {
        u32 ndirtyblks;
 
-       down_read(&nilfs->ns_sem);
+       down_read(&nilfs->ns_segctor_sem);
        ndirtyblks = atomic_read(&nilfs->ns_ndirtyblks);
-       up_read(&nilfs->ns_sem);
+       up_read(&nilfs->ns_segctor_sem);
 
        return snprintf(buf, PAGE_SIZE, "%u\n", ndirtyblks);
 }
@@ -789,14 +789,15 @@ nilfs_superblock_sb_update_frequency_store(struct nilfs_superblock_attr *attr,
 
        err = kstrtouint(skip_spaces(buf), 0, &val);
        if (err) {
-               printk(KERN_ERR "NILFS: unable to convert string: err=%d\n",
-                       err);
+               nilfs_msg(nilfs->ns_sb, KERN_ERR,
+                         "unable to convert string: err=%d", err);
                return err;
        }
 
        if (val < NILFS_SB_FREQ) {
                val = NILFS_SB_FREQ;
-               printk(KERN_WARNING "NILFS: superblock update frequency cannot be lesser than 10 seconds\n");
+               nilfs_msg(nilfs->ns_sb, KERN_WARNING,
+                         "superblock update frequency cannot be lesser than 10 seconds");
        }
 
        down_write(&nilfs->ns_sem);
@@ -999,7 +1000,8 @@ int nilfs_sysfs_create_device_group(struct super_block *sb)
        nilfs->ns_dev_subgroups = kzalloc(devgrp_size, GFP_KERNEL);
        if (unlikely(!nilfs->ns_dev_subgroups)) {
                err = -ENOMEM;
-               printk(KERN_ERR "NILFS: unable to allocate memory for device group\n");
+               nilfs_msg(sb, KERN_ERR,
+                         "unable to allocate memory for device group");
                goto failed_create_device_group;
        }
 
@@ -1109,15 +1111,15 @@ int __init nilfs_sysfs_init(void)
        nilfs_kset = kset_create_and_add(NILFS_ROOT_GROUP_NAME, NULL, fs_kobj);
        if (!nilfs_kset) {
                err = -ENOMEM;
-               printk(KERN_ERR "NILFS: unable to create sysfs entry: err %d\n",
-                       err);
+               nilfs_msg(NULL, KERN_ERR,
+                         "unable to create sysfs entry: err=%d", err);
                goto failed_sysfs_init;
        }
 
        err = sysfs_create_group(&nilfs_kset->kobj, &nilfs_feature_attr_group);
        if (unlikely(err)) {
-               printk(KERN_ERR "NILFS: unable to create feature group: err %d\n",
-                       err);
+               nilfs_msg(NULL, KERN_ERR,
+                         "unable to create feature group: err=%d", err);
                goto cleanup_sysfs_init;
        }