ocfs2: add ocfs2_xattr_set_handle
[cascardo/linux.git] / fs / ocfs2 / xattr.c
index f1da381..6480254 100644 (file)
@@ -71,6 +71,13 @@ struct ocfs2_xattr_bucket {
        int bu_blocks;
 };
 
+struct ocfs2_xattr_set_ctxt {
+       handle_t *handle;
+       struct ocfs2_alloc_context *meta_ac;
+       struct ocfs2_alloc_context *data_ac;
+       struct ocfs2_cached_dealloc_ctxt dealloc;
+};
+
 #define OCFS2_XATTR_ROOT_SIZE  (sizeof(struct ocfs2_xattr_def_value_root))
 #define OCFS2_XATTR_INLINE_SIZE        80
 
@@ -133,11 +140,13 @@ static int ocfs2_xattr_tree_list_index_block(struct inode *inode,
                                        size_t buffer_size);
 
 static int ocfs2_xattr_create_index_block(struct inode *inode,
-                                         struct ocfs2_xattr_search *xs);
+                                         struct ocfs2_xattr_search *xs,
+                                         struct ocfs2_xattr_set_ctxt *ctxt);
 
 static int ocfs2_xattr_set_entry_index_block(struct inode *inode,
                                             struct ocfs2_xattr_info *xi,
-                                            struct ocfs2_xattr_search *xs);
+                                            struct ocfs2_xattr_search *xs,
+                                            struct ocfs2_xattr_set_ctxt *ctxt);
 
 static int ocfs2_delete_xattr_index_block(struct inode *inode,
                                          struct buffer_head *xb_bh);
@@ -334,14 +343,11 @@ static void ocfs2_xattr_hash_entry(struct inode *inode,
 static int ocfs2_xattr_extend_allocation(struct inode *inode,
                                         u32 clusters_to_add,
                                         struct buffer_head *xattr_bh,
-                                        struct ocfs2_xattr_value_root *xv)
+                                        struct ocfs2_xattr_value_root *xv,
+                                        struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int status = 0;
-       int restart_func = 0;
-       int credits = 0;
-       handle_t *handle = NULL;
-       struct ocfs2_alloc_context *data_ac = NULL;
-       struct ocfs2_alloc_context *meta_ac = NULL;
+       handle_t *handle = ctxt->handle;
        enum ocfs2_alloc_restarted why;
        struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        u32 prev_clusters, logical_start = le32_to_cpu(xv->xr_clusters);
@@ -351,26 +357,6 @@ static int ocfs2_xattr_extend_allocation(struct inode *inode,
 
        ocfs2_init_xattr_value_extent_tree(&et, inode, xattr_bh, xv);
 
-restart_all:
-
-       status = ocfs2_lock_allocators(inode, &et, clusters_to_add, 0,
-                                      &data_ac, &meta_ac);
-       if (status) {
-               mlog_errno(status);
-               goto leave;
-       }
-
-       credits = ocfs2_calc_extend_credits(osb->sb, et.et_root_el,
-                                           clusters_to_add);
-       handle = ocfs2_start_trans(osb, credits);
-       if (IS_ERR(handle)) {
-               status = PTR_ERR(handle);
-               handle = NULL;
-               mlog_errno(status);
-               goto leave;
-       }
-
-restarted_transaction:
        status = ocfs2_journal_access(handle, inode, xattr_bh,
                                      OCFS2_JOURNAL_ACCESS_WRITE);
        if (status < 0) {
@@ -386,12 +372,11 @@ restarted_transaction:
                                             0,
                                             &et,
                                             handle,
-                                            data_ac,
-                                            meta_ac,
+                                            ctxt->data_ac,
+                                            ctxt->meta_ac,
                                             &why);
-       if ((status < 0) && (status != -EAGAIN)) {
-               if (status != -ENOSPC)
-                       mlog_errno(status);
+       if (status < 0) {
+               mlog_errno(status);
                goto leave;
        }
 
@@ -403,47 +388,13 @@ restarted_transaction:
 
        clusters_to_add -= le32_to_cpu(xv->xr_clusters) - prev_clusters;
 
-       if (why != RESTART_NONE && clusters_to_add) {
-               if (why == RESTART_META) {
-                       mlog(0, "restarting function.\n");
-                       restart_func = 1;
-               } else {
-                       BUG_ON(why != RESTART_TRANS);
-
-                       mlog(0, "restarting transaction.\n");
-                       /* TODO: This can be more intelligent. */
-                       credits = ocfs2_calc_extend_credits(osb->sb,
-                                                           et.et_root_el,
-                                                           clusters_to_add);
-                       status = ocfs2_extend_trans(handle, credits);
-                       if (status < 0) {
-                               /* handle still has to be committed at
-                                * this point. */
-                               status = -ENOMEM;
-                               mlog_errno(status);
-                               goto leave;
-                       }
-                       goto restarted_transaction;
-               }
-       }
+       /*
+        * We should have already allocated enough space before the transaction,
+        * so no need to restart.
+        */
+       BUG_ON(why != RESTART_NONE || clusters_to_add);
 
 leave:
-       if (handle) {
-               ocfs2_commit_trans(osb, handle);
-               handle = NULL;
-       }
-       if (data_ac) {
-               ocfs2_free_alloc_context(data_ac);
-               data_ac = NULL;
-       }
-       if (meta_ac) {
-               ocfs2_free_alloc_context(meta_ac);
-               meta_ac = NULL;
-       }
-       if ((!status) && restart_func) {
-               restart_func = 0;
-               goto restart_all;
-       }
 
        return status;
 }
@@ -452,42 +403,27 @@ static int __ocfs2_remove_xattr_range(struct inode *inode,
                                      struct buffer_head *root_bh,
                                      struct ocfs2_xattr_value_root *xv,
                                      u32 cpos, u32 phys_cpos, u32 len,
-                                     struct ocfs2_cached_dealloc_ctxt *dealloc)
+                                     struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret;
        u64 phys_blkno = ocfs2_clusters_to_blocks(inode->i_sb, phys_cpos);
-       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
-       handle_t *handle;
-       struct ocfs2_alloc_context *meta_ac = NULL;
+       handle_t *handle = ctxt->handle;
        struct ocfs2_extent_tree et;
 
        ocfs2_init_xattr_value_extent_tree(&et, inode, root_bh, xv);
 
-       ret = ocfs2_lock_allocators(inode, &et, 0, 1, NULL, &meta_ac);
-       if (ret) {
-               mlog_errno(ret);
-               return ret;
-       }
-
-       handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               goto out;
-       }
-
        ret = ocfs2_journal_access(handle, inode, root_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
-       ret = ocfs2_remove_extent(inode, &et, cpos, len, handle, meta_ac,
-                                 dealloc);
+       ret = ocfs2_remove_extent(inode, &et, cpos, len, handle, ctxt->meta_ac,
+                                 &ctxt->dealloc);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        le32_add_cpu(&xv->xr_clusters, -len);
@@ -495,20 +431,14 @@ static int __ocfs2_remove_xattr_range(struct inode *inode,
        ret = ocfs2_journal_dirty(handle, root_bh);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
-       ret = ocfs2_cache_cluster_dealloc(dealloc, phys_blkno, len);
+       ret = ocfs2_cache_cluster_dealloc(&ctxt->dealloc, phys_blkno, len);
        if (ret)
                mlog_errno(ret);
 
-out_commit:
-       ocfs2_commit_trans(osb, handle);
 out:
-
-       if (meta_ac)
-               ocfs2_free_alloc_context(meta_ac);
-
        return ret;
 }
 
@@ -516,15 +446,12 @@ static int ocfs2_xattr_shrink_size(struct inode *inode,
                                   u32 old_clusters,
                                   u32 new_clusters,
                                   struct buffer_head *root_bh,
-                                  struct ocfs2_xattr_value_root *xv)
+                                  struct ocfs2_xattr_value_root *xv,
+                                  struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret = 0;
        u32 trunc_len, cpos, phys_cpos, alloc_size;
        u64 block;
-       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
-       struct ocfs2_cached_dealloc_ctxt dealloc;
-
-       ocfs2_init_dealloc_ctxt(&dealloc);
 
        if (old_clusters <= new_clusters)
                return 0;
@@ -544,7 +471,7 @@ static int ocfs2_xattr_shrink_size(struct inode *inode,
 
                ret = __ocfs2_remove_xattr_range(inode, root_bh, xv, cpos,
                                                 phys_cpos, alloc_size,
-                                                &dealloc);
+                                                ctxt);
                if (ret) {
                        mlog_errno(ret);
                        goto out;
@@ -558,16 +485,14 @@ static int ocfs2_xattr_shrink_size(struct inode *inode,
        }
 
 out:
-       ocfs2_schedule_truncate_log_flush(osb, 1);
-       ocfs2_run_deallocs(osb, &dealloc);
-
        return ret;
 }
 
 static int ocfs2_xattr_value_truncate(struct inode *inode,
                                      struct buffer_head *root_bh,
                                      struct ocfs2_xattr_value_root *xv,
-                                     int len)
+                                     int len,
+                                     struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret;
        u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb, len);
@@ -579,11 +504,11 @@ static int ocfs2_xattr_value_truncate(struct inode *inode,
        if (new_clusters > old_clusters)
                ret = ocfs2_xattr_extend_allocation(inode,
                                                    new_clusters - old_clusters,
-                                                   root_bh, xv);
+                                                   root_bh, xv, ctxt);
        else
                ret = ocfs2_xattr_shrink_size(inode,
                                              old_clusters, new_clusters,
-                                             root_bh, xv);
+                                             root_bh, xv, ctxt);
 
        return ret;
 }
@@ -999,6 +924,7 @@ static int ocfs2_xattr_get(struct inode *inode,
 }
 
 static int __ocfs2_xattr_set_value_outside(struct inode *inode,
+                                          handle_t *handle,
                                           struct ocfs2_xattr_value_root *xv,
                                           const void *value,
                                           int value_len)
@@ -1010,14 +936,17 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
        u32 clusters = ocfs2_clusters_for_bytes(inode->i_sb, value_len);
        u64 blkno;
        struct buffer_head *bh = NULL;
-       handle_t *handle;
 
        BUG_ON(clusters > le32_to_cpu(xv->xr_clusters));
 
+       /*
+        * In __ocfs2_xattr_set_value_outside has already been dirtied,
+        * so we don't need to worry about whether ocfs2_extend_trans
+        * will create a new transactio for us or not.
+        */
        credits = clusters * bpc;
-       handle = ocfs2_start_trans(OCFS2_SB(inode->i_sb), credits);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
+       ret = ocfs2_extend_trans(handle, credits);
+       if (ret) {
                mlog_errno(ret);
                goto out;
        }
@@ -1027,7 +956,7 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
                                               &num_clusters, &xv->xr_list);
                if (ret) {
                        mlog_errno(ret);
-                       goto out_commit;
+                       goto out;
                }
 
                blkno = ocfs2_clusters_to_blocks(inode->i_sb, p_cluster);
@@ -1036,7 +965,7 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
                        ret = ocfs2_read_block(inode, blkno, &bh);
                        if (ret) {
                                mlog_errno(ret);
-                               goto out_commit;
+                               goto out;
                        }
 
                        ret = ocfs2_journal_access(handle,
@@ -1045,7 +974,7 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
                                                   OCFS2_JOURNAL_ACCESS_WRITE);
                        if (ret < 0) {
                                mlog_errno(ret);
-                               goto out_commit;
+                               goto out;
                        }
 
                        cp_len = value_len > blocksize ? blocksize : value_len;
@@ -1059,7 +988,7 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
                        ret = ocfs2_journal_dirty(handle, bh);
                        if (ret < 0) {
                                mlog_errno(ret);
-                               goto out_commit;
+                               goto out;
                        }
                        brelse(bh);
                        bh = NULL;
@@ -1073,8 +1002,6 @@ static int __ocfs2_xattr_set_value_outside(struct inode *inode,
                }
                cpos += num_clusters;
        }
-out_commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
 out:
        brelse(bh);
 
@@ -1082,28 +1009,21 @@ out:
 }
 
 static int ocfs2_xattr_cleanup(struct inode *inode,
+                              handle_t *handle,
                               struct ocfs2_xattr_info *xi,
                               struct ocfs2_xattr_search *xs,
                               size_t offs)
 {
-       handle_t *handle = NULL;
        int ret = 0;
        size_t name_len = strlen(xi->name);
        void *val = xs->base + offs;
        size_t size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE;
 
-       handle = ocfs2_start_trans((OCFS2_SB(inode->i_sb)),
-                                  OCFS2_XATTR_BLOCK_UPDATE_CREDITS);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               goto out;
-       }
        ret = ocfs2_journal_access(handle, inode, xs->xattr_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
        /* Decrease xattr count */
        le16_add_cpu(&xs->header->xh_count, -1);
@@ -1114,32 +1034,23 @@ static int ocfs2_xattr_cleanup(struct inode *inode,
        ret = ocfs2_journal_dirty(handle, xs->xattr_bh);
        if (ret < 0)
                mlog_errno(ret);
-out_commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
 out:
        return ret;
 }
 
 static int ocfs2_xattr_update_entry(struct inode *inode,
+                                   handle_t *handle,
                                    struct ocfs2_xattr_info *xi,
                                    struct ocfs2_xattr_search *xs,
                                    size_t offs)
 {
-       handle_t *handle = NULL;
-       int ret = 0;
+       int ret;
 
-       handle = ocfs2_start_trans((OCFS2_SB(inode->i_sb)),
-                                  OCFS2_XATTR_BLOCK_UPDATE_CREDITS);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               goto out;
-       }
        ret = ocfs2_journal_access(handle, inode, xs->xattr_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        xs->here->xe_name_offset = cpu_to_le16(offs);
@@ -1153,8 +1064,6 @@ static int ocfs2_xattr_update_entry(struct inode *inode,
        ret = ocfs2_journal_dirty(handle, xs->xattr_bh);
        if (ret < 0)
                mlog_errno(ret);
-out_commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
 out:
        return ret;
 }
@@ -1167,6 +1076,7 @@ out:
 static int ocfs2_xattr_set_value_outside(struct inode *inode,
                                         struct ocfs2_xattr_info *xi,
                                         struct ocfs2_xattr_search *xs,
+                                        struct ocfs2_xattr_set_ctxt *ctxt,
                                         size_t offs)
 {
        size_t name_len = strlen(xi->name);
@@ -1186,18 +1096,18 @@ static int ocfs2_xattr_set_value_outside(struct inode *inode,
        xv->xr_list.l_next_free_rec = 0;
 
        ret = ocfs2_xattr_value_truncate(inode, xs->xattr_bh, xv,
-                                        xi->value_len);
+                                        xi->value_len, ctxt);
        if (ret < 0) {
                mlog_errno(ret);
                return ret;
        }
-       ret = __ocfs2_xattr_set_value_outside(inode, xv, xi->value,
-                                             xi->value_len);
+       ret = ocfs2_xattr_update_entry(inode, ctxt->handle, xi, xs, offs);
        if (ret < 0) {
                mlog_errno(ret);
                return ret;
        }
-       ret = ocfs2_xattr_update_entry(inode, xi, xs, offs);
+       ret = __ocfs2_xattr_set_value_outside(inode, ctxt->handle, xv,
+                                             xi->value, xi->value_len);
        if (ret < 0)
                mlog_errno(ret);
 
@@ -1317,6 +1227,7 @@ static void ocfs2_xattr_set_entry_local(struct inode *inode,
 static int ocfs2_xattr_set_entry(struct inode *inode,
                                 struct ocfs2_xattr_info *xi,
                                 struct ocfs2_xattr_search *xs,
+                                struct ocfs2_xattr_set_ctxt *ctxt,
                                 int flag)
 {
        struct ocfs2_xattr_entry *last;
@@ -1324,7 +1235,7 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
        struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data;
        size_t min_offs = xs->end - xs->base, name_len = strlen(xi->name);
        size_t size_l = 0;
-       handle_t *handle = NULL;
+       handle_t *handle = ctxt->handle;
        int free, i, ret;
        struct ocfs2_xattr_info xi_l = {
                .name_index = xi->name_index,
@@ -1387,7 +1298,7 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
                if (ocfs2_xattr_is_local(xs->here) && size == size_l) {
                        /* Replace existing local xattr with tree root */
                        ret = ocfs2_xattr_set_value_outside(inode, xi, xs,
-                                                           offs);
+                                                           ctxt, offs);
                        if (ret < 0)
                                mlog_errno(ret);
                        goto out;
@@ -1406,25 +1317,28 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
                                ret = ocfs2_xattr_value_truncate(inode,
                                                                 xs->xattr_bh,
                                                                 xv,
-                                                                xi->value_len);
+                                                                xi->value_len,
+                                                                ctxt);
                                if (ret < 0) {
                                        mlog_errno(ret);
                                        goto out;
                                }
 
-                               ret = __ocfs2_xattr_set_value_outside(inode,
-                                                               xv,
-                                                               xi->value,
-                                                               xi->value_len);
+                               ret = ocfs2_xattr_update_entry(inode,
+                                                              handle,
+                                                              xi,
+                                                              xs,
+                                                              offs);
                                if (ret < 0) {
                                        mlog_errno(ret);
                                        goto out;
                                }
 
-                               ret = ocfs2_xattr_update_entry(inode,
-                                                              xi,
-                                                              xs,
-                                                              offs);
+                               ret = __ocfs2_xattr_set_value_outside(inode,
+                                                               handle,
+                                                               xv,
+                                                               xi->value,
+                                                               xi->value_len);
                                if (ret < 0)
                                        mlog_errno(ret);
                                goto out;
@@ -1434,44 +1348,29 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
                                 * just trucate old value to zero.
                                 */
                                 ret = ocfs2_xattr_value_truncate(inode,
-                                                                xs->xattr_bh,
-                                                                xv,
-                                                                0);
+                                                                 xs->xattr_bh,
+                                                                 xv,
+                                                                 0,
+                                                                 ctxt);
                                if (ret < 0)
                                        mlog_errno(ret);
                        }
                }
        }
 
-       handle = ocfs2_start_trans((OCFS2_SB(inode->i_sb)),
-                                  OCFS2_INODE_UPDATE_CREDITS);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               goto out;
-       }
-
        ret = ocfs2_journal_access(handle, inode, xs->inode_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        if (!(flag & OCFS2_INLINE_XATTR_FL)) {
-               /* set extended attribute in external block. */
-               ret = ocfs2_extend_trans(handle,
-                                        OCFS2_INODE_UPDATE_CREDITS +
-                                        OCFS2_XATTR_BLOCK_UPDATE_CREDITS);
-               if (ret) {
-                       mlog_errno(ret);
-                       goto out_commit;
-               }
                ret = ocfs2_journal_access(handle, inode, xs->xattr_bh,
                                           OCFS2_JOURNAL_ACCESS_WRITE);
                if (ret) {
                        mlog_errno(ret);
-                       goto out_commit;
+                       goto out;
                }
        }
 
@@ -1485,7 +1384,7 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
                ret = ocfs2_journal_dirty(handle, xs->xattr_bh);
                if (ret < 0) {
                        mlog_errno(ret);
-                       goto out_commit;
+                       goto out;
                }
        }
 
@@ -1522,16 +1421,13 @@ static int ocfs2_xattr_set_entry(struct inode *inode,
        if (ret < 0)
                mlog_errno(ret);
 
-out_commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
-
        if (!ret && xi->value_len > OCFS2_XATTR_INLINE_SIZE) {
                /*
                 * Set value outside in B tree.
                 * This is the second step for value size > INLINE_SIZE.
                 */
                size_t offs = le16_to_cpu(xs->here->xe_name_offset);
-               ret = ocfs2_xattr_set_value_outside(inode, xi, xs, offs);
+               ret = ocfs2_xattr_set_value_outside(inode, xi, xs, ctxt, offs);
                if (ret < 0) {
                        int ret2;
 
@@ -1540,14 +1436,14 @@ out_commit:
                         * If set value outside failed, we have to clean
                         * the junk tree root we have already set in local.
                         */
-                       ret2 = ocfs2_xattr_cleanup(inode, xi, xs, offs);
+                       ret2 = ocfs2_xattr_cleanup(inode, ctxt->handle,
+                                                  xi, xs, offs);
                        if (ret2 < 0)
                                mlog_errno(ret2);
                }
        }
 out:
        return ret;
-
 }
 
 static int ocfs2_remove_value_outside(struct inode*inode,
@@ -1555,6 +1451,17 @@ static int ocfs2_remove_value_outside(struct inode*inode,
                                      struct ocfs2_xattr_header *header)
 {
        int ret = 0, i;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
+       struct ocfs2_xattr_set_ctxt ctxt = { NULL, NULL, };
+
+       ocfs2_init_dealloc_ctxt(&ctxt.dealloc);
+
+       ctxt.handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS);
+       if (IS_ERR(ctxt.handle)) {
+               ret = PTR_ERR(ctxt.handle);
+               mlog_errno(ret);
+               goto out;
+       }
 
        for (i = 0; i < le16_to_cpu(header->xh_count); i++) {
                struct ocfs2_xattr_entry *entry = &header->xh_entries[i];
@@ -1567,14 +1474,19 @@ static int ocfs2_remove_value_outside(struct inode*inode,
                                le16_to_cpu(entry->xe_name_offset);
                        xv = (struct ocfs2_xattr_value_root *)
                                (val + OCFS2_XATTR_SIZE(entry->xe_name_len));
-                       ret = ocfs2_xattr_value_truncate(inode, bh, xv, 0);
+                       ret = ocfs2_xattr_value_truncate(inode, bh, xv,
+                                                        0, &ctxt);
                        if (ret < 0) {
                                mlog_errno(ret);
-                               return ret;
+                               break;
                        }
                }
        }
 
+       ocfs2_commit_trans(osb, ctxt.handle);
+       ocfs2_schedule_truncate_log_flush(osb, 1);
+       ocfs2_run_deallocs(osb, &ctxt.dealloc);
+out:
        return ret;
 }
 
@@ -1836,7 +1748,8 @@ static int ocfs2_xattr_ibody_find(struct inode *inode,
  */
 static int ocfs2_xattr_ibody_set(struct inode *inode,
                                 struct ocfs2_xattr_info *xi,
-                                struct ocfs2_xattr_search *xs)
+                                struct ocfs2_xattr_search *xs,
+                                struct ocfs2_xattr_set_ctxt *ctxt)
 {
        struct ocfs2_inode_info *oi = OCFS2_I(inode);
        struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data;
@@ -1853,7 +1766,7 @@ static int ocfs2_xattr_ibody_set(struct inode *inode,
                }
        }
 
-       ret = ocfs2_xattr_set_entry(inode, xi, xs,
+       ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt,
                                (OCFS2_INLINE_XATTR_FL | OCFS2_HAS_XATTR_FL));
 out:
        up_write(&oi->ip_alloc_sem);
@@ -1926,13 +1839,13 @@ cleanup:
  */
 static int ocfs2_xattr_block_set(struct inode *inode,
                                 struct ocfs2_xattr_info *xi,
-                                struct ocfs2_xattr_search *xs)
+                                struct ocfs2_xattr_search *xs,
+                                struct ocfs2_xattr_set_ctxt *ctxt)
 {
        struct buffer_head *new_bh = NULL;
        struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        struct ocfs2_dinode *di =  (struct ocfs2_dinode *)xs->inode_bh->b_data;
-       struct ocfs2_alloc_context *meta_ac = NULL;
-       handle_t *handle = NULL;
+       handle_t *handle = ctxt->handle;
        struct ocfs2_xattr_block *xblk = NULL;
        u16 suballoc_bit_start;
        u32 num_got;
@@ -1940,96 +1853,542 @@ static int ocfs2_xattr_block_set(struct inode *inode,
        int ret;
 
        if (!xs->xattr_bh) {
-               /*
-                * Alloc one external block for extended attribute
-                * outside of inode.
-                */
-               ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac);
+               ret = ocfs2_journal_access(handle, inode, xs->inode_bh,
+                                          OCFS2_JOURNAL_ACCESS_CREATE);
                if (ret < 0) {
                        mlog_errno(ret);
-                       goto out;
+                       goto end;
                }
-               handle = ocfs2_start_trans(osb,
-                                          OCFS2_XATTR_BLOCK_CREATE_CREDITS);
-               if (IS_ERR(handle)) {
-                       ret = PTR_ERR(handle);
+
+               ret = ocfs2_claim_metadata(osb, handle, ctxt->meta_ac, 1,
+                                          &suballoc_bit_start, &num_got,
+                                          &first_blkno);
+               if (ret < 0) {
                        mlog_errno(ret);
-                       goto out;
+                       goto end;
                }
-               ret = ocfs2_journal_access(handle, inode, xs->inode_bh,
+
+               new_bh = sb_getblk(inode->i_sb, first_blkno);
+               ocfs2_set_new_buffer_uptodate(inode, new_bh);
+
+               ret = ocfs2_journal_access(handle, inode, new_bh,
                                           OCFS2_JOURNAL_ACCESS_CREATE);
                if (ret < 0) {
                        mlog_errno(ret);
-                       goto out_commit;
+                       goto end;
                }
 
-               ret = ocfs2_claim_metadata(osb, handle, meta_ac, 1,
-                                          &suballoc_bit_start, &num_got,
-                                          &first_blkno);
-               if (ret < 0) {
-                       mlog_errno(ret);
-                       goto out_commit;
+               /* Initialize ocfs2_xattr_block */
+               xs->xattr_bh = new_bh;
+               xblk = (struct ocfs2_xattr_block *)new_bh->b_data;
+               memset(xblk, 0, inode->i_sb->s_blocksize);
+               strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE);
+               xblk->xb_suballoc_slot = cpu_to_le16(osb->slot_num);
+               xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start);
+               xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation);
+               xblk->xb_blkno = cpu_to_le64(first_blkno);
+
+               xs->header = &xblk->xb_attrs.xb_header;
+               xs->base = (void *)xs->header;
+               xs->end = (void *)xblk + inode->i_sb->s_blocksize;
+               xs->here = xs->header->xh_entries;
+
+               ret = ocfs2_journal_dirty(handle, new_bh);
+               if (ret < 0) {
+                       mlog_errno(ret);
+                       goto end;
+               }
+               di->i_xattr_loc = cpu_to_le64(first_blkno);
+               ocfs2_journal_dirty(handle, xs->inode_bh);
+       } else
+               xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data;
+
+       if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) {
+               /* Set extended attribute into external block */
+               ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt,
+                                           OCFS2_HAS_XATTR_FL);
+               if (!ret || ret != -ENOSPC)
+                       goto end;
+
+               ret = ocfs2_xattr_create_index_block(inode, xs, ctxt);
+               if (ret)
+                       goto end;
+       }
+
+       ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs, ctxt);
+
+end:
+
+       return ret;
+}
+
+/* Check whether the new xattr can be inserted into the inode. */
+static int ocfs2_xattr_can_be_in_inode(struct inode *inode,
+                                      struct ocfs2_xattr_info *xi,
+                                      struct ocfs2_xattr_search *xs)
+{
+       u64 value_size;
+       struct ocfs2_xattr_entry *last;
+       int free, i;
+       size_t min_offs = xs->end - xs->base;
+
+       if (!xs->header)
+               return 0;
+
+       last = xs->header->xh_entries;
+
+       for (i = 0; i < le16_to_cpu(xs->header->xh_count); i++) {
+               size_t offs = le16_to_cpu(last->xe_name_offset);
+               if (offs < min_offs)
+                       min_offs = offs;
+               last += 1;
+       }
+
+       free = min_offs - ((void *)last - xs->base) - sizeof(__u32);
+       if (free < 0)
+               return 0;
+
+       BUG_ON(!xs->not_found);
+
+       if (xi->value_len > OCFS2_XATTR_INLINE_SIZE)
+               value_size = OCFS2_XATTR_ROOT_SIZE;
+       else
+               value_size = OCFS2_XATTR_SIZE(xi->value_len);
+
+       if (free >= sizeof(struct ocfs2_xattr_entry) +
+                  OCFS2_XATTR_SIZE(strlen(xi->name)) + value_size)
+               return 1;
+
+       return 0;
+}
+
+static int ocfs2_calc_xattr_set_need(struct inode *inode,
+                                    struct ocfs2_dinode *di,
+                                    struct ocfs2_xattr_info *xi,
+                                    struct ocfs2_xattr_search *xis,
+                                    struct ocfs2_xattr_search *xbs,
+                                    int *clusters_need,
+                                    int *meta_need,
+                                    int *credits_need)
+{
+       int ret = 0, old_in_xb = 0;
+       int clusters_add = 0, meta_add = 0, credits = 0;
+       struct buffer_head *bh = NULL;
+       struct ocfs2_xattr_block *xb = NULL;
+       struct ocfs2_xattr_entry *xe = NULL;
+       struct ocfs2_xattr_value_root *xv = NULL;
+       char *base = NULL;
+       int name_offset, name_len = 0;
+       u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb,
+                                                   xi->value_len);
+       u64 value_size;
+
+       if (xis->not_found && xbs->not_found) {
+               credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb);
+
+               if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) {
+                       clusters_add += new_clusters;
+                       credits += ocfs2_calc_extend_credits(inode->i_sb,
+                                                       &def_xv.xv.xr_list,
+                                                       new_clusters);
+               }
+
+               goto meta_guess;
+       }
+
+       if (!xis->not_found) {
+               xe = xis->here;
+               name_offset = le16_to_cpu(xe->xe_name_offset);
+               name_len = OCFS2_XATTR_SIZE(xe->xe_name_len);
+               base = xis->base;
+               credits += OCFS2_INODE_UPDATE_CREDITS;
+       } else {
+               int i, block_off;
+               xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data;
+               xe = xbs->here;
+               name_offset = le16_to_cpu(xe->xe_name_offset);
+               name_len = OCFS2_XATTR_SIZE(xe->xe_name_len);
+               i = xbs->here - xbs->header->xh_entries;
+               old_in_xb = 1;
+
+               if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) {
+                       ret = ocfs2_xattr_bucket_get_name_value(inode,
+                                                       bucket_xh(xbs->bucket),
+                                                       i, &block_off,
+                                                       &name_offset);
+                       base = bucket_block(xbs->bucket, block_off);
+                       credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb);
+               } else {
+                       base = xbs->base;
+                       credits += OCFS2_XATTR_BLOCK_UPDATE_CREDITS;
+               }
+       }
+
+       /*
+        * delete a xattr doesn't need metadata and cluster allocation.
+        * so just calculate the credits and return.
+        *
+        * The credits for removing the value tree will be extended
+        * by ocfs2_remove_extent itself.
+        */
+       if (!xi->value) {
+               if (!ocfs2_xattr_is_local(xe))
+                       credits += OCFS2_REMOVE_EXTENT_CREDITS;
+
+               goto out;
+       }
+
+       /* do cluster allocation guess first. */
+       value_size = le64_to_cpu(xe->xe_value_size);
+
+       if (old_in_xb) {
+               /*
+                * In xattr set, we always try to set the xe in inode first,
+                * so if it can be inserted into inode successfully, the old
+                * one will be removed from the xattr block, and this xattr
+                * will be inserted into inode as a new xattr in inode.
+                */
+               if (ocfs2_xattr_can_be_in_inode(inode, xi, xis)) {
+                       clusters_add += new_clusters;
+                       credits += OCFS2_REMOVE_EXTENT_CREDITS +
+                                   OCFS2_INODE_UPDATE_CREDITS;
+                       if (!ocfs2_xattr_is_local(xe))
+                               credits += ocfs2_calc_extend_credits(
+                                                       inode->i_sb,
+                                                       &def_xv.xv.xr_list,
+                                                       new_clusters);
+                       goto out;
+               }
+       }
+
+       if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) {
+               /* the new values will be stored outside. */
+               u32 old_clusters = 0;
+
+               if (!ocfs2_xattr_is_local(xe)) {
+                       old_clusters =  ocfs2_clusters_for_bytes(inode->i_sb,
+                                                                value_size);
+                       xv = (struct ocfs2_xattr_value_root *)
+                            (base + name_offset + name_len);
+               } else
+                       xv = &def_xv.xv;
+
+               if (old_clusters >= new_clusters) {
+                       credits += OCFS2_REMOVE_EXTENT_CREDITS;
+                       goto out;
+               } else {
+                       meta_add += ocfs2_extend_meta_needed(&xv->xr_list);
+                       clusters_add += new_clusters - old_clusters;
+                       credits += ocfs2_calc_extend_credits(inode->i_sb,
+                                                            &xv->xr_list,
+                                                            new_clusters -
+                                                            old_clusters);
+                       goto out;
+               }
+       } else {
+               /*
+                * Now the new value will be stored inside. So if the new
+                * value is smaller than the size of value root or the old
+                * value, we don't need any allocation, otherwise we have
+                * to guess metadata allocation.
+                */
+               if ((ocfs2_xattr_is_local(xe) && value_size >= xi->value_len) ||
+                   (!ocfs2_xattr_is_local(xe) &&
+                    OCFS2_XATTR_ROOT_SIZE >= xi->value_len))
+                       goto out;
+       }
+
+meta_guess:
+       /* calculate metadata allocation. */
+       if (di->i_xattr_loc) {
+               if (!xbs->xattr_bh) {
+                       ret = ocfs2_read_block(inode,
+                                              le64_to_cpu(di->i_xattr_loc),
+                                              &bh);
+                       if (ret) {
+                               mlog_errno(ret);
+                               goto out;
+                       }
+
+                       xb = (struct ocfs2_xattr_block *)bh->b_data;
+               } else
+                       xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data;
+
+               if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) {
+                       struct ocfs2_extent_list *el =
+                                &xb->xb_attrs.xb_root.xt_list;
+                       meta_add += ocfs2_extend_meta_needed(el);
+                       credits += ocfs2_calc_extend_credits(inode->i_sb,
+                                                            el, 1);
+               }
+
+               /*
+                * This cluster will be used either for new bucket or for
+                * new xattr block.
+                * If the cluster size is the same as the bucket size, one
+                * more is needed since we may need to extend the bucket
+                * also.
+                */
+               clusters_add += 1;
+               credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb);
+               if (OCFS2_XATTR_BUCKET_SIZE ==
+                       OCFS2_SB(inode->i_sb)->s_clustersize) {
+                       credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb);
+                       clusters_add += 1;
+               }
+       } else {
+               meta_add += 1;
+               credits += OCFS2_XATTR_BLOCK_CREATE_CREDITS;
+       }
+out:
+       if (clusters_need)
+               *clusters_need = clusters_add;
+       if (meta_need)
+               *meta_need = meta_add;
+       if (credits_need)
+               *credits_need = credits;
+       brelse(bh);
+       return ret;
+}
+
+static int ocfs2_init_xattr_set_ctxt(struct inode *inode,
+                                    struct ocfs2_dinode *di,
+                                    struct ocfs2_xattr_info *xi,
+                                    struct ocfs2_xattr_search *xis,
+                                    struct ocfs2_xattr_search *xbs,
+                                    struct ocfs2_xattr_set_ctxt *ctxt,
+                                    int *credits)
+{
+       int clusters_add, meta_add, ret;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
+
+       memset(ctxt, 0, sizeof(struct ocfs2_xattr_set_ctxt));
+
+       ocfs2_init_dealloc_ctxt(&ctxt->dealloc);
+
+       ret = ocfs2_calc_xattr_set_need(inode, di, xi, xis, xbs,
+                                       &clusters_add, &meta_add, credits);
+       if (ret) {
+               mlog_errno(ret);
+               return ret;
+       }
+
+       mlog(0, "Set xattr %s, reserve meta blocks = %d, clusters = %d, "
+            "credits = %d\n", xi->name, meta_add, clusters_add, *credits);
+
+       if (meta_add) {
+               ret = ocfs2_reserve_new_metadata_blocks(osb, meta_add,
+                                                       &ctxt->meta_ac);
+               if (ret) {
+                       mlog_errno(ret);
+                       goto out;
+               }
+       }
+
+       if (clusters_add) {
+               ret = ocfs2_reserve_clusters(osb, clusters_add, &ctxt->data_ac);
+               if (ret)
+                       mlog_errno(ret);
+       }
+out:
+       if (ret) {
+               if (ctxt->meta_ac) {
+                       ocfs2_free_alloc_context(ctxt->meta_ac);
+                       ctxt->meta_ac = NULL;
+               }
+
+               /*
+                * We cannot have an error and a non null ctxt->data_ac.
+                */
+       }
+
+       return ret;
+}
+
+static int __ocfs2_xattr_set_handle(struct inode *inode,
+                                   struct ocfs2_dinode *di,
+                                   struct ocfs2_xattr_info *xi,
+                                   struct ocfs2_xattr_search *xis,
+                                   struct ocfs2_xattr_search *xbs,
+                                   struct ocfs2_xattr_set_ctxt *ctxt)
+{
+       int ret = 0, credits;
+
+       if (!xi->value) {
+               /* Remove existing extended attribute */
+               if (!xis->not_found)
+                       ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt);
+               else if (!xbs->not_found)
+                       ret = ocfs2_xattr_block_set(inode, xi, xbs, ctxt);
+       } else {
+               /* We always try to set extended attribute into inode first*/
+               ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt);
+               if (!ret && !xbs->not_found) {
+                       /*
+                        * If succeed and that extended attribute existing in
+                        * external block, then we will remove it.
+                        */
+                       xi->value = NULL;
+                       xi->value_len = 0;
+
+                       xis->not_found = -ENODATA;
+                       ret = ocfs2_calc_xattr_set_need(inode,
+                                                       di,
+                                                       xi,
+                                                       xis,
+                                                       xbs,
+                                                       NULL,
+                                                       NULL,
+                                                       &credits);
+                       if (ret) {
+                               mlog_errno(ret);
+                               goto out;
+                       }
+
+                       ret = ocfs2_extend_trans(ctxt->handle, credits +
+                                       ctxt->handle->h_buffer_credits);
+                       if (ret) {
+                               mlog_errno(ret);
+                               goto out;
+                       }
+                       ret = ocfs2_xattr_block_set(inode, xi, xbs, ctxt);
+               } else if (ret == -ENOSPC) {
+                       if (di->i_xattr_loc && !xbs->xattr_bh) {
+                               ret = ocfs2_xattr_block_find(inode,
+                                                            xi->name_index,
+                                                            xi->name, xbs);
+                               if (ret)
+                                       goto out;
+
+                               xis->not_found = -ENODATA;
+                               ret = ocfs2_calc_xattr_set_need(inode,
+                                                               di,
+                                                               xi,
+                                                               xis,
+                                                               xbs,
+                                                               NULL,
+                                                               NULL,
+                                                               &credits);
+                               if (ret) {
+                                       mlog_errno(ret);
+                                       goto out;
+                               }
+
+                               ret = ocfs2_extend_trans(ctxt->handle, credits +
+                                       ctxt->handle->h_buffer_credits);
+                               if (ret) {
+                                       mlog_errno(ret);
+                                       goto out;
+                               }
+                       }
+                       /*
+                        * If no space in inode, we will set extended attribute
+                        * into external block.
+                        */
+                       ret = ocfs2_xattr_block_set(inode, xi, xbs, ctxt);
+                       if (ret)
+                               goto out;
+                       if (!xis->not_found) {
+                               /*
+                                * If succeed and that extended attribute
+                                * existing in inode, we will remove it.
+                                */
+                               xi->value = NULL;
+                               xi->value_len = 0;
+                               xbs->not_found = -ENODATA;
+                               ret = ocfs2_calc_xattr_set_need(inode,
+                                                               di,
+                                                               xi,
+                                                               xis,
+                                                               xbs,
+                                                               NULL,
+                                                               NULL,
+                                                               &credits);
+                               if (ret) {
+                                       mlog_errno(ret);
+                                       goto out;
+                               }
+
+                               ret = ocfs2_extend_trans(ctxt->handle, credits +
+                                               ctxt->handle->h_buffer_credits);
+                               if (ret) {
+                                       mlog_errno(ret);
+                                       goto out;
+                               }
+                               ret = ocfs2_xattr_ibody_set(inode, xi,
+                                                           xis, ctxt);
+                       }
                }
+       }
 
-               new_bh = sb_getblk(inode->i_sb, first_blkno);
-               ocfs2_set_new_buffer_uptodate(inode, new_bh);
+out:
+       return ret;
+}
 
-               ret = ocfs2_journal_access(handle, inode, new_bh,
-                                          OCFS2_JOURNAL_ACCESS_CREATE);
-               if (ret < 0) {
-                       mlog_errno(ret);
-                       goto out_commit;
-               }
+/*
+ * This function only called duing creating inode
+ * for init security/acl xattrs of the new inode.
+ * The xattrs could be put into ibody or extent block,
+ * xattr bucket would not be use in this case.
+ * transanction credits also be reserved in here.
+ */
+int ocfs2_xattr_set_handle(handle_t *handle,
+                          struct inode *inode,
+                          struct buffer_head *di_bh,
+                          int name_index,
+                          const char *name,
+                          const void *value,
+                          size_t value_len,
+                          int flags,
+                          struct ocfs2_alloc_context *meta_ac,
+                          struct ocfs2_alloc_context *data_ac)
+{
+       struct ocfs2_dinode *di;
+       int ret;
 
-               /* Initialize ocfs2_xattr_block */
-               xs->xattr_bh = new_bh;
-               xblk = (struct ocfs2_xattr_block *)new_bh->b_data;
-               memset(xblk, 0, inode->i_sb->s_blocksize);
-               strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE);
-               xblk->xb_suballoc_slot = cpu_to_le16(osb->slot_num);
-               xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start);
-               xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation);
-               xblk->xb_blkno = cpu_to_le64(first_blkno);
+       struct ocfs2_xattr_info xi = {
+               .name_index = name_index,
+               .name = name,
+               .value = value,
+               .value_len = value_len,
+       };
 
-               xs->header = &xblk->xb_attrs.xb_header;
-               xs->base = (void *)xs->header;
-               xs->end = (void *)xblk + inode->i_sb->s_blocksize;
-               xs->here = xs->header->xh_entries;
+       struct ocfs2_xattr_search xis = {
+               .not_found = -ENODATA,
+       };
 
+       struct ocfs2_xattr_search xbs = {
+               .not_found = -ENODATA,
+       };
 
-               ret = ocfs2_journal_dirty(handle, new_bh);
-               if (ret < 0) {
-                       mlog_errno(ret);
-                       goto out_commit;
-               }
-               di->i_xattr_loc = cpu_to_le64(first_blkno);
-               ret = ocfs2_journal_dirty(handle, xs->inode_bh);
-               if (ret < 0)
-                       mlog_errno(ret);
-out_commit:
-               ocfs2_commit_trans(osb, handle);
-out:
-               if (meta_ac)
-                       ocfs2_free_alloc_context(meta_ac);
-               if (ret < 0)
-                       return ret;
-       } else
-               xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data;
+       struct ocfs2_xattr_set_ctxt ctxt = {
+               .handle = handle,
+               .meta_ac = meta_ac,
+               .data_ac = data_ac,
+       };
 
-       if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) {
-               /* Set extended attribute into external block */
-               ret = ocfs2_xattr_set_entry(inode, xi, xs, OCFS2_HAS_XATTR_FL);
-               if (!ret || ret != -ENOSPC)
-                       goto end;
+       if (!ocfs2_supports_xattr(OCFS2_SB(inode->i_sb)))
+               return -EOPNOTSUPP;
+
+       xis.inode_bh = xbs.inode_bh = di_bh;
+       di = (struct ocfs2_dinode *)di_bh->b_data;
 
-               ret = ocfs2_xattr_create_index_block(inode, xs);
+       down_write(&OCFS2_I(inode)->ip_xattr_sem);
+
+       ret = ocfs2_xattr_ibody_find(inode, name_index, name, &xis);
+       if (ret)
+               goto cleanup;
+       if (xis.not_found) {
+               ret = ocfs2_xattr_block_find(inode, name_index, name, &xbs);
                if (ret)
-                       goto end;
+                       goto cleanup;
        }
 
-       ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs);
+       ret = __ocfs2_xattr_set_handle(inode, di, &xi, &xis, &xbs, &ctxt);
 
-end:
+cleanup:
+       up_write(&OCFS2_I(inode)->ip_xattr_sem);
+       brelse(xbs.xattr_bh);
 
        return ret;
 }
@@ -2050,7 +2409,10 @@ int ocfs2_xattr_set(struct inode *inode,
 {
        struct buffer_head *di_bh = NULL;
        struct ocfs2_dinode *di;
-       int ret;
+       int ret, credits;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
+       struct inode *tl_inode = osb->osb_tl_inode;
+       struct ocfs2_xattr_set_ctxt ctxt = { NULL, NULL, };
 
        struct ocfs2_xattr_info xi = {
                .name_index = name_index,
@@ -2115,48 +2477,44 @@ int ocfs2_xattr_set(struct inode *inode,
                        goto cleanup;
        }
 
-       if (!value) {
-               /* Remove existing extended attribute */
-               if (!xis.not_found)
-                       ret = ocfs2_xattr_ibody_set(inode, &xi, &xis);
-               else if (!xbs.not_found)
-                       ret = ocfs2_xattr_block_set(inode, &xi, &xbs);
-       } else {
-               /* We always try to set extended attribute into inode first*/
-               ret = ocfs2_xattr_ibody_set(inode, &xi, &xis);
-               if (!ret && !xbs.not_found) {
-                       /*
-                        * If succeed and that extended attribute existing in
-                        * external block, then we will remove it.
-                        */
-                       xi.value = NULL;
-                       xi.value_len = 0;
-                       ret = ocfs2_xattr_block_set(inode, &xi, &xbs);
-               } else if (ret == -ENOSPC) {
-                       if (di->i_xattr_loc && !xbs.xattr_bh) {
-                               ret = ocfs2_xattr_block_find(inode, name_index,
-                                                            name, &xbs);
-                               if (ret)
-                                       goto cleanup;
-                       }
-                       /*
-                        * If no space in inode, we will set extended attribute
-                        * into external block.
-                        */
-                       ret = ocfs2_xattr_block_set(inode, &xi, &xbs);
-                       if (ret)
-                               goto cleanup;
-                       if (!xis.not_found) {
-                               /*
-                                * If succeed and that extended attribute
-                                * existing in inode, we will remove it.
-                                */
-                               xi.value = NULL;
-                               xi.value_len = 0;
-                               ret = ocfs2_xattr_ibody_set(inode, &xi, &xis);
-                       }
+
+       mutex_lock(&tl_inode->i_mutex);
+
+       if (ocfs2_truncate_log_needs_flush(osb)) {
+               ret = __ocfs2_flush_truncate_log(osb);
+               if (ret < 0) {
+                       mutex_unlock(&tl_inode->i_mutex);
+                       mlog_errno(ret);
+                       goto cleanup;
                }
        }
+       mutex_unlock(&tl_inode->i_mutex);
+
+       ret = ocfs2_init_xattr_set_ctxt(inode, di, &xi, &xis,
+                                       &xbs, &ctxt, &credits);
+       if (ret) {
+               mlog_errno(ret);
+               goto cleanup;
+       }
+
+       ctxt.handle = ocfs2_start_trans(osb, credits);
+       if (IS_ERR(ctxt.handle)) {
+               ret = PTR_ERR(ctxt.handle);
+               mlog_errno(ret);
+               goto cleanup;
+       }
+
+       ret = __ocfs2_xattr_set_handle(inode, di, &xi, &xis, &xbs, &ctxt);
+
+       ocfs2_commit_trans(osb, ctxt.handle);
+
+       if (ctxt.data_ac)
+               ocfs2_free_alloc_context(ctxt.data_ac);
+       if (ctxt.meta_ac)
+               ocfs2_free_alloc_context(ctxt.meta_ac);
+       if (ocfs2_dealloc_has_cluster(&ctxt.dealloc))
+               ocfs2_schedule_truncate_log_flush(osb, 1);
+       ocfs2_run_deallocs(osb, &ctxt.dealloc);
 cleanup:
        up_write(&OCFS2_I(inode)->ip_xattr_sem);
        ocfs2_inode_unlock(inode, 1);
@@ -2734,15 +3092,15 @@ static void ocfs2_xattr_update_xattr_search(struct inode *inode,
 }
 
 static int ocfs2_xattr_create_index_block(struct inode *inode,
-                                         struct ocfs2_xattr_search *xs)
+                                         struct ocfs2_xattr_search *xs,
+                                         struct ocfs2_xattr_set_ctxt *ctxt)
 {
-       int ret, credits = OCFS2_SUBALLOC_ALLOC;
+       int ret;
        u32 bit_off, len;
        u64 blkno;
-       handle_t *handle;
+       handle_t *handle = ctxt->handle;
        struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        struct ocfs2_inode_info *oi = OCFS2_I(inode);
-       struct ocfs2_alloc_context *data_ac;
        struct buffer_head *xb_bh = xs->xattr_bh;
        struct ocfs2_xattr_block *xb =
                        (struct ocfs2_xattr_block *)xb_bh->b_data;
@@ -2755,12 +3113,6 @@ static int ocfs2_xattr_create_index_block(struct inode *inode,
        BUG_ON(xb_flags & OCFS2_XATTR_INDEXED);
        BUG_ON(!xs->bucket);
 
-       ret = ocfs2_reserve_clusters(osb, 1, &data_ac);
-       if (ret) {
-               mlog_errno(ret);
-               goto out;
-       }
-
        /*
         * XXX:
         * We can use this lock for now, and maybe move to a dedicated mutex
@@ -2768,29 +3120,18 @@ static int ocfs2_xattr_create_index_block(struct inode *inode,
         */
        down_write(&oi->ip_alloc_sem);
 
-       /*
-        * We need more credits.  One for the xattr block update and one
-        * for each block of the new xattr bucket.
-        */
-       credits += 1 + ocfs2_blocks_per_xattr_bucket(inode->i_sb);
-       handle = ocfs2_start_trans(osb, credits);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               goto out_sem;
-       }
-
        ret = ocfs2_journal_access(handle, inode, xb_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
-       ret = ocfs2_claim_clusters(osb, handle, data_ac, 1, &bit_off, &len);
+       ret = __ocfs2_claim_clusters(osb, handle, ctxt->data_ac,
+                                    1, 1, &bit_off, &len);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        /*
@@ -2806,14 +3147,14 @@ static int ocfs2_xattr_create_index_block(struct inode *inode,
        ret = ocfs2_init_xattr_bucket(xs->bucket, blkno);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket,
                                                OCFS2_JOURNAL_ACCESS_CREATE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        ocfs2_cp_xattr_block_to_bucket(inode, xb_bh, xs->bucket);
@@ -2838,21 +3179,10 @@ static int ocfs2_xattr_create_index_block(struct inode *inode,
 
        xb->xb_flags = cpu_to_le16(xb_flags | OCFS2_XATTR_INDEXED);
 
-       ret = ocfs2_journal_dirty(handle, xb_bh);
-       if (ret) {
-               mlog_errno(ret);
-               goto out_commit;
-       }
-
-out_commit:
-       ocfs2_commit_trans(osb, handle);
-
-out_sem:
-       up_write(&oi->ip_alloc_sem);
+       ocfs2_journal_dirty(handle, xb_bh);
 
 out:
-       if (data_ac)
-               ocfs2_free_alloc_context(data_ac);
+       up_write(&oi->ip_alloc_sem);
 
        return ret;
 }
@@ -2877,6 +3207,7 @@ static int cmp_xe_offset(const void *a, const void *b)
  * so that we can spare some space for insertion.
  */
 static int ocfs2_defrag_xattr_bucket(struct inode *inode,
+                                    handle_t *handle,
                                     struct ocfs2_xattr_bucket *bucket)
 {
        int ret, i;
@@ -2886,7 +3217,6 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode,
        u64 blkno = bucket_blkno(bucket);
        u16 xh_free_start;
        size_t blocksize = inode->i_sb->s_blocksize;
-       handle_t *handle;
        struct ocfs2_xattr_entry *xe;
 
        /*
@@ -2905,19 +3235,11 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode,
        for (i = 0; i < bucket->bu_blocks; i++, buf += blocksize)
                memcpy(buf, bucket_block(bucket, i), blocksize);
 
-       handle = ocfs2_start_trans((OCFS2_SB(inode->i_sb)), bucket->bu_blocks);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               handle = NULL;
-               mlog_errno(ret);
-               goto out;
-       }
-
        ret = ocfs2_xattr_bucket_journal_access(handle, bucket,
                                                OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret < 0) {
                mlog_errno(ret);
-               goto commit;
+               goto out;
        }
 
        xh = (struct ocfs2_xattr_header *)bucket_buf;
@@ -2975,7 +3297,7 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode,
                        "bucket %llu\n", (unsigned long long)blkno);
 
        if (xh_free_start == end)
-               goto commit;
+               goto out;
 
        memset(bucket_buf + xh_free_start, 0, end - xh_free_start);
        xh->xh_free_start = cpu_to_le16(end);
@@ -2990,8 +3312,6 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode,
                memcpy(bucket_block(bucket, i), buf, blocksize);
        ocfs2_xattr_bucket_journal_dirty(handle, bucket);
 
-commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
 out:
        kfree(bucket_buf);
        return ret;
@@ -3042,7 +3362,7 @@ static int ocfs2_mv_xattr_bucket_cross_cluster(struct inode *inode,
         * 1 more for the update of the 1st bucket of the previous
         * extent record.
         */
-       credits = bpc / 2 + 1;
+       credits = bpc / 2 + 1 + handle->h_buffer_credits;
        ret = ocfs2_extend_trans(handle, credits);
        if (ret) {
                mlog_errno(ret);
@@ -3434,7 +3754,7 @@ static int ocfs2_cp_xattr_cluster(struct inode *inode,
         * We need to update the new cluster and 1 more for the update of
         * the 1st bucket of the previous extent rec.
         */
-       credits = bpc + 1;
+       credits = bpc + 1 + handle->h_buffer_credits;
        ret = ocfs2_extend_trans(handle, credits);
        if (ret) {
                mlog_errno(ret);
@@ -3504,7 +3824,7 @@ static int ocfs2_divide_xattr_cluster(struct inode *inode,
                                      u32 *first_hash)
 {
        u16 blk_per_bucket = ocfs2_blocks_per_xattr_bucket(inode->i_sb);
-       int ret, credits = 2 * blk_per_bucket;
+       int ret, credits = 2 * blk_per_bucket + handle->h_buffer_credits;
 
        BUG_ON(OCFS2_XATTR_BUCKET_SIZE < OCFS2_SB(inode->i_sb)->s_clustersize);
 
@@ -3614,16 +3934,15 @@ static int ocfs2_add_new_xattr_cluster(struct inode *inode,
                                       u32 *num_clusters,
                                       u32 prev_cpos,
                                       u64 prev_blkno,
-                                      int *extend)
+                                      int *extend,
+                                      struct ocfs2_xattr_set_ctxt *ctxt)
 {
-       int ret, credits;
+       int ret;
        u16 bpc = ocfs2_clusters_to_blocks(inode->i_sb, 1);
        u32 prev_clusters = *num_clusters;
        u32 clusters_to_add = 1, bit_off, num_bits, v_start = 0;
        u64 block;
-       handle_t *handle = NULL;
-       struct ocfs2_alloc_context *data_ac = NULL;
-       struct ocfs2_alloc_context *meta_ac = NULL;
+       handle_t *handle = ctxt->handle;
        struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        struct ocfs2_extent_tree et;
 
@@ -3634,23 +3953,6 @@ static int ocfs2_add_new_xattr_cluster(struct inode *inode,
 
        ocfs2_init_xattr_tree_extent_tree(&et, inode, root_bh);
 
-       ret = ocfs2_lock_allocators(inode, &et, clusters_to_add, 0,
-                                   &data_ac, &meta_ac);
-       if (ret) {
-               mlog_errno(ret);
-               goto leave;
-       }
-
-       credits = ocfs2_calc_extend_credits(osb->sb, et.et_root_el,
-                                           clusters_to_add);
-       handle = ocfs2_start_trans(osb, credits);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               handle = NULL;
-               mlog_errno(ret);
-               goto leave;
-       }
-
        ret = ocfs2_journal_access(handle, inode, root_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret < 0) {
@@ -3658,7 +3960,7 @@ static int ocfs2_add_new_xattr_cluster(struct inode *inode,
                goto leave;
        }
 
-       ret = __ocfs2_claim_clusters(osb, handle, data_ac, 1,
+       ret = __ocfs2_claim_clusters(osb, handle, ctxt->data_ac, 1,
                                     clusters_to_add, &bit_off, &num_bits);
        if (ret < 0) {
                if (ret != -ENOSPC)
@@ -3704,41 +4006,20 @@ static int ocfs2_add_new_xattr_cluster(struct inode *inode,
                }
        }
 
-       if (handle->h_buffer_credits < credits) {
-               /*
-                * The journal has been restarted before, and don't
-                * have enough space for the insertion, so extend it
-                * here.
-                */
-               ret = ocfs2_extend_trans(handle, credits);
-               if (ret) {
-                       mlog_errno(ret);
-                       goto leave;
-               }
-       }
        mlog(0, "Insert %u clusters at block %llu for xattr at %u\n",
             num_bits, (unsigned long long)block, v_start);
        ret = ocfs2_insert_extent(osb, handle, inode, &et, v_start, block,
-                                 num_bits, 0, meta_ac);
+                                 num_bits, 0, ctxt->meta_ac);
        if (ret < 0) {
                mlog_errno(ret);
                goto leave;
        }
 
        ret = ocfs2_journal_dirty(handle, root_bh);
-       if (ret < 0) {
+       if (ret < 0)
                mlog_errno(ret);
-               goto leave;
-       }
 
 leave:
-       if (handle)
-               ocfs2_commit_trans(osb, handle);
-       if (data_ac)
-               ocfs2_free_alloc_context(data_ac);
-       if (meta_ac)
-               ocfs2_free_alloc_context(meta_ac);
-
        return ret;
 }
 
@@ -3747,6 +4028,7 @@ leave:
  * We meet with start_bh. Only move half of the xattrs to the bucket after it.
  */
 static int ocfs2_extend_xattr_bucket(struct inode *inode,
+                                    handle_t *handle,
                                     struct buffer_head *first_bh,
                                     struct buffer_head *start_bh,
                                     u32 num_clusters)
@@ -3756,7 +4038,6 @@ static int ocfs2_extend_xattr_bucket(struct inode *inode,
        u16 blk_per_bucket = ocfs2_blocks_per_xattr_bucket(inode->i_sb);
        u64 start_blk = start_bh->b_blocknr, end_blk;
        u32 num_buckets = num_clusters * ocfs2_xattr_buckets_per_cluster(osb);
-       handle_t *handle;
        struct ocfs2_xattr_header *first_xh =
                                (struct ocfs2_xattr_header *)first_bh->b_data;
        u16 bucket = le16_to_cpu(first_xh->xh_num_buckets);
@@ -3773,11 +4054,10 @@ static int ocfs2_extend_xattr_bucket(struct inode *inode,
         * We will touch all the buckets after the start_bh(include it).
         * Then we add one more bucket.
         */
-       credits = end_blk - start_blk + 3 * blk_per_bucket + 1;
-       handle = ocfs2_start_trans(osb, credits);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               handle = NULL;
+       credits = end_blk - start_blk + 3 * blk_per_bucket + 1 +
+                 handle->h_buffer_credits;
+       ret = ocfs2_extend_trans(handle, credits);
+       if (ret) {
                mlog_errno(ret);
                goto out;
        }
@@ -3786,14 +4066,14 @@ static int ocfs2_extend_xattr_bucket(struct inode *inode,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto commit;
+               goto out;
        }
 
        while (end_blk != start_blk) {
                ret = ocfs2_cp_xattr_bucket(inode, handle, end_blk,
                                            end_blk + blk_per_bucket, 0);
                if (ret)
-                       goto commit;
+                       goto out;
                end_blk -= blk_per_bucket;
        }
 
@@ -3804,8 +4084,6 @@ static int ocfs2_extend_xattr_bucket(struct inode *inode,
        le16_add_cpu(&first_xh->xh_num_buckets, 1);
        ocfs2_journal_dirty(handle, first_bh);
 
-commit:
-       ocfs2_commit_trans(osb, handle);
 out:
        return ret;
 }
@@ -3821,7 +4099,8 @@ out:
  */
 static int ocfs2_add_new_xattr_bucket(struct inode *inode,
                                      struct buffer_head *xb_bh,
-                                     struct buffer_head *header_bh)
+                                     struct buffer_head *header_bh,
+                                     struct ocfs2_xattr_set_ctxt *ctxt)
 {
        struct ocfs2_xattr_header *first_xh = NULL;
        struct buffer_head *first_bh = NULL;
@@ -3872,7 +4151,8 @@ static int ocfs2_add_new_xattr_bucket(struct inode *inode,
                                                  &num_clusters,
                                                  e_cpos,
                                                  p_blkno,
-                                                 &extend);
+                                                 &extend,
+                                                 ctxt);
                if (ret) {
                        mlog_errno(ret);
                        goto out;
@@ -3881,6 +4161,7 @@ static int ocfs2_add_new_xattr_bucket(struct inode *inode,
 
        if (extend)
                ret = ocfs2_extend_xattr_bucket(inode,
+                                               ctxt->handle,
                                                first_bh,
                                                header_bh,
                                                num_clusters);
@@ -4054,14 +4335,13 @@ set_new_name_value:
  * space for the xattr insertion.
  */
 static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode,
+                                          handle_t *handle,
                                           struct ocfs2_xattr_info *xi,
                                           struct ocfs2_xattr_search *xs,
                                           u32 name_hash,
                                           int local)
 {
        int ret;
-       handle_t *handle = NULL;
-       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
        u64 blkno;
 
        mlog(0, "Set xattr entry len = %lu index = %d in bucket %llu\n",
@@ -4078,14 +4358,6 @@ static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode,
                }
        }
 
-       handle = ocfs2_start_trans(osb, xs->bucket->bu_blocks);
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               handle = NULL;
-               mlog_errno(ret);
-               goto out;
-       }
-
        ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket,
                                                OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret < 0) {
@@ -4097,32 +4369,22 @@ static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode,
        ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket);
 
 out:
-       ocfs2_commit_trans(osb, handle);
-
        return ret;
 }
 
 static int ocfs2_xattr_value_update_size(struct inode *inode,
+                                        handle_t *handle,
                                         struct buffer_head *xe_bh,
                                         struct ocfs2_xattr_entry *xe,
                                         u64 new_size)
 {
        int ret;
-       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
-       handle_t *handle = NULL;
-
-       handle = ocfs2_start_trans(osb, 1);
-       if (IS_ERR(handle)) {
-               ret = -ENOMEM;
-               mlog_errno(ret);
-               goto out;
-       }
 
        ret = ocfs2_journal_access(handle, inode, xe_bh,
                                   OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret < 0) {
                mlog_errno(ret);
-               goto out_commit;
+               goto out;
        }
 
        xe->xe_value_size = cpu_to_le64(new_size);
@@ -4131,8 +4393,6 @@ static int ocfs2_xattr_value_update_size(struct inode *inode,
        if (ret < 0)
                mlog_errno(ret);
 
-out_commit:
-       ocfs2_commit_trans(osb, handle);
 out:
        return ret;
 }
@@ -4147,7 +4407,8 @@ out:
 static int ocfs2_xattr_bucket_value_truncate(struct inode *inode,
                                             struct buffer_head *header_bh,
                                             int xe_off,
-                                            int len)
+                                            int len,
+                                            struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret, offset;
        u64 value_blk;
@@ -4182,13 +4443,14 @@ static int ocfs2_xattr_bucket_value_truncate(struct inode *inode,
 
        mlog(0, "truncate %u in xattr bucket %llu to %d bytes.\n",
             xe_off, (unsigned long long)header_bh->b_blocknr, len);
-       ret = ocfs2_xattr_value_truncate(inode, value_bh, xv, len);
+       ret = ocfs2_xattr_value_truncate(inode, value_bh, xv, len, ctxt);
        if (ret) {
                mlog_errno(ret);
                goto out;
        }
 
-       ret = ocfs2_xattr_value_update_size(inode, header_bh, xe, len);
+       ret = ocfs2_xattr_value_update_size(inode, ctxt->handle,
+                                           header_bh, xe, len);
        if (ret) {
                mlog_errno(ret);
                goto out;
@@ -4200,8 +4462,9 @@ out:
 }
 
 static int ocfs2_xattr_bucket_value_truncate_xs(struct inode *inode,
-                                               struct ocfs2_xattr_search *xs,
-                                               int len)
+                                       struct ocfs2_xattr_search *xs,
+                                       int len,
+                                       struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret, offset;
        struct ocfs2_xattr_entry *xe = xs->here;
@@ -4211,7 +4474,7 @@ static int ocfs2_xattr_bucket_value_truncate_xs(struct inode *inode,
 
        offset = xe - xh->xh_entries;
        ret = ocfs2_xattr_bucket_value_truncate(inode, xs->bucket->bu_bhs[0],
-                                               offset, len);
+                                               offset, len, ctxt);
        if (ret)
                mlog_errno(ret);
 
@@ -4219,6 +4482,7 @@ static int ocfs2_xattr_bucket_value_truncate_xs(struct inode *inode,
 }
 
 static int ocfs2_xattr_bucket_set_value_outside(struct inode *inode,
+                                               handle_t *handle,
                                                struct ocfs2_xattr_search *xs,
                                                char *val,
                                                int value_len)
@@ -4234,7 +4498,8 @@ static int ocfs2_xattr_bucket_set_value_outside(struct inode *inode,
 
        xv = (struct ocfs2_xattr_value_root *)(xs->base + offset);
 
-       return __ocfs2_xattr_set_value_outside(inode, xv, val, value_len);
+       return __ocfs2_xattr_set_value_outside(inode, handle,
+                                              xv, val, value_len);
 }
 
 static int ocfs2_rm_xattr_cluster(struct inode *inode,
@@ -4327,27 +4592,19 @@ out:
 }
 
 static void ocfs2_xattr_bucket_remove_xs(struct inode *inode,
+                                        handle_t *handle,
                                         struct ocfs2_xattr_search *xs)
 {
-       handle_t *handle = NULL;
        struct ocfs2_xattr_header *xh = bucket_xh(xs->bucket);
        struct ocfs2_xattr_entry *last = &xh->xh_entries[
                                                le16_to_cpu(xh->xh_count) - 1];
        int ret = 0;
 
-       handle = ocfs2_start_trans((OCFS2_SB(inode->i_sb)),
-                                  ocfs2_blocks_per_xattr_bucket(inode->i_sb));
-       if (IS_ERR(handle)) {
-               ret = PTR_ERR(handle);
-               mlog_errno(ret);
-               return;
-       }
-
        ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket,
                                                OCFS2_JOURNAL_ACCESS_WRITE);
        if (ret) {
                mlog_errno(ret);
-               goto out_commit;
+               return;
        }
 
        /* Remove the old entry. */
@@ -4357,9 +4614,6 @@ static void ocfs2_xattr_bucket_remove_xs(struct inode *inode,
        le16_add_cpu(&xh->xh_count, -1);
 
        ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket);
-
-out_commit:
-       ocfs2_commit_trans(OCFS2_SB(inode->i_sb), handle);
 }
 
 /*
@@ -4375,7 +4629,8 @@ out_commit:
  */
 static int ocfs2_xattr_set_in_bucket(struct inode *inode,
                                     struct ocfs2_xattr_info *xi,
-                                    struct ocfs2_xattr_search *xs)
+                                    struct ocfs2_xattr_search *xs,
+                                    struct ocfs2_xattr_set_ctxt *ctxt)
 {
        int ret, local = 1;
        size_t value_len;
@@ -4403,7 +4658,8 @@ static int ocfs2_xattr_set_in_bucket(struct inode *inode,
                        value_len = 0;
 
                ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs,
-                                                          value_len);
+                                                          value_len,
+                                                          ctxt);
                if (ret)
                        goto out;
 
@@ -4423,7 +4679,8 @@ static int ocfs2_xattr_set_in_bucket(struct inode *inode,
                xi->value_len = OCFS2_XATTR_ROOT_SIZE;
        }
 
-       ret = ocfs2_xattr_set_entry_in_bucket(inode, xi, xs, name_hash, local);
+       ret = ocfs2_xattr_set_entry_in_bucket(inode, ctxt->handle, xi, xs,
+                                             name_hash, local);
        if (ret) {
                mlog_errno(ret);
                goto out;
@@ -4434,7 +4691,7 @@ static int ocfs2_xattr_set_in_bucket(struct inode *inode,
 
        /* allocate the space now for the outside block storage. */
        ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs,
-                                                  value_len);
+                                                  value_len, ctxt);
        if (ret) {
                mlog_errno(ret);
 
@@ -4444,13 +4701,14 @@ static int ocfs2_xattr_set_in_bucket(struct inode *inode,
                         * storage and we have allocated xattr already,
                         * so need to remove it.
                         */
-                       ocfs2_xattr_bucket_remove_xs(inode, xs);
+                       ocfs2_xattr_bucket_remove_xs(inode, ctxt->handle, xs);
                }
                goto out;
        }
 
 set_value_outside:
-       ret = ocfs2_xattr_bucket_set_value_outside(inode, xs, val, value_len);
+       ret = ocfs2_xattr_bucket_set_value_outside(inode, ctxt->handle,
+                                                  xs, val, value_len);
 out:
        return ret;
 }
@@ -4485,7 +4743,8 @@ static int ocfs2_check_xattr_bucket_collision(struct inode *inode,
 
 static int ocfs2_xattr_set_entry_index_block(struct inode *inode,
                                             struct ocfs2_xattr_info *xi,
-                                            struct ocfs2_xattr_search *xs)
+                                            struct ocfs2_xattr_search *xs,
+                                            struct ocfs2_xattr_set_ctxt *ctxt)
 {
        struct ocfs2_xattr_header *xh;
        struct ocfs2_xattr_entry *xe;
@@ -4562,7 +4821,8 @@ try_again:
                         * name/value will be moved, the xe shouldn't be changed
                         * in xs.
                         */
-                       ret = ocfs2_defrag_xattr_bucket(inode, xs->bucket);
+                       ret = ocfs2_defrag_xattr_bucket(inode, ctxt->handle,
+                                                       xs->bucket);
                        if (ret) {
                                mlog_errno(ret);
                                goto out;
@@ -4603,7 +4863,8 @@ try_again:
 
                ret = ocfs2_add_new_xattr_bucket(inode,
                                                 xs->xattr_bh,
-                                                xs->bucket->bu_bhs[0]);
+                                                xs->bucket->bu_bhs[0],
+                                                ctxt);
                if (ret) {
                        mlog_errno(ret);
                        goto out;
@@ -4622,7 +4883,7 @@ try_again:
        }
 
 xattr_set:
-       ret = ocfs2_xattr_set_in_bucket(inode, xi, xs);
+       ret = ocfs2_xattr_set_in_bucket(inode, xi, xs, ctxt);
 out:
        mlog_exit(ret);
        return ret;
@@ -4636,6 +4897,17 @@ static int ocfs2_delete_xattr_in_bucket(struct inode *inode,
        struct ocfs2_xattr_header *xh = bucket_xh(bucket);
        u16 i;
        struct ocfs2_xattr_entry *xe;
+       struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
+       struct ocfs2_xattr_set_ctxt ctxt = {NULL, NULL,};
+
+       ocfs2_init_dealloc_ctxt(&ctxt.dealloc);
+
+       ctxt.handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS);
+       if (IS_ERR(ctxt.handle)) {
+               ret = PTR_ERR(ctxt.handle);
+               mlog_errno(ret);
+               goto out;
+       }
 
        for (i = 0; i < le16_to_cpu(xh->xh_count); i++) {
                xe = &xh->xh_entries[i];
@@ -4644,13 +4916,17 @@ static int ocfs2_delete_xattr_in_bucket(struct inode *inode,
 
                ret = ocfs2_xattr_bucket_value_truncate(inode,
                                                        bucket->bu_bhs[0],
-                                                       i, 0);
+                                                       i, 0, &ctxt);
                if (ret) {
                        mlog_errno(ret);
                        break;
                }
        }
 
+       ret = ocfs2_commit_trans(osb, ctxt.handle);
+       ocfs2_schedule_truncate_log_flush(osb, 1);
+       ocfs2_run_deallocs(osb, &ctxt.dealloc);
+out:
        return ret;
 }