Merge branch 'timers/for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git...
[cascardo/linux.git] / sound / soc / codecs / wm8731.c
index 9956d65..369d39c 100644 (file)
@@ -19,7 +19,6 @@
 #include <linux/pm.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
-#include <sound/driver.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include "wm8731.h"
 
 #define AUDIO_NAME "wm8731"
-#define WM8731_VERSION "0.12"
-
-/*
- * Debug
- */
-
-#define WM8731_DEBUG 0
-
-#ifdef WM8731_DEBUG
-#define dbg(format, arg...) \
-       printk(KERN_DEBUG AUDIO_NAME ": " format "\n" , ## arg)
-#else
-#define dbg(format, arg...) do {} while (0)
-#endif
-#define err(format, arg...) \
-       printk(KERN_ERR AUDIO_NAME ": " format "\n" , ## arg)
-#define info(format, arg...) \
-       printk(KERN_INFO AUDIO_NAME ": " format "\n" , ## arg)
-#define warn(format, arg...) \
-       printk(KERN_WARNING AUDIO_NAME ": " format "\n" , ## arg)
+#define WM8731_VERSION "0.13"
 
 struct snd_soc_codec_device soc_codec_dev_wm8731;
 
+/* codec private data */
+struct wm8731_priv {
+       unsigned int sysclk;
+};
+
 /*
  * wm8731 register cache
  * We can't read the WM8731 register space when we are
@@ -65,191 +50,6 @@ static const u16 wm8731_reg[WM8731_CACHEREGNUM] = {
     0x0000, 0x0000
 };
 
-#define WM8731_DAIFMT \
-       (SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_RIGHT_J | \
-       SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_NB_IF | SND_SOC_DAIFMT_IB_NF | \
-       SND_SOC_DAIFMT_IB_IF)
-
-#define WM8731_DIR \
-       (SND_SOC_DAIDIR_PLAYBACK | SND_SOC_DAIDIR_CAPTURE)
-
-#define WM8731_RATES \
-       (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 | SNDRV_PCM_RATE_16000 | \
-       SNDRV_PCM_RATE_22050 | SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | \
-       SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000)
-
-#define WM8731_HIFI_BITS \
-       (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
-       SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
-
-static struct snd_soc_dai_mode wm8731_modes[] = {
-       /* codec frame and clock master modes */
-       /* 8k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 1536,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 2304,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 1408,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 2112,
-               .bfs = 64,
-       },
-
-       /* 32k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_32000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 384,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_32000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 576,
-               .bfs = 64,
-       },
-
-       /* 44.1k & 48k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 256,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 384,
-               .bfs = 64,
-       },
-
-       /* 88.2 & 96k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 128,
-               .bfs = 64,
-       },
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_RATE,
-               .fs = 192,
-               .bfs = 64,
-       },
-
-       /* USB codec frame and clock master modes */
-       /* 8k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_8000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 1500,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 44.1k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_44100,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 272,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 48k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_48000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 250,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 88.2k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_88200,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 136,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* 96k */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBM_CFM,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = SNDRV_PCM_RATE_96000,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = 125,
-               .bfs = SND_SOC_FSBD(1),
-       },
-
-       /* codec frame and clock slave modes */
-       {
-               .fmt = WM8731_DAIFMT | SND_SOC_DAIFMT_CBS_CFS,
-               .pcmfmt = WM8731_HIFI_BITS,
-               .pcmrate = WM8731_RATES,
-               .pcmdir = WM8731_DIR,
-               .flags = SND_SOC_DAI_BFS_DIV,
-               .fs = SND_SOC_FS_ALL,
-               .bfs = SND_SOC_FSB_ALL,
-       },
-};
-
 /*
  * read wm8731 register cache
  */
@@ -291,7 +91,7 @@ static int wm8731_write(struct snd_soc_codec *codec, unsigned int reg,
        data[0] = (reg << 1) | ((value >> 8) & 0x0001);
        data[1] = value & 0x00ff;
 
-       wm8731_write_reg_cache (codec, reg, value);
+       wm8731_write_reg_cache(codec, reg, value);
        if (codec->hw_write(codec->control_data, data, 2) == 2)
                return 0;
        else
@@ -335,8 +135,10 @@ static int wm8731_add_controls(struct snd_soc_codec *codec)
        int err, i;
 
        for (i = 0; i < ARRAY_SIZE(wm8731_snd_controls); i++) {
-               if ((err = snd_ctl_add(codec->card,
-                               snd_soc_cnew(&wm8731_snd_controls[i],codec, NULL))) < 0)
+               err = snd_ctl_add(codec->card,
+                                 snd_soc_cnew(&wm8731_snd_controls[i],
+                                               codec, NULL));
+               if (err < 0)
                        return err;
        }
 
@@ -372,7 +174,7 @@ SND_SOC_DAPM_INPUT("RLINEIN"),
 SND_SOC_DAPM_INPUT("LLINEIN"),
 };
 
-static const char *intercon[][3] = {
+static const struct snd_soc_dapm_route intercon[] = {
        /* output mixer */
        {"Output Mixer", "Line Bypass Switch", "Line Input"},
        {"Output Mixer", "HiFi Playback Switch", "DAC"},
@@ -393,24 +195,14 @@ static const char *intercon[][3] = {
        {"Line Input", NULL, "LLINEIN"},
        {"Line Input", NULL, "RLINEIN"},
        {"Mic Bias", NULL, "MICIN"},
-
-       /* terminator */
-       {NULL, NULL, NULL},
 };
 
 static int wm8731_add_widgets(struct snd_soc_codec *codec)
 {
-       int i;
+       snd_soc_dapm_new_controls(codec, wm8731_dapm_widgets,
+                                 ARRAY_SIZE(wm8731_dapm_widgets));
 
-       for(i = 0; i < ARRAY_SIZE(wm8731_dapm_widgets); i++) {
-               snd_soc_dapm_new_control(codec, &wm8731_dapm_widgets[i]);
-       }
-
-       /* set up audio path interconnects */
-       for(i = 0; intercon[i][0] != NULL; i++) {
-               snd_soc_dapm_connect_input(codec, intercon[i][0],
-                       intercon[i][1], intercon[i][2]);
-       }
+       snd_soc_dapm_add_routes(codec, intercon, ARRAY_SIZE(intercon));
 
        snd_soc_dapm_new_widgets(codec);
        return 0;
@@ -435,6 +227,7 @@ static const struct _coeff_div coeff_div[] = {
        /* 32k */
        {12288000, 32000, 384, 0x6, 0x0, 0x0},
        {18432000, 32000, 576, 0x6, 0x1, 0x0},
+       {12000000, 32000, 375, 0x6, 0x0, 0x1},
 
        /* 8k */
        {12288000, 8000, 1536, 0x3, 0x0, 0x0},
@@ -470,18 +263,34 @@ static inline int get_coeff(int mclk, int rate)
        return 0;
 }
 
-/* WM8731 supports numerous clocks per sample rate */
-static unsigned int wm8731_config_sysclk(struct snd_soc_codec_dai *dai,
-       struct snd_soc_clock_info *info, unsigned int clk)
+static int wm8731_hw_params(struct snd_pcm_substream *substream,
+       struct snd_pcm_hw_params *params)
 {
-       dai->mclk = 0;
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->codec;
+       struct wm8731_priv *wm8731 = codec->private_data;
+       u16 iface = wm8731_read_reg_cache(codec, WM8731_IFACE) & 0xfff3;
+       int i = get_coeff(wm8731->sysclk, params_rate(params));
+       u16 srate = (coeff_div[i].sr << 2) |
+               (coeff_div[i].bosr << 1) | coeff_div[i].usb;
+
+       wm8731_write(codec, WM8731_SRATE, srate);
 
-       /* check that the calculated FS and rate actually match a clock from
-        * the machine driver */
-       if (info->fs * info->rate == clk)
-               dai->mclk = clk;
+       /* bit size */
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               break;
+       case SNDRV_PCM_FORMAT_S20_3LE:
+               iface |= 0x0004;
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               iface |= 0x0008;
+               break;
+       }
 
-       return dai->mclk;
+       wm8731_write(codec, WM8731_IFACE, iface);
+       return 0;
 }
 
 static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
@@ -489,24 +298,76 @@ static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->codec;
-       u16 iface = 0, srate;
-       int i = get_coeff(rtd->codec_dai->mclk,
-               snd_soc_get_rate(rtd->codec_dai->dai_runtime.pcmrate));
+
+       /* set active */
+       wm8731_write(codec, WM8731_ACTIVE, 0x0001);
+
+       return 0;
+}
+
+static void wm8731_shutdown(struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->codec;
+
+       /* deactivate */
+       if (!codec->active) {
+               udelay(50);
+               wm8731_write(codec, WM8731_ACTIVE, 0x0);
+       }
+}
+
+static int wm8731_mute(struct snd_soc_dai *dai, int mute)
+{
+       struct snd_soc_codec *codec = dai->codec;
+       u16 mute_reg = wm8731_read_reg_cache(codec, WM8731_APDIGI) & 0xfff7;
+
+       if (mute)
+               wm8731_write(codec, WM8731_APDIGI, mute_reg | 0x8);
+       else
+               wm8731_write(codec, WM8731_APDIGI, mute_reg);
+       return 0;
+}
+
+static int wm8731_set_dai_sysclk(struct snd_soc_dai *codec_dai,
+               int clk_id, unsigned int freq, int dir)
+{
+       struct snd_soc_codec *codec = codec_dai->codec;
+       struct wm8731_priv *wm8731 = codec->private_data;
+
+       switch (freq) {
+       case 11289600:
+       case 12000000:
+       case 12288000:
+       case 16934400:
+       case 18432000:
+               wm8731->sysclk = freq;
+               return 0;
+       }
+       return -EINVAL;
+}
+
+
+static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
+               unsigned int fmt)
+{
+       struct snd_soc_codec *codec = codec_dai->codec;
+       u16 iface = 0;
 
        /* set master/slave audio interface */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_CLOCK_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBM_CFM:
                iface |= 0x0040;
                break;
        case SND_SOC_DAIFMT_CBS_CFS:
                break;
+       default:
+               return -EINVAL;
        }
-       srate = (coeff_div[i].sr << 2) |
-               (coeff_div[i].bosr << 1) | coeff_div[i].usb;
-       wm8731_write(codec, WM8731_SRATE, srate);
 
        /* interface format */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
        case SND_SOC_DAIFMT_I2S:
                iface |= 0x0002;
                break;
@@ -521,25 +382,12 @@ static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
        case SND_SOC_DAIFMT_DSP_B:
                iface |= 0x0013;
                break;
-       }
-
-       /* bit size */
-       switch (rtd->codec_dai->dai_runtime.pcmfmt) {
-       case SNDRV_PCM_FMTBIT_S16_LE:
-               break;
-       case SNDRV_PCM_FMTBIT_S20_3LE:
-               iface |= 0x0004;
-               break;
-       case SNDRV_PCM_FMTBIT_S24_LE:
-               iface |= 0x0008;
-               break;
-       case SNDRV_PCM_FMTBIT_S32_LE:
-               iface |= 0x000c;
-               break;
+       default:
+               return -EINVAL;
        }
 
        /* clock inversion */
-       switch (rtd->codec_dai->dai_runtime.fmt & SND_SOC_DAIFMT_INV_MASK) {
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
        case SND_SOC_DAIFMT_NB_NF:
                break;
        case SND_SOC_DAIFMT_IB_IF:
@@ -551,88 +399,74 @@ static int wm8731_pcm_prepare(struct snd_pcm_substream *substream)
        case SND_SOC_DAIFMT_NB_IF:
                iface |= 0x0010;
                break;
+       default:
+               return -EINVAL;
        }
 
        /* set iface */
        wm8731_write(codec, WM8731_IFACE, iface);
-
-       /* set active */
-       wm8731_write(codec, WM8731_ACTIVE, 0x0001);
-       return 0;
-}
-
-static void wm8731_shutdown(struct snd_pcm_substream *substream)
-{
-       struct snd_soc_pcm_runtime *rtd = substream->private_data;
-       struct snd_soc_device *socdev = rtd->socdev;
-       struct snd_soc_codec *codec = socdev->codec;
-
-       /* deactivate */
-       if (!codec->active) {
-               udelay(50);
-               wm8731_write(codec, WM8731_ACTIVE, 0x0);
-       }
-}
-
-static int wm8731_mute(struct snd_soc_codec *codec,
-       struct snd_soc_codec_dai *dai, int mute)
-{
-       u16 mute_reg = wm8731_read_reg_cache(codec, WM8731_APDIGI) & 0xfff7;
-       if (mute)
-               wm8731_write(codec, WM8731_APDIGI, mute_reg | 0x8);
-       else
-               wm8731_write(codec, WM8731_APDIGI, mute_reg);
        return 0;
 }
 
-static int wm8731_dapm_event(struct snd_soc_codec *codec, int event)
+static int wm8731_set_bias_level(struct snd_soc_codec *codec,
+                                enum snd_soc_bias_level level)
 {
        u16 reg = wm8731_read_reg_cache(codec, WM8731_PWR) & 0xff7f;
 
-       switch (event) {
-       case SNDRV_CTL_POWER_D0: /* full On */
+       switch (level) {
+       case SND_SOC_BIAS_ON:
                /* vref/mid, osc on, dac unmute */
                wm8731_write(codec, WM8731_PWR, reg);
                break;
-       case SNDRV_CTL_POWER_D1: /* partial On */
-       case SNDRV_CTL_POWER_D2: /* partial On */
+       case SND_SOC_BIAS_PREPARE:
                break;
-       case SNDRV_CTL_POWER_D3hot: /* Off, with power */
+       case SND_SOC_BIAS_STANDBY:
                /* everything off except vref/vmid, */
                wm8731_write(codec, WM8731_PWR, reg | 0x0040);
                break;
-       case SNDRV_CTL_POWER_D3cold: /* Off, without power */
+       case SND_SOC_BIAS_OFF:
                /* everything off, dac mute, inactive */
                wm8731_write(codec, WM8731_ACTIVE, 0x0);
                wm8731_write(codec, WM8731_PWR, 0xffff);
                break;
        }
-       codec->dapm_state = event;
+       codec->bias_level = level;
        return 0;
 }
 
-struct snd_soc_codec_dai wm8731_dai = {
+#define WM8731_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
+               SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\
+               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |\
+               SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |\
+               SNDRV_PCM_RATE_96000)
+
+#define WM8731_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
+       SNDRV_PCM_FMTBIT_S24_LE)
+
+struct snd_soc_dai wm8731_dai = {
        .name = "WM8731",
        .playback = {
                .stream_name = "Playback",
                .channels_min = 1,
                .channels_max = 2,
-       },
+               .rates = WM8731_RATES,
+               .formats = WM8731_FORMATS,},
        .capture = {
                .stream_name = "Capture",
                .channels_min = 1,
                .channels_max = 2,
-       },
-       .config_sysclk = wm8731_config_sysclk,
-       .digital_mute = wm8731_mute,
+               .rates = WM8731_RATES,
+               .formats = WM8731_FORMATS,},
        .ops = {
                .prepare = wm8731_pcm_prepare,
+               .hw_params = wm8731_hw_params,
                .shutdown = wm8731_shutdown,
        },
-       .caps = {
-               .num_modes = ARRAY_SIZE(wm8731_modes),
-               .mode = wm8731_modes,
-       },
+       .dai_ops = {
+               .digital_mute = wm8731_mute,
+               .set_sysclk = wm8731_set_dai_sysclk,
+               .set_fmt = wm8731_set_dai_fmt,
+       }
 };
 EXPORT_SYMBOL_GPL(wm8731_dai);
 
@@ -642,7 +476,7 @@ static int wm8731_suspend(struct platform_device *pdev, pm_message_t state)
        struct snd_soc_codec *codec = socdev->codec;
 
        wm8731_write(codec, WM8731_ACTIVE, 0x0);
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3cold);
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);
        return 0;
 }
 
@@ -660,8 +494,8 @@ static int wm8731_resume(struct platform_device *pdev)
                data[1] = cache[i] & 0x00ff;
                codec->hw_write(codec->control_data, data, 2);
        }
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3hot);
-       wm8731_dapm_event(codec, codec->suspend_dapm_state);
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+       wm8731_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
 }
 
@@ -678,18 +512,13 @@ static int wm8731_init(struct snd_soc_device *socdev)
        codec->owner = THIS_MODULE;
        codec->read = wm8731_read_reg_cache;
        codec->write = wm8731_write;
-       codec->dapm_event = wm8731_dapm_event;
+       codec->set_bias_level = wm8731_set_bias_level;
        codec->dai = &wm8731_dai;
        codec->num_dai = 1;
        codec->reg_cache_size = ARRAY_SIZE(wm8731_reg);
-
-       codec->reg_cache =
-                       kzalloc(sizeof(u16) * ARRAY_SIZE(wm8731_reg), GFP_KERNEL);
+       codec->reg_cache = kmemdup(wm8731_reg, sizeof(wm8731_reg), GFP_KERNEL);
        if (codec->reg_cache == NULL)
                return -ENOMEM;
-       memcpy(codec->reg_cache,
-               wm8731_reg, sizeof(u16) * ARRAY_SIZE(wm8731_reg));
-       codec->reg_cache_size = sizeof(u16) * ARRAY_SIZE(wm8731_reg);
 
        wm8731_reset(codec);
 
@@ -701,17 +530,17 @@ static int wm8731_init(struct snd_soc_device *socdev)
        }
 
        /* power on device */
-       wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3hot);
+       wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
 
        /* set the update bits */
        reg = wm8731_read_reg_cache(codec, WM8731_LOUT1V);
-       wm8731_write(codec, WM8731_LOUT1V, reg 0x0100);
+       wm8731_write(codec, WM8731_LOUT1V, reg & ~0x0100);
        reg = wm8731_read_reg_cache(codec, WM8731_ROUT1V);
-       wm8731_write(codec, WM8731_ROUT1V, reg 0x0100);
+       wm8731_write(codec, WM8731_ROUT1V, reg & ~0x0100);
        reg = wm8731_read_reg_cache(codec, WM8731_LINVOL);
-       wm8731_write(codec, WM8731_LINVOL, reg 0x0100);
+       wm8731_write(codec, WM8731_LINVOL, reg & ~0x0100);
        reg = wm8731_read_reg_cache(codec, WM8731_RINVOL);
-       wm8731_write(codec, WM8731_RINVOL, reg 0x0100);
+       wm8731_write(codec, WM8731_RINVOL, reg & ~0x0100);
 
        wm8731_add_controls(codec);
        wm8731_add_widgets(codec);
@@ -733,7 +562,7 @@ pcm_err:
 
 static struct snd_soc_device *wm8731_socdev;
 
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
 
 /*
  * WM8731 2 wire address is determined by GPIO5
@@ -766,24 +595,23 @@ static int wm8731_codec_probe(struct i2c_adapter *adap, int addr, int kind)
        client_template.adapter = adap;
        client_template.addr = addr;
 
-       i2c = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
+       i2c = kmemdup(&client_template, sizeof(client_template), GFP_KERNEL);
        if (i2c == NULL) {
                kfree(codec);
                return -ENOMEM;
        }
-       memcpy(i2c, &client_template, sizeof(struct i2c_client));
        i2c_set_clientdata(i2c, codec);
        codec->control_data = i2c;
 
        ret = i2c_attach_client(i2c);
        if (ret < 0) {
-               err("failed to attach codec at addr %x\n", addr);
+               pr_err("failed to attach codec at addr %x\n", addr);
                goto err;
        }
 
        ret = wm8731_init(socdev);
        if (ret < 0) {
-               err("failed to initialise WM8731\n");
+               pr_err("failed to initialise WM8731\n");
                goto err;
        }
        return ret;
@@ -796,7 +624,7 @@ err:
 
 static int wm8731_i2c_detach(struct i2c_client *client)
 {
-       struct snd_soc_codeccodec = i2c_get_clientdata(client);
+       struct snd_soc_codec *codec = i2c_get_clientdata(client);
        i2c_detach_client(client);
        kfree(codec->reg_cache);
        kfree(client);
@@ -831,22 +659,30 @@ static int wm8731_probe(struct platform_device *pdev)
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct wm8731_setup_data *setup;
        struct snd_soc_codec *codec;
+       struct wm8731_priv *wm8731;
        int ret = 0;
 
-       info("WM8731 Audio Codec %s", WM8731_VERSION);
+       pr_info("WM8731 Audio Codec %s", WM8731_VERSION);
 
        setup = socdev->codec_data;
        codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
        if (codec == NULL)
                return -ENOMEM;
 
+       wm8731 = kzalloc(sizeof(struct wm8731_priv), GFP_KERNEL);
+       if (wm8731 == NULL) {
+               kfree(codec);
+               return -ENOMEM;
+       }
+
+       codec->private_data = wm8731;
        socdev->codec = codec;
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
 
        wm8731_socdev = socdev;
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
        if (setup->i2c_address) {
                normal_i2c[0] = setup->i2c_address;
                codec->hw_write = (hw_write_t)i2c_master_send;
@@ -867,13 +703,14 @@ static int wm8731_remove(struct platform_device *pdev)
        struct snd_soc_codec *codec = socdev->codec;
 
        if (codec->control_data)
-               wm8731_dapm_event(codec, SNDRV_CTL_POWER_D3cold);
+               wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
        snd_soc_free_pcms(socdev);
        snd_soc_dapm_free(socdev);
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
        i2c_del_driver(&wm8731_i2c_driver);
 #endif
+       kfree(codec->private_data);
        kfree(codec);
 
        return 0;
@@ -885,7 +722,6 @@ struct snd_soc_codec_device soc_codec_dev_wm8731 = {
        .suspend =      wm8731_suspend,
        .resume =       wm8731_resume,
 };
-
 EXPORT_SYMBOL_GPL(soc_codec_dev_wm8731);
 
 MODULE_DESCRIPTION("ASoC WM8731 driver");