cpupower: Remove redundant error check
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 29 Jul 2014 16:12:20 +0000 (18:12 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 29 Jul 2014 23:57:13 +0000 (01:57 +0200)
commit059802f961db9717412b6958111ca1cd1865726e
treed5cdc976411b8e08f853fd88516b06f55c5957be
parent13f6de52b149c030b0d529a3d8d68267ed20f01c
cpupower: Remove redundant error check

Remove double checks, and move the call to print_error to the
first check. Replace break by return, and return 0 on success.
The simplified version of the coccinelle semantic patch that
fixes this issue is as follows:

// <smpl>
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
tools/power/cpupower/utils/cpufreq-set.c