cifs: fix off-by-one bug in build_unc_path_to_root
authorJeff Layton <jlayton@redhat.com>
Fri, 31 May 2013 14:00:18 +0000 (10:00 -0400)
committerSteve French <sfrench@us.ibm.com>
Fri, 31 May 2013 21:23:35 +0000 (16:23 -0500)
commit1fc29bacedeabb278080e31bb9c1ecb49f143c3b
treed4066d88f8ffb3431d766d49035f1f7caa1439ed
parenta93cb29acaa8f75618c3f202d1cf43c231984644
cifs: fix off-by-one bug in build_unc_path_to_root

commit 839db3d10a (cifs: fix up handling of prefixpath= option) changed
the code such that the vol->prepath no longer contained a leading
delimiter and then fixed up the places that accessed that field to
account for that change.

One spot in build_unc_path_to_root was missed however. When doing the
pointer addition on pos, that patch failed to account for the fact that
we had already incremented "pos" by one when adding the length of the
prepath. This caused a buffer overrun by one byte.

This patch fixes the problem by correcting the handling of "pos".

Cc: <stable@vger.kernel.org> # v3.8+
Reported-by: Marcus Moeller <marcus.moeller@gmx.ch>
Reported-by: Ken Fallon <ken.fallon@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/connect.c