net: tcp: deal with listen sockets properly in tcp_abort.
authorLorenzo Colitti <lorenzo@google.com>
Mon, 21 Dec 2015 15:03:44 +0000 (00:03 +0900)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Dec 2015 21:01:47 +0000 (16:01 -0500)
commit2010b93e9317cc12acd20c4aed385af7f9d1681e
tree739641a02d6d007daf790d87500a662777e46616
parente7bc73cbb522c1704aafc428d5d9763c44666e38
net: tcp: deal with listen sockets properly in tcp_abort.

When closing a listen socket, tcp_abort currently calls
tcp_done without clearing the request queue. If the socket has a
child socket that is established but not yet accepted, the child
socket is then left without a parent, causing a leak.

Fix this by setting the socket state to TCP_CLOSE and calling
inet_csk_listen_stop with the socket lock held, like tcp_close
does.

Tested using net_test. With this patch, calling SOCK_DESTROY on a
listen socket that has an established but not yet accepted child
socket results in the parent and the child being closed, such
that they no longer appear in sock_diag dumps.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c