mm: fix race in kunmap_atomic()
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Wed, 27 Oct 2010 22:32:58 +0000 (15:32 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Oct 2010 01:03:05 +0000 (18:03 -0700)
commit20273941f2129aa5a432796d98a276ed73d60782
tree85da0d951ac10f239f81ad7f69559fdeb692095b
parenta8e23a291852cd7c4fb5ca696dbb93912185ad10
mm: fix race in kunmap_atomic()

Christoph reported a nice splat which illustrated a race in the new stack
based kmap_atomic implementation.

The problem is that we pop our stack slot before we're completely done
resetting its state -- in particular clearing the PTE (sometimes that's
CONFIG_DEBUG_HIGHMEM).  If an interrupt happens before we actually clear
the PTE used for the last slot, that interrupt can reuse the slot in a
dirty state, which triggers a BUG in kmap_atomic().

Fix this by introducing kmap_atomic_idx() which reports the current slot
index without actually releasing it and use that to find the PTE and delay
the _pop() until after we're completely done.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reported-by: Christoph Hellwig <hch@infradead.org>
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/arm/mm/highmem.c
arch/frv/mm/highmem.c
arch/mips/mm/highmem.c
arch/mn10300/include/asm/highmem.h
arch/powerpc/mm/highmem.c
arch/sparc/mm/highmem.c
arch/tile/mm/highmem.c
arch/x86/mm/highmem_32.c
arch/x86/mm/iomap_32.c
include/linux/highmem.h