tipc: fix a possible memory leak
authorYing Xue <ying.xue@windriver.com>
Fri, 25 Apr 2014 02:44:15 +0000 (10:44 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 27 Apr 2014 23:08:06 +0000 (19:08 -0400)
commit22e7987ae7d8d13beeaf0717215800f7e803ddcf
treebf796b7b8020397483e5a2ed4bc6b48dd7a6cb86
parenta42c3a28e8c2f071749a051f3afdbc1777418a07
tipc: fix a possible memory leak

The commit a8b9b96e959f3c035af20b1bd2ba67b0b7269b19 ("tipc: fix race
in disc create/delete") leads to the following static checker warning:

net/tipc/discover.c:352 tipc_disc_create()
warn: possible memory leak of 'req'

The risk of memory leak really exists in practice. Especially when
it's failed to allocate memory for "req->buf", tipc_disc_create()
doesn't free its allocated memory, instead just directly returns
with ENOMEM error code. In this situation, memory leak, of course,
happens.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/discover.c