sdhci: only reprogram retuning timer when flag is set
authorArend van Spriel <arend@broadcom.com>
Sat, 4 Jan 2014 12:51:26 +0000 (13:51 +0100)
committerChris Ball <chris@printf.net>
Tue, 25 Mar 2014 20:54:00 +0000 (16:54 -0400)
commit2bc024855e881c697fc9bf9799f377c392192a43
tree4a83d097677501c554c03f88871dd07a5b77371e
parentfc2bd2e492a1e4f131a91c69c21c65be9e2e0125
sdhci: only reprogram retuning timer when flag is set

When the host->tuning_count is zero it means that the retuning is
disabled. This is checked on the first run of sdhci_execute_tuning()
by the if statement below:

if (!(host->flags & SDHCI_NEEDS_RETUNING) && host->tuning_count &&
    (host->tuning_mode == SDHCI_TUNING_MODE_1)) {

So only when tuning_count is non-zero it will set the host flag
SDHCI_USING_RETUNING_TIMER. The else statement is only for re-programming
the timer, which means that flag must be set. Because that is not checked
the else statement is executed in the first run when tuning_count is zero.

This was seen on a host controller which indicated SDHCI_TUNING_MODE_1 (0)
and tuning_count being zero. Suspect that (one of) these registers is not
properly set.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Chris Ball <chris@printf.net>
drivers/mmc/host/sdhci.c