V4L/DVB (5525): Usbvision: fix confusion over 7-bit vs 8-bit TDDA9887 addresses
authorTrent Piepho <xyzzy@speakeasy.org>
Sun, 15 Apr 2007 13:09:56 +0000 (10:09 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Fri, 27 Apr 2007 18:45:40 +0000 (15:45 -0300)
commit3153bd91bfe14b6b93aef5b6b7c9fc279eec60d9
treee363753883366121fbe9bdd7109d3cea65b558d4
parent66ab6e023ebbb362b7cf42c8f56cc54a85fb7bb0
V4L/DVB (5525): Usbvision: fix confusion over 7-bit vs 8-bit TDDA9887 addresses

The code was testing an 8-bit address against a 7-bit address.  Will the
confusion of the two never cease?
Biggest flaw of the I2C protocol:  the R/W bit is the LSB instead of the
MSB.  No one can ever agree if addresses are 7-bits and the R/W bit
follows them, or if they are 8-bit and the R/W bit is OR-ed into the
address byte.  If the R/W bit was first, it wouldn't make any difference!

Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/usbvision/usbvision-i2c.c