ASoC: tlv320aic3x: fix PLL D configuration
authorDmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
Fri, 3 Oct 2014 13:18:56 +0000 (16:18 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 3 Oct 2014 15:06:11 +0000 (16:06 +0100)
commit31d9f8faf9a54c851e835af489c82f45105a442f
tree384e3f64d35d650cababae4abfa2a46487bdfe12
parent7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
ASoC: tlv320aic3x: fix PLL D configuration

Current caching implementation during regcache_sync() call bypasses
all register writes of values that are already known as default
(regmap reg_defaults). Same time in TLV320AIC3x codecs register 5
(AIC3X_PLL_PROGC_REG) write should be immediately followed by register
6 write (AIC3X_PLL_PROGD_REG) even if it was not changed. Otherwise
both registers will not be written.

This brings to issue that appears particulary in case of 44.1kHz
playback with 19.2MHz master clock. In this case AIC3X_PLL_PROGC_REG
is 0x6e while AIC3X_PLL_PROGD_REG is 0x0 (same as register
default). Thus AIC3X_PLL_PROGC_REG also remains not written and we get
wrong playback speed.

In this patch snd_soc_read() is used to get cached pll values and
snd_soc_write() (unlike regcache_sync() this function doesn't bypasses
hardware default values) to write them to registers.

Signed-off-by: Dmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
sound/soc/codecs/tlv320aic3x.c