rbd: fix leak of format 2 snapshot context
authorAlex Elder <elder@inktank.com>
Mon, 6 May 2013 13:37:00 +0000 (08:37 -0500)
committerAlex Elder <elder@inktank.com>
Wed, 8 May 2013 12:38:30 +0000 (07:38 -0500)
commit49ece554288caf1a8ea9e546ab1ff5bc4b175456
tree348c9a673077b2c43e07e75a12873d72a3920a29
parentb5b09be30cf99f9c699e825629f02e3bce555d44
rbd: fix leak of format 2 snapshot context

When rbd_dev_v2_refresh() is called, the rbd device already has a
snapshot context associated with it.  But that never gets freed,
the pointer just gets overwritten.

Fix this by dropping the rbd device's reference to the snapshot
context before overwriting the pointer.

Because ceph_put_snap_context() already handles for a null pointer
we don't need to check for that (for the probe case, where no
context has yet been assigned).

This resolves:
    http://tracker.ceph.com/issues/4912

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
drivers/block/rbd.c