RDMA/ocrdma: fix double free on pd
authorColin Ian King <colin.king@canonical.com>
Fri, 5 Jun 2015 14:47:27 +0000 (15:47 +0100)
committerDoug Ledford <dledford@redhat.com>
Thu, 11 Jun 2015 05:12:28 +0000 (01:12 -0400)
commit4dc544427991e3cef38ce3ae124b7e6557063bd3
treec90200677ad7ab12d77d3178a15e94643532783b
parentfc3aa45b63101a11859e171aed9622d35cb02d16
RDMA/ocrdma: fix double free on pd

A reorganisation of the PD allocation and deallocation in commit
9ba1377daa ("RDMA/ocrdma: Move PD resource management to driver.")
introduced a double free on pd, as detected by static analysis by
smatch:

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:682 ocrdma_alloc_pd()
  error: double free of 'pd'^

The original call to ocrdma_mbx_dealloc_pd() (which does not kfree
pd) was replaced with a call to _ocrdma_dealloc_pd() (which does
kfree pd).  The kfree following this call causes the double free,
so just remove it to fix the problem.

Fixes: 9ba1377daa ("RDMA/ocrdma: Move PD resource management to driver.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-By: Devesh Sharma <devesh.sharma@avagotech.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c