[SCSI] remove a useless get/put_device pair in scsi_request_fn
authorBart Van Assche <bvanassche@acm.org>
Thu, 20 Feb 2014 22:20:56 +0000 (14:20 -0800)
committerJames Bottomley <JBottomley@Parallels.com>
Sat, 15 Mar 2014 17:19:25 +0000 (10:19 -0700)
commit613be1f626e602c6744101a003e8fc5c180e1af9
tree4c78a6ed1be7b817fdb7a233dd1d346e786f2f31
parent0479633686d370303e3430256ace4bd5f7f138dc
[SCSI] remove a useless get/put_device pair in scsi_request_fn

SCSI devices may only be removed by calling scsi_remove_device().
That function must invoke blk_cleanup_queue() before the final put
of sdev->sdev_gendev. Since blk_cleanup_queue() waits for the
block queue to drain and then tears it down, scsi_request_fn cannot
be active anymore after blk_cleanup_queue() has returned and hence
the get_device()/put_device() pair in scsi_request_fn is unnecessary.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_lib.c