xfrm: fix xfrm_input/xfrm_tunnel_check oops
authorAlexey Dobriyan <adobriyan@gmail.com>
Thu, 2 Apr 2015 07:58:24 +0000 (10:58 +0300)
committerSteffen Klassert <steffen.klassert@secunet.com>
Tue, 7 Apr 2015 05:52:27 +0000 (07:52 +0200)
commit68c11e98ef6748ddb63865799b12fc45abb3755d
tree0e50342a5653383d927364a0158f650e83d77bd0
parentf22e6e847115abc3a0e2ad7bb18d243d42275af1
xfrm: fix xfrm_input/xfrm_tunnel_check oops

https://bugzilla.kernel.org/show_bug.cgi?id=95211

Commit 70be6c91c86596ad2b60c73587880b47df170a41
("xfrm: Add xfrm_tunnel_skb_cb to the skb common buffer") added check
which dereferences ->outer_mode too early but larval SAs don't have
this pointer set (yet). So check for tunnel stuff later.

Mike Noordermeer reported this bug and patiently applied all the debugging.

Technically this is remote-oops-in-interrupt-context type of thing.

BUG: unable to handle kernel NULL pointer dereference at 0000000000000034
IP: [<ffffffff8150dca2>] xfrm_input+0x3c2/0x5a0
...
[<ffffffff81500fc6>] ? xfrm4_esp_rcv+0x36/0x70
[<ffffffff814acc9a>] ? ip_local_deliver_finish+0x9a/0x200
[<ffffffff81471b83>] ? __netif_receive_skb_core+0x6f3/0x8f0
...

RIP  [<ffffffff8150dca2>] xfrm_input+0x3c2/0x5a0
Kernel panic - not syncing: Fatal exception in interrupt

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_input.c