direct-io: fix uninitialized warning in do_direct_IO()
authorBoaz Harrosh <boaz@plexistor.com>
Sun, 20 Jul 2014 09:09:04 +0000 (12:09 +0300)
committerChristoph Hellwig <hch@lst.de>
Thu, 24 Jul 2014 10:17:07 +0000 (06:17 -0400)
commit6fcc5420bfb91049a318bb4d88fe471248b5b391
tree7facf80d3bcacbd21131c90721355f7ea0ddb0ee
parent82e13c71bc655b6dc7110da4e164079dadb44892
direct-io: fix uninitialized warning in do_direct_IO()

The following warnings:

  fs/direct-io.c: In function ‘__blockdev_direct_IO’:
  fs/direct-io.c:1011:12: warning: ‘to’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  fs/direct-io.c:913:16: note: ‘to’ was declared here
  fs/direct-io.c:1011:12: warning: ‘from’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  fs/direct-io.c:913:10: note: ‘from’ was declared here

are false positive because dio_get_page() either fails, or sets both
'from' and 'to'.

Paul Bolle said ...
Maybe it's better to move initializing "to" and "from" out of
dio_get_page(). That _might_ make it easier for both the the reader and
the compiler to understand what's going on. Something like this:

Christoph Hellwig said ...
The fix of moving the code definitively looks nicer, while I think
uninitialized_var is horrible wart that won't get anywhere near my code.

Boaz Harrosh: I agree with Christoph and Paul

Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
fs/direct-io.c