uprobes/x86: Emulate unconditional relative jmp's
authorOleg Nesterov <oleg@redhat.com>
Sat, 5 Apr 2014 18:05:02 +0000 (20:05 +0200)
committerOleg Nesterov <oleg@redhat.com>
Thu, 17 Apr 2014 19:58:22 +0000 (21:58 +0200)
commit7ba6db2d688bdf83049a18c8e55b2d1e58e8b0bc
treec2be845e50bb6057b8ea0716a18bca4120964060
parent8faaed1b9f500d6cf32702716733a645c9b0727a
uprobes/x86: Emulate unconditional relative jmp's

Currently we always execute all insns out-of-line, including relative
jmp's and call's. This assumes that even if regs->ip points to nowhere
after the single-step, default_post_xol_op(UPROBE_FIX_IP) logic will
update it correctly.

However, this doesn't work if this regs->ip == xol_vaddr + insn_offset
is not canonical. In this case CPU generates #GP and general_protection()
kills the task which tries to execute this insn out-of-line.

Now that we have uprobe_xol_ops we can teach uprobes to emulate these
insns and solve the problem. This patch adds branch_xol_ops which has
a single branch_emulate_op() hook, so far it can only handle rel8/32
relative jmp's.

TODO: move ->fixup into the union along with rip_rela_target_address.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Jonathan Lebon <jlebon@redhat.com>
Reviewed-by: Jim Keniston <jkenisto@us.ibm.com>
arch/x86/include/asm/uprobes.h
arch/x86/kernel/uprobes.c