clk: get matching entry under lock in of_clk_init()
authorAlex Elder <alex.elder@linaro.org>
Thu, 22 Aug 2013 16:31:31 +0000 (11:31 -0500)
committerMike Turquette <mturquette@linaro.org>
Tue, 27 Aug 2013 23:05:39 +0000 (16:05 -0700)
commit7f7ed584d11be77a7521d170431bb14bc32a5980
tree805ab187a9fce4b7c20170ceeffe9d074ea8da53
parent1ec5502ef20acc0af5c9172aac4652cd7cafd852
clk: get matching entry under lock in of_clk_init()

Currently of_clk_init() finds a matching device node while holding
the device tree spinlock.  When a matching device node is found, the
lock is dropped and then re-acquired in order to get a reference
to the matching device id structure.

Acquiring the spinlock twice is unnecessary (and it opens a
vulnerable window that could conceivably lead to errors).

There already exists an interface for both finding and taking a
reference to a device id under lock, so use it.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
drivers/clk/clk.c