wmi: use memcmp instead of strncmp to compare GUIDs
authorThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Sun, 28 Nov 2010 21:46:50 +0000 (19:46 -0200)
committerMatthew Garrett <mjg@redhat.com>
Mon, 6 Dec 2010 22:19:13 +0000 (17:19 -0500)
commit8b14d7b22c61f17ccb869e0047d9df6dd9f50a9f
treee0d21c1bf4b70e4edf318985a9a56c365ac62a5a
parent53c96dfdd0c0ccbba7aee84c60ce0f2aa466413f
wmi: use memcmp instead of strncmp to compare GUIDs

While looking for the duplicates in /sys/class/wmi/, I couldn't find
them. The code that looks for duplicates uses strncmp in a binary GUID,
which may contain zero bytes. The right function is memcmp, which is
also used in another section of wmi code.

It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of
39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth
printed, they were found as equal by strncmp.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: stable@kernel.org
drivers/platform/x86/wmi.c