mmc: sdhci-pci: Fix error case in sdhci_pci_probe_slot()
authorChris Ball <cjb@laptop.org>
Tue, 29 Mar 2011 04:46:12 +0000 (00:46 -0400)
committerChris Ball <cjb@laptop.org>
Wed, 27 Apr 2011 23:14:55 +0000 (19:14 -0400)
commit9fdcdbb0d84922e7ccda2f717a04ea62629f7e18
treee19e33d135d5c7a53fbb99bf2f39e7456c503352
parente8dad69408a9812d6bb42d03e74d2c314534a4fa
mmc: sdhci-pci: Fix error case in sdhci_pci_probe_slot()

If pci_ioremap_bar() fails during probe, we "goto release;" and free the
host, but then we return 0 -- which tells sdhci_pci_probe() that the probe
succeeded.  Since we think the probe succeeded, when we unload sdhci we'll
go to sdhci_pci_remove_slot() and it will try to dereference slot->host,
which is now NULL because we freed it in the error path earlier.

The patch simply sets ret appropriately, so that sdhci_pci_probe() will
detect the failure immediately and bail out.

Signed-off-by: Chris Ball <cjb@laptop.org>
Cc: <stable@kernel.org>
drivers/mmc/host/sdhci-pci.c