ipv4: do not use this_cpu_ptr() in preemptible context
authorEric Dumazet <edumazet@google.com>
Mon, 22 Sep 2014 17:38:16 +0000 (10:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Sep 2014 22:31:18 +0000 (18:31 -0400)
commita35165ca101695aa2cc5a6300ef69ae60be39a49
treed9f2aa4a8b447c524c4803d8e087a54d75698d2f
parent84de67b29882efaacd05861f41e749c5e8f0c3ed
ipv4: do not use this_cpu_ptr() in preemptible context

this_cpu_ptr() in preemptible context is generally bad

Sep 22 05:05:55 br kernel: [   94.608310] BUG: using smp_processor_id()
in
preemptible [00000000] code: ip/2261
Sep 22 05:05:55 br kernel: [   94.608316] caller is
tunnel_dst_set.isra.28+0x20/0x60 [ip_tunnel]
Sep 22 05:05:55 br kernel: [   94.608319] CPU: 3 PID: 2261 Comm: ip Not
tainted
3.17.0-rc5 #82

We can simply use raw_cpu_ptr(), as preemption is safe in these
contexts.

Should fix https://bugzilla.kernel.org/show_bug.cgi?id=84991

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Joe <joe9mail@gmail.com>
Fixes: 9a4aa9af447f ("ipv4: Use percpu Cache route in IP tunnels")
Acked-by: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_tunnel.c