ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Mon, 22 Feb 2016 17:43:25 +0000 (18:43 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Feb 2016 19:11:34 +0000 (14:11 -0500)
commita8c4a2522a0808c5c2143612909717d1115c40cf
tree630d9bda2a7e98752fbb442f1d1a96d92035ef98
parentc7dfe3abf40ec9a298884a4c0775062eac27afc9
ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

Otherwise we break the contract with GSO to only pass CHECKSUM_PARTIAL
skbs down. This can easily happen with UDP+IPv4 sockets with the first
MSG_MORE write smaller than the MTU, second write is a sendfile.

Returning -EOPNOTSUPP lets the callers fall back into normal sendmsg path,
were we calculate the checksum manually during copying.

Commit d749c9cbffd6 ("ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked
sockets") started to exposes this bug.

Fixes: d749c9cbffd6 ("ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets")
Reported-by: Jiri Benc <jbenc@redhat.com>
Cc: Jiri Benc <jbenc@redhat.com>
Reported-by: Wakko Warner <wakko@animx.eu.org>
Cc: Wakko Warner <wakko@animx.eu.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c