iser-target: Fix session reset bug with RDMA_CM_EVENT_DISCONNECTED
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 3 Jul 2013 10:05:37 +0000 (03:05 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 8 Jul 2013 01:35:56 +0000 (18:35 -0700)
commitb2cb96494d83b894a43ba8b9023eead8ff50684b
treeb16b85fe4b65448fb8d03c004d8a7d83c988c412
parent186a9647019587b3784694894c4d136fd00cfd7b
iser-target: Fix session reset bug with RDMA_CM_EVENT_DISCONNECTED

This patch addresses a bug where RDMA_CM_EVENT_DISCONNECTED may occur
before the connection shutdown has been completed by rx/tx threads,
that causes isert_free_conn() to wait indefinately on ->conn_wait.

This patch allows isert_disconnect_work code to invoke rdma_disconnect
when isert_disconnect_work() process context is started by client
session reset before isert_free_conn() code has been reached.

It also adds isert_conn->conn_mutex protection for ->state within
isert_disconnect_work(), isert_cq_comp_err() and isert_free_conn()
code, along with isert_check_state() for wait_event usage.

(v2: Add explicit iscsit_cause_connection_reinstatement call
     during isert_disconnect_work() to force conn reset)

Cc: stable@vger.kernel.org # 3.10+
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c
drivers/infiniband/ulp/isert/ib_isert.h
drivers/target/iscsi/iscsi_target_erl0.c
include/target/iscsi/iscsi_transport.h