iscsi-target: Fix iscsit_add_reject* usage for iser
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 3 Jul 2013 10:48:24 +0000 (03:48 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sun, 7 Jul 2013 04:59:53 +0000 (21:59 -0700)
commitba159914086f06532079fc15141f46ffe7e04a41
tree9618efce9323083a5812cf831997e0cf560a6b0a
parent3df8f68aaf7ebe3d136a22262b41b350b0a1858b
iscsi-target: Fix iscsit_add_reject* usage for iser

This patch changes iscsit_add_reject() + iscsit_add_reject_from_cmd()
usage to not sleep on iscsi_cmd->reject_comp to address a free-after-use
usage bug in v3.10 with iser-target code.

It saves ->reject_reason for use within iscsit_build_reject() so the
correct value for both transport cases.  It also drops the legacy
fail_conn parameter usage throughput iscsi-target code and adds
two iscsit_add_reject_cmd() and iscsit_reject_cmd helper functions,
along with various small cleanups.

(v2: Re-enable target_put_sess_cmd() to be called from
     iscsit_add_reject_from_cmd() for rejects invoked after
     target_get_sess_cmd() has been called)

Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target.h
drivers/target/iscsi/iscsi_target_core.h
drivers/target/iscsi/iscsi_target_erl0.c
drivers/target/iscsi/iscsi_target_erl1.c
drivers/target/iscsi/iscsi_target_util.c
include/target/iscsi/iscsi_transport.h