ext4: don't manipulate recovery flag when freezing no-journal fs
authorEric Sandeen <sandeen@redhat.com>
Sat, 15 Aug 2015 14:45:06 +0000 (10:45 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 15 Aug 2015 14:45:06 +0000 (10:45 -0400)
commitc642dc9e1aaed953597e7092d7df329e6234096e
tree00f79b143e45278787e8a9bfa18ed0c66f11bd55
parent6d3ec14d703c660c4baf8d726538b5415e23b4fb
ext4: don't manipulate recovery flag when freezing no-journal fs

At some point along this sequence of changes:

f6e63f9 ext4: fold ext4_nojournal_sops into ext4_sops
bb04457 ext4: support freezing ext2 (nojournal) file systems
9ca9238 ext4: Use separate super_operations structure for no_journal filesystems

ext4 started setting needs_recovery on filesystems without journals
when they are unfrozen.  This makes no sense, and in fact confuses
blkid to the point where it doesn't recognize the filesystem at all.

(freeze ext2; unfreeze ext2; run blkid; see no output; run dumpe2fs,
see needs_recovery set on fs w/ no journal).

To fix this, don't manipulate the INCOMPAT_RECOVER feature on
filesystems without journals.

Reported-by: Stu Mark <smark@datto.com>
Reviewed-by: Jan Kara <jack@suse.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/super.c