projects / cascardo / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 590b743) | patch
svcrpc: fix handling of too-short rpc's
authorJ. Bruce Fields <bfields@redhat.com>
Wed, 26 Jun 2013 15:09:06 +0000 (11:09 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 1 Jul 2013 21:32:04 +0000 (17:32 -0400)
commitcf3aa02cb4a0c5af5557dd47f15a08a7df33182a
tree54995388695e95c0abed33d68171ca160c5bfd2dtree | snapshot
parent590b743143eae8db40abdfd1ab20bc51ee0ee5dbcommit | diff
svcrpc: fix handling of too-short rpc's

If we detect that an rpc is too short, we abort and close the
connection.  Except, there's a bug here: we're leaving sk_datalen
nonzero without leaving any pages in the sk_pages array.  The most
likely result of the inconsistency is a subsequent crash in
svc_tcp_clear_pages.

Also demote the BUG_ON in svc_tcp_clear_pages to a WARN.

Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svcsock.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.