iwlwifi: fix activating inactive stations
authorJohannes Berg <johannes.berg@intel.com>
Mon, 25 Jun 2012 07:36:41 +0000 (09:36 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 25 Jun 2012 19:14:13 +0000 (15:14 -0400)
commiteac9ac6d1f5d0e9d33e4ded682187b630e7606cd
tree9d12bf90dfc820e0931997b1962154b6691491fb
parentff0b804632f025b072f81fc0cd585102b0a43534
iwlwifi: fix activating inactive stations

When authentication/association timed out, the driver would
complain bitterly, printing the message
ACTIVATE a non DRIVER active station id ... addr ...

The cause turns out to be that when the AP station is added
but we don't associate, the IWL_STA_UCODE_INPROGRESS is set
but never cleared. This then causes iwl_restore_stations()
to attempt to resend it because it uses the flag internally
and uploads even if it didn't set it itself.

To fix this issue and not upload the station again when it
has already been removed by mac80211, clear the flag after
adding it in case we add it only for association.

Cc: stable@vger.kernel.org
Reviewed-by: Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-mac80211.c