leds: leds-gpio: Fix legacy GPIO number case
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 6 Nov 2014 11:23:23 +0000 (12:23 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 6 Nov 2014 20:34:21 +0000 (21:34 +0100)
commitec98a4975e66a3aa366cd227edab027b01adea37
tree766cafb359e4a53d961840c0d2f0761a56584aeb
parent60ba032ed76e851d30d4fa514847285252147d07
leds: leds-gpio: Fix legacy GPIO number case

In the legacy case, led_dat->gpiod is initialized correctly, but
overwritten later by template->gpiod, which is NULL, causing leds-gpio
to fail with:

    gpiod_direction_output: invalid GPIO
    leds-gpio: probe of leds-gpio failed with error -22

Move the initialization of led_dat->gpiod from template->gpiod up, and
always use led_dat->gpiod later, to fix this.

Fixes: 5c51277a9ababfa4 (leds: leds-gpio: Add support for GPIO descriptors)
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/leds/leds-gpio.c