spi/mpc52xx: Fix device remove function
authorGuenter Roeck <linux@roeck-us.net>
Sat, 18 Aug 2012 16:29:22 +0000 (09:29 -0700)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 22 Aug 2012 18:26:36 +0000 (19:26 +0100)
commitf95e1028e3317a084af955aa0b1c25a6c9213869
tree9d5abf5261e7c8de51c183445671bdae277fab69
parent866c0f25d2dc896e647970cf5e371b5083a6e5d5
spi/mpc52xx: Fix device remove function

The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is
complete; it reduces the device reference count to zero, which results in
device memory being freed. An extra call to spi_master_put is unnecessary
and results in an access to free memory.

At the same time, since the call to spi_unregister_master results in device
memory being freed, it must no longer be accessed afterwards.

To fix both problems, call spi_master_get to get an extra reference to the
device, and call spi_master_put only after the last access to device data.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/spi/spi-mpc52xx.c