sched/idle: Add missing checks to the exit condition of cpu_idle_poll()
authorPreeti U Murthy <preeti@linux.vnet.ibm.com>
Wed, 21 Jan 2015 10:57:25 +0000 (16:27 +0530)
committerIngo Molnar <mingo@kernel.org>
Fri, 30 Jan 2015 18:38:52 +0000 (19:38 +0100)
commitff6f2d29bd31cdfa1ac494a8b26d2af8ba887d59
tree9c40af46ead9789f5c0a6c55ea2f30a18d08d756
parenta18b5d01819235629289212ad428a5ee2b40f0d9
sched/idle: Add missing checks to the exit condition of cpu_idle_poll()

cpu_idle_poll() is entered into when either the cpu_idle_force_poll is set or
tick_check_broadcast_expired() returns true. The exit condition from
cpu_idle_poll() is tif_need_resched().

However this does not take into account scenarios where cpu_idle_force_poll
changes or tick_check_broadcast_expired() returns false, without setting
the resched flag. So a cpu will be caught in cpu_idle_poll() needlessly,
thereby wasting power. Add an explicit check on cpu_idle_force_poll and
tick_check_broadcast_expired() to the exit condition of cpu_idle_poll()
to avoid this.

Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20150121105655.15279.59626.stgit@preeti.in.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/idle.c