greybus: connection: convert connected dev_warn() to dev_err()

Failures from control-connected operations are fatal errors and
must be reported with dev_err() instead of dev_warn().

Fix it.

Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
[ johan: do not promote disconnected warnings, update summary ]
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>

diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 62cbeb3..f89b199 100644 (file)
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -386,9 +386,9 @@ static int gb_connection_init(struct gb_connection *connection)
 
                ret = gb_control_connected_operation(control, cport_id);
                if (ret) {
 
                ret = gb_control_connected_operation(control, cport_id);
                if (ret) {

-                       dev_warn(&connection->dev,
-                                "Failed to connect CPort-%d (%d)\n",
-                                cport_id, ret);
+                       dev_err(&connection->dev,
+                               "Failed to connect CPort-%d (%d)\n",
+                               cport_id, ret);

                        return 0;
                }
        }
                        return 0;
                }
        }