ath10k: remove unused dl_is_polled
authorRajkumar Manoharan <rmanohar@qti.qualcomm.com>
Mon, 12 Oct 2015 12:57:05 +0000 (18:27 +0530)
committerKalle Valo <kvalo@qca.qualcomm.com>
Fri, 16 Oct 2015 12:49:39 +0000 (15:49 +0300)
Since polling for received messages not supported, remove unused
dl_is_polled.

Reviewed-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/hif.h
drivers/net/wireless/ath/ath10k/htc.c
drivers/net/wireless/ath/ath10k/htc.h
drivers/net/wireless/ath/ath10k/pci.c

index 6e826bb..633594c 100644 (file)
@@ -59,7 +59,7 @@ struct ath10k_hif_ops {
 
        int (*map_service_to_pipe)(struct ath10k *ar, u16 service_id,
                                   u8 *ul_pipe, u8 *dl_pipe,
-                                  int *ul_is_polled, int *dl_is_polled);
+                                  int *ul_is_polled);
 
        void (*get_default_pipe)(struct ath10k *ar, u8 *ul_pipe, u8 *dl_pipe);
 
@@ -133,12 +133,11 @@ static inline void ath10k_hif_stop(struct ath10k *ar)
 static inline int ath10k_hif_map_service_to_pipe(struct ath10k *ar,
                                                 u16 service_id,
                                                 u8 *ul_pipe, u8 *dl_pipe,
-                                                int *ul_is_polled,
-                                                int *dl_is_polled)
+                                                int *ul_is_polled)
 {
        return ar->hif.ops->map_service_to_pipe(ar, service_id,
                                                ul_pipe, dl_pipe,
-                                               ul_is_polled, dl_is_polled);
+                                               ul_is_polled);
 }
 
 static inline void ath10k_hif_get_default_pipe(struct ath10k *ar,
index 13d0119..20e0c48 100644 (file)
@@ -759,8 +759,7 @@ setup:
                                                ep->service_id,
                                                &ep->ul_pipe_id,
                                                &ep->dl_pipe_id,
-                                               &ep->ul_is_polled,
-                                               &ep->dl_is_polled);
+                                               &ep->ul_is_polled);
        if (status)
                return status;
 
@@ -770,8 +769,8 @@ setup:
                   ep->dl_pipe_id, ep->eid);
 
        ath10k_dbg(ar, ATH10K_DBG_BOOT,
-                  "boot htc ep %d ul polled %d dl polled %d\n",
-                  ep->eid, ep->ul_is_polled, ep->dl_is_polled);
+                  "boot htc ep %d ul polled %d\n",
+                  ep->eid, ep->ul_is_polled);
 
        if (disable_credit_flow_ctrl && ep->tx_credit_flow_enabled) {
                ep->tx_credit_flow_enabled = false;
index aed3708..2ddd41e 100644 (file)
@@ -313,7 +313,6 @@ struct ath10k_htc_ep {
        u8 ul_pipe_id;
        u8 dl_pipe_id;
        int ul_is_polled; /* call HIF to get tx completions */
-       int dl_is_polled; /* call HIF to fetch rx (not implemented) */
 
        u8 seq_no; /* for debugging */
        int tx_credits;
index 8d364e4..c5875bb 100644 (file)
@@ -1404,8 +1404,7 @@ static void ath10k_pci_kill_tasklet(struct ath10k *ar)
 
 static int ath10k_pci_hif_map_service_to_pipe(struct ath10k *ar,
                                              u16 service_id, u8 *ul_pipe,
-                                             u8 *dl_pipe, int *ul_is_polled,
-                                             int *dl_is_polled)
+                                             u8 *dl_pipe, int *ul_is_polled)
 {
        const struct service_to_pipe *entry;
        bool ul_set = false, dl_set = false;
@@ -1413,9 +1412,6 @@ static int ath10k_pci_hif_map_service_to_pipe(struct ath10k *ar,
 
        ath10k_dbg(ar, ATH10K_DBG_PCI, "pci hif map service\n");
 
-       /* polling for received messages not supported */
-       *dl_is_polled = 0;
-
        for (i = 0; i < ARRAY_SIZE(target_service_to_ce_map_wlan); i++) {
                entry = &target_service_to_ce_map_wlan[i];
 
@@ -1458,7 +1454,7 @@ static int ath10k_pci_hif_map_service_to_pipe(struct ath10k *ar,
 static void ath10k_pci_hif_get_default_pipe(struct ath10k *ar,
                                            u8 *ul_pipe, u8 *dl_pipe)
 {
-       int ul_is_polled, dl_is_polled;
+       int ul_is_polled;
 
        ath10k_dbg(ar, ATH10K_DBG_PCI, "pci hif get default pipe\n");
 
@@ -1466,8 +1462,7 @@ static void ath10k_pci_hif_get_default_pipe(struct ath10k *ar,
                                                 ATH10K_HTC_SVC_ID_RSVD_CTRL,
                                                 ul_pipe,
                                                 dl_pipe,
-                                                &ul_is_polled,
-                                                &dl_is_polled);
+                                                &ul_is_polled);
 }
 
 static void ath10k_pci_irq_msi_fw_mask(struct ath10k *ar)