cpuidle: Fix finding state with min power_usage
authorSivaram Nair <sivaramn@nvidia.com>
Tue, 18 Dec 2012 12:52:50 +0000 (13:52 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 3 Jan 2013 12:11:05 +0000 (13:11 +0100)
Since cpuidle_state.power_usage is a signed value, use INT_MAX (instead
of -1) to init the local copies so that functions that tries to find
cpuidle states with minimum power usage works correctly even if they use
non-negative values.

Signed-off-by: Sivaram Nair <sivaramn@nvidia.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/cpuidle.c
drivers/cpuidle/governors/menu.c

index 8df53dd..fb4a7dd 100644 (file)
@@ -70,7 +70,7 @@ int cpuidle_play_dead(void)
        struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);
        struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
        int i, dead_state = -1;
-       int power_usage = -1;
+       int power_usage = INT_MAX;
 
        if (!drv)
                return -ENODEV;
index bd40b94..20ea33a 100644 (file)
@@ -312,7 +312,7 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
 {
        struct menu_device *data = &__get_cpu_var(menu_devices);
        int latency_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY);
-       int power_usage = -1;
+       int power_usage = INT_MAX;
        int i;
        int multiplier;
        struct timespec t;