greybus: ratelimit errors usually seen on unipro_reset

It is believed that excessive serial messages from greybus
on suspend/resume is leading to watchdog bite.
There is still discussion going on whether ratelimiting
prints would really fix anything, except it may reduce
traffic on serial console and probably bring out real issues
in the front.
So in order to meet the alpha requirement, we all decided to
get ratelimit change "as a TEMP fix" and decide later whether
we should revert back once we get proper suspend/resume implementation.

Please follow the discussion on Jira card SW-6261.

Testing Done: Build tested against ara/main branch.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Reviewed-by: Konstantin Buhchev <buhchev_konstantin@projectara.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index bdf5024..426f83e 100644 (file)
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -473,7 +473,7 @@ static int message_send(struct gb_host_device *hd, u16 cport_id,
 
        retval = usb_submit_urb(urb, gfp_mask);
        if (retval) {
-               dev_err(&udev->dev, "failed to submit out-urb: %d\n", retval);
+               dev_err_ratelimited(&udev->dev, "failed to submit out-urb: %d\n", retval);
 
                spin_lock_irqsave(&es2->cport_out_urb_lock, flags);
                message->hcpriv = NULL;

diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c
index 659e84b..1367070 100644 (file)
--- a/drivers/staging/greybus/operation.c
+++ b/drivers/staging/greybus/operation.c
@@ -1127,7 +1127,7 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type,
 
        ret = gb_operation_request_send_sync_timeout(operation, timeout);
        if (ret) {
-               dev_err(&connection->hd->dev,
+               dev_err_ratelimited(&connection->hd->dev,
                        "%s: synchronous operation of type 0x%02x failed: %d\n",
                        connection->name, type, ret);
        } else {