drm/crtc_helper/set_config: Remove redundant NULL pointer check on set->mode
authorLiu Ying <gnuiyl@gmail.com>
Thu, 14 Jan 2016 06:00:10 +0000 (14:00 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jan 2016 06:51:12 +0000 (07:51 +0100)
We've done sanity NULL pointer check on set->mode at the beginning of
drm_crtc_helper_set_config() and bailed out if necessary, thus any later on
check is redundant.

Signed-off-by: Liu Ying <gnuiyl@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1452751210-19216-2-git-send-email-gnuiyl@gmail.com
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc_helper.c

index 63e8881..5d4bc64 100644 (file)
@@ -588,7 +588,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
        if (set->x != set->crtc->x || set->y != set->crtc->y)
                fb_changed = true;
 
-       if (set->mode && !drm_mode_equal(set->mode, &set->crtc->mode)) {
+       if (!drm_mode_equal(set->mode, &set->crtc->mode)) {
                DRM_DEBUG_KMS("modes are different, full mode set\n");
                drm_mode_debug_printmodeline(&set->crtc->mode);
                drm_mode_debug_printmodeline(set->mode);