V4L/DVB (12477): Use dst_type field instead of type_flags
authorJulia Lawall <julia@diku.dk>
Tue, 21 Jul 2009 16:47:46 +0000 (13:47 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 12 Sep 2009 15:19:03 +0000 (12:19 -0300)
It seems from other code that it is the dst_type field rather than the
type_flags field that contains values of the form DST_TYPE_IS...
The type_flags field contains values of the form DST_TYPE_HAS...

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ struct dst_state E; @@

(
*E.type_flags ==
  \( DST_TYPE_IS_SAT\|DST_TYPE_IS_TERR\|DST_TYPE_IS_CABLE\|DST_TYPE_IS_ATSC \)
|
*E.type_flags !=
  \( DST_TYPE_IS_SAT\|DST_TYPE_IS_TERR\|DST_TYPE_IS_CABLE\|DST_TYPE_IS_ATSC \)
)
// </smpl>

Cc: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/bt8xx/dst.c

index fec1d77..91353a6 100644 (file)
@@ -1059,7 +1059,7 @@ static int dst_get_tuner_info(struct dst_state *state)
                dprintk(verbose, DST_ERROR, 1, "DST type has TS=188");
        }
        if (state->board_info[0] == 0xbc) {
-               if (state->type_flags != DST_TYPE_IS_ATSC)
+               if (state->dst_type != DST_TYPE_IS_ATSC)
                        state->type_flags |= DST_TYPE_HAS_TS188;
                else
                        state->type_flags |= DST_TYPE_HAS_NEWTUNE_2;