IB/qib: add missing braces in do_qib_user_sdma_queue_create()
authorYann Droneaud <ydroneaud@opteya.com>
Mon, 10 Mar 2014 22:06:28 +0000 (23:06 +0100)
committerRoland Dreier <roland@purestorage.com>
Mon, 17 Mar 2014 23:16:51 +0000 (16:16 -0700)
Commit c804f07248895ff9c moved qib_assign_ctxt() to
do_qib_user_sdma_queue_create() but dropped the braces
around the statements.

This was spotted by coccicheck (coccinelle/spatch):

$ make C=2 CHECK=scripts/coccicheck drivers/infiniband/hw/qib/

  CHECK   drivers/infiniband/hw/qib/qib_file_ops.c
drivers/infiniband/hw/qib/qib_file_ops.c:1583:2-23: code aligned with following code on line 1587

This patch adds braces back.

Link: http://marc.info/?i=cover.1394485254.git.ydroneaud@opteya.com
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: infinipath@intel.com
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: cocci@systeme.lip6.fr
Cc: stable@vger.kernel.org
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/qib/qib_file_ops.c

index 275f247..2023cd6 100644 (file)
@@ -1578,7 +1578,7 @@ static int do_qib_user_sdma_queue_create(struct file *fp)
        struct qib_ctxtdata *rcd = fd->rcd;
        struct qib_devdata *dd = rcd->dd;
 
-       if (dd->flags & QIB_HAS_SEND_DMA)
+       if (dd->flags & QIB_HAS_SEND_DMA) {
 
                fd->pq = qib_user_sdma_queue_create(&dd->pcidev->dev,
                                                    dd->unit,
@@ -1586,6 +1586,7 @@ static int do_qib_user_sdma_queue_create(struct file *fp)
                                                    fd->subctxt);
                if (!fd->pq)
                        return -ENOMEM;
+       }
 
        return 0;
 }