CHROMIUM: ALSA: ASoC: max98095 - Don't enable VDDPU by default.
authorDylan Reid <dgreid@chromium.org>
Thu, 4 Oct 2012 21:17:37 +0000 (14:17 -0700)
committerGerrit <chrome-bot@google.com>
Tue, 9 Oct 2012 04:28:59 +0000 (21:28 -0700)
The DSP clock selection was also setting bit four of the config register
which enables a pullup resistor between AVDD and JACKSNS.  The datasheet
specifies that this should not be set at the same time as MICBIAS2.
Setting both results in noise on MIC2, which is obvious on Daisy without
this fix.

BUG=chrome-os-partner:14903
TEST=arecord with headset listen for noise.  i2cdump shows register 45
doesn't have VDDPU set.

Change-Id: I5aa0e8be2652e550fef0942f16ea9214fe9571d5
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/34679
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Tested-by: Evan Ragsdale <evan.ragsdale@maximintegrated.com>
Reviewed-by: Olof Johansson <olofj@chromium.org>
sound/soc/codecs/max98095.h

index 5e9ff0f..28edb0e 100644 (file)
        #define M98095_DAI_DHF                  (1<<3)
 
 /* M98095_045_DSP_CFG */
-       #define M98095_DSPNORMAL                (5<<4)
+       #define M98095_DSPNORMAL                (4<<4)
 
 /* M98095_048_MIX_DAC_LR */
        #define M98095_DAI1L_TO_DACR            (1<<7)