[media] media/v4l2-ctrls: Code cleanout validate_new()
authorRicardo Ribalda <ricardo.ribalda@gmail.com>
Wed, 10 Jun 2015 13:38:29 +0000 (10:38 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 6 Jul 2015 11:25:52 +0000 (08:25 -0300)
We can simplify the code removing the if().

v4l2_ctr_new sets ctrls->elems to 1 when !ctrl->is_ptr.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/v4l2-core/v4l2-ctrls.c

index e3a3468..b6b7dcc 100644 (file)
@@ -1678,21 +1678,6 @@ static int validate_new(const struct v4l2_ctrl *ctrl, union v4l2_ctrl_ptr p_new)
        unsigned idx;
        int err = 0;
 
-       if (!ctrl->is_ptr) {
-               switch (ctrl->type) {
-               case V4L2_CTRL_TYPE_INTEGER:
-               case V4L2_CTRL_TYPE_INTEGER_MENU:
-               case V4L2_CTRL_TYPE_MENU:
-               case V4L2_CTRL_TYPE_BITMASK:
-               case V4L2_CTRL_TYPE_BOOLEAN:
-               case V4L2_CTRL_TYPE_BUTTON:
-               case V4L2_CTRL_TYPE_CTRL_CLASS:
-               case V4L2_CTRL_TYPE_INTEGER64:
-                       return ctrl->type_ops->validate(ctrl, 0, p_new);
-               default:
-                       break;
-               }
-       }
        for (idx = 0; !err && idx < ctrl->elems; idx++)
                err = ctrl->type_ops->validate(ctrl, idx, p_new);
        return err;