mmc: sdhci-pltfm: Do not use parent as the host's device
authorPawel Moll <pawel.moll@arm.com>
Tue, 12 Aug 2014 10:37:52 +0000 (11:37 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 9 Sep 2014 11:58:58 +0000 (13:58 +0200)
The code selecting a device for the sdhci host has been
continuously tweaked (4b711cb13843f5082e82970dd1e8031383134a65
"mmc: sdhci-pltfm: Add structure for host-specific data" and
a4d2177f00a5252d825236c5124bc1e9918bdb41 "mmc: sdhci-pltfm: dt
device does not pass parent to sdhci_alloc_host" while there
does not seem to be any reason to use platform device's parent
in the first place.

The comment saying "Some PCI-based MFD need the parent here"
seem to refer to Timberdale FPGA driver (the only MFD driver
registering SDHCI cell, drivers/mfd/timberdale.c) but again,
the only situation when parent device matter is runtime PM,
which is not implemented for Timberdale.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pltfm.c

index 7e834fb..c5b01d6 100644 (file)
@@ -123,7 +123,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
                                    size_t priv_size)
 {
        struct sdhci_host *host;
-       struct device_node *np = pdev->dev.of_node;
        struct resource *iomem;
        int ret;
 
@@ -136,13 +135,8 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
        if (resource_size(iomem) < 0x100)
                dev_err(&pdev->dev, "Invalid iomem size!\n");
 
-       /* Some PCI-based MFD need the parent here */
-       if (pdev->dev.parent != &platform_bus && !np)
-               host = sdhci_alloc_host(pdev->dev.parent,
-                       sizeof(struct sdhci_pltfm_host) + priv_size);
-       else
-               host = sdhci_alloc_host(&pdev->dev,
-                       sizeof(struct sdhci_pltfm_host) + priv_size);
+       host = sdhci_alloc_host(&pdev->dev,
+               sizeof(struct sdhci_pltfm_host) + priv_size);
 
        if (IS_ERR(host)) {
                ret = PTR_ERR(host);