pinctrl/abx500: use the BIT() macro where appropriate
authorLee Jones <lee.jones@linaro.org>
Wed, 23 Jan 2013 13:26:02 +0000 (13:26 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 5 Feb 2013 12:54:22 +0000 (13:54 +0100)
The BIT() macro provides a simple and easy to read way of
obtaining bit offsets into things like masks and hardware
registers. In this patch we're simply replacing all
instances of '1 << x' with 'bit(x)'.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-abx500.c

index 7046aef..539c9bb 100644 (file)
@@ -157,7 +157,7 @@ static int abx500_gpio_set_bits(struct gpio_chip *chip, u8 reg,
 
        reg += offset / 8;
        ret = abx500_mask_and_set_register_interruptible(pct->dev,
-                               AB8500_MISC, reg, 1 << pos, val << pos);
+                               AB8500_MISC, reg, BIT(pos), val << pos);
        if (ret < 0)
                dev_err(pct->dev, "%s write failed\n", __func__);
        return ret;