phy: rockchip-emmc: give DLL some extra time to be ready
authorShawn Lin <shawn.lin@rock-chips.com>
Mon, 20 Jun 2016 17:56:40 +0000 (10:56 -0700)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 25 Jul 2016 08:34:14 +0000 (10:34 +0200)
According to the databook, 10.2us is the max time for dll to be ready to
work. However in testing, some chips need 20us for dll to be ready. This
patch adds some extra margin for dllrdy to be ready, fixing our
-ETIMEDOUT issues.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/phy/phy-rockchip-emmc.c

index 6ebcf3e..48cbe69 100644 (file)
@@ -119,10 +119,11 @@ static int rockchip_emmc_phy_power(struct rockchip_emmc_phy *rk_phy,
                                   PHYCTRL_ENDLL_MASK,
                                   PHYCTRL_ENDLL_SHIFT));
        /*
-        * After enable analog DLL circuits, we need extra 10.2us
-        * for dll to be ready for work.
+        * After enable analog DLL circuits, we need an extra 10.2us
+        * for dll to be ready for work. But according to testing, we
+        * find some chips need more than 25us.
         */
-       udelay(11);
+       udelay(30);
        regmap_read(rk_phy->reg_base,
                    rk_phy->reg_offset + GRF_EMMCPHY_STATUS,
                    &dllrdy);