greybus: control: Drop get_version support
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 11 Aug 2015 02:06:02 +0000 (07:36 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Wed, 12 Aug 2015 02:33:05 +0000 (19:33 -0700)
This is done from a common place now, no need to replicate it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/control.c
drivers/staging/greybus/control.h

index a69a703..605e613 100644 (file)
@@ -12,9 +12,6 @@
 #include <linux/slab.h>
 #include "greybus.h"
 
-/* Define get_version() routine */
-define_get_version(gb_control, CONTROL);
-
 /* Get Manifest's size from the interface */
 int gb_control_get_manifest_size_operation(struct gb_interface *intf)
 {
@@ -100,7 +97,6 @@ static int gb_control_request_recv(u8 type, struct gb_operation *op)
 static int gb_control_connection_init(struct gb_connection *connection)
 {
        struct gb_control *control;
-       int ret;
 
        control = kzalloc(sizeof(*control), GFP_KERNEL);
        if (!control)
@@ -109,14 +105,10 @@ static int gb_control_connection_init(struct gb_connection *connection)
        control->connection = connection;
        connection->private = control;
 
-       ret = get_version(control);
-       if (ret)
-               kfree(control);
-
        /* Set interface's control connection */
        connection->bundle->intf->control = control;
 
-       return ret;
+       return 0;
 }
 
 static void gb_control_connection_exit(struct gb_connection *connection)
index 6e41a2b..3248d96 100644 (file)
@@ -12,8 +12,6 @@
 
 struct gb_control {
        struct gb_connection    *connection;
-       u8                      version_major;
-       u8                      version_minor;
 };
 
 int gb_control_connected_operation(struct gb_control *control, u16 cport_id);