qed: Fix static checker warnings.
authorSudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Tue, 28 Jun 2016 06:10:58 +0000 (02:10 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Jun 2016 11:53:35 +0000 (07:53 -0400)
Static checker warnings:
drivers/net/ethernet/qlogic/qed/qed_int.c:2450 qed_init_cau_sb_entry()
warn: always true condition '(cdev->rx_coalesce_usecs <= 255) =>
(0-255 <= 255)'
drivers/net/ethernet/qlogic/qed/qed_int.c:2511 qed_int_cau_conf_sb()
warn: always true condition '(p_hwfn->cdev->rx_coalesce_usecs <= 255)
=> (0-255 <= 255)'
..

The data types for rx/tx_coalesce_usecs should be u16.

Fixes: commit 722003ac40c2 ("qed: Add support for coalescing config read/update.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed.h

index 9a63df1..35e5377 100644 (file)
@@ -489,8 +489,8 @@ struct qed_dev {
 
        u32                             int_mode;
        enum qed_coalescing_mode        int_coalescing_mode;
-       u                             rx_coalesce_usecs;
-       u                             tx_coalesce_usecs;
+       u16                             rx_coalesce_usecs;
+       u16                             tx_coalesce_usecs;
 
        /* Start Bar offset of first hwfn */
        void __iomem                    *regview;